Alexandre Kühn
a479a0bba6
Steps to reproduce: - install `hr_homeworking` - connect as Mitchell Admin - make a private chat with Marc Demo - `@mention` Marc Demo => crash (cannot read name of undefined (reading persona)) This happens because a spread record was inserted in model, and in this scenario the record list in data can be the exact same as the record list used in the model. The internal code of assigning a many list is to `clear()` and then `push()` from data, but if the data mutates from the `clear()`, then the `push()` does nothing and the resulting relation is emptied. This commit fixes the issue by keeping a copy of collection before `clear()` so that push applies on original data that is intended by insert. This commit also adapt code in hr to not use spread record to insert Persona. While it works with the fix, it's simpler to just update the appropriate field and also more efficient, because spread a record has to process all fields as an insert, wasting CPU time. closes odoo/odoo#139143 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials