Eteil Djoumatchoua(etdj) a1944aa4ad [FIX] website_sale_loyalty: Stop getting succes message after applying invalid coupon
Current Behaviour:
In E-commerce, when you apply a ``LoyaltyCard`` which is not applicable on the ``SaleOrder``,
in a specific case it displays a success message even if the coupon is not applied.

Expected behaviour
Don't display a success message when the coupon is not applicable

Steps:
- Create a program with 'coupon' type, a rule of 'minimum 1' and a reward on a specific product A.
- Generate a coupon
- Go to shop add product A to the cart, go to checkout and apply the coupon code(Everything goes well).
- Delete the coupon and the product, and add a product B.
- Go to checkout and try to apply the same coupon code.

Issue:
Wrong success message

Reason:
The wrong message is displayed beacause on the python side we just check if there
is 'error' in the ``Request.session`` but in this case there is also 'error_promo_code'
that should be considered.

opw-3355632

closes odoo/odoo#129663

X-original-commit: 6ee60a30e0798ce69152385b08e49b223782d785
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Signed-off-by: Eteil Junior Djoumatchoua (etdj) <etdj@odoo.com>
2023-07-26 10:48:51 +02:00
2023-07-26 09:22:30 +02:00
…
…
…

Build Status Tech Doc Help Nightly Builds

Odoo

Odoo is a suite of web based open source business apps.

The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...

Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.

Getting started with Odoo

For a standard installation please follow the Setup instructions from the documentation.

To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials

S
Description
No description provided
Readme LGPL-3.0
3.4 GiB
Languages
Python 49.6%
JavaScript 47.8%
SCSS 2%
CSS 0.3%
HTML 0.2%