Younn Olivier
9b66ee66cd
This commit fixes an inconsistent behaviour in tours using the website's "Edit Menu" dialogs. When adding a mega menu, two dialogs are displayed: - The main "Edit Menu" dialog, from which you can open - The "Menu" dialog with the mega menu label input When these two dialogs were opened, and closed successively (click on "Ok" to confirm the menu label, then click on "Save" to save the new website menu), the tour was sometimes triggering the primary button of the wrong dialog. Two issues were leading to this inconsistent behaviour: 1/ Sometimes, the tour would click twice on the same primary button, and would not wait for the current dialog to close. To prevent that, extra_triggers are added to the steps to check that the first click was correctly taken into account (and so, that the upper dialog, that was the active dialog, was closed). 2/ Other times, the tour would click on the wrong dialog primary button (it would click on the inactive dialog's button that would save the menu without validating the label first). This was coming from the web_tour.TourManager inaccurate $modal_displayed property, which was defined and used in two different javascript threads of execution. It could reference modals that were not the actual modals from the DOM, when used in _check_for_tooltip. To prevent that, that property is set inside the method it is used in. It could be defined as a const and not a property, but this way the commit history is left untouched. runbot-4000 runbot-4001 runbot-4004 runbot-4005 closes odoo/odoo#94924 Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials