Joseph Caburnay
9b1b36e2df
This only happens after the introduction of PosPopupController. ProductInfoPopup and ClosePosPopup manages their own error but it's not compatible with the new controller. Basically after the error in onWillStart, the renderer will attempt to render the component but there will be error which results to *not* being able to call onMounted hook which is responsible in calling error popup. Furthermore, the PosPopupController is unable to cleanup the original popup that failed. So the connection returns, all the unshown popups will show up again. In this change, we clear the problematic popup by immediately calling `cancel` and showing the proper error in the onWillStart call stack, no need for the onMounted hook. IMPROVEMENT: Perhaps it's better to delegate the management of error to the component that requests for showing the popup, such that the popup popup is more or less dumb which only receives props, and not make it's own rpc during mounting. To reproduce: https://watch.screencastify.com/v/1LE31gapmkIjTfkB7dTY closes odoo/odoo#96166 X-original-commit: f692b403213d593d7327a2cbc33bd00359fd079d Signed-off-by: Masereel Pierre <pim@odoo.com> Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials