90679836ffa155d79859924a7da5354f9cd01498
Follow-up of https://github.com/odoo/odoo/pull/130821 `name_get` has been deprecated for `display_name`. In old `name_get`, when the record had no display_name (`convert(rec._rec_name)` returns `False`) then the fallback was empty string `""`. This has been changed with default `_compute_display_name`, to instead show `<rec._name>,<rec.id>`. Discuss channel `display_name` was relying on this "" fallback somehow: even though `rec._rec_name == ""`, `convert("") == False`, thus fallback "" cancels out to "". The value "" for name is intentional and necessary in discuss channels for the good working of some other fallbacks UI, e.g. group chat concats member names. With the recent changes of `_compute_display_name` default fallback, it showed `discuss.channel,10` instead of "". Steps to reproduce: - Log in as Mitchell Admin - Open Discuss app - Click "Start a meeting" => expected: shows group chat name "Mitchell Admin" => result: shows group chat name "discuss.channel,10" This commit fixes the issue by removing reliance on `display_name` for discuss channels: it always uses `name`, thus showing taking into account `""` as it needs for fallbacks like in group chat when it has no name. Task-3493629 closes odoo/odoo#134531 X-original-commit: 5592fc107790c910910c2719ede04a86910dc79f Signed-off-by: Sébastien Theys (seb) <seb@odoo.com> Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
…
…
…
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials
Languages
Python
49.6%
JavaScript
47.8%
SCSS
2%
CSS
0.3%
HTML
0.2%