Touati Djamel (otd)
8f6e85f752
Steps to reproduce the bug: - Install Accounting and Expense app - Go to accounting settings > enable cash basis option - Go to accounting > configuration > accounting > taxes - Create a new tax or choose an existing one e.g “Tax abc”: Tax Computation = `”Percentage of Price”` Tax Type = `”Purchases”` Choose any value for amount Select "Based on Payment" in tax due choose an account with the "Allow Reconciliation" option activated in the Cash Basis Transition Account field Save - Go to expenses > Expense Reports > All reports > Create a new one : - Add 2 expense and for both set up the taxes to "Tax abc" and unit price > 0 - Submit to manager - Approve - Post journal entries - Register a payment Problem: A user error with the following message is triggered: “You are trying to reconcile some entries that are already reconciled” In the use case we have two expenses and for each, an `" account.partial.reconcile "` will be created, so we will loop twice and therefore add twice all the `”account.move.line”` linked to the taxes in the dict `" to_reconcile_after "`: https://github.com/odoo/odoo/blob/beccf82e09d536255d9d9cb9bfe58ebae2559843/addons/account/models/account_partial_reconcile.py#L585 Then we loop to reconcile all the `" account.move.line "` which are in the dict `" to_reconcile_after "`, but since we added them all twice, at each turn of the loop we give them all as a parameter of the “reconcile” function without checking whether they are already reconciled or not. opw-2565934 closes odoo/odoo#74432 X-original-commit: fb2b1482f5d3dec924b08e08dc915d6608c7d6b3 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com> Signed-off-by: Djamel Touati <DjamelTouati@users.noreply.github.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials