Guillaume (guva)
8b743ba30a
With this commit, we make sure that all lines are fully reconciled when reversing a move. Steps to reproduce: - Create a Journal Entry, with eg a line with 300$ debit/credit and two others lines to make the journal entry fully balanced | Account | Partner | Debit | Credit | |-------------|-------------|-----------|------------| | Account X | | 300.0 | 0.0 | | Account Y | partner A | 0.0 | 100.0 | | Account Y | partner B | 0.0 | 200.0 | - Then reverse the move -> Only one line is marked as fully reconciled, the other one is marked as partially reconciled. This is because each line was passed in the reconcile method with all the counterpart lines, even those which didn't belong to it. Therefore, all the firsts lines was marked as partially reconciled until the last one, which passed with the only counterpart line left. With this commit, we group the lines and counterpart lines by account, and reconcile them. This is a correction of this commit 6481eb720f36f3e81c2ec8371cccdd893a5e8ddf which introduced a bug in l10n_mx, when unreconciling moves with tax 0%, here are the steps to reproduce this bug: - With l10n_mx installed - Create an invoice with tax 0% - Confirm and register payment - Try to unreconcile the payment -> We get an UserError : "You are trying to reconcile some entries that are already reconciled" This happened because in the first fix, we didn't filtered the already reconciled moves. Also, it's reproductible in 15 but change is made here in order to keep consistency between versions. opw-2810392 opw-2851999 closes odoo/odoo#92446 X-original-commit: 869ed09c23c0ab64b6c030a673d5f549b9b095f9 Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: Guillaume Vanleynseele <guva@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials