Simon Lejeune
7d2cccfc12
Before this patch, it was not possible to manually process a pack (i.e. checking the "is_done" box), because the field was always reset *before* saving. It was still possible to process it by hitting "validate", but it was not possible to put a pack in a pack. Manually process a pack means hitting the checkbox "is_done" on the pack operation. This "is_done" field is a boolean computed field with a reverse function, and this reverse function set the "qty_done" on the pack operation to 1.0. The compute field doesn't have any depends declared, so the value was invalidated after any changes in the form view. The computed method was used to check the checkbox is the "qty_done" is set to 1.0. It was probably used to check the checkbox when opening later a picking for which the pack was already processed. The issue is that the "qty_done" was never updated, because the inverse method is only called when saving, and the compute method already reset the "is_done" field to False, as the "qty_done" was not updated. To fix this issue, we do not use an inverse method but an onchange. Indeed, this was the expected behavior: hitting the checkbox should change the "qty_done". We already have a test covering this use case, committed in v9 [1]. It didn't discovered this regression because the test was using directly the "qty_done" field on the pack operation, not the "is_done" field used in the view. We change the test to use the "is_done" field and manually trigger the onchanges. This is due to a bad new API migration [2]. [1] reve248420348[2] revd8548e0771
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, Purchase Management, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
If you are a developer you may type the following command at your terminal:
wget -O- https://raw.githubusercontent.com/odoo/odoo/9.0/odoo.py | python
Then follow the developer tutorials
For Odoo employees
To add the odoo-dev remote use this command:
$ ./odoo.py setup_git_dev
To fetch odoo merge pull requests refs use this command:
$ ./odoo.py setup_git_review