Yolann Sabauxandflvr-odoo
7cc4b6cfe8
Steps to reproduce: - Install website_sale, contact, l10n_ch - make sure your company is in Switzerland and has all the address information - in settings, activate QR - in Accounting/Journals/Bank:add a bank account (iban: CH4431999123000889012; qr-iban: CH11 3000 5228 1308 3501 F) - install and enable the provider "Wire Transfer" - From the Website, create an order and make sure the customer set an Invoicing address in Switzerland (address + Country) - Validate the order - In Website/unpaid orders: select your order and Confirm the order - Create and confirm the invoice - Print the invoice Issue: User Error is raised Cause: With Swiss QR code you need to have a valid payment reference. That is, an ISR reference such as in https://github.com/odoo/odoo/blob/c6631df1c5b0b6d4c2268a826ca150edd0ca653e/addons/l10n_ch/models/account_invoice.py#L90 But when you create an order from the website, it creates an automatic reference "SO0001" which, when converted to an invoice, stays the same. Since the reference is prepoluted, the `_compute_l10n_ch_isr_number` will not be triggered and therefore will raise an error when trying to print the invoice. Solution: Check if the Customer Invoice Journal uses the swiss reference model, then we know that the swiss loca is installed and can call the correct function to compute the reference/ Note: In the test we check that `payment_custom` is installed. It is because the `_set_pending` method checks taht the payment_provider.code is "custom"="wire_transfer" in which case the sale order reference is computed https://github.com/odoo/odoo/blob/b4ed9537895ecee48ed146add4257af0aebeb3f4/addons/sale/models/payment_transaction.py#L54-L56 opw-3334534 closes odoo/odoo#127338 X-original-commit: dfa4844e57b67d16b181e1e58813cdbbc7efa956 Signed-off-by: Yolann Sabaux (yosa) <yosa@odoo.com> Signed-off-by: Olivier Colson (oco) <oco@odoo.com> Co-authored-by: flvr-odoo <flvr@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials