Adesh Jolhe
8eda018910
Steps to Produce:- - Install `Advanced Events` - Go to ` website` then `Configuration` - Open `setting` - Then change favicon and Select svg type file and click on save - Traceback is here Cause :- - The traceback occurs when an SVG image is passed to the ImageProcess method. In this scenario, the method sets the image as false, and then attempts to access its size, resulting in the traceback Fix :- - The issue has been resolved by implementing a condition check for the image before accessing its properties. This ensures that the image is valid before trying to retrieve its size, preventing the traceback from occurring. sentry-4199175498 closes odoo/odoo#127958 X-original-commit: ebb1e89b367dced4a2157751de12a53bf41ae400 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> Signed-off-by: Achraf Ben Azzouz (abz) <abz@odoo.com>
60 lines
2.1 KiB
Python
60 lines
2.1 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
|
|
import base64
|
|
|
|
from odoo import api, fields, models
|
|
from odoo.exceptions import ValidationError
|
|
from odoo.tools import ImageProcess
|
|
from odoo.tools.translate import _
|
|
|
|
|
|
class Website(models.Model):
|
|
_inherit = "website"
|
|
|
|
app_icon = fields.Image(
|
|
string='Website App Icon',
|
|
compute='_compute_app_icon',
|
|
store=True,
|
|
readonly=True,
|
|
help='This field holds the image used as mobile app icon on the website (PNG format).')
|
|
events_app_name = fields.Char(
|
|
string='Events App Name',
|
|
compute='_compute_events_app_name',
|
|
store=True,
|
|
readonly=False,
|
|
help="This fields holds the Event's Progressive Web App name.")
|
|
|
|
@api.depends('name')
|
|
def _compute_events_app_name(self):
|
|
for website in self:
|
|
if not website.events_app_name:
|
|
website.events_app_name = _('%s Events') % website.name
|
|
|
|
@api.constrains('events_app_name')
|
|
def _check_events_app_name(self):
|
|
for website in self:
|
|
if not website.events_app_name:
|
|
raise ValidationError(_('"Events App Name" field is required.'))
|
|
|
|
@api.depends('favicon')
|
|
def _compute_app_icon(self):
|
|
""" Computes a squared image based on the favicon to be used as mobile webapp icon.
|
|
App Icon should be in PNG format and size of at least 512x512.
|
|
|
|
If the favicon is an SVG image, it will be skipped and the app_icon will be set to False.
|
|
|
|
"""
|
|
for website in self:
|
|
image = ImageProcess(base64.b64decode(website.favicon)) if website.favicon else None
|
|
if not (image and image.image):
|
|
website.app_icon = False
|
|
continue
|
|
w, h = image.image.size
|
|
square_size = w if w > h else h
|
|
image.crop_resize(square_size, square_size)
|
|
image.image = image.image.resize((512, 512))
|
|
image.operationsCount += 1
|
|
website.app_icon = base64.b64encode(image.image_quality(output_format='PNG'))
|