Benoit Socias
55b9e4c588
When CSS properties are updated, a check is made to verify whether the new value is different from the old one. This process sometimes involves unit conversions. Since [1] when a CSS property is updated, it is also set before the check, in order to verify whether it should be set as `!important`. When the CSS property is a size, such as the `background-size` CSS property, it is made of two dimensions. However the verification does not handle that situation: it handles `15px auto` as being a single number with the unit `px auto`, which is wrong. The full comparison is made because the strings do not fully match: when a size property is set to a measure followed by `auto`, it is returned without `auto` when reading the computed style. E.g. after setting `15px auto`, it is read as `15px`. This commit adapts the CSS properties comparison mechanism by splitting the size properties into their parts and comparing each part separately. This commit also introduces a few tests about the already existing CSS properties comparisons. Steps to reproduce: - Drop a "Banner" block. - Set "Position" as "Repeat Pattern". - Type "5" in the "Width". => It raised an error. [1]: https://github.com/odoo/odoo/commit/d3c3dab8950abc25b29937605091d8ce32305fa4 task-2853161 X-original-commit: 07e471b9398e042c45182f1e8ca33e74dd8087a3 Part-of: odoo/odoo#109078
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials