Denis Ledoux
5ccc32fcf7
In the web client, in a real use case, it's not possible to write on fields which are invisible, as it's not possible to write on fields which are readonly. This is a first step in the goal to change the behavior of the `groups=` attribute in the back-end views, to remove them for the view instead of making them invisible. This is mainly to reduce the diff of the revision that will introduce the mentioned above behavior change. As nodes with `groups=` will be removed from the view when the user doesn't have the group, it's no longer possible to set a value on a field having a `groups=` the user doesn't have in the `Form` test class, as the field will no longer be at all in the view. However, these unit tests shouldn't have been able to set values on invisible fields in the first place. This revision therefore aims to correct the unit tests setting value on fields which were invisible because the user executing the test was not part of the required group(s) for these fields to be visible in the view. closes odoo/odoo#94337 Related: odoo/enterprise#28936 Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
235 lines
10 KiB
Python
235 lines
10 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
|
|
|
from datetime import datetime
|
|
from dateutil.relativedelta import relativedelta
|
|
from lxml import etree
|
|
|
|
from odoo import fields
|
|
from odoo.addons.survey.tests import common
|
|
from odoo.exceptions import UserError
|
|
from odoo.tests import Form
|
|
from odoo.tests.common import users
|
|
|
|
|
|
class TestSurveyInvite(common.TestSurveyCommon):
|
|
|
|
def setUp(self):
|
|
res = super(TestSurveyInvite, self).setUp()
|
|
# by default signup not allowed
|
|
self.env["ir.config_parameter"].set_param('auth_signup.invitation_scope', 'b2b')
|
|
view = self.env.ref('survey.survey_invite_view_form').sudo()
|
|
tree = etree.fromstring(view.arch)
|
|
# Remove the invisible on `emails` to be able to test the onchange `_onchange_emails`
|
|
# which raises an error when attempting to change `emails`
|
|
# while the survey is set with `users_login_required` to True
|
|
# By default, `<field name="emails"/>` is invisible when `survey_users_login_required` is True,
|
|
# making it normally impossible to change by the user in the web client by default.
|
|
# For tests `test_survey_invite_authentication_nosignup` and `test_survey_invite_token_internal`
|
|
tree.xpath('//field[@name="emails"]')[0].attrib.pop('attrs')
|
|
view.arch = etree.tostring(tree)
|
|
return res
|
|
|
|
@users('survey_manager')
|
|
def test_survey_invite_action(self):
|
|
# Check correctly configured survey returns an invite wizard action
|
|
action = self.survey.action_send_survey()
|
|
self.assertEqual(action['res_model'], 'survey.invite')
|
|
|
|
# Bad cases
|
|
surveys = [
|
|
# no page
|
|
self.env['survey.survey'].create({'title': 'Test survey'}),
|
|
# no questions
|
|
self.env['survey.survey'].create({'title': 'Test survey', 'question_and_page_ids': [(0, 0, {'is_page': True, 'question_type': False, 'title': 'P0', 'sequence': 1})]}),
|
|
# closed
|
|
self.env['survey.survey'].with_user(self.survey_manager).create({
|
|
'title': 'S0',
|
|
'active': False,
|
|
'question_and_page_ids': [
|
|
(0, 0, {'is_page': True, 'question_type': False, 'title': 'P0', 'sequence': 1}),
|
|
(0, 0, {'title': 'Q0', 'sequence': 2, 'question_type': 'text_box'})
|
|
]
|
|
})
|
|
]
|
|
for survey in surveys:
|
|
with self.assertRaises(UserError):
|
|
survey.action_send_survey()
|
|
|
|
@users('survey_manager')
|
|
def test_survey_invite(self):
|
|
Answer = self.env['survey.user_input']
|
|
deadline = fields.Datetime.now() + relativedelta(months=1)
|
|
|
|
self.survey.write({'access_mode': 'public', 'users_login_required': False})
|
|
action = self.survey.action_send_survey()
|
|
invite_form = Form(self.env[action['res_model']].with_context(action['context']))
|
|
|
|
# some lowlevel checks that action is correctly configured
|
|
self.assertEqual(Answer.search([('survey_id', '=', self.survey.id)]), self.env['survey.user_input'])
|
|
self.assertEqual(invite_form.survey_id, self.survey)
|
|
|
|
invite_form.partner_ids.add(self.customer)
|
|
invite_form.deadline = fields.Datetime.to_string(deadline)
|
|
|
|
invite = invite_form.save()
|
|
invite.action_invite()
|
|
|
|
answers = Answer.search([('survey_id', '=', self.survey.id)])
|
|
self.assertEqual(len(answers), 1)
|
|
self.assertEqual(
|
|
set(answers.mapped('email')),
|
|
set([self.customer.email]))
|
|
self.assertEqual(answers.mapped('partner_id'), self.customer)
|
|
self.assertEqual(set(answers.mapped('deadline')), set([deadline]))
|
|
|
|
@users('survey_manager')
|
|
def test_survey_invite_authentication_nosignup(self):
|
|
Answer = self.env['survey.user_input']
|
|
|
|
self.survey.write({'access_mode': 'public', 'users_login_required': True})
|
|
action = self.survey.action_send_survey()
|
|
invite_form = Form(self.env[action['res_model']].with_context(action['context']))
|
|
|
|
with self.assertRaises(UserError): # do not allow to add customer (partner without user)
|
|
invite_form.partner_ids.add(self.customer)
|
|
invite_form.partner_ids.clear()
|
|
invite_form.partner_ids.add(self.user_portal.partner_id)
|
|
invite_form.partner_ids.add(self.user_emp.partner_id)
|
|
with self.assertRaises(UserError):
|
|
invite_form.emails = 'test1@example.com, Raoulette Vignolette <test2@example.com>'
|
|
invite_form.emails = False
|
|
|
|
invite = invite_form.save()
|
|
invite.action_invite()
|
|
|
|
answers = Answer.search([('survey_id', '=', self.survey.id)])
|
|
self.assertEqual(len(answers), 2)
|
|
self.assertEqual(
|
|
set(answers.mapped('email')),
|
|
set([self.user_emp.email, self.user_portal.email]))
|
|
self.assertEqual(answers.mapped('partner_id'), self.user_emp.partner_id | self.user_portal.partner_id)
|
|
|
|
@users('survey_manager')
|
|
def test_survey_invite_authentication_signup(self):
|
|
self.env["ir.config_parameter"].sudo().set_param('auth_signup.invitation_scope', 'b2c')
|
|
self.env.invalidate_all()
|
|
Answer = self.env['survey.user_input']
|
|
|
|
self.survey.write({'access_mode': 'public', 'users_login_required': True})
|
|
action = self.survey.action_send_survey()
|
|
invite_form = Form(self.env[action['res_model']].with_context(action['context']))
|
|
|
|
invite_form.partner_ids.add(self.customer)
|
|
invite_form.partner_ids.add(self.user_portal.partner_id)
|
|
invite_form.partner_ids.add(self.user_emp.partner_id)
|
|
# TDE FIXME: not sure for emails in authentication + signup
|
|
# invite_form.emails = 'test1@example.com, Raoulette Vignolette <test2@example.com>'
|
|
|
|
invite = invite_form.save()
|
|
invite.action_invite()
|
|
|
|
answers = Answer.search([('survey_id', '=', self.survey.id)])
|
|
self.assertEqual(len(answers), 3)
|
|
self.assertEqual(
|
|
set(answers.mapped('email')),
|
|
set([self.customer.email, self.user_emp.email, self.user_portal.email]))
|
|
self.assertEqual(answers.mapped('partner_id'), self.customer | self.user_emp.partner_id | self.user_portal.partner_id)
|
|
|
|
@users('survey_manager')
|
|
def test_survey_invite_public(self):
|
|
Answer = self.env['survey.user_input']
|
|
|
|
self.survey.write({'access_mode': 'public', 'users_login_required': False})
|
|
action = self.survey.action_send_survey()
|
|
invite_form = Form(self.env[action['res_model']].with_context(action['context']))
|
|
|
|
invite_form.partner_ids.add(self.customer)
|
|
invite_form.emails = 'test1@example.com, Raoulette Vignolette <test2@example.com>'
|
|
|
|
invite = invite_form.save()
|
|
invite.action_invite()
|
|
|
|
answers = Answer.search([('survey_id', '=', self.survey.id)])
|
|
self.assertEqual(len(answers), 3)
|
|
self.assertEqual(
|
|
set(answers.mapped('email')),
|
|
set(['test1@example.com', '"Raoulette Vignolette" <test2@example.com>', self.customer.email]))
|
|
self.assertEqual(answers.mapped('partner_id'), self.customer)
|
|
|
|
@users('survey_manager')
|
|
def test_survey_invite_token(self):
|
|
Answer = self.env['survey.user_input']
|
|
|
|
self.survey.write({'access_mode': 'token', 'users_login_required': False})
|
|
action = self.survey.action_send_survey()
|
|
invite_form = Form(self.env[action['res_model']].with_context(action['context']))
|
|
|
|
invite_form.partner_ids.add(self.customer)
|
|
invite_form.emails = 'test1@example.com, Raoulette Vignolette <test2@example.com>'
|
|
|
|
invite = invite_form.save()
|
|
invite.action_invite()
|
|
|
|
answers = Answer.search([('survey_id', '=', self.survey.id)])
|
|
self.assertEqual(len(answers), 3)
|
|
self.assertEqual(
|
|
set(answers.mapped('email')),
|
|
set(['test1@example.com', '"Raoulette Vignolette" <test2@example.com>', self.customer.email]))
|
|
self.assertEqual(answers.mapped('partner_id'), self.customer)
|
|
|
|
@users('survey_manager')
|
|
def test_survey_invite_token_internal(self):
|
|
Answer = self.env['survey.user_input']
|
|
|
|
self.survey.write({'access_mode': 'token', 'users_login_required': True})
|
|
action = self.survey.action_send_survey()
|
|
invite_form = Form(self.env[action['res_model']].with_context(action['context']))
|
|
|
|
with self.assertRaises(UserError): # do not allow to add customer (partner without user)
|
|
invite_form.partner_ids.add(self.customer)
|
|
with self.assertRaises(UserError): # do not allow to add portal user
|
|
invite_form.partner_ids.add(self.user_portal.partner_id)
|
|
invite_form.partner_ids.clear()
|
|
invite_form.partner_ids.add(self.user_emp.partner_id)
|
|
with self.assertRaises(UserError):
|
|
invite_form.emails = 'test1@example.com, Raoulette Vignolette <test2@example.com>'
|
|
invite_form.emails = False
|
|
|
|
invite = invite_form.save()
|
|
invite.action_invite()
|
|
|
|
answers = Answer.search([('survey_id', '=', self.survey.id)])
|
|
self.assertEqual(len(answers), 1)
|
|
self.assertEqual(
|
|
set(answers.mapped('email')),
|
|
set([self.user_emp.email]))
|
|
self.assertEqual(answers.mapped('partner_id'), self.user_emp.partner_id)
|
|
|
|
def test_survey_invite_token_by_email_nosignup(self):
|
|
"""
|
|
Case: have multiples partners with the same email address
|
|
If I set one email address, I expect one email to be sent
|
|
"""
|
|
|
|
first_partner = self.env['res.partner'].create({
|
|
'name': 'Test 1',
|
|
'email': 'test@example.com',
|
|
})
|
|
|
|
self.env['res.partner'].create({
|
|
'name': 'Test 2',
|
|
'email': '"Raoul Poilvache" <TEST@example.COM>',
|
|
})
|
|
|
|
self.survey.write({'access_mode': 'token', 'users_login_required': False})
|
|
action = self.survey.action_send_survey()
|
|
invite_form = Form(self.env[action['res_model']].with_context(action['context']))
|
|
invite_form.emails = 'test@example.com'
|
|
invite = invite_form.save()
|
|
invite.action_invite()
|
|
|
|
answers = self.env['survey.user_input'].search([('survey_id', '=', self.survey.id)])
|
|
self.assertEqual(len(answers), 1)
|
|
self.assertEqual(answers.partner_id.display_name, first_partner.display_name)
|