Files
odoo_source/addons/membership/models/partner.py
T
Baptiste Vergote 90e0abb413 [FIX] membership: fix state computing for non paid invoice
Having a non paid membership for last year and being associate with
someone having a non paid membership was dispalying an 'old' membership
state instead if a 'non' membership.

Assumption:
If an associate member is added, take the state of the associate member
(tooltip of associate member).
In case the associate member is a 'non member', it's stupid to associate
with someone that is paying or have paid as it won't consider the state of
the current paid member, the link has to be made on the other side:
the 'non' paying will be associate with the 'paid'.

Create membership for
        a/ 2019 (1jan to 31dec)
           > For the calculation of the 'old' state
        b/ 2020 (1jan to 31dec)
           > For the calculation of the 'paid' state

Create few res.partner:
AA: No associate.
        2019 - Paid
        2020 - Paid
        >> Paid member
        (= ok)

CC Case 1:
Associate with AA
        2019 - Invoiced (but not paid)
        2020 - None
        >> Paid member due to association with AA
        (= ok)

CC Case 2:
Not associate:
		2019 - Invoiced (but not paid)
        2020 - None
        >> Before fix: Old member
        (= nok)
        >> After fix: Non member
        (= ok) As he never paid and not linked to someone that paid.

DD: Associate with AA
        2019 - Invoiced not paid
        2020 - Paid
        >> Paid member (with or without association with AA)
        (= ok)

EE Case 1:
Not associate:
        2019 - Paid
        2020 - None
        >> Old member
        (= ok)

Case 2:
Associate with DD
        2019 - Invoiced (not paid)
        2020 - None
        >> Paid member (due to association with DD)
        (= ok)

Case 3:
Associate with CC
        2019 - Invoiced (not paid)
        2020 - None
        >> Before fix: Old member (due to none having a current 2020 invoiced)
        (= nok it should take the state of CC)
        >> After fix: Non member (as CC is not a member)

opw-2287050

closes odoo/odoo#55773

X-original-commit: 5e7b7b0a645bcff175bf8d2483eae5ffd4aaf89b
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
2020-08-12 07:25:28 +00:00

137 lines
6.7 KiB
Python

# -*- coding: utf-8 -*-
# Part of Odoo. See LICENSE file for full copyright and licensing details.
from datetime import date
from odoo import api, fields, models, _
from odoo.exceptions import UserError, ValidationError
from . import membership
class Partner(models.Model):
_inherit = 'res.partner'
associate_member = fields.Many2one('res.partner', string='Associate Member',
help="A member with whom you want to associate your membership."
"It will consider the membership state of the associated member.")
member_lines = fields.One2many('membership.membership_line', 'partner', string='Membership')
free_member = fields.Boolean(string='Free Member',
help="Select if you want to give free membership.")
membership_amount = fields.Float(string='Membership Amount', digits=(16, 2),
help='The price negotiated by the partner')
membership_state = fields.Selection(membership.STATE, compute='_compute_membership_state',
string='Current Membership Status', store=True,
help='It indicates the membership state.\n'
'-Non Member: A partner who has not applied for any membership.\n'
'-Cancelled Member: A member who has cancelled his membership.\n'
'-Old Member: A member whose membership date has expired.\n'
'-Waiting Member: A member who has applied for the membership and whose invoice is going to be created.\n'
'-Invoiced Member: A member whose invoice has been created.\n'
'-Paying member: A member who has paid the membership fee.')
membership_start = fields.Date(compute='_compute_membership_state',
string ='Membership Start Date', store=True,
help="Date from which membership becomes active.")
membership_stop = fields.Date(compute='_compute_membership_state',
string ='Membership End Date', store=True,
help="Date until which membership remains active.")
membership_cancel = fields.Date(compute='_compute_membership_state',
string ='Cancel Membership Date', store=True,
help="Date on which membership has been cancelled")
@api.depends('member_lines.account_invoice_line',
'member_lines.account_invoice_line.move_id.state',
'member_lines.account_invoice_line.move_id.payment_state',
'member_lines.account_invoice_line.move_id.partner_id',
'free_member',
'member_lines.date_to', 'member_lines.date_from',
'associate_member')
def _compute_membership_state(self):
today = fields.Date.today()
for partner in self:
state = 'none'
partner.membership_start = self.env['membership.membership_line'].search([
('partner', '=', partner.associate_member.id or partner.id), ('date_cancel','=',False)
], limit=1, order='date_from').date_from
partner.membership_stop = self.env['membership.membership_line'].search([
('partner', '=', partner.associate_member.id or partner.id),('date_cancel','=',False)
], limit=1, order='date_to desc').date_to
partner.membership_cancel = self.env['membership.membership_line'].search([
('partner', '=', partner.id)
], limit=1, order='date_cancel').date_cancel
if partner.membership_cancel and today > partner.membership_cancel:
partner.membership_state = 'free' if partner.free_member else 'canceled'
continue
if partner.membership_stop and today > partner.membership_stop:
if partner.free_member:
partner.membership_state = 'free'
continue
if partner.associate_member:
partner.associate_member._compute_membership_state()
partner.membership_state = partner.associate_member.membership_state
continue
line_states = [mline.state for mline in partner.member_lines if \
(mline.date_to or date.min) >= today and \
(mline.date_from or date.min) <= today and \
mline.account_invoice_line.move_id.partner_id == partner]
if 'paid' in line_states:
state = 'paid'
elif 'invoiced' in line_states:
state = 'invoiced'
elif 'waiting' in line_states:
state = 'waiting'
elif 'canceled' in line_states:
state = 'canceled'
if state == 'none':
for mline in partner.member_lines:
# if there is an old invoice paid, set the state to 'old'
if ((mline.date_from or date.min) < today and (mline.date_to or date.min) < today and \
(mline.date_from or date.min) <= (mline.date_to or date.min) and \
mline.account_invoice_id and mline.account_invoice_id.payment_state in ('in_payment', 'paid')):
state = 'old'
break
if partner.free_member and state != 'paid':
state = 'free'
partner.membership_state = state
@api.constrains('associate_member')
def _check_recursion_associate_member(self):
for partner in self:
level = 100
while partner:
partner = partner.associate_member
if not level:
raise ValidationError(_('You cannot create recursive associated members.'))
level -= 1
@api.model
def _cron_update_membership(self):
partners = self.search([('membership_state', 'in', ['invoiced', 'paid'])])
# mark the field to be recomputed, and recompute it
self.env.add_to_compute(self._fields['membership_state'], partners)
def create_membership_invoice(self, product, amount):
""" Create Customer Invoice of Membership for partners.
"""
invoice_vals_list = []
for partner in self:
addr = partner.address_get(['invoice'])
if partner.free_member:
raise UserError(_("Partner is a free Member."))
if not addr.get('invoice', False):
raise UserError(_("Partner doesn't have an address to make the invoice."))
invoice_vals_list.append({
'move_type': 'out_invoice',
'partner_id': partner.id,
'invoice_line_ids': [
(0, None, {'product_id': product.id, 'quantity': 1, 'price_unit': amount, 'tax_ids': [(6, 0, product.taxes_id.ids)]})
]
})
return self.env['account.move'].create(invoice_vals_list)