qsm-odoo
41b3e0f1c0
With [1] and [2], the colorpicker / colorpalette were implemented. In both cases, for the custom colors hue / saturation / lightness selection we listened to mousemove/mouseup events on the whole body / document. That is to be able to start dragging the color cursors from inside the colorpicker to anywhere on the screen (the cursor being confined into their own box of course). Problems occur when iframes come into the equation. Indeed, from that moment, listening to mousemove events on an unique document is not the way to go as mousemove over inner iframes will be ignored. This should not be the case anywhere in 15.0 (that this original commit targets). The only iframe there should be the mass_mailing one and in that case, the colorpicker is inside the iframe so it should not be a problem. However, [3] (then fixed by [4]) were meant to tackle a similar problem (although [3] seems to say the goal was to ignore mousemove outside the iframe which is the opposite of what this current commit tries to do: listening on the whole screen). However, by doing so, a memory leak was created as the document on which the events were bound was not properly cleaned as the `destroy` which unbinds the events was not adapted. That is the main reason why this commit targets 15.0 (although, the solution here still makes sense generically in 15.0 and should make the code simpler and easier to understand). In 16.0, however, the iframe situation is a problem: the website builder colorpickers are now in the main document but the edited content is inside an inner iframe. In that case, listening to the main document's mousemove/mouseup events makes the colorpicker only work when not hovering the edited content (which could be acceptable but not perfect). Note that during that website builder refactoring, [5] worsened the code of [3] and [4] to do exactly that. Later, [6] was made to solve an unrelated problem and actually woke up that worsened code, not understanding what the new undocumented `ownerDocument` option was for (it will stay like this in stable from now on, as it will be not used anywhere anymore... hopefully). Because of that, the situation became the opposite: dragging inside the colorpicker did not work until the edited content was hovered. And because of that functional fact, an even more visible problem was created: - Click on a snippet - Select a custom background color using the hsl selection - Hover a non custom color (like nearly always the case "by mistake" after configuring a custom color, your mouse just moves over the non custom colors) => your custom color is lost This was because the chain of events that were listened inside the colorpicker were gone (because of the combination of [5] and [6]). In the end, this only revealed the shortcomings of the implementation in [1], [2], [3] and [4]: we should not try to search which frame we have to listen to: we should listen to the whole screen. This commit solves the issue by listening to the top window document and all its inner iframes, also fixing the memory leak mentioned earlier. task-3332711 [1]: https://github.com/odoo/odoo/commit/29f0c0a186a9a60d6e5b7f026c305d689b6fc807 [2]: https://github.com/odoo/odoo/commit/99910b526ed792235a778863b993d10cf4e77cd7 [3]: https://github.com/odoo/odoo/commit/4fb33f7f8d6955a44fbb7c94c7d204e9baa09707 [4]: https://github.com/odoo/odoo/commit/f1b26335a286a47f685b7830db97c21e6fefd68b [5]: https://github.com/odoo/odoo/commit/03c552690b15cbf2e7d6b7812386ac64042219af [6]: https://github.com/odoo/odoo/commit/418c1178301e28b4bd1412da6d0558e219060830 closes odoo/odoo#126313 X-original-commit: e03158e6da45d83c977b7cf51f0f998343dc6fd6 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials