Romain Derie
340d4a09c3
Before this commit, the only possibility when adding a google font was to use google servers to serve the font. This was not ideal as some people really want to serve it themselves without the need of their visitors to reach google servers. That's especially true since recently where it seems like German clients are receiving letters about that to tell them it's illegal and this should be changed, as it wouldn't respect the GDPR. Somehow, it seems related to the fact that google knows you visited a website by just downloading the font, because they very well know with just your IP who you are exactly. It's yet unsure if that issue is well-founded or not, but since German courts seem to be sanctioning people about this, there is no reason to not at least provide a workaround. What is sure is that it makes a lot of noise and more and more people seem to be impacted by this as many opw are getting opened, as well as github messages. Whether it is well-founded or not is thus not really our problem anymore, we should just provide a way for our users to protect themselves against this "German law problem" (or at least think they are protecting, if Odoo thinks that's a non issue or the German court is wrong or ambiguous). Note that a cookies banner to inform users would not be enough for that "problem", as the user would already have accessed your website and thus the related problematic fonts. Another solution which is not something we want (at all) would be to serve local system fonts while the user did not consent about google fonts, or having a blocking screen page telling people visiting the website will fetch google fonts. Obviously those 2 possibilities are a no go as it leads to terrible UX. Finally, note that: - in Odoo 16, the default fonts will be the system fonts, meaning there won't be any call to google by default, regardless of this pr - there is a work in progress to improve the current cookies bar to differentiate essential and non essential cookies and to allow user to accept only one or both (task-2800976). Useful links: - https://github.com/odoo/odoo/issues/83638#issuecomment-1054470699 ODO detailed point of view about this - https://rewis.io/urteile/urteil/lhm-20-01-2022-3-o-1749320/ The German law about this Closes #83638 task-2756486 opw-2970167 opw-2960466 opw-2960555 opw-2952427 opw-2800976 opw-2748647 (possibly many more) Courtesy of @bso-odoo for the regex part which was inspired by another of his google font fix attempt closes odoo/odoo#101826 X-original-commit: b06ce21eba6388ce34bbffffadcb489f0e8557dd Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials