Thomas Lefebvre (thle)
23aa895cf7
Steps to reproduce: ------------------- - create a promotion program with the type "Discount code"; - add a rule to trigger the promotion with the code "12345"; - add two rewards; - go to ecommerce and create a cart; - apply the promo code. Issue: ------ It is not possible to claim a reward. Cause: ------ When we apply the code "12345", we call the `pricelist` method, which will try to apply the code. If it's not a coupon and it's not nominative, we create a loyalty card (a coupon) with a default code (for example: "044d-3364-42d0"). This previously created loyalty card is linked to the current sale order, which is only fair since we don't want to be able to apply it a second time. The two rewards are linked to the same coupon and therefore have the same code (which is right because we can apply only one of these rewards). This problem doesn't occur with a single reward, because when only one reward is detected, we automatically apply it when we call the `pricelist` method. In the case of two rewards, it is possible to select the reward. This will trigger the `claim_reward` method. In this method, if we use a coupon with a code (which is the case here, "044d-3364-42d0"), we call the `pricelist` method with this code. This will trigger an error, as the code is already in use with the loyalty card linked to the sale order. Solution: --------- When claiming a reward generated by a program of the `promo_code` type, i.e. in the case of more than a rewards, don't call the `pricelist` method (which triggers an error due to the code) but `_apply_reward`. This will apply the reward to the sale order. A redirect will be use which will remove all "claimable and showable rewards" from this program. If we want to re-trigger it via code "12345", this will no longer be possible. Note: ----- Modification of the view to distinguish between coupons and "Discount Code" programs. The current display suggests that rewards are coupons (with the same code) that we use, whereas they are rewards that we can claim. Furthermore, there's no description of the rewards. opw-3520137 closes odoo/odoo#144349 X-original-commit: d56b46ccb6c736856af3dd62df8c2c8b99a8eaa5 Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials