Denis Ledoux
15948702e5
`if isinstance(node, SKIPPED_ELEMENT_TYPES):` --------------------------------------------- It has been added in https://github.com/odoo/odoo/commit/31b9bee00676e179c124f3d42539103305cf7423 It's hard to tell why it has been added. Though it seems not useful: - Has we iter the nodes using the tag of the specification, `arch.iter(spec.tag)`, this is normally impossible to iter on a node type from that SKIPPED_ELEMENT_TYPES node type list (`etree._Comment, etree._ProcessingInstruction, etree.CommentBase, etree.PIBase, etree._Entity`), as those node types do not have a tag (`spec.tag`). In addition, in the place calling `locate_node`, we already do this same check on the specification node: https://github.com/odoo/odoo/blob/48109c15d319ae69a8fcdd4a6c3b19172a2de6d9/odoo/tools/template_inheritance.py#L144-L150 Version spec should match parent's root element's version --------------------------------------------------------- It has also been added in the same revision: https://github.com/odoo/odoo/commit/31b9bee00676e179c124f3d42539103305cf7423 This has been added in 7.0 to handle `version="7.0"` in xml views. However, these `version="7.0"` have been removed in 8.0, in revision odoo/odoo@faa09da325 After the above revision, there were still some leftovers, but which have all been removed in 11.0 in revision odoo/odoo@70942e4cfb during an improvement of the RNG validator. This is therefore enough evidence to say this code checking for the `version` attribute in `locate_node` is no longer useful since a quite long time now. It can therefore be removed. closes odoo/odoo#107340 Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials