Nicolas Martinelli 1229b9a19c [FIX] sale_purchase: do not set Drop Ship Address
- Create 2 companies A & B
- Customers are not shared between companies
- Intercompany transactions activated (SO/PO + automatic validation)
- Create a service product P with MTO + Buy route
- Company B is a supplier for the product P
- Sell the product in company A to a customer C
  => a PO is generated in A thanks to the MTO rule
- Confirm the PO
  => a SO is generated in company B
- Set the user to have access to company B only
- Open the SO

An `AccessError` is raised during a `read` call on `res.partner` C.

The partner C is set as a delivery address of the SO because it is set
on the PO as a `dest_address_id`:

https://github.com/odoo/enterprise/blob/5a841b25389106ce254828a0383b4c71987b9f3a/inter_company_rules/models/purchase_order.py#L62

Looking further, it is set on the PO in the `sale_purchase` module.

Actually, there is no point of setting the field on the PO:
`dest_address_id` is a Dropship address only used in Stock:

https://github.com/odoo/odoo/blob/f705c4088ea7584b17769220a0a7ffcb00546e0b/addons/purchase_stock/views/purchase_views.xml#L38

Dropshipping is not supported for services. Moreover, in that specific
case the picking type usage is internal, so it should be `False`:

https://github.com/odoo/odoo/blob/f705c4088ea7584b17769220a0a7ffcb00546e0b/addons/purchase_stock/models/purchase.py#L55

opw-2260553

closes odoo/odoo#51888

X-original-commit: 9d6da7724a40bcc6b5c76aa733e7deee1b0ce922
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-05-26 11:42:25 +00:00
2020-04-20 11:41:39 +00:00
…
2019-10-03 12:48:09 +00:00
…
…
…
2019-11-08 11:24:04 +00:00
2019-10-03 12:48:09 +00:00

Build Status Tech Doc Help Nightly Builds

Odoo

Odoo is a suite of web based open source business apps.

The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...

Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.

Getting started with Odoo

For a standard installation please follow the Setup instructions from the documentation.

To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials

S
Description
No description provided
Readme LGPL-3.0
3.4 GiB
Languages
Python 49.6%
JavaScript 47.8%
SCSS 2%
CSS 0.3%
HTML 0.2%