034d78b3166ac5659d4d28e5419e70aac6194788
The test `test_15_website_link_tools` associated with the 'link_tools' tour has been problematic for a long time. Many fixes have been made already, mainly [1] but also [2], etc. As of today, the test now succeeds 100% of the time in 16.2 and below. Starting from 16.3, the tests still contains race conditions. As a first step towards fixing those, we will first disable the problematic steps so that we can re-enable the test on runbot. First, this commit is about unifying the 16.3 version of the tour with the previous versions (16.2). Indeed, while the test currently tests the same things as 16.2, for no apparent reason (see [3] and others): - Some phases of the test were reordered during the forward-port that introduced them. - A new "Popover should be shown" step was added during some forward-port (it is actually one that is the cause of a race condition, see below). - 16.4 and above: many new steps which save/re-enter edit mode were added, random clicks were added, trigger were changed, check were rewritten for no reason, etc... none changed the race condition rate (if anything, it worsened in 16.4, see below). - 17.0 above: some useful steps were added and do not seem to impact the success rate, this commit of course keeps them. This commit thus: - Reorders the steps the same way as 16.2. - Temporarily disables the problematic new step. - Removes all those useless changes. Here are some tests made in all those versions (before this commit): => 16.2 and below: - Tested: 100% working => 16.3: - Tested: 162 - Failed: 88 - 57 on "Check popover content is up-to-date" - 31 on "Popover should be shown" => 16.4: - Tested: 30 - Failed: 28 - 24 on "Check popover content is up-to-date" - 4 on "Popover should be shown" => 17.0: - Tested: 80 - Failed: 80 - 69 on "Check popover content is up-to-date" - 10 on "Popover should be shown" - 1 on "Check that links's href was updated" => 17.1: - Tested: 83 - Failed: 83 - 64 on "Check popover content is up-to-date" - 17 on "Popover should be shown" - 2 on "Check that links's href was updated" => master: - Tested: 37 - Failed: 37 - 26 on "Check popover content is up-to-date" - 11 on "Popover should be shown" Note that this commit actually seems to reduce the race conditions... which is of course not a solution on its own. The next commit will disable the problematic steps to have the test pass 100% of the time, until a real solution is found. => Tests with this commit: - Tested: 11 - Failed: 4 - 4 on "Check popover content is up-to-date" [1]: https://github.com/odoo/odoo/commit/da9afc46e32111afbe0f4bdae6d539795239290a [2]: https://github.com/odoo/odoo/commit/06f9a21c60b4bf7d375bdaba3fd4c8bc89d16b54 [3]: https://github.com/odoo/odoo/commit/9fc283b514d420fdfd66123845d9ec3563572692 runbot-57204 X-original-commit: 155bfd45b0678d69ed34d4e832df5a331a91a551 Part-of: odoo/odoo#154679
…
…
…
Odoo
Odoo is a suite of web based open source business apps.
The main Odoo Apps include an Open Source CRM, Website Builder, eCommerce, Warehouse Management, Project Management, Billing & Accounting, Point of Sale, Human Resources, Marketing, Manufacturing, ...
Odoo Apps can be used as stand-alone applications, but they also integrate seamlessly so you get a full-featured Open Source ERP when you install several Apps.
Getting started with Odoo
For a standard installation please follow the Setup instructions from the documentation.
To learn the software, we recommend the Odoo eLearning, or Scale-up, the business game. Developers can start with the developer tutorials
Languages
Python
49.6%
JavaScript
47.8%
SCSS
2%
CSS
0.3%
HTML
0.2%