Commit Graph
167393 Commits
Author SHA1 Message Date
Antoine Guenet fff405a6c2 [FIX] web_editor: temporarily skip mobile tests
The editor mobile tests are making wrong assumptions about the way the
editor behaves on mobile and are therefore wrong. This temporarily
disables them until the discrepancy is resolved.

Part-of: odoo/odoo#141303
2023-11-07 21:02:24 +00:00
Antoine Guenet ca034c0d8b [IMP] web_editor: notify when mobile version test fails
This adds a note in the error message when a mobile test fails, to
inform that it was a mobile test.

Part-of: odoo/odoo#141303
2023-11-07 21:02:24 +00:00
Thomas Lefebvre (thle) c7dd4d8242 [FIX] hr_attendance: take account lunchtimes
Steps to reproduce:
-------------------
- add lunchtime in an employee's calendar;
- in Attendance app, add attendance for
    this employee for the current month;
(The hours calculated in the attendances
take into account the lunchtime.)
- go to the form view of this employee;

Issue:
------
The statistics button, which displays the hours worked this month,
does not take into account lunchtimes.

Cause:
------
To find the hours worked, we calculate the difference
between the `check_in` and the `check_out`.

Solution:
---------
Use the `worked_hours` field of attendance, which takes into
account the employee's calendar and therefore lunchtimes.

opw-3547521

closes odoo/odoo#141282

X-original-commit: 94bd34af19d14da5deafd8f34f93ff71e35c8782
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
2023-11-07 21:02:22 +00:00
Maryam Kia 546f77d1ca [IMP] mail: sharing both screen and camera tests
This commit contains the tests related to the screen sharing at the same time with camera sharing on call

closes odoo/odoo#141275

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-11-07 21:02:21 +00:00
Sakesun 9e8259b0e1 [CLA] signature for sakesun
closes odoo/odoo#141270

X-original-commit: 0c0bf4f51a8f3d7ec37506b2321b24ad3b9b23ec
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2023-11-07 21:02:19 +00:00
tsm-odoo 9bf36e00a4 [FIX] bus: fix websocket outdated on db change
When the bus service is loaded, it connects to the websocket
worker and passes some information that are used to determine
whether the websocket connection is outdated.

Amongst them, the user id is used to detect when the user changed
and when the websocket connection should be refreshed.

This is not enough to ensure the websocket connection is still
relevant: the user id could be the same but the db could have
changed. The websocket would then be linked to the previous
database.

This commit fixes the issue by sending the db name alongside the
user id. This will ensure the connection is refreshed when it is
outdated.

Steps to reproduce the issue:
- Log in on db1 on 2 tabs
- Log out
- Log in on db2
- Try to star a message in the discuss app
- Nothing happens, the messages are sent from db2 but the socket
listens to db1

closes odoo/odoo#141263

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-11-07 21:02:17 +00:00
Pierre Rousseau d8efcd383f [FIX] web: correctly apply invisible attribute on button box
Steps to reproduce:
- Create a form view with a `div` with class `oe_button_box` and an
  invisible modifier inside a `sheet` tag
- Open the form view

=> The invisible modifier is not applied on the button box.

Since https://github.com/odoo/odoo/pull/116641, the invisible modifier
set on a button box inside a sheet tag is **replaced** by a condition
that check if the form is displayed in a dialog. This is not correct,
the invisible modifier should be **extended** with the dialog condition.

closes odoo/odoo#141259

X-original-commit: 570a1a9bf3e7c3012c516beb8850f320a6cc8f63
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
2023-11-07 21:02:16 +00:00
vlst ca43821f82 [IMP] point_of_sale: style receipt tracking number
In this PR we make the tracking number on the pos receipt
slightly larger.

closes odoo/odoo#141241

Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
2023-11-07 19:32:31 +00:00
Tiffany Chang (tic) df0a859555 [FIX] stock: exclude not-picked mls at validation
Requires barcode to be installed to reproduce (or customization of
view/direct shell manipulation)

Steps to reproduce:
- create a SN tracked product with 2 serial numbers
- setup a delivery with a demand of 1 of the SN tracked product
- open the delivery in barcode
- scan the product then scan the not reserved SN
- validate

Expected result:
Only the scanned SN is marked as done

Actual result:
Both SNs are marked as done and the move quantity = 2

Issue is due to the code expecting all mls of a "picked" move to be
processed as done. Typically when this flow is done in the backend, the
user can see that they need to set the not used SN quantity to 0, but
this is not the case in barcode. Therefore since barcode will mark the
scanned SN ml as "picked", but not the other (reserved, but not scanned)
SN, we check at time of picking validation whether or not all of the mls
are marked as "picked" and if now, only count the ones that are marked.

Note that same issue can occur when multi-location quants and
non-reserved loc quantities are scanned.

closes odoo/odoo#141210

Related: odoo/enterprise#50274
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
2023-11-07 19:32:30 +00:00
qsm-odoo 351f5cf54e [REM] website: remove dead code related to o_navbar_toggler_container
closes odoo/odoo#141198

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2023-11-07 19:32:28 +00:00
qsm-odoo d9c0b8f5ca [IMP] website: optimize CSS for mobile navbar background color
The `o-bg-color` mixin was used to color the mobile navbar: it was
useless. First, in general, `o-bg-color` should rarely be used:
`o-apply-color` is best as it will call the other one when needed. Then,
this comes with many extra rules to color the text, inner subtitle, etc.
All of those rules are already inherited from the parent navbar: we only
want to re-apply the background-color on a sub element (the mobile
navbar) in this case.

Part-of: odoo/odoo#141198
2023-11-07 19:32:28 +00:00
Pierre Masereel 54afc1366f [FIX] base_import_module: get industries categories
Since we have multiple categories for the Industries apps. We are now
getting them from apps.odoo.com. And we are using the ids from apps in
the domain that is sent back to apps.

closes odoo/odoo#141173

Signed-off-by: Pierre Masereel (pim) <pim@odoo.com>
2023-11-07 19:32:27 +00:00
dise-odoo 6d9302c786 [FIX] project_todo: missing "add a to-do" in the command palette
Task 3300854 would remove the "add a to-do" action in the systray, but
by doing so, it removed the action in the command palette as well. This
PR will re-add the action in the command palette.

The ActivityMenu component is patched to add the command each time it is
loaded.

task-3580533

closes odoo/odoo#141168

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-11-07 19:32:25 +00:00
Nicolas Viseur (vin) f3a2ba5e7e [IMP] account: AU Remittance Advice
On top of the change in the template done in
https://github.com/odoo/odoo/commit/5dc625fada8ac07ba419f60a7d416210d7b1cb89

This will change the Payment Receipt string when
using the en_au language in order to also display
that this will print a remittance advice.

Task id #3465257

closes odoo/odoo#141144

Signed-off-by: John Laterre (jol) <jol@odoo.com>
2023-11-07 19:32:24 +00:00
Habib (ayh) 00efda4d77 [IMP] analytic,purchase,sale: misc analytic improvements
1. Order Plans by sequence in the widget and analytic item views
2. Add amount_field to analytic widget in sales and purchase views
3. UI improvements (split plan name and percentage)

Task-3572128

closes odoo/odoo#141030

Signed-off-by: William André (wan) <wan@odoo.com>
2023-11-07 19:32:22 +00:00
Romain Derie a23e19cf95 [FIX] website: remove useless code messing with action todos
With the new website scraper (see enterprise counterpart), there would
be a failing test / flow due to the `ir.actions.todo` introduced by this
new module.

This is because when the testing suite is run, this module is installed
and after choosing a theme for a website, the next action is fetch and
executed.

But that doesn't make sense anymore, it seems to be code leftover
messing around. On top of code leftover, it's also probably never what
we want as when choosing a theme, we want the user to be redirected to
his website. Other TODO actions should not alter that.

The `action_launch()` code removed here is was initially introduced with
commit [1] which was coming with an override of this method in website
but this override was removed with commit [2], nullyfing the need of
this call.

The condition to show the loaded which is removed here was introduced
with commit [3] in case the edit mode was requested.
But that "if edit mode" condition was actually removed with commit [4].

All in all, what we want is to always show the loader and always
redirect to the website.

[1]: https://github.com/odoo/odoo/commit/c1e0b03d8b5482a5150a0973e1ca48d70864a4e1
[2]: https://github.com/odoo/odoo/commit/e8a5af2e28a4724f86783746706cb59175f086bf#diff-2eb3a36c4664b647c665047166b246667200bf5f18ec53c640a9612b0d5e06ceL69
[3]: https://github.com/odoo/odoo/commit/1ff7f1e8b6b5539311f94f9828d203ec233daccb
[4]: https://github.com/odoo/odoo/commit/e38808e1a77dab291beb4020a2bf3c248f88cdef

closes odoo/odoo#141450

Related: odoo/enterprise#50161
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2023-11-07 19:32:20 +00:00
Arnold Moyaux 3e179ad437 [FIX] stock: remove show details before button group
Only keep the forecast widget since it does the same with more data.
There's no point in showing the forecast for done or cancelled
production orders.

The purpose is to have an easy view at the beginning. Avoid to
add too much useless information for users
Also put it at the end so it's the same standard for
stock/mrp/repair

closes odoo/odoo#140955

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
2023-11-07 19:32:19 +00:00
FrancoisGe 5674e221c4 [FIX] web, *: clicking on a button that crashes does not enabled buttons
In many situations, when you click on a button, you want to disable all
the other buttons while it is running.
Currently, in each of these situations, we duplicate the same code that
disabled all the buttons and enabled them afterwards. Unfortunately, in
many cases, if the code executed crashes, the buttons are not enabled.
In this commit, we're going to create a helper so that we have a single
version of the code that correctly handles crashes. This helper will
disabled all the buttons, then execute the click code and enabled all the
buttons afterwards. If the code crashes, it will also enbaled them.

The problem has been reported for the Settings Form view:
When you edit this view and click save, if an error occurs in the save,
all the buttons remain disabled.

closes odoo/odoo#140938

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2023-11-07 19:32:17 +00:00
qsm-odoo 1fa701c436 [FIX] website: properly allow to edit header texts and links
The text and links in the header configurations were always the root
elements that were editable. For them to be properly editable, we need
their container (at minimum) to be the root editable element. Indeed,
on root editable elements, only the class and style can be changed (if
not dynamic). But changing a link requires to change the href, the
target. Changing a text style requires to change the tag entirely, etc.

For this to work, the `_link_class` configuration was removed, it was in
fact mostly useless and actually even breaking some layouts. So doing
this fix actually improves the design as well. For the layout were it
made sense, it actually became useless by refactoring the templates.
This was necessary anyway for texts which did not use `_link_class` but
were root editable nodes anyway because of the `t-if` conditions laying
around.

closes odoo/odoo#140869

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2023-11-07 19:32:16 +00:00
qsm-odoo 7f3ad07cf6 [FIX] website: remove useless class configuration for header text
The configurable text in the header templates has a `_link_class`
option which sometimes was set to add the "nav-link" class on the
links in the default header texts... but that class was already there
no matter the config.

This removes the double class addition.

Part-of: odoo/odoo#140869
2023-11-07 19:32:16 +00:00
Alexandre Kühn d68488db7d [FIX] mail: several slight messaging menu improvements
Before this commit, the Messaging Menu had the following issues:

- Header is too large;
- Header color in dark theme is too white;
- Important notifications (= needactions) are not highlighted enough
  compared to muted notifications;
- Notification body and title looked too alike;
  => title should be more visible than content
- Mouse-hovering on notification items breaks background-inherit
  style of avatar and IM status;
  => side-effect of `list-group-item-action`
- Desktop: Header items slightly move when changing selection;
  => comes from `fw-bolder`
- Desktop: mark as read button was too small and not visible enough;
- Mobile: too many borders, and they are too strong;
  => undesirable dropdown style
- Mobile: Messaging Menu had poor "New message" button link whereas
  Discuss app has nice "Start a conversation" button;
- Mobile: "Start a conversation" button is not shown on livechat tab;
- Mobile: when menu is open while Discuss app is open in background,
  it's unclear whether the messaging menu is open or not;
  => missing background highlight on Messaging Menu toggler
- Mobile: State of Mobile Discuss App was not synced properly when
  using Messaging Menu at the same time;
  => e.g. unselected tab
- Mobile: Discuss app and Messaging Menu were not properly aligned;
  => Messaging Menu did not offset position based on systray navbar
  height
- Mobile: active navbar item was not highlighted enough, especially
  in white theme;
- "OdooBot has a suggestion" is shown on all tabs instead of only
  in "All" tab like "OdooBot has a request";

This commit fixes all the above issues.
Some styling issues were also affecting the Activity Menu, such as
borders and highlighted open state. This commit applies these
few improvements on the Activity Menu too.

closes odoo/odoo#140405

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2023-11-07 19:32:15 +00:00
yhu-odoo e2f54d904c [FIX] mrp: wrong manual consumption value in onchange
When `manual_consumption` field on sm is used in any onchange function,
the value will always be computed for the `new_id` record instead of
using the original value stored in database. This results in a different
value in some cases. In this commit, we chech if the compute function is
called from an onchange funtion or not, if so, we use the original value
instead of recomputation.

closes odoo/odoo#140753

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
2023-11-07 17:57:16 +00:00
yhu-odoo 9028b76e90 [FIX] mrp: set qty not working for manual consumption
When a component is in manual consumption and without picked checked,
set qty button on the warning wizard doesn't work for it. This is
because we didn't set the move picked = True when click set qty button.
Fix it by set the value.

Part-of: odoo/odoo#140753
2023-11-07 17:57:16 +00:00
yhu-odoo 71f77ba67c [FIX] mrp: wrong consumption warning lines
To reproduce:
1. Create an MO of Product with BOM
2. Manually set qty for a component
3. Produce all

Issue:
Two consumtion warning lines are shown, and numbers are wrong

Part-of: odoo/odoo#140753
2023-11-07 17:57:16 +00:00
Pierre Rousseau e4b66668e0 [FIX] web: do not use command "set"
In a many2many_tags field with onchange and on a slow network, quickly
add or remove tags several times. Each call to update sends a command 6
(SET) based on the current state of the record (typically here,
the very initial state). For example, if there're 2 tags [1, 2] in the
relation and I add 3, a command 6 with ids [1, 2, 3] is sent. If I
quickly add 4 before the onchange returns, another command 6 with ids
[1, 2, 4] is sent. At the end, 3 would not have been added to the
relation.

With this commit, we don't use the command "set" anymore. Instead, we
use a combinaison of commands "link" and "unlink" to add and remove
records from the relation. This way, we don't need to know the current
state of the record, and we can be sure that the final state of the
relation is the one we expect.

Task-id 3522153

closes odoo/odoo#140644

Related: odoo/enterprise#49995
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2023-11-07 17:57:14 +00:00
Thomas Beckers 1c83d4f41b [FIX] l10n_it_stock_ddt: fix comparing date and datetime
Field 'date_done' is a datetime object and field 'invoice_date' is a date
object. They will be considered as different even if the 'date' part is
the same which is the opposite required to check if invoice is direct.

>>> ddt.date_done
datetime.datetime(2023, 7, 11, 10, 2, 56)
>>> invoice.invoice_date
datetime.date(2023, 7, 11)
>>> ddt.date_done != invoice.invoice_date
True

This fix casts 'date_done' into a date object before comparison.

>>> ddt.date_done.date() != invoice.invoice_date
False

opw-3571327

closes odoo/odoo#140538

X-original-commit: 87a6f398e2047b4739e27be28e75399c2ddd717f
Signed-off-by: John Laterre (jol) <jol@odoo.com>
2023-11-07 17:57:13 +00:00
Rémi Rahir (rar) 542b3b97ed [IMP] spreadsheet*: Add a print mode for spreadsheets
The current spreadsheet layout is not adapted to print the document as
the spreadsheet component is designed to only be rendered in the visible
part of the client viewport, the invisible parts of the spreadsheet are
not rendered.

This revision adds the possibility to render the whole spreadsheet when
the user wants to print the document (either via a top menu button or
with the generic shortcut Ctrl+P).

closes odoo/odoo#140281

Task: 3575484
Related: odoo/enterprise#49829
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
2023-11-07 17:57:11 +00:00
Guillaume-gdi b7d5d2686a [IMP] website: reduce padding of the website loader
This commit reduces the padding of the website loader to prevent too
much line breaks of the text.

task-3557675

closes odoo/odoo#138921

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2023-11-07 17:57:09 +00:00
Guillaume-gdi ebd09603c1 [IMP] website: add a fake loader during website install
This commit adds a fake loader during website install. [Another commit]
already added a loader during extra module install. The goal here is to
have a loader even if there is no extra module to install. This should
make the user think the install is faster and prevent him from leaving.

This commits also improves the loader when there are extra modules to
install. We split the loader in two parts: one for the modules install
(70%) and another for the rest of the install (30%).

Note that to test this feature properly, you need to be in a multiple
workers environment.

[Another commit]: https://github.com/odoo/odoo/commit/ab6564be94533a64a0a942202f0860423ec7dc4d

task-3557675

Part-of: odoo/odoo#138921
2023-11-07 17:57:09 +00:00
Tiffany Chang (tic) ee2fe22db8 [FIX] stock: optimize _search_product_qty
The existing `_search_product_qty` was not scaleable for dbs with many
lots, therefore we optimize it to be more clever.

Also add in the missing operator/value checks.

closes odoo/odoo#126795

Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
2023-11-07 17:57:07 +00:00
kir-odoo 03b6d593ea [IMP] stock_account: add new menu inventory aging
- Add a new menu called Inventory aging.

- The purpose of inventory aging is that users can track the quantity and time
  spent on inventory.

- When accessing the `Inventory Aging` menu, users will be directed to the same
  model found in the valuation menu.
  However,the `Inventory Ageing` menu presents an open default pivot view
  with predefined filters that facilitate the visualization of inventory aging based on quantity.

Task: 3207613
Part-of: odoo/odoo#126795
2023-11-07 17:57:07 +00:00
Christophe Monniez 252becef19 [FIX] base: 3.11 compatibility
Complement of the previous complement e2752a04ff (#137099)

Those opcodes were added in Python 3.11 and we missed them.

Fixes #140588

closes odoo/odoo#141015

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2023-11-07 15:12:48 +00:00
Benoit Socias 2b2122a3c6 [FIX] website: make generated templates noupdate
Since [1] when the generation of missing configurator templates and new
page templates was introduced, `_load_xmlid` was called for every
generated record so that `_process_end` does not delete them after a
module update.
Unfortunately, this trick does not work when using the "Upgrade" command
on the Website app in the Apps view. (or calling
```py
env['ir.module.module'].search([
    ('name', '=', 'website')
]).button_immediate_upgrade()`
```
from the shell): in that case, the `self.pool` onto which the xmlids
were registered was a different instance from the one accessed by
`_process_end`.

This commit avoids this problem by making the generated templates
`noupdate: True`, thus preventing `_process_end` from deleting them.

Steps to reproduce:
- Install website with -i
- Go to Apps, search Website, upgrade Website
=> In the logs you can see that some templates are deleted at the end of
   the upgrade
- Website configurator: a business website, furniture store, get leads,
  choose a palette, about us + services + pricing + privacy policy,
  choose the center template (loftspace)
=> You see some crash in the logs

[1]: https://github.com/odoo/odoo/commit/a2f8e18b76e52e1a349b77691d0af18edc09a1be

closes odoo/odoo#140986

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2023-11-07 15:12:47 +00:00
prye-odoo 04e5eff325 [FIX] point_of_sale: prevent traceback while uninstalling module
When users try to uninstall the "point_of_sale", a traceback will be generated.

Error:   TypeError: uninstall_hook() missing 1 required positional argument: 'registry'

This is because the https://github.com/odoo/odoo/pull/138189 added the
unistallhook from 16, but in the forword port of this PR, it did not change
the argument list according to the new unistall hook from saas-16.2.

This commit fixes the above issue by passing a valid argument
in the unistill hook.

code reference:
https://github.com/odoo/odoo/blob/saas-16.2/addons/point_of_sale/__init__.py#L11

sentry-4586084597

closes odoo/odoo#140591

X-original-commit: 9eda662a89943f3c6725e223bf30238ef8e661f2
Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>
Signed-off-by: Pradip Yenpure (prye) <prye@odoo.com>
2023-11-07 11:21:56 +00:00
Jeremy Kersten 495a5090a5 [IMP] website_sale: don't try to support url manipulation
In case user tries to play with url/input to change the partner_id the
code handle the case and pop the wrong value.

Instead, raise an explicit error message.

closes odoo/odoo#140266

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2023-11-07 11:21:55 +00:00
svs-odoo 3bcfd6a4e5 [FIX] product: colored background in catalog
Before odoo/odoo#135502, the background of a record was colored if it
has some quantities or if it is read only, but this detail was lost.
This commit fixes that.

closes odoo/odoo#140255

Related: odoo/enterprise#49808
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2023-11-07 11:21:53 +00:00
Julien Castiaux fb2e401359 [FIX] survey: next question is not iterable
Open a live session for the burger quiz, join as an attendee. Everytime
the host reveal the next question, the attendees get a traceback.

```js
TypeError: ... is not Iterable
```

A recent commit 7109f48 changed the controllers of survey, they used to
`return self._prepare_question_html(...)`, most of them now
`return {...}, self._prepare_question_html(...)`, with the notable
exception of the `survey_next_question` controller which continues on
returning only the `_prepare_question_html(...)`.

JS-side, the `self._prepare_question_html(...)` payload is retrieved via
`const [,result] = await nextScreenPromise;`, i.e. it excepts an array
of 2 elements and retrieve the second one.

As the other survey controllers have been modified inside 7109f48,  the
`survey_next_question` should be updated too but was forgotten. Returns
an empty dict for the correct answers and the next page html.

Task-3374998

closes odoo/odoo#139204

Reference-to: 7109f48 ([IMP] survey: add scoring after each page)
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
2023-11-07 11:21:50 +00:00
Julien CastiauxandPierre Pulinckx 36882a45c7 [FIX] survey: missing vote count on top of bars
Start the a live session, I used Burger Quizz, answer a question. On the
manager side, the current vote count for each choice should be visible
on top of each bar in the chart. That vote count is missing.

During the migration of chartjs from v2 to v4, the datalabel plugin was
updated from v0.7 to v2.2 in the same time. Using the new version of the
datalabel plugin, the plugin is not automatically loaded anymore, one
must explicitely loads it.

We also removed the datalabel plugin from the bundle to load it
explicitelly instead. The JS framework finds it cleaner this way.

Task-3537480

Reference-to: 7e3c1ecdb8 ([REF] *: Update Chart.js to V4.3)
Part-of: odoo/odoo#139204
Co-authored-by: Pierre Pulinckx <pipu@odoo.com>
2023-11-07 11:21:50 +00:00
Mayurrajsinh Rathod 8f77a30cc5 [FIX] web: fix dialog overlap on fullscreen
Steps to reproduce
==================
1. Open marketing automation and select any campaign.
2. Click 'edit' on activity or click 'add new activity'.
3. Select existing mail template and open it to edit the template.
4. Select template on mail body page and click fullscreen from snippet.
The activity modal dialog appear at top of everything.

Technical
=========
In prior version, the 'owl_dialog.js' file includes a 'display' function that
applies the 'o_inactive_modal' class to the inactive dialog, adjusting its
z-index. However in master, the commit https://github.com/odoo/odoo/commit/036307ba260ef1a08e80a14f7cffe1ef9a24021c removes the'owl_dialog.js'
file, resulting in the class no longer being applied.

After this commit
=================
The 'o_inactive_modal' class is applied based on the state 'data' to
position the dialog below the fullscreen editor.

Task-3512850

closes odoo/odoo#139165

Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
2023-11-07 11:21:49 +00:00
Odoo's Mergebot 6a0888175d [MERGE][FIX][IMP] mail: display activities without record access in the systray
When scheduling plans on employees, activities may be assigned to people who
don't have access to the record. It was managed locally in HR through a dummy
model aggregating activities. However, it was removed and we replace it here by
a generic solution that adds an entry in the systray: "Other activities". When
clicking on that entry, it displays a list view of the activities assigned to
the user for which he has no access to the related record. Those activities
were not visible to the user before.

Technical note: to allow displaying such records, we have modified the custom
acl defined in python to allow users to read activities assigned to them even
if they don't have access to the related record.

[IMP] mail: allow to mark as done activity without record access

When scheduling plans on employees, activities may be assigned to people who
don't have access to the record, but they still need to mark them as done. And
as marking as done (action_done on mail_activity) triggers a message post on
the related record, that action cannot be executed by a user without access to
the record.

We change that here to allow user having delete/archive right on the activity,
to be able as well to mark it as done (as the activity is archived/deleted at
the end of the method _action_done, the user must at least have the right to do
that to be able to mark as done the activity).

[IMP] mail: add custom view for "other activities"

When clicking on "Other activities" in the systray, a list of activities
assigned to the user for which he has no access to underlying record is
displayed. The default list allows to delete, archive, duplicate, ...
activities but what we want is a readonly view. We add here a new view that
doesn't allow any modification on the activities by removing those actions.
Unfortunately, archive and unarchive action is not controllable with an
attribute (nor by setting the active field as readonly in the view), so we
create a very simple extension of the list view to disable it.

We also add in the list view a button to mark an activity as done and a simple
form view to see the details of the activity (note, ...). The "mark as done is
not added in the form view as the activity is deleted causing an error because
the form is still displayed and the record is gone.

Note that those action are only removed from the client but the actions are
not forbidden on the server side.

[IMP] mail: limit performance impact of the systray

To limit performance impact of the systray, we fetch by default only the last
1000 activities. That value can be configured with mail.activity.systray.limit
config parameter. Note that this can also improve a bit the readability of the
other activities view (for the standard activity view a pager is already
present).

[IMP] mail: add fallback for not deployed action/view

To avoid crash on possibly not deployed action and related views
(mail.mail_activity_without_access_action), we temporary add a fallback on
existing action and views.

Task-3562098

closes odoo/odoo#139917

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2023-11-07 09:19:03 +00:00
Pierre-Yves Dufays 5415953b21 [IMP] mail: add fallback for not deployed action/view
To avoid crash on possibly not deployed action and related views
(mail.mail_activity_without_access_action), we temporary add a fallback on
existing action and views.

Task-3562098

Part-of: odoo/odoo#139917
2023-11-07 09:19:03 +00:00
Pierre-Yves Dufays bbc1b5c0a6 [IMP] mail: limit performance impact of the systray
To limit performance impact of the systray, we fetch by default only the last
1000 activities. That value can be configured with mail.activity.systray.limit
config parameter. Note that this can also improve a bit the readability of the
other activities view (for the standard activity view a pager is already
present).

Task-3562098

Part-of: odoo/odoo#139917
2023-11-07 09:19:03 +00:00
Pierre-Yves Dufays c5bd3f6b2f [IMP] mail: add custom view for "other activities"
When clicking on "Other activities" in the systray, a list of activities
assigned to the user for which he has no access to underlying record is
displayed. The default list allows to delete, archive, duplicate, ...
activities but what we want is a readonly view. We add here a new view that
doesn't allow any modification on the activities by removing those actions.
Unfortunately, archive and unarchive action is not controllable with an
attribute (nor by setting the active field as readonly in the view), so we
create a very simple extension of the list view to disable it.

We also add in the list view a button to mark an activity as done and a simple
form view to see the details of the activity (note, ...). The "mark as done is
not added in the form view as the activity is deleted causing an error because
the form is still displayed and the record is gone.

Note that those action are only removed from the client but the actions are
not forbidden on the server side.

Task-3562098

Part-of: odoo/odoo#139917
2023-11-07 09:19:03 +00:00
Pierre-Yves Dufays e918146670 [IMP] mail: allow to mark as done activity without record access
When scheduling plans on employees, activities may be assigned to people who
don't have access to the record, but they still need to mark them as done. And
as marking as done (action_done on mail_activity) triggers a message post on
the related record, that action cannot be executed by a user without access to
the record.

We change that here to allow user having delete/archive right on the activity,
to be able as well to mark it as done (as the activity is archived/deleted at
the end of the method _action_done, the user must at least have the right to do
that to be able to mark as done the activity).

Task-3562098

Part-of: odoo/odoo#139917
2023-11-07 09:19:03 +00:00
Pierre-Yves Dufays 54aaf3a0a5 [IMP] mail: display activities without record access in the systray
When scheduling plans on employees, activities may be assigned to people who
don't have access to the record. It was managed locally in HR through a dummy
model aggregating activities. However, it was removed and we replace it here by
a generic solution that adds an entry in the systray: "Other activities". When
clicking on that entry, it displays a list view of the activities assigned to
the user for which he has no access to the related record. Those activities
were not visible to the user before.

Technical note: to allow displaying such records, we have modified the custom
acl defined in python to allow users to read activities assigned to them even
if they don't have access to the related record.

Task-3562098

Part-of: odoo/odoo#139917
2023-11-07 09:19:02 +00:00
Ritika Rathore d5b40f0007 [FIX] hr_timesheet,project: fix visibility of fields in portal
Steps:
- Install project, timesheet & website
- Open project module
- Select any task
- Set Allocated Hours
- Go to the task corresponding project & disable the timesheet
- Then appear in portal form view

Issue:
- In portal form view of project's task the 'allocated time' and the 'progress' fields shouldn't be visible if the 'timesheets' feature is disabled on the project.

Cause:
- There is no any condition for allocated time  and progress field.

Fix:
- Added condition for both field in hr_timesheet & project respectively.

Task-3495253

closes odoo/odoo#141357

X-original-commit: 58040fed8b075b40cf6d2be73de53b600bf9f94d
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
2023-11-07 08:01:01 +00:00
Pedram (PEBR) 18941ac6a7 [FIX] point_of_sale: load partners by email and mobile/phone number
Before this commit, partners that were not already loaded in the PoS
couldn't be retrieved using their phone number or email address. This
functionality is essential for customer recognition.

opw-3548843

closes odoo/odoo#140573

X-original-commit: 57eff2d338f96d80bf2332502a352601292109d1
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Robin Heinz (rhe) <rhe@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
2023-11-07 08:00:59 +00:00
Nshimiyimana Séna 5d5c3f2151 [FIX] l10n_latam_check, account_check_printing: ensure third party check number are numeric
Summary
-------
Currently, when `l10n_latam_check` is installed, third party checks'
number can be non-numeric.

Steps to reproduce
------------------
* install  `l10n_latam_check`, and `l10n_ar`
* switch to an Argentinean company
* create and validate an invoice
* register a payment for that invoice using:
  - Journal: Third Party Checks
  - Check Number: anything that's not a number

The payment is created without issue, but it shouldn't. This ends up
causing tracebacks elsewhere because we expect the check number to only
contain digits.

Cause
-----
The `l10n_latam_check` module overrides `_constrains_check_number`, to
disable it on third party checks. The goal is to allow third party check
numbers to be non-unique. However, the code that checks whether the
`check_number` value only contains digits is in the same method. This
means that by skipping the uniqueness check, the code also skips the
value check.

Fix
---
This commit splits `_constrains_check_number` into two methods (one for
checking the value, and the other for uniqueness), and modifies
`l10n_latam_check` to override the uniqueness check only.

opw-3464012

closes odoo/odoo#141371

X-original-commit: 3e7b1f014af9b34473fe6eba07bc051b38a74c72
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Séna Serge Nshimiyimana (sesn) <sesn@odoo.com>
2023-11-07 06:07:01 +00:00
TSO bc16aae6e2 [FIX] discuss: rely on streaming state flags instead of streams
Before this commit, we used to rely on duplicates of streams and the
presence of streams to know if a session was streaming.

This commit changes this and make it so that we now use streaming
activity flags instead.

This is a prerequisite for https://github.com/odoo/odoo/pull/132153 as,
similarly to webRTC "unified plan", the SFU keeps the same streams for
the whole lifespan of a connection.

closes odoo/odoo#140053

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-11-07 04:29:04 +00:00
Didier (did) f09d659a26 [FIX] mail: add missing threadService to mailCoreWeb
closes odoo/odoo#141207

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2023-11-06 20:52:29 +00:00