*: website
As the text editor is still the summernote one, this improvement was
made possible through a series of hack. It has to be reviewed once the
new editor is ready.
This makes the text tools only appear in the style tab by switching to
it as soon as the summernote tools are updated. To prevent flickering,
css and js hacks had to be made.
This also moves the undo/redo buttons in the top bar with another hack:
those simulates click on the hidden summernote ones.
Part of https://github.com/odoo/odoo/pull/58638
X-original-commit: 0f65015b1b0a849bf109df11fd18a9e3a62820e4
*: website
Inside a color combination (or outside, as considered the same as inside
color combination number 1), the link color can be configured. It is
set by themes to one of the 5 theme colors. Sometimes, no color of
those 5 colors contrast enough with the color combination's background
and we accepted that before, relying on the fact the user can change the
link color if he wants too. Now we automatically increase the contrast
of those link colors, except if the user overrides it.
This system might be extended to all foreground colors in the future but
the system has to be improved for that.
closesodoo/odoo#58739
X-original-commit: f8abb476fe0475799a3da66d49a92c7de2ace8a0
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The invoicing tour suggests to change the invoice number manualy but it
is not doable with l10n_ar because of the document number mechanism.
The partner needs the AFIP responsability to be set in order to generate
the number.
closesodoo/odoo#58721
X-original-commit: 25889e469c063c307fee9c15b48fe4316207aeb3
Signed-off-by: Josse Colpaert <jco@openerp.com>
This commit aim to improve the algorithm to select the next talk suggestion
after a track has ended, in order to support small interact between two longer
talks.
Idea:
- all talks that begin less than 10 minutes before (all at same ordering level
whatever actual time)
- then talks beginning in a near future
Task ID: 2344522
closesodoo/odoo#58701
X-original-commit: 7f1e46331aecdaa4e08828240a495923c251c69f
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The prefetching optimization was simply broken for x2many lines in the
snapshot method `diff()`. Indeed, iterating on `line._prefetch_ids`
actually returns nothing, because this iterable object relies on the
value in cache of the x2many field, and the cache has been invalidated
before calling `diff()`. In order to re-enable prefetching, we simply
populate the cache of x2many fields before looping on the lines.
Some testing with `account.move` and the relation `invoice_line_ids`:
For 335 invoice lines, changing the value of a field in the invoice
lines took about 1.9s with 1415 queries. It now takes about 1.1s and 82
queries.
closesodoo/odoo#58687
X-original-commit: 5bd7ddd0850e56fbbae52b4478970331f9db1589
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Co-authored-by: Raphael Collet <rco@odoo.com>
If we select a line without an name for the automatic entry wizard, it
will be displayed as "false" in the preview widget. Even though, the
value will be set to NULL in the database, we don't want to see "false"
in the preview.
closesodoo/odoo#58680
X-original-commit: e6c93c2632555b100d31ba6745a8bca62d44450e
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
When opening automatic entries on a group of entries which sum equals to
zero, a division by zero occurs which cause a traceback.
This commit will fix the issue.
task id #2334872
X-original-commit: bd8b81c62c4256898d579f81f066ad202f4ea79a
When the alias had been set, if the user wanted to disable it
he had to erase the email first. Otherwise unchecking the check box
didn't work.
Task-2299286
closesodoo/odoo#58634
X-original-commit: 45cd13e14fef0bab6921a1fff79335df9015cbf0
Related: odoo/enterprise#13613
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Currently, in employee form view edit mode, the icon of chat is
displayed underneath the name but it should be dsiaplyed in right
side of name like in readonly mode.
So in this commit, Fix the icon display issue and icon should be
right side of the name.
closesodoo/odoo#58623
Taskid: 2344588
X-original-commit: 903c8ef53cb0187075ce9db705a3d0b6faa32c8c
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
User settings (Calendar) the token was too long to be kept on one line.
closesodoo/odoo#58583
Taskid: 2335303
X-original-commit: b497837522779def181c19957e25c7629a567793
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Currently, expense analysis menu have default view as list and kanban
but is should be graph,pivot,list and kanban.
Here viewmode is already in same sequence but only list and kanban
view is linked with action. graph and pivot view is not linked with
action so it will be always comes up in last in sequence.
So in this commit, Link graph and pivot with the action so it should
comes up first in expense analysis menu.
closesodoo/odoo#58582
Taskid: 2337224
X-original-commit: e273afd187edca1df6b462af42db3cce58df88d7
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
In a multi-company environment it can be difficult to see which journal
is from which company on the dashboard, when multiple company have been
selected.
This commit will update the dashboard to show the company names on the
journals in those cases
Task id #2337719closesodoo/odoo#58574
X-original-commit: 64402d92e8e96350a909bd77818e70c40bdd29ae
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
The kanban view was not properly using the custom javascript class.
closesodoo/odoo#58567
Taskid: 2340951
X-original-commit: dbc3785f5057a784104c434d6f0a06f2e9097208
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Fix traceback when creating a new contact by checking the id list is not empty.
Task ID : 2302578
closesodoo/odoo#58681
X-original-commit: 31f2bb5e494965d31f5e49d47908fd4b5eb64077
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Fix weird behavior between linear-gradient and background-size
with safari, if we don't set the value for linear-gradient.
task-2334731
closesodoo/odoo#58673
X-original-commit: c2747c60161c66f9c77feae884fd101edb693d80
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose of the retro-compatibility route was to redirect the old to the new.
And not redirect to themself and create a loop
closesodoo/odoo#58672
X-original-commit: b5e1bafeb42e94b587c245e9e7aa844770a129c6
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Fix margin for kanban view that was displaying a horizontal
scrollbar.
task-2346202
closesodoo/odoo#58669
X-original-commit: 97a43dde99835d4e3c4daf7e3e0b46342af46ab9
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
When registering payment, we display now the date + time instead just the date.
closesodoo/odoo#58667
X-original-commit: eb534d078dcdf58aedf09131dd57c8f6da69a910
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
The method get_fiscal_position was missing the @api.model decorator
closesodoo/odoo#58665
X-original-commit: 7cad8db251b62972b3a0ea8ca970014cd0f1b5c1
Signed-off-by: Josse Colpaert <jco@openerp.com>
Calling a compute method on 1M records inevitably brings a worst case in
cache prefetching: the code that determines which records to fetch has
time complexity O(N²). We avoid this situation by calling the compute
method on maximum 1K records. Each computed batch has a "prefetch set"
of maximum 1K records too, which avoids the worst-case scenario above.
closesodoo/odoo#58664
X-original-commit: 0b1aa660b1d94fe46dea09670b875f2d81ca36a3
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
This commit improves the performance of the 'sale_price_subtotal' field of
event.event by refactoring the way it's computed.
The previous naive implementation looped on sale.order.lines linked to the
event and performed a currency conversion for every single line. This leads
up to thousands of requests to fetch the conversion rate and sum up everything
on a real production database like Odoo.com .
This new implementation groups the amounts by currency and performs a single
conversion per currency (factored by the number of events in 'self'). It has
the drawback of using 'today' to fetch conversion rates instead of the actual
SO date like previous implementation.
We (aka: all main POs as this decision was discussed) consider that as an
acceptable trade-off to increase performances.
Task ID-2335287
closesodoo/odoo#58650
X-original-commit: a4c4b03a09ffc08842f44b5759e3c7298cfbd915
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit, the colors of the navbar in the table of content
menu were not adapted to the color combinations system. With navbar in
top position, the background and the colors of the links were using the
same color.
After this commit, the colors of the list-group-item links are also
adapted with color combinations.
task-2312878
closesodoo/odoo#58645
X-original-commit: a0dc17676c570887773854243bcb8cd8823359d5
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
When creating an event through the quickcreate, the user creating the
event was not set as attendee.
closesodoo/odoo#58631
Taskid: 2334943
X-original-commit: 07d799a5f676ed68fd2ffd9cd9bac3269f947ad1
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Kevin Baptiste <kba@odoo.com>
After this commit, if an url with trailing slash is not found we fallback
to the url without the slash with a redirect to respect seo.
With this change we have the same behavior that controllers.
We continue to support trailing slash if page explicitely created with /
via backend e.g. and for retrocompatibility.
task-2346185
closesodoo/odoo#58603
X-original-commit: 3d65424708d1623654756d58d78cec5f8d71276f
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
When a company is created, a note is added with all the additional
info retrieved from the IAP. Just like when autocomplete is enabled.
closesodoo/odoo#58598
X-original-commit: 0cc87a9349ab3d4e0d51a837deb6630d692ac98f
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
This commit fixes several issues
* there are still some jinja references although the template is now done
in QWeb;
* put preferences content inside the same paragraph to avoid unnecessary
blank spaces;
* fix hardcoded company name (olé);
Followup of fd8709515c
Task ID-2338930
closesodoo/odoo#58577
X-original-commit: fd838a3d87f5bd326921dd15c2a41c3d1d3dd131
Related: odoo/enterprise#13591
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Since yet another change in view / server synchronization order line was
not correctly propagated to registration editor values. Registrations
were created several times when confirming an order as backend did not
receive order line information.
Task ID-2344167
X-original-commit: 406795fbee7be60c3346fa00a20755bfc1c8eff3
In this commit we remove the warning logger when not being able to format
a phone number. Indeed this does not indicate there was a real issue.
It simply indicates that either the phone number is not parsable or not
matching given country format.
It happens in a lot of situation that phone numbers are not valid: bad
encoding, country mismatch due to {lead, task, ticket} / partner not always
being the same, ... This should not raise a server warning.
When using frontend SMS composer for phone number, a warning is displayed
to the user telling the number is probably incorrect. This is considered
as sufficient from UX point of view as it warns users. We do not think
we should warn admins that some data is incoherent in database.
This commit also
* Revert "[FIX] crm: avoid linking demo leads with an unrelated partner"
This reverts commit 2c94c4c81ffa171158586cd64828d27c537cd1d6
-> having "invalid" data should be a valid use case of real life
* Revert "[FIX] crm: get correct country for phone validation"
This reverts commit a58f9fc154c038d72031b281e2bec2c0fc2915ba
-> country of a lead comes from its partner if set but can be different.
Same for phone numbers. Values on a lead after a compute are considered
as complete. Sales persons could effectively have incoherent data on their
form view but that is the result of what has been encoded.
Task ID-2325228
X-original-commit: cecc4ca6f02e599e193c3fa688bfcbd02ac0580b
Currently rating globally allows 3 values for customers through email
requests: 5, 3 and 1. Through other means (frontend use of rating widget)
values from 5 to 1 are possible.
Only 5 is considered as a valid value for parent container satisfaction.
This leads to strange situation where a document with 4, 4, 4 and 5 has
only 25% of satisfaction.
This is considered as a bit harsh. In this commit we move the "satisfied"
limit of parent container as being above the "ok" value (aka, 4 and 5).
X-original-commit: c884a29b6b0f2cbc8b0aebbaed93d6f211621d1d
Steps to reproduce the bug:
- Let's consider a service product P with Service Tracking = 'Create a task in an existing project'
and Project = PT
- Create a lead L and set a tag T on it
- Mark L as won and create a new quotation Q from L
- Add P on Q and confirm it
Bug:
An error was raised because the tag T didn't exsit on model project.task
PS: Confirming an order can trigger the creation of many records in different models and the generic field
tag_ids is defined on many models. So keeping it in the context when confirming an order can lead to many issues.
opw:2338764
closesodoo/odoo#58455
X-original-commit: 61a55aabaa46b002b7a4afb6335ab879026c740b
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Add hooks to be able to tweak the Bank customer ID number for ISR-B
Those hooks will allow to not use of the field l10n_ch_postal for
multiple purposes.
Fixes conditions on which the reference is generated.
It shouldn't be always generated if l10n_ch_postal is set.
Only if a l10n_ch_subscription_xxx is set.
closesodoo/odoo#58398
X-original-commit: 4790b8e57aa357cda32818392d795b8c0dc48f43
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Some of the TOTP-related forms contained an attempt at making a centered
modal pop-up, using a bootstrap `card` that would also serve to
emphasize that the interaction was sensitive and security-related.
Some of the "footer buttons" were moved inside the form to make it
more obvious that they were part of the interaction flow.
However some of this caused breakages of responsiveness and did not yield
a really satisfactory result anyway.
This commit switches back to using regular non-centered forms. It looks
quite ugly because the content is better suited for a narrow modal, but
it means less surprises in terms of layout and less responsiveness
issues.
closesodoo/odoo#58541closesodoo/odoo#58544
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
Fix the scroll when the snippet is the dynamic one because it did not
work as we tried to get the offset of an element with the d-none class.
Remove the scrollValue variable because we don't need it anymore.
It was used before the code was reviewed in a previous commit.
task-2312878
closesodoo/odoo#58486closesodoo/odoo#58530
X-original-commit: e6d32bc4bfa7f0c3c2f82c2eb99a562c1cb93d83
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Three cases were not covered:
- If the partner with duplicated VAT is inactive (false negative).
- If there are specific contact record rules that hides some of the results for
that user (false negative).
- If the user have several companies viewed at the same time, but the contacts
don't overlap the company scope (false positive).
We cover all of them with this modification.
Was PR #53701closesodoo/odoo#57859
X-original-commit: 35cd931735e2092e08b2cf59434fb3bd579b12ea
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Make sure that model dependencies are flushed before searching with a
given domain. This fixes inconsistencies in `search` and `read_group`.
closesodoo/odoo#57037
X-original-commit: 6b80632e98a932d2b552d6dec0fc7208ca8e04c1
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Before this commit the layout of the off-canvas menu was broken with an
affixed header.
task-2312878
closesodoo/odoo#57442closesodoo/odoo#58528
X-original-commit: 6e1c2ad5db69fe7eaa8f53c8da8375435b59f486
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
* Prior to this commit, the auto scroll is triggered when dragging
items over the right panel (if the dragged item is close to bottom
or top).
* After this commit the auto scroll is is no more triggered as long
as the dragged item is over the right panel area.
closesodoo/odoo#58527
X-original-commit: 0262e33d32fa6b3364f4d9c4144879bf28a0869f
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
* Prior to this commit the dynamic snippet was flickering (destroy followed
by init) because the parallax option triggers a _refreshPublicWidgets
in the onFocus. As such each time the user clicks somewhere in the snippet
the snippet desapears and reappears which can be confusing for the user.
* After this commit, the parallax option will only trigger a refresh on snippets that
are using parallax. This commit also prevent the user from selecting an element of
the dynamic snippet as it is not customizable.
task-2339246
closesodoo/odoo#57693closesodoo/odoo#58525
X-original-commit: ac2d836af9a38687dd0c6d377212f49b102892af
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit :The notification message is not being sent when a message
that should be moderated is posted
After this commit:The notification message will be sent when a message that
should be moderated is posted
LINKS
Task-2282596
closesodoo/odoo#58512
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Currently, in demo data project's allow timesheet is set as False
even there is lots of timesheet entry exist in task's of that project.
So in this commit, when timesheet installed then default allow
timesheet should be set as True for the demo data projects
closesodoo/odoo#58224
Taskid: 2342606
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
* calender_sms, hr_expense, sale_project
PURPOSE
Enable the framework to define some of actions in the controlpanel,
as buttons similar to the 'create/edit/discard' buttons.
SPECIFICATIONS
Replace the below-mentioned dropdown actions with controlpanel buttons
- 'send sms to attendees' in Calendar > Calendar
- 'approve report' in Expenses > Expense Reports > To approve
- 'post entries' in Expenses > Expense Reports > To post
- 'register payment' in Expenses > Expenses Reports > To pay
- 'create invoice' in Field Service > All Tasks > To Invoice
LINKS
PR https://github.com/odoo/odoo/pull/57830
Task-2300426
closesodoo/odoo#57830
Related: odoo/enterprise#13272
Related: odoo/upgrade#1785
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Currently, when there is modal dialog in website the header part of
the modal is hidden behind the navbar and the modal is not centered.
so in this commit, When the modal is in #wrapwrap, modal position
top should be size of the navbar.
closesodoo/odoo#56056
Taskid: 2320303
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
*: web, web_editor
Since the right-panelization made with [1], the modals were not
compensating the body scrollbar when opened anymore and the backdrop
was misplaced. This commit fixes the problems generically, to support
modals with non-body scrolling.
[1]: https://github.com/odoo/odoo/pull/57975closesodoo/odoo#58442
X-original-commit: ebd0c90a146145079061e79c2d4c37fa182a2975
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
qsm-odoo