Commit Graph
141473 Commits
Author SHA1 Message Date
sri-odoo 498b4b4350 [FIX] website_slides: add missing <h1> tag (seo)
closes odoo/odoo#34137

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-06-14 10:16:58 +00:00
xmo-odoo 867fb21b05 [FIX] survey_crm: re-remove
Was apparently re-introduced by a forward port (of an export in 12.0).

closes odoo/odoo#34136

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-06-14 10:00:17 +00:00
qmo-odoo 974418b169 [FIX] website_slides: Fix tag link on slide card
Before this commit, clicking on tag located on a
slide card in the course page would filter the channels
instead of the slides

Now, it filters the slides in the course

closes odoo/odoo#33635

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-06-14 13:18:48 +00:00
qmo-odoo 4ccd859bd4 [FIX] website_slides: Fix the breadcrumbs on a slide content
This commit adds the name of the currently viewed slide
to the breadcrumbs at the top of the page

Task ID: 1999672
PR: #33635
2019-06-14 13:18:26 +00:00
Jeremy Kersten 856685d640 [FIX] website_slides: use bigger image for shared content
Before this commit, share a slide was done with a small picture and so ugly

closes odoo/odoo#34133

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-06-14 09:42:03 +00:00
Christophe Simonis 5b2f64fd5d [MERGE] forward port branch 12.0 up to 4870251f0b 2019-06-14 10:15:49 +02:00
Laurent Smet 94dc2fe5f7 [FIX] account: Fix matching rules with empty communication
The way to find a matching about structured communication is done by:
1 - making a filter to keep only numerical values.
2 - splitting the result into array.
3 - finding an intersect between the sets.

For example,
"Payment about +++123/456789+++ and +++987/654321+++" is matching "123456789 blablabla"?
1 - "123456789 987654321" is matching "123456789" ?
2 - ["123456789", "987654321"] is matching ["123456789"]
3 - YES because "123456789" intersects both sets.

This commit is about the check is always TRUE when both sets are empty.
In this specific case, the result must be FALSE.

-opw: 2008299

closes odoo/odoo#34115

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-06-14 07:28:41 +00:00
Raphael Collet c65325b5c4 [FIX] mail: setting template to False in composer clears attachments
closes odoo/odoo#34104

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-06-13 15:27:18 +00:00
Raphael Collet be560c2828 [FIX] models: new() cannot not trigger any recomputation
Set the flag `validate=False` to prevent `convert_to_cache` on x2many
fields from triggering recomputations with command 1 (update).
2019-06-13 15:01:29 +00:00
Raphael Collet 26bf8ca880 [FIX] fields: x2many value overrides default value on new records
When instantiating a new record, the commands of an x2many field apply
on an empty recordset instead of the field's default value.  This is
less bug-prone, and avoids an infinite recursion in `convert_to_cache`.
2019-06-13 15:01:29 +00:00
Raphael Collet ef3a2118f6 [FIX] models: inverse field when setting changed x2many in onchange 2019-06-13 15:01:29 +00:00
Christophe Simonis 8a19a6a2a3 [MERGE] forward port branch 11.0 up to ec8c66991d 2019-06-13 16:52:40 +02:00
Raphael Collet c22912ec42 [FIX] models: convert values to cache in the right order
When updating the cache of a record, convert currency fields before
monetary fields in order to enable proper rouding.
2019-06-13 14:46:21 +00:00
Raphael Collet fb04afb15d [FIX] fields: avoid infinite recursion in convert_to_write 2019-06-13 14:39:13 +00:00
Raphael Collet e0e9ae1edd [FIX] *: special cases for new records 2019-06-13 14:39:13 +00:00
Raphael Collet 59b2e29a9c [FIX] models: multiple x2many fields in onchange
When the model has several x2many fields which are non-disjoint, the web
client sometimes invokes `onchange` with inconsistent data: a line
appearing in two x2many fields with different values for a subfield.
The method must deal with that inconsistency and return correct data to
the client.
2019-06-13 14:39:13 +00:00
Olivier Colson 819514309b [FIX] account: make tax report compatible with new multicompany implementation
[IMP] account: make all tax report lines accessible in every company

The former implementation, with a record rule, did not support the new multicompany implementation. Furthermore, making the tax reports accessible by every company whatever their contries is more consistent with the way other accounting reports work.

closes odoo/odoo#34154

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-06-14 15:13:23 +00:00
Christophe Simonis 618ea1ab67 [FIX] test_mail: bump query count
For unknown reason (I didn't manage to find the culprit), the previous
forward-port generate more queries than before.
2019-06-17 18:27:28 +02:00
Christophe Simonis 0da246ef55 [FIX] core: not all falsy objects have an origin attribute
It avoid `X.browse([0]).exists()` to blow up.
2019-06-17 14:44:25 +02:00
Christophe Simonis 93b0f9ad2a [FIX] uom: define reference UoM first 2019-06-17 14:15:58 +02:00
Christophe Simonis 8fa477cbd9 [FIX] web_editor: use only ES5 compatible code 2019-06-17 14:10:03 +02:00
Christophe Simonis b6f7fe9a81 [IMP] test_lint: correctly format es-check error message 2019-06-17 14:09:31 +02:00
Christophe Simonis 65cc06e3ab [FIX] mail: use defined variable
Oversight of previous forward-port.
2019-06-17 14:08:45 +02:00
Christophe Simonis 25e3f27062 [MERGE] forward port branch saas-12.3 up to 48a9f5a633 2019-06-17 13:20:35 +02:00
Christophe Simonis ec8c66991d [MERGE] forward port branch saas-15 up to 641ca4f7f4 2019-06-13 16:22:23 +02:00
Sébastien Theys 382989c341 [FIX] product: remove useless create_from_tmpl context change
Since 0477bdb75a

The last use of `create_from_tmpl` was removed therefore it is better to not
change the context for no reason.

closes odoo/odoo#34107

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-06-13 13:59:04 +00:00
rhe 6a2f83a08e [FIX] point_of_sale: fix binding model reference
You are not able to install pos_sale because of a wrong reference to a
model in the action "pos_session_action_from_crm_team".

It was referencing the module 'crm' instead of 'sales_team'.

Thi behavior has been introduced in the revision: 10f1a1a0c4

closes odoo/odoo#34119

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-06-14 08:16:52 +00:00
Nicolas Martinelli 4870251f0b [FIX] payment: save credit card
- Set a payment provider with:
'Save Cards': 'Always'
'Payment Flow': 'Redirection to the acquirer website'
- Process an order on the eCommerce

The payment token is not saved.

The `save_token` value is based on the checkbox which is only added in
'ask' mode:

https://github.com/odoo/odoo/blob/4b8f72eb2315e675ca6d5a0d0961272fc024c475/addons/payment/static/src/js/payment_form.js#L162

We hide and pre-check the checkbox in this case.

opw-2008441
opw-2008275

closes odoo/odoo#34106

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-06-13 13:52:03 +00:00
Christophe Simonis 641ca4f7f4 [MERGE] forward port branch saas-14 up to 6a247212f8 2019-06-13 15:32:55 +02:00
Christophe Simonis 6a247212f8 [MERGE] forward port branch 10.0 up to 818d34630d 2019-06-13 15:25:43 +02:00
Nicolas Martinelli 5af6928107 [FIX] google_spreadsheet: boolean
It seems that Google Spreadsheet only recognizes `true` and `false` as
valid boolean values.

opw-2000623

closes odoo/odoo#34100

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-06-13 12:10:20 +00:00
Christophe Simonis a526ff3f70 [FIX] mail: use correct variable
Oversight of previous forward-port.
2019-06-13 18:20:47 +02:00
Christophe Simonis a0a11fd5e2 [MERGE] forward port branch saas-11.3 up to 8a19a6a2a3 2019-06-13 18:18:17 +02:00
Julien Castiaux dad9265d69 [FIX] project: correct filename on portal attachment
Create a project visible to a portal customer, create a task and attach
an attachment. As a portal user, go to the task and download the
attachment, the downloaded filename is the numeric identifier of the
document instead of the document filename.

The `?download=true` force the download of the attachment and correctly
set the filename.

opw-2008517

closes odoo/odoo#34098

Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>
2019-06-13 13:22:22 +00:00
Nans Lefebvre ea064c81c9 [FIX] website: fix access error at settings save
Let a database with company C1, C2,
and a website W belonging to C1, used for both companies.
Settings in C2 cannot be saved without setting a website.
At settings load W is removed from C2 because it belongs to C1.
So reset C2's website to W.
This triggers a (useless) write of company_id (C1.id) on W.
Then we have w.user_id.company_id.id != self.env.user.company_id.id, (C1 != C2).
So if contacts are not shared, then accessing w.user_id.company_id would cause
an access error because of record rules, preventing the save.
As a result, settings are unusable for company C2.

opw 2008887

closes odoo/odoo#34102

Signed-off-by: Denis Ledoux <beledouxdenis@users.noreply.github.com>
2019-06-13 12:41:15 +00:00
mreficent 255088ba52 [FIX] purchase: wrong uom in demo data
closes odoo/odoo#34099

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-06-13 11:56:39 +00:00
Goffin Simon 07e6cc73c1 [FIX] sale: sales_to_invoice_count in Sales Channel
The count sales_to_invoice_count was wrong due to the domain
wrote in function _compute_sales_to_invoice. Using 'order_line.qty_to_invoice'
in the domain included duplicate orders in the read_group on 'sale.order'
because there is auto_join=True on the field order_line.

opw:2009808

closes odoo/odoo#34391

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-06-26 14:44:34 +00:00
Christophe Simonis f7d442a2f6 [MERGE] forward port branch saas-15 up to cf18c9bae1 2019-06-26 19:28:52 +02:00
Nicolas Martinelli 98a590b359 [FIX] l10n_fr_fec: remove new line
- Make a SO with a product that have a carriage return in its
description
- Export FEC report

The CSV contains new lines and is not correctly formatted. This is due
to c712231745.

opw-2026861

closes odoo/odoo#34386

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-06-26 12:54:28 +00:00
Nicolas Martinelli aad824067c [FIX] l10n_fr_fec: wrong forwart-port
Incorrect forward-port of commit cd26eb8e7c

opw-2026861
2019-06-26 12:53:20 +00:00
Goffin Simon 06375de3bc [FIX] crm: Wrong opportunities_count in Sales Channels
Steps to reproduce:
- Go to CRM > Reporting > Sales Channels
- Click on link Open Opportunities,

Bug:

It displayed all the opportunities instead of just the open opertunities.

opw:2009808

closes odoo/odoo#34365

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-06-26 14:41:42 +00:00
Goffin Simon 87685fc9b3 [FIX] stock: Inventory of one product only
Steps to reproduce:
- Enable serial numbers
- Create two products P1 and P2 tracked by lots
- Create an inventory adjustment and specify inventory of one product only
- Select P1 and create a serial number for it
- Save the adjustment and change P1 to P2, adapt the quantity to 10 and
validate the inventory adjustment

Bug:
Go to Lots and serial numbers and the created lot was linked to P1 intead of P2

opw:2010934

closes odoo/odoo#34373

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-06-26 09:10:06 +00:00
Nans Lefebvre c6ae7eea03 [FIX] stock: do not update moves when writing quantities lower than UoM precision
Suppose product P has UoM U with rounding R, and the stock move has quantity Q.
Edit the quantity done to be Q + e, with e << R.
By the semantic of the UoM rounding, this should mean that no change has been
done.
However no such check was done, so a message was posted in chatter, of the form:
The done move line has been corrected.
P:
Quantity : 1000.0 -> 1000.0000000000001

opw 2006831

closes odoo/odoo#34124

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-06-14 11:26:16 +00:00
Nans Lefebvre a5a4b154ee [FIX] stock_account: round quantities to UoM precision when updating moves
Have a product P values in FIFO, create an incoming stock move.
Suppose P has UoM U with rounding R, and the stock move has quantity Q.
Edit the quantity done to be Q + e, with e << R.
By the semantic of the UoM rounding, this should mean that no change has been
done. However no such check was done, so the move was updated.
As a result, this would mess up the valuation of P.

opw 2006831
2019-06-14 11:25:56 +00:00
Nicolas Martinelli 963475bcfd [FIX] stock: use float_compare
Use proper `float_compare` method when comparing floats.

opw-1958608

closes odoo/odoo#34370

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-06-26 07:46:19 +00:00
Olivier Colson 13f5dc905b [IMP] l10n_lu: remove unnecessary space at the end of some tax report line name
closes odoo/odoo#34094

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-06-13 10:59:05 +00:00
shreya thakrar ffeb855bc7 [FIX] sale_timesheet: remove the down payment line in project overview
Before this commit, in project overview, there was an advance payment
line under 'Timesheets' section which was unnecessary for the timesheet.

After this commit, down payment line will not considered in project overview.

task-1957272

closes odoo/odoo#34062

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-06-13 09:16:05 +00:00
Nicolas Martinelli 988018a5ba [FIX] account: fiscal year end dates in wizard
- From Accounting dashboard > Configuration panel > Configure fiscal year
- Set opening date: 01/07/2018
- Set fiscal year end: June 30
- Click Apply button

An error is raised: 'Invalid fiscal year last day'.

This is because the 3 fields are linked by the constraint
`_check_fiscalyear_last_day`. However, non-stored writeable related
fields are evaluated one at a time, meaning that the constraint is
evaluated one value at a time.

We do a fancy workaround to write the 3 values at once on the company,
hence evaluating the constraint for the 3 fields once.

opw-2024927

closes odoo/odoo#34275

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-06-20 10:51:56 +00:00
Odoo Translation Bot 53b6ab9f05 [I18N] Update translation terms from Transifex 2019-06-23 01:17:13 +02:00
Julien Castiaux 81147140ac [FIX] calendar: shift midnight to current locale
Configure your system to be in the Mexico timezone, configure your Odoo
profile accordingly. Go to calendar, show daily events, add an event at
the end of the day (like 10pm). The resulting event is not visible on
the daily view although it is on the weekly view. The same problem
occurs on the weekly view if the event was create late the last day.

The problem is the initial `search_read` has a domain to filter the
events using 00:00 UTC to 23:59 UTC boundaries. Those boundaries are not locale
aware, they should be shifted to the MX timezone.

opw-2009877

closes odoo/odoo#34247

Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>
2019-06-19 14:38:00 +00:00