action_view_invoice is made to work on empty/single/multi records, but there are context keys used to provide defaults when creating invoices in the next view. However when those fields are different among the origin sale orders, we get an error, because the record set's values is accessed like in a single record.
In this record we add the default_* context keys only if the recordset is of length 1, so it keep working as before for single/no records. And it doesn't crash when coming from multiple sale orders with different fields.
related task 2047389
Project overview was broken since the display name field on project search view was renamed into simply name, but a context key was used to enable it, which was not updated
related task 2047389
The action_timesheet_from_invoice was not working anymore, it was redirecting to a list of all timesheet instead of only those linked to the actual invoice. It seems like the action was using a filter since it passed a search_default_* key in the context, but that filter is nowhere to be found. In order to fix the action, it was converted int a python method which gave access to the active move id.
related task 2047389
Since this settings widget is a check-box it is already obvious that this field turn on or off a feature. Plus it makes the field easier to translate and the form view a little bit lighter.
related task 2047389
This commit changes the display of dates on kanban cards. It is now conditional.
Depending on the date versus actual date we conditionally set the color.
Depending if the record are grouped by date, we format the date as a date or as a time.
If the task is an fsm task we show the planned date begin otherwise we display the deadline.
From which App | project | fsm |
-------------------------------------------------------------------------------
task.is_fsm | y | n | y | n |
-------------------------------------------------------------------------------
task.fsm_state == 'done' | y | n | y | n | y | n | y | n |
-------------------------------------------------------------------------------
-------------------------------------------------------------------------------
display deadline | n | n | y | y | n | n | y | y |
-------------------------------------------------------------------------------
should it be colored? | n | y | y | y | n | y | y | y |
-------------------------------------------------------------------------------
display city ? | n | n | n | n | y | y | y | y |
extra case: in fsm, if the records are grouped by date, we display time only in red, if the task is late, taking the time into account.
Task-2047389 Closes#5388
The modification of a helpdesk team may trigger the installation of some
modules. The code was calling multiple times the installation of
modules (once per module to install), and this was triggering cache
misses on computed fields (probably because of a completely inconsistent
cache/registry). We have grouped all the modules to install into a
single installation, and this fixes the issue.
Co-authored with Samuel Degueldre <sad@odoo.com>
closesodoo/odoo#37059
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Prior to this commit, the org chart was taking 2/3 of the available
width. This commit aims at reducing the space used and to be consistent
with the private employee profile.
closesodoo/odoo#37052
Taskid: 2073361
Signed-off-by: Romain Libert (rli) <rli@odoo.com>
Before this commit, only "Total" column was shown on mobile and
it wasn't possible to add another one.
(1) Now, we let the user to add it even if he probably will have to
scroll horizontally.
(2) The "Flip" button has been reintroduced like in desktop.
(3) By default, the old behavior will remain the same (only one
colum will be displayed) but to avoid frustrating for users
who always have to add manually columns to see the same information
as in desktop; you can use favorite filters.
In this case, all columns will be displayed.
Task ID : 1945893
opw-1935645
closesodoo/odoo#37057
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Before when creating a vendor bill with a tax 15% and a price unit less than 87, the widget to edit the tax amount was wrongly displayed, the pencil and amount was broken into two lines. This fixes this behavior by ensuring that the all block stays together using the css property white-space: nowrap
closesodoo/odoo#37049
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
Validation and user errors do not support
html tags anymore.
This commit removes the last strong tags present in
such errors.
Task ID: 2061442
closesodoo/odoo#36231
Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
_bom_subcontract_find return a BoM of typer subcontractor for
any partners if the subcontractor is not set. The real behavior is
to not create a subcontracting order if the partner is not set.
- correct some errors in the text field
- transform the utm.tag.view.form view to utm.tag.view.tree view to allow direct tag editing
closesodoo/odoo#37008
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The status returned bby PrinterDriver contained a list of connected
printers to be used in Enterprise, to determine if the printer that was
selected in POS Config was used in the POS. We now read this status
from the db and we therefore don't need this anymore.
In Community the user only needs to know if there's a printer connected
to the Box. We just have to know if any printer is present.
TaskID: 1970884
Change the default value of the miscellaneous product to a discount product. When the module pos_discount is installed, the default value will now be the discount product.
closesodoo/odoo#36665
Task: bug fix
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Before this commit, the field to generate serial numbers in the
detailed operation move view wasn't displayed.
closesodoo/odoo#37197
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Purpose of the commit is to adapt demo data for the maps view
as we currently have a cluster of pins, which doesn't showcase the feature.
So updated the address of the main partners.
Task-2041896
closes odoo/odoo#36179
Closes: #36179
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
We should avoid showing the title in edit mode as it doesn't get updated
automatically.
closesodoo/odoo#37193
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
With the actual code, some computations are done
in the graph renderer to determine if it is worth
to show the "Stacked" button in the graph view control
panel for the data on hand. It turns out that that
problem is not satisfactorily addressed and is quite
hard from a usability perspective. We prefer to restore
the old behavior as long as we don't have better ideas.
closesodoo/odoo#37188
Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
The message for the validity of the leave type was not clear enough,
this commit makes it clearer.
closesodoo/odoo#37191
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
In time off dashbord, due to python precision computation we can
have amount of days like 9.9999998. This commit make a rounding
after 2 digits and doesn't add new 0 at the end.
For example:
3 -> 3
3.1 -> 3.1
3.14 -> 3.14
3.141 -> 3.14
closesodoo/odoo#37182
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Currently in the slide.question view it is possible to open a form
to create new questions for quizzes, but it is impossible to fill the form with
the required information to create a new question. So the create button has no purpose.
This as "slide_id" is required but can't be set in the form.
Now the option to add question from the reporting tab 'Quizzes'
is removed as the questions (with the answers) are added in the form from
slide.slide.
closesodoo/odoo#37117
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The onchange on tax_ids and second_tax_ids was only recomputed when
tax_ids changes (duh) so the variables show_force_tax_included and
show_second_force_tax_included were not set when coming back to the
formm after having saved a line with one tax.
closesodoo/odoo#37111
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
After submitting the quiz, buttons and validation content was rendering on top
of the quiz instead of under it. This display bug is fixed in this commit.
Task-2072564
closesodoo/odoo#37040
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Fixed the button allowing to reset to the logo colors in the
document layout configurator.
Before this commit, the custom_colors boolean asserting that
the colors used by the layout are different than the ones computed
from the logo and used to revert to those colors was in readonly
and couldn't be toggled.
Now, the boolean is editable and allows to revert the colors properly.
Task 2072557
closesodoo/odoo#36968
Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
Remove the "sale.group_sale_order_dates" group and settings, all the date
fields are always displayed but we put schedule_date and commitment_date
(for which the label was renamed "delivery date") on the same line (with
a design to make the schedule date looks like a suggestion for the
delivery date).
task 2057802
closesodoo/odoo#37174
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
This "bugprovement" resolve the old issue of writing on a translatable
field a falsy value.
Before this commit, only the translation value was removed. When no
translation is present (or when the value is not set), the value is
retrieved directly from the source field.
Before 18d9c2cab2, it was still possible to go around this issue by
removing manually all ir.translation entries and writing with a user
in en_US.
This is no longer possible as writing on a translatable field always
uses translations when in multi-language environment, without
exception of en_US.
When writing a falsy value on a field, the expected behaviour is to
reset the value and see that falsy value after saving, not the old
value stored on the source model.
Remove all translations and force to update the column.
Removing one individual translation is still possible in the
translation popup.
Task id: 2062415
closesodoo/odoo#37077
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
If it isn't set manually, it defaults to now and the result is not
consistent with planned date end. We make it an hour before totally
subjectively.
closesodoo/odoo#37173
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
To avoid slowing down search like "{relational_field}" contains "{value}"
we always need to return the lazy name_get() for each [_]name_search method
closesodoo/odoo#36735
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
As there's technically no way to hide partially a selection field,
we raise a warning when the user set a `stock.picking.type` as
internal without having the setting `stock.group_stock_multilocations`
enabled.
closesodoo/odoo#37129
Taskid: BugsLogistics
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
For some reasons, when the `mail_compose_message` wizard tries to
read the name of its source document, the id and the model are
sometimes mismatched as a `purchase.requisition` or a `purchase.order`.
To avoid this we force the `active_model` and `active_id` in the context of `action_rfq_send` to be always referring to the current `puchase.order`.
closesodoo/odoo#37097
Taskid: BugsLogistics.
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
There are too many image sizes. Since they are stored resized this takes time to
generate when saving a new image, it's more rows on the attachment table, more
files on the disk, ...
64px is close enough to 128px that it can be removed without a big impact on
download size.
It will even reduce download and number of requests when both images are
displayed because now only one has to be downloaded and then benefit from cache.
The difference between the two is typically around 1.5kB which is negligible
these days, especially when the request overhead is around 0.5kB already, not
even taking into account other factors such as latency.
If a 64px image must absolutely be returned, it is still possible to pass the
size parameters to the image route. But the current guideline is to handle
resizing in the views when necessary.
Views
=====
- remove width and height attributes when existing CSS rules are overriding them
(eg. `.oe_kanban_avatar` in the right context)
- add CSS rules instead of width and height attributes when possible
- use `object-fit: cover;` where width and height are forced to avoid distortion
of non-square images
- for products, use `object-fit: contain;` instead, keep ratio but without crop
- add new CSS rules where the expected size was max 64px*64px before due to the
image size itself
- remove `img-fluid` where using size classes to avoid conflicting rules
task-2060865
closesodoo/odoo#36147
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
When an event is published/unpublished, the 'Is Published' value appears
twice in the chatter.
This is because `website_published` is defined as a related of
`is_published`, and `is_published` is tracked. The button calls
`website_publish_button` which triggers a `write` on
`website_published`, the latter triggering a `write` on `is_published`.
The situation is quite exceptional: we usually don't define a related on
a field of the same model. Therefore, we can simply change the field
tracked.
opw-2073804
closesodoo/odoo#37128
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
In the inline editor (eg. task description), the inline bar of an
element (eg. link or image) has higher bootstrap z-index than modal that
can be opened via this bar (eg. croping window for an image, link
editing for a link).
So the bar would be over the modal opened by the bar which is
unexpected.
This was solved in 12.3 f2969923 by setting the inline bar to z-index of
$o-wysiwyg-zindex (defined to 1000).
This is the equivalent of 12.0 #37119 fix.
opw-2073761
closes#37125
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
MaxLarue