Commit Graph
101836 Commits
Author SHA1 Message Date
Goffin Simon ff1845bf86 [FIX] website_sale: price_tax and amount_tax in confirmation page
All the information about the taxes must be displayed in the  confirmation page.

opw:679316
2016-06-14 15:36:31 +02:00
Patrik Lermon 01a81b975b [FIX] base: position of SEK currency after amount
Source: http://lh.2xlibre.net/locale/sv_SE/ (p_cs_precedes)

Closes #12414, related to #12350
2016-06-14 14:23:30 +02:00
Richard Mathot 54cf8d0ce7 [FIX] account_voucher: allow the web client to catch the warning instead of returning the whole traceback
Actually, it was a Python ``Warning`` exception that was returned, and
not an ``openerp.exceptions.Warning``, that is an alias of ``openerp.exceptions.UserError``.
2016-06-14 14:12:37 +02:00
Martin Trigaux 0ec664d1a7 [FIX] web: close popup after backup
All actions of the database manager redirect the user after an action except the
backup option which returns an octet stream.
Close the modal after form submission to mimic the same behaviour.

Do not close the modal for other actions than database manager to avoid waiting
time for create that may be long to process.

Add message to warn the user about backup waiting time after cliking on submit
to be less confusing for big databases that may take a lot of time to be ready.

Fixes #10803
2016-06-14 13:42:14 +02:00
Nicolas Martinelli e0c4ec54ca [FIX] web: new record on editable list
On an editable list view, an issue occurs with the following procedure:
- Click "Add an item", write something
- Press "Enter" key --> a new item is added, write something
- Click outside of the list, then click on the last item created
- Press "Enter" key --> the cursor is set at the beginning of the list

This is an issue for two reasons. First, the behavior is not the same if
we have clicked outside of the list before pressing "Enter", which is
not logical. Then, in some undetermined cases, the focus can be lost
then retrieved on the last record. It means that suddenly, the cursor
goes back at the beginning of the list without notice.

The latter issue is problematic when batch-encoding data, for example
encoding the lot numbers of incoming products thanks to a scanner.

opw-680758
2016-06-14 12:39:11 +02:00
Olivier Dony 285deb9a14 [FIX] base_import: handle other cases of wrong CVS mime types
Improves 8049d1e855 for other detected
cases, e.g. on Firefox + OSX.

opw-680347
2016-06-14 12:35:59 +02:00
Denis Ledoux 811771d3f8 [FIX] account_voucher: get_product_accounts expects a browse record
The method `get_products_accounts` obviously requires
a fiscal position browse record for its `fiscal_pos` parameter:

```
    @api.multi
    def get_product_accounts(self, fiscal_pos=None):
        accounts = self._get_product_accounts()
        if not fiscal_pos:
            fiscal_pos = self.env['account.fiscal.position']
        return fiscal_pos.map_accounts(accounts)
```

But the method `product_id_change` called it with a fiscal
position id, through its own class method `_get_account`

This probably happened during the merge at revision
75d7bbb46e

which has not been correctly rebased on the acounting 9.0
revision
c04065abd8

opw-678735
2016-06-14 12:21:27 +02:00
Damien Bouvy 87717509c0 [FIX] website_payment: fetch default provider + render issue
* Fixes a bug that prevented the system to fetch the default provider
because the default_get call was wrong (wrong model + missing
company_id kwarg)
* Displays the amount as a monetary widget (to do that, the amount
must be sent as a float in the controller)
* Display the acquirer 'pre_msg' field to display eventual fees
2016-06-14 08:53:41 +02:00
Olivier Dony 0f5f960c60 [FIX] payment: render acquirer form values even if partner is missing
When no `partner_id` was passed to `render()` and the acquirer
had a fees computation method, (e.g. Paypal), it would crash.
Could happen when coming through the /website_payment/pay
controller, for instance.
2016-06-13 19:21:02 +02:00
Denis Ledoux c95e46eedb [FIX] account: invoice reset to draft when the default report is removed
When the report `account.report_invoice` was being deleted,
it was no longer possible to reset an invoice to draft.

This is related to revision
291561a197
2016-06-13 19:00:03 +02:00
Denis Ledoux 2d47ea2563 [FIX] link_tracker: page title encoding
When tracking a page with special characters
in the title (e.g. `Ä`), the title
of the page in the tracked links was
badly encoded, because the
encoding was not handled correctly
when parsing the given website page.

opw-679993
2016-06-13 17:30:59 +02:00
Denis Ledoux 3b4560cf42 [FIX] account: multiple journal items to fix in full batch reconciling
In a batch reconciliation of journal items,
it could happen that multiple journal items
in a foreign currency required the creation
of an exchange entry
`aml_to_balance_currency |= aml`

But the statement `aml.matched_debit_ids[0] or aml.matched_credit_ids[0]`
requires a single browse record (singleton) to work

The partial  reconciliation is supposed to be the same for all
the journal items to fix, we can therefore safely do
`aml = aml_to_balance_currency[0]` to overcome this issue.

In addition, in this condition, the full reconcile must be
skipped to avoid passing multiple times in the `create_exchange_rate_entry`
method (which is called in the method `create` of `account.partial.reconcile`

This has been reviewed by qdp.

opw-680044
2016-06-13 17:20:48 +02:00
Simon Leblanc ec005af5b9 [FIX] anonymization: default anonymization fields
res_partner.name was twice : remove one
res_users.name doesn't exist (now, it use the partner name) : remove
remove training.* fields that do not exists

Closes #11806
2016-06-13 17:09:02 +02:00
Simon Leblanc 45483b963e [FIX] anonymization: allow anonymization on HTML fields
Was missing in the (old) list of fields
2016-06-13 17:09:02 +02:00
Simon Leblanc 42aa79d63f [CLA] Sign CLA of leblanc-simon
Done at #11806
2016-06-13 17:09:02 +02:00
Goffin Simon 96621a3427 [FIX] account: deleting a default tax(ir.values)
When a chart of account is created, ir.values for the fields taxes_id
and supplier_taxes_id in the model 'product.template' are created.
But if one of this two taxes are deleted, there was a crash when
creating a new product template because the default tax was missing.

opw:680576
2016-06-13 17:00:16 +02:00
Goffin Simon 67a9ea20d8 [FIX] crm: force view_id in window action
When clicking on "Your Pipeline" in Sale app and clicking afterwards
on an opportunity, the form view "crm.crm_case_form_view_oppor".
But if you refreshed, the form view of a lead was used.

opw:677962
2016-06-13 15:45:59 +02:00
Nicolas Martinelli 3389b5f28a [FIX] account: analytic line amount
When an analytic account is added on an invoice line, the amount
recorded on the analytic line can be wrong if the invoice is not in the
company currency.

The issue is that the debit/credit amount is converted from the company
currency to the account move currency.

opw-679947
2016-06-13 10:53:12 +02:00
Odoo Translation Bot 596398a759 [I18N] Update translation terms from Transifex 2016-06-12 00:39:18 +02:00
Jeremy Kersten 20989b8b17 [FIX] website_blog: fix url in rss
post.website_url contains the heading /.
Old code generate 404 url (https://www.odoo.com//blog/1/post/294)
2016-06-11 21:13:57 +02:00
Simon Lejeune efe37469e9 [FIX] packaging: debian: update-python-module is no more
The command is not installed by default. It was available in the
python-support library which we didn't depend on and now this library
is no more in debian jessie/ubuntu xenial.

fixes #11785
2016-06-10 17:22:03 +02:00
Simon Lejeune 123e51f4d5 [REF] ir_qweb: less webasset: compress output instead of minifying it
* Remove dependency on less-plugin-clean-css which distribution
  packages are broken on debian stretch and derivated.
* Updated documentation.
* Lessc provides a `--compress` argument that could solve this issue.
  According to the documentation at http://lesscss.org/usage/: "[...]
  Compress using less built-in compression. This does an okay job but
  does not utilise all the tricks of dedicated css compression[...]"
  However, using this argument works on lessc 2.5.3 but not on 1.4.2
  (`--compress` arg is present but seems to be break some rules
  i haven't been able to put my finger on).
* Finally, use the minification of the StylesheetAsset that takes care
  of removing the spaces, the comments and the sourcemap with regexes.

fixes issue #9113
2016-06-10 17:22:03 +02:00
xmo-odoo b466a9eea0 [FIX] report: Backport of 6d73087d to 9.0
Closes #12131
[FIX] report: don't hide errors in custom reports

If a custom report's render_html raises a KeyError for some
reason, Report.get_html would swallow the exception and fallback
on generic HTML rendering, usually blowing up with unfathomable
errors of missing rendering context data.

Check if a custom report object exists instead of waiting for a
KeyError.
2016-06-10 16:31:23 +02:00
Marius Vaišvila 1412a73d74 [CLA] signature for MariusVaisvila
Closes #12131
2016-06-10 16:31:23 +02:00
Olivier Dony f9688cc63f [FIX] calendar.event: wrong return type when message_post was called from new API 2016-06-10 15:51:29 +02:00
Dhinesh D deb439fe6a [FIX] stock_calendar: missing parameter in write
Surprisingly it doesn't work to write without ids
Closes #12369
2016-06-10 15:12:54 +02:00
Dhinesh D 65308e7492 [CLA] Signature for Dhinesh D
Closes #12370
2016-06-10 15:12:54 +02:00
Joren Van Onder 298fc213dd [FIX] point_of_sale: ensure that there is always an order creation_date
Introduced by e9b1254a5c. This commit made
sense but there are certain POS modules that send the order to the
backend before validation and thus depend on there always being a
creation date, even if the order has not been validated yet.

This ensures that we don't end up with an undefined creation_date in the
backend.

opw-680590
2016-06-10 14:31:23 +02:00
Simon Lejeune 02484f899a [FIX] report: thread-safe barcode generation
A lock occurs when the user wants to print a report having multiple barcode while the server is
started in threaded-mode. The reason is that reportlab has to build a cache of the T1 fonts
before rendering a barcode (done in a C extension) and this part is not thread safe. We attempt
here to init the T1 fonts cache at the start-up of Odoo so that rendering of barcode in multiple
thread does not lock the server.

Another workaround was to set an explicit lock around the reportlab's function call, but it's
more dangerous as it may introduce undetectable lock between python and postgresql.

Thanks to @odony and @KangOl.

Fixes #12236
2016-06-10 11:26:01 +02:00
Denis Ledoux d6e93d063b [FIX] project: project duplicate message followers
This is related to revision
c8aac116a6

`message_follower_ids` is a one2many field
on the thread. To copy them, you must
create new `mail.followers` records, and not
linking the followers of the project
being duplicated to the duplicated project.
2016-06-09 18:26:06 +02:00
Denis Ledoux 291561a197 [FIX] report, account: invoice reset to draft attachments
When cancelling and resetting to draft an invoice,
delete only the invoice report attachment from the
attachment, not all of them.

The reason why the report is removed from the
attachments on the invoice resetted to draft
is explained in
db0def38cc

opw-680295
2016-06-09 17:37:55 +02:00
Denis Ledoux c8aac116a6 [FIX] project: duplicate project must copy followers
Since duplicating a project copies the project
tasks, with the followers, the project followers must
remain as well.

This is done in the already overriden method
`copy` instead of simply adding `copy=True`
on the according one2many field, since this field
is defined on the inherited model
`mail.thread`, and to add `copy=True`, in the old api,
we would have to re-define the `message_follower_ids`
field within the `project.project`
model completely, making sure to copy all properties

opw-680313
2016-06-09 17:27:31 +02:00
Nicolas Martinelli 8049d1e855 [FIX] base_import: file type on Windows
When a user imports a CSV file on Windows, the "CSV Format Options…"
field does not appear. This is an issue since it might be necessary to
tune these options depending on the file, e.g. change the encoding.

For some unknown reason, on Windows, the file type is empty whatever the
browser used. Therefore, we fall back on the extension of the file.

opw-680347
2016-06-09 15:09:22 +02:00
Goffin Simon a46f361698 [FIX] delivery, stock: carrier_id field in incoming stock picking
The field "carrier_id" must be hidden for the incoming stock picking.

In stock picking view form,
for an incoming stock picking, the Destination Location Zone must be hidden
for an outgoing stock picking, the Source Location Zone must be hidden
Introduced by 2cb3a90

opw:676411
2016-06-09 14:49:14 +02:00
Jeremy Kersten 6f223edf4f [FIX] mail: display date and datetime in tracking value with the right timzeone.
When tracking value is converted to be rendered as a message_post, we convert
the date/datetime with the current local from momentjs.

Related to #12327

Courtesy of @aab-odoo for help and review.
2016-06-09 10:45:35 +02:00
qdp-odoo 09bf8b4363 [FIX] account: let the note field be visible on form view of fiscal positions 2016-06-09 10:17:19 +02:00
Nicolas Martinelli af2c69f0e5 [FIX] account: duplicate journal entry
When a journal entry includes taxes, it is impossible to duplicate it
because of an unbalanced entry error.
Indeed, by default the taxes are computed at the creation of the account
move lines, leading to the creation of a new tax line, therefore
unbalancing the account move.

Fixes #11919
opw-676788
2016-06-09 10:03:05 +02:00
Denis Ledoux dd1e67d263 Revert "[FIX] delivery, stock: carrier_id field in incoming stock picking"
This reverts commit 07e6f28df3.

This was no longer possible to create a picking from scratch.
`Inventory > Your Company: Receipts > Create`
Because `picking_type_id` is not in the res returned by the above call to default_get

Even by forcing `picking_type_id` in the `fields` list,
it doesn't return the value in the fields.
2016-06-08 18:23:08 +02:00
Denis Ledoux 3ddb446b3b [FIX] crm, mail: Convert to opportunity in mail notification
The button "Convert to opportunity" in the mail notifications
sent when posting a message on an opportunity just coudln't
work as it attempted to call the `convert_opportunity`
method without one of its required method parameter.

opw-680017
2016-06-08 17:15:15 +02:00
Denis Ledoux 876b893a53 [FIX] stock_picking_wave: remove picking from a wave
When removing a picking from a wave,
it should simply remove the link between
the picking and the wave, not remove the picking itself.

opw-677590
2016-06-08 15:43:14 +02:00
Goffin Simon 07e6f28df3 [FIX] delivery, stock: carrier_id field in incoming stock picking
The field "carrier_id" must be hidden for the incoming stock picking.

opw:676411
2016-06-08 15:10:39 +02:00
Nicolas Martinelli 4cc01a34e4 [FIX] website_portal_sale: prevent overlap
In the website portal summary ('/my/home'), a long invoice number might
overlap the date.

opw-677567
2016-06-08 08:18:35 +02:00
Christophe Simonis fa4a371ba8 [MERGE] forward port of branch saas-6 up to 0211782 2016-06-07 19:11:49 +02:00
Denis Ledoux 57a5d1976b [FIX] qweb: t-lang warning logger
The evaluated lang is within the variable
`d.context['lang']`

`lang` contains the non-evaluated `t` attribute,
so, in the case of `report_saleorder`,
`doc.partner_id.lang`

opw-680074
2016-06-07 18:23:25 +02:00
Christophe Simonis 021178242f [MERGE] forward port of branch 8.0 up to 6140300 2016-06-07 18:01:12 +02:00
Nicolas Lempereur 5ea4937e5a [FIX] stock: reordering_{min,max}_qty &several ids
dict.fromkeys doesn't duplicate the passed 'values', hence the code
created a table with several times the same instance of values dict.

opw-679203
2016-06-07 17:27:17 +02:00
Jos De Graeve 2098b703a4 [FIX] sale_timesheet: set wrong code on analytic line
The product_id is the one of the timesheet line, not the one of the order (which
actually is the one of the first line).
Closes #12013
2016-06-07 17:02:21 +02:00
Denis Ledoux 4601b044a6 [FIX] web: prevent search dropdowns to close on click inside
In the Filters, Group By and Favorites dropdowns,
when clicking outside the `li` elements but still
inside the dropdown menu itself
(like on the dividers,
or next to the advanced search `Apply` button),
the dropdowns was closed.

This behavior was annoying when doing an advanced search
with a field using the datetime picker, as, to close the datetime
picker, you have to click outside it, and when you did, it closed
automatically the filter dropdown... So you had to open it again to
finally apply the filter.

opw-674310
2016-06-07 16:48:58 +02:00
Olivier Dony af47009815 [FIX] website_{quote,sale}: payment tx handling consistency
Both website_sale and website_quote have logic to independently
confirm sales orders when a successful payment transaction is
processed.
Rev 46c5f93b6c introduced an extra
check and logging for transactions with mismatching amounts in
website_sale, but the same change was not done in website_quote.

Consequently, when both modules were installed, the tx mismatch
check was bypassed by website_quote, and a spurious logging message
was emitted by website_sale if the website_quote logic had executed
first.

This patch makes tx handling consistent in both modules, and avoids
the misleading log message when both modules are installed.
2016-06-07 16:29:52 +02:00
Simon Lejeune 879e2b27d9 [FIX] packaging: redhat: don't write the conf file if already there
this avoid to overwrite the configuration file at each update.

closes  #11722
2016-06-07 16:25:21 +02:00