Create a new live-session survey with a multi-choice question of 4
choices. In one of the choices write a word of 20+ characters. Start the
live-session, on the manager side the choices overlap on the screen.
In case a word is longer that the available place, it can overlap on the
labels of the other columns, making the text very hard to read. This
work wraps words that are too long for a single line over multiple ones.
Task-3530706
closesodoo/odoo#146554
X-original-commit: f085957855f86fb669c533be09fd13a14a6c874d
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
Current behavior:
When trying to print the changes of an order, nothing was printed.
This was happening because we were first saving the changes before
sending them to the printer. Because of this when we tried to retrieve
the changes to print them, they were already saved and we were not
retrieving anything.
Steps to reproduce:
- Setup a printer to print order changes
- Create a new order in PoS restaurant
- Add a product to the order
- Click on the "Order" button
- Nothing is printed
opw-3625397
closesodoo/odoo#146461
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
In list views with search panel, in case there are no records found,
the nocontenthelp is being cut off,
because the o_list_renderer doesn't take the full height.
This commit sets the height on the div, so there is no cut off happening.
Part of: task-3619987
closesodoo/odoo#147268
X-original-commit: 52c916089547c96c2d16c0c6134b40270b72b72d
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Aliya Tastemirova (alta) <alta@odoo.com>
Currently, categories' images can only be seen while logged in. This fix will allow public user to have access to images.
Description of the issue/feature this PR addresses: add access rights for booth category for public user
Current behavior before PR: images of booths' are not loading if not logged in
Desired behavior after PR is merged: images of booths' are loading regardless of the user
opw-3625773
closesodoo/odoo#147267
X-original-commit: 1599e5c3c004e439e8ff45dfc40a92a045a66c21
Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
Before this commit:
Filter items in the sidebar/panel are sorted DESC. Items without value
are put at the end of the sorted list (eg : Open Shifts)
After this commit:
Filter items are sorted ASC. Label that begins with numeric are also
sorted correctly. Items without value are stull put at the end of the
sorted list.
task~3524031
closesodoo/odoo#146127
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Task latam: 1137
Task Adhoc: 33333
Prevent delete document number if invoice date is assigned (manual documents).
Description of the issue/feature this PR addresses:
On a draft vendor bill (manual documents) if the document number setted, and then if the user set a date, the document number is automatically cleaned and it`s must not be cleaned.
Current behavior before PR:
On a draft vendor bill if the document number setted, and then if the user set a date, the document number is automatically cleaned.
Desired behavior after PR is merged:
On a draft vendor bill if the document number setted, and then if the user set a date, the document number is not automatically cleaned.
closesodoo/odoo#147242
X-original-commit: 8212f7dd73028fa6c68819218e1e63fe60d71913
Signed-off-by: Josse Colpaert <jco@odoo.com>
Steps to reproduce:
Go to the website's home page > Site > Properties > The control panel
buttons in the footer of the "Page Properties" dialog are not aligned
correctly.
The "Page Properties" dialog extends the `FormViewDialog` component and
updates its template using `xpath` to add extra buttons on the right
side of the footer (to "duplicate" & "delete" the current page).
But since [1], a `w-100` class has been added to the default button
container (`.o_cp_buttons`) on form view dialogs to get the same result
as the "More Options" button on `Calendar > Quick Create` dialogs (the
difference here is that the extra button was added inside the default
buttons wrapper, while on page properties, the buttons are added next
to it).
The goal of this commit is to "safely" fix this misalignment issue on
stable by simply removing the `w-100` class for the page properties
dialog. On master, we will adapt the page properties buttons to have
the same structure as on the calendar dialog.
[1]: https://github.com/odoo/odoo/commit/7dd6e5d1a55de99a4212abc6f24490e47d9ce5bb
task-3642712
closesodoo/odoo#146541
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
Phone and mobile numbers are not well displayed
on contact widget..
This is because of the display flex that split
the column in two if there is too much information.
We remove the display flex + flex column as
all the children of the element are div, which is
a block element, therefore they are already arranged
one on top of the other.
Steps:
- Having a contact X with full address informations
(address, name, phone)
- With purchase module, you see the bug by
printing a RFQ for the contact X
opw-3626486
closesodoo/odoo#146455
Related: odoo/enterprise#53201
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
This commit involves reorganization of demo data in the Indian localization
modules.
Specifically:
- Removed demo data entries.
- Added new demo data entries for improved examples.
task id: 3614544
closesodoo/odoo#144951
Related: odoo/enterprise#52104
Signed-off-by: Josse Colpaert <jco@odoo.com>
steps to reproduce:
- install the module "2FA by mail" (auth_totp_mail_enforce)
- open settings (this should bring the settings of the settings app)
- activate "Two-factor authentification enforcing policy" to "Employees only"
(or "All users") and save
- try to (re)connect with a user (demo/demo or admin/admin)
before this commit:
- internal server error
after this commit:
- error is passed to the user, allowing him (or the admin) to
debug without contacting odoo support
opw-3624816
closesodoo/odoo#147196
X-original-commit: a449210cc18f64460096cb43b3633d4861120d0e
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
Before this commit:
Got a traceback instead of an error message on scanning a barcode.
Reason:
Until 16.4 error message send in the object via Eventbus, which removed in
https://github.com/odoo/odoo/commit/72dbb75d4de529a35c45273ded472d038a7bb738 so because of that error message will be sent directly(not in object).
After this commit:
User will get an error message if anything wrong happened.
Task:3524284
closesodoo/odoo#138877
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Fix a small issue with the trusted account lock system, where we would raise an error
when you change the partner or account number on a record at the same time as you untrust it.
Before this fix it would be blocked, and you would need to untrust, save, and then redo the
change in a second edition for it to work.
At the same time, we will allow the process to untrust an account and change values at the
same time.
Task id #3647635closesodoo/odoo#147089
X-original-commit: 3815ccea98c95130a770772aa29c87112e695914
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
Description of the issue/feature this commit addresses:
On the first of Janurary 2024, Indonesia will use 16 digits VAT numbers in
addition to 15 digits ones. This commit makes it possible to use any of these
two possibilites when entering the VAT number on an indonesian company.
Desired behavior after this commit is merged:
This commit makes it possible to enter either a 15 or 16 digit VAT Number on
an Indonesian company.
task-3636748
closesodoo/odoo#147215
X-original-commit: aae3495334f02eaf43e0396b040b75c926406fbd
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
Signed-off-by: Thomas Becquevort (thbe) <thbe@odoo.com>
Steps to Reproduce:
Create 2 companies > Create employee in 1st company > Enable both companies > Create public holidays company-wise> In company 1 create a public holiday for (13/11/2023) > In company 2 create public holidays (13/11/2023) and (29/11/2023).
Then switch to the one company (where the public holiday was created only for (13/11/2023))> Go to attendance > Configuration > Enable the count extra hours feature > Create attendance date (29/11/2023) for ex. 9 hours > Go to employee form > You may see the extra hour of "1 hour" > Because there is no public holiday on 29/11/2023.
Then enable both companies > Create attendance date (29/11/2023) for ex. 9 hours > Go to employee form > You may see the extra hours of "9 hours" > Because there is a public holiday in another company on 29/11/2023.
Bug Source:
commit 1407052 fixed the fact that public holidays are not taken into account when computing the overtime, but it doesn't cover the multi companies case.
Solution:
Verify that the public holiday company and the employee company are the same before applying the compute.
An optimization was also added to avoid searching for public holidays in db by filtering with the
employee company.
opw-3597287
closesodoo/odoo#146987
X-original-commit: 62494f5c7c80f2fafa56e397f2cd918e1a9e2648
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Steps to reproduce the bug:
- Create two storable product “P1” & “P2”
- Create a purchase order:
- Add 10 quantity of “P1” & “P2”
- Confirm the PO
- Go to the delivery:
- Set the quantity of “P1” at 2 and “P2” at 0
- validate the delivery and create a backorder
- Go to the backorder:
- The quantity set for “P1” is 8 and for “P2” is 0
- Try to validate and create a backorder
Problem:
Nothing happens because the quantity of "P2" is 0, and the "picked"
field is set to True. However, the quantity should be 10, and the
"picked" field should be set to False when the backorder is created:
https://github.com/odoo/odoo/blob/17.0/addons/stock/models/stock_move.py#L1822-L1828
opw-3629848
closesodoo/odoo#147128
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Current behavior:
The pos_self_ordering_mode field was not interpreted as invisible when
no PoS existed. Because this is a required field you were not able to do
any changes in the settings if you had no PoS.
Steps to reproduce:
- Archive all PoS
- Go to Settings, and change any settings you want
- Save the settings
- You get an error "Invalid field 'pos_self_ordering_mode'"
opw-3649784
closesodoo/odoo#147126
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Fix a bug where quick-create of products from the expense form view
would not use the service detailed_type by default. Allowing bugs
when sale_stock module is installed as it would be considered
as a storable product
Also updates the demo data accordingly
task-3458826
closesodoo/odoo#147123
Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>
Signed-off-by: Julien Alardot (jual) <jual@odoo.com>
When setting the ordered quantity on a sale order
under the delivered quantity, if the product used is storable in stocks,
an error is raised.
This improves the error message so that it's more understandable when
this happens due to canceling an expense report (move)
or re-setting it to draft
task-3458826
Part-of: odoo/odoo#147123
This deals with a bug when an expense re-invoiced
with a 'sale_price' expense_policy and 'delivery' invoice_policy
Current bad behaviour:
- When re-invoicing another expense matching the first one's
price_unit and product the quantities aren't updated properly
- Furthermore, reversing the original move doesn't impact the sale order
- Resetting the expense sheet to draft neither
New correct behaviour:
- When re-invoicing another expense matching the first one's
they aren't grouped together on the same line, allowing to update
and reverse the lines independently
- Reversing the original move sets its corresponding sale order line
quantity and delivered quantity to 0
- Resetting the expense sheet to draft does the same
- Resetting the original move does the same
- Adds clarity to the sale_stock error message, so it's understandable
from the expense view
task-3458826
Part-of: odoo/odoo#147123
Current behavior:
When you only used the "Next order coupons" loyalty program, the "enter
code" button was not displayed.
Steps to reproduce:
- Install the pos_loyalty module
- Archive all the loyalty programs
- Create a loyalty program with "Next order coupons" as reward
- Open a PoS session
opw-3608894
closesodoo/odoo#147101
X-original-commit: 55ad2020e4b56a2ce525959f0c021b83198446bc
Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>
Current behavior:
When grouping by warehouse in the sales report, the pos orders appeared
under the "None" warehouse group.
Steps to reproduce:
- Create a PoS order
- Validate the PoS order, and close the session
- Go to sale reporting, group by warehouse
- A group "None" appears, with the PoS order inside
opw-3540797
closesodoo/odoo#147100
X-original-commit: 132dd31e7e7a941ad375ada0be35dde05d0b3a43
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>
- Create a "/test" page, publish it
- Set "/test" as homepage url directly on the website (in the settings)
- Go to that page
- Open the page properties and change its URL from /test to /else
From there, the website setting (`homepage_url` field) was still set to
/test and not /else.
It means that the first "published" menu would then be used to avoid
serving a 404 as homepage to your visitors.
It is a bit confusing and people probably just expect to change that
website setting too when changing the page URL.
We had some feedback about similar flows (that couldn't be reproduced or
where people weren't sure) where people ended up writting on the wrong
page or losing their content.
Maybe this will mitigate the issue.
Kind of related: task-3476840
closesodoo/odoo#147086
X-original-commit: 374a1b31f70a3209b1ae11db8e5886350579c7f9
Signed-off-by: Jérémy Kersten <jke@odoo.com>
To reproduce
============
- on studio > create new report from internal layout
- execute 2 columns command --> the second column will be under the first one
Problem
=======
the browser finds out that the `iframe` is small to keep two `col-lg-6` side by side.
Solution
========
use `col-6` instead, like in 17
opw-3585043
closesodoo/odoo#147074
X-original-commit: 246f42baf76b308210a2b03d46a6143ace4bb7cc
Signed-off-by: Antoine Guenet (age) <age@odoo.com>
Signed-off-by: Abdelouahab Laaroussi (abla) <abla@odoo.com>
Before this PR, the "can reconnect after late close event" test
was relying on the `nextTick` helper to check which bus events
were received when the device switches from online to offline.
This test was non deterministic since a tick might not be enough
to receive the related events: the bus service communicates with
a shared worker through the MessagePort API, the worker uses a
Websocket which dispatch events upon connection/reconnection.
This commit replaces the use of the `nextTick` helper by the
dedicated `waitForBusEvent` helper which resolves once the event
is received.
fixed runbot-45695
closesodoo/odoo#147068
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
If multiple questions are conditionally displayed if the user selects an answer
in another multi-choice question, that answer was added multiple times in the
list used to filter mandatory questions that have to be answered when displayed.
This is an issue because the answer was only removed once if the user changes
his choice resulting in a state where a mandatory question that is hidden stays
mandatory even though it is not displayed to the user.
How to reproduce:
- create a new survey with:
- Question1:
- multi-choice with one answer
- 2 answers (A, B)
- Question2:
- single line text box
- mandatory answer
- conditional display depending on answer B of Question1
- Question3:
- single line text box
- conditional display depending on answer B of Question1
- start the survey
- click on answer B then click on answer A
Current behavior:
- user is not able to submit the survey with answer A selected
Expected behavior:
- user should be able to submit the survey
Note:
The issue was already fixed from 17.0 in this [commit], but the test is
still adjusted to ensure that displaying/hiding multiple questions at once
depending on conditional triggers works as intended without preventing the user
to finalize the survey.
[commit]: https://github.com/odoo/odoo/commit/55fa52be8a80e6f7ee2a526db29c0d97c24ae8f6
task-3630079
closesodoo/odoo#147008
X-original-commit: f574ec49b730917e8e781a9b47895048a389d585
Signed-off-by: Florian Charlier (flch) <flch@odoo.com>
Co-authored-by: Salvo Rapisarda <sdrapisarda@gmail.com>
Co-authored-by: Damien Abeloos <abd@odoo.com>
If customer did not have address,email and telephone fields,
"False" would be send to Adyen resulting in these field
containing False values, which in some cases was falsely
triggering anti-fraud system.
task-3159378
closesodoo/odoo#146990
X-original-commit: 0de6864e32cff260393fde391250cff0fa6d9653
Signed-off-by: anko-odoo <anko@odoo.com>
Steps to reproduce the issue:
- In website edit mode, add newsletter block onto the page.
- In the options of the snippet, change the template to "form".
- Click on the "Display Thanks Button" checkbox.
- => Traceback.
In this commit [1], a button has been added to the options of the
"Newsletter Block" snippet to allow the user to display the "thanks"
button in edit mode to be able to edit it.
Later, in another commit [2], a new "Form" template was added to the
"Newsletter Block" snippet, but the "Display Thanks Button" option was
not adapted for it.
This commit adapts the "Display Thanks Button" option for the "Form"
template of the "Newsletter Block" snippet so that it displays the thank
you message on the page, and the user can also edit it.
[1]: https://github.com/odoo/odoo/commit/a9eae10af88a0aba88ce6d3e3f517926edf36c00
[2]: https://github.com/odoo/odoo/commit/bd6ef64f4c79b9c04dc8b85dc2daccb61d55cad0
task-3610063
closesodoo/odoo#146867
X-original-commit: ccf338c67219b10fe86b15012e143a84c886654f
Signed-off-by: Guillaume Dieleman (gdi) <gdi@odoo.com>
The portal view of the sale order total is broken.
This issue was fixed in this commit 619e5e0dad but it was removed in this commit df8535fbd4
The changes that were removed have been re-added.
task-3646364
closesodoo/odoo#146806
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Using the animation option on an image can turn the image src from
relative to absolute.
It then makes our code crash in some cases (multi domain & cors
protected img). The previous commit makes sure to protect this case by
making the code more robust.
This commit is fixing one of the detected root cause (explained in
previous commit).
The fixed code was introduced with commit [1].
Since we can't guarantee our code has no other way to turn relative into
absolute url, neither that we won't introduce new code doing that, the
very small safety net from previous commit has to be keep as defensive
programming.
[1]: https://github.com/odoo/odoo/commit/7f730f81ec541cc7791fc6b3fded17c838433f85closesodoo/odoo#146731
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The image mouseover animation, introduced with [1], can crash through
legit UI flows:
- Visit your website on domain 1 (you will need to access the same
website from another domain later):
1. On local: use http://localhost:8069/ and http://127.0.0.1:8069/
2. On runbot: use master-all and master in URL
3. On odoo.com: use xyz.odoo.com and xyz.com
- Drag & drop "Text - Image" snippet
- Double click on the image to replace it
- Upload any image
- Click on the image and set its "Animation" option to "On Hover"
- Save
- Outside edit mode, mouseover the image to see the animation
- Behind the scene, the img src is changed from /web/image/xyz to a
hardcoded base64 value to show the animation
- Now enter edit mode, the system will actually reset the src to the
original src (to replace the b64) but it will replace it by an
absolute link and not the initial relative link
- Edit the text below the image, BUT DON'T MOUSEOVER THE IMAGE
(otherwise the absolute url would be turned into b64)
- Save, again DON'T MOUSEOVER THE IMAGE
- Now go on your second domain to access the same page
Bug: Mouseover the image, a `Uncaught Promise > Failed to fetch` error
will be raised because of a CORS error.
Indeed, on http://localhost:8069/, simply doing this in your debug tool:
```js
fetch('http://127.0.0.1:8069/website/static/src/img/snippets_demo/s_image_text.jpg')
```
will throw the same error.
Note: we can't just modify the CSP rule(s) to allow that domain because
we have no way to know which domains are safe and really domains from
the same database:
- When you are on xx.odoo.com, there is no way to know that xx.com is
also your domain for the same website. At best it will be set in the
website domain but it's not always the case (often not the case in
mono website)
- When you are on xx.com, we have no way to know that xx.odoo.com is
also your domain for the same website. At best it will be set in the
ICP `web.base_url` but until that ICP is actually frozen, it will
change every time the admin logs in the database.
[1]: https://github.com/odoo/odoo/commit/7f730f81ec541cc7791fc6b3fded17c838433f85
Part-of: odoo/odoo#146731
HOW TO REPRODUCE
================
- Don't need to login
- From Odoo front-end, go to Courses > Trees, Wood and Gardens >
Main Trees Categories
- You get the following client error:
Uncaught Promise > datetimeObj.getTime is not a function
HOW TO SOLVE:
============
Unlike standard JS equivalent, luxon datetime objects don't have a
getTime() function. Replace it by valueOf() function.
Also, remove calls to `DateTime.fromJSDate().formatting_fn()` by
luxon equivalent functions.
see bb09cf76e3
task-3632077
closesodoo/odoo#145573
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit, when a user uploaded a webp logo through the website
configurator, the colors of the logo were not detected. This commit adds
the possibility to detect the colors of a webp logo.
task-3609329
closesodoo/odoo#145047
Signed-off-by: Soukéina Bojabza (sobo) <sobo@odoo.com>
Before this commit, when a user was uploading a logo for a website via
the website configurator, the logo was added as an attachment but the
potential previous logo was not deleted. This commit fixes this by
deleting the previous logo when a new one is uploaded.
Steps to reproduce the issue:
- Create a new website
- Fill the configurator until you can upload a logo
- Upload a logo, then upload another one
- Finish the configurator
- Edit a page of the website
- Change an image
=> You can see the first logo you uploaded in the list of images.
task-3609329
Part-of: odoo/odoo#145047
If incorrect code was applied, possibility of putting another
code was blocked.
task-3601317
closesodoo/odoo#144367
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
The margin between the `Log note`/`Activities` is more than
`Send message`/`Log note` buttons. Which looks weird after the `WhatsApp`
button is added.
So, we update the margin between `Log note`/`Activities` to be
the same as `Send message`/`Log note` buttons.
task-3497496
closesodoo/odoo#146811
Related: odoo/enterprise#53066
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
Since [1], the test that ensures live chat threads are sorted
according to their last interrest date is broken. Indeed, the sort was
moved from `im_livechat` to `website_livechat`. This is incorrect.
Also, most of the compare functions used to sort by datetime were
incorrect: those datetimes can be undefined in which case the result
of the compare function would be `NaN`.
This PR moves back the sort function in the correct module and
introduce a standard way to compare by datetime which handles
undefined datetimes correctly.
[1]: https://github.com/odoo/odoo/pull/143382
fixes runbot-47784
closesodoo/odoo#146805
Related: odoo/enterprise#53065
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
To reproduce:
- Create a new plan with an account
- Add an analytic item with this account
- Go to the view of this account
- Gross Margin Button has a value
- Click on it
=> List is empty
The reason being that the view should not include account_id,
but auto_account_id
closesodoo/odoo#147080
Signed-off-by: William André (wan) <wan@odoo.com>
When the verification code is saved,
it triggers the full save and and users get errors about other required fields, e.g. website language missing.
This commit removes save on every focusout, as the save is triggered when clicking confirm.
closesodoo/odoo#147037
X-original-commit: 06d67a05211a24b856b95bc3bdae775dfbd90c19
Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>
Signed-off-by: Aliya Tastemirova (alta) <alta@odoo.com>
According to:
https://requests.readthedocs.io/en/stable/user/advanced/#timeouts
There is 2 different timeout, the connect and read one.
Both have their own exception if they timeout, the connect one
was handled but not the read one.
Before this commit:
If the read timeout happen, a traceback will occur interrupting
the (scheduled) job:
File ".../odoo/addons/product_images/wizard/product_fetch_image_wizard.py", line 308, in _get_image_from_url
response = self._session.get(url, timeout=5)
...
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='...', port=443): Read timed out. (read timeout=5)
After this commit:
We ignore the timeout-ing request the same way the
request.ConnectionError do
opw-3546601
closesodoo/odoo#147012
X-original-commit: a4c382e3e03541d5db7fd7c627b78658573732a4
Signed-off-by: Loan Sens (lse) <lse@odoo.com>
Description:
===========
Before this commit, when a line in edit mode in a list view is the last
tabable element in a dialog, pressing "tab" does not cause a switch to
the next line in edit mode. It is therefore not possible to navigate
in this dialog using "tab".
Problem:
=======
Currently, the ListRenderer listens to keydown events using few t-on-keydown.synthetic
in order to know whether to switch the next line to edition.
For information, the effect of a synthetic is to create a single listener
on "document" instead of creating a listener for each element. There is
a conflict with the ui service which listens to all the "tab" keydowns
in order to check whether or not we are on the last tabable element of
the current activeElement. If we are, we stop the event and focus on the
first tabable element. This feature avoids the need to navigate outside
dialogs by pressing tab.
In our situation, this has the effect of stopping the keydown event
before the synthetic can receive it, as the service ui listener is placed
on the dialog and the synthetic listener on the document.
Solution:
========
Remove the use of synthetic in the ListRenderer.
No significant loss of performance was observed.
closesodoo/odoo#147027
X-original-commit: 48e154e
Related: odoo/enterprise#53150
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Prior to this change, anything passed in the context of a m2m
avatar field would not be taken into account because the context
was not passed properly in the many2many_tags_avatar_field template.
This commit fixes that and also adds a test for future testing.
task-3599601
closesodoo/odoo#146562
X-original-commit: 03202b7c790be266674e12b96a0b99f44ac773ed
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
This commit changes the style of warehouse filter on hover and when something is selected so there is evidence that is clickable and if something is selected
closesodoo/odoo#146371
X-original-commit: 229fd7e5351889307f8b6340990a195cbfe1cebc
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
To reproduce:
1. enable 'debug' mode
2. go to menu "Settings / Translations / Languages" and enable a new
language (ex: nl_NL)
3 create a new lead and set that language
(IMPORTANT: do not set a customer)
4. go back to menu "Settings / Translations / Languages" and disable the
language you previously enabled at step 2.
5. from the lead list view, selection the lead you created at step 3,
click "Action" and choose "Convert to opportunities"
6. In the wizard choose for:
* Conversion Action: Convert to opportunity
* Customer: Create a new customer
7. Click button "Convert to opportunity"
This crash with the following error:
```
Traceback (most recent call last):
File "/data/build/odoo/odoo/http.py", line 654, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/data/build/odoo/odoo/http.py", line 301, in _handle_exception
raise exception.with_traceback(None) from new_cause
ValueError: Wrong value for res.partner.lang: 'nl_NL'
```
This commit ensure that when converting a lead to an opportunity, we
don't crash if language is archived.
OPW-3617359
closesodoo/odoo#147003
X-original-commit: 208d6ed021f62b1b53f75129a18e8a0d302f47b0
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Xavier Alt (xal) <xal@odoo.com>
Steps to reproduce:
- Install `website_event_crm` module
- Go to events and create a new event
- Add a question of type `text input`
- Publish the event and go to it on the website
- Register to the event with an email containing `@example.com` and
answer the question.
- Go to CRM in backend and open the new lead created.
Issue:
Html tags are not escaped in the lead description.
Same issue with `text_box` type question when having html in answer.
Cause:
The override of `_get_lead_description_registration` is returning
a string that escape also the `</br>` tags + the `text_box` answer
is not escaped.
Solution:
Use Markup around strings that contain the `</br>` tags to be not
escaped + escape `text_box` answers.
opw-3471097
closesodoo/odoo#146937
X-original-commit: 27faa1f9b28d01e13277d8d16d7dfbbab8701b01
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Previously, the multi-record selector dropdown occupied an entire line.
This commit addresses this issue by applying the `flex: 1 0 1rem;`
property to the auto-complete dropdown. This adjustment confines the
dropdown to the necessary space. If the space available is less than 1rem,
it will wrap to a new line.
Task ID: 3607067
closesodoo/odoo#146919
Related: odoo/enterprise#53071
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
This traceback arises when the user removes the from or to values.
To reproduce this traceback:
1) Install 'account_accountant' and make sure the debugger mode on
2) Open 'Accounting/Configuration/Account Groups'
3) Create a new record
4) Give the 'from' and 'to' values and save the record.
5) Now remove the 'From' value and try to save it
Error:- "TypeError: '>' not supported between instances of 'str' and 'bool'"
When removing the 'to' value 'code_prefix_end' will be False.
It leads to the above traceback from here.
https://github.com/odoo/odoo/blob/230b680bf92583c9f5e4a3739be1d8602df44331/addons/account/models/account_account.py#L838-L842
sentry-4715927815
closesodoo/odoo#147041
X-original-commit: 0d20e3f14c749c3bf6df4349ce1c2c256f771c7e
Signed-off-by: Andrea Grazioso (agr) <agr@odoo.com>
Signed-off-by: Altaf Shaik (alsh) <alsh@odoo.com>
Julien Castiaux
