Commit Graph
129339 Commits
Author SHA1 Message Date
jbm-odoo fa77ef1d2a [FIX] stock_sms: Wrong function name in button
closes odoo/odoo#35922

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-21 14:12:30 +00:00
Denis Ledoux 47f488a564 [FIX] calendar: recurrent event no longer working
Creating a recurrent event was no longer displaying
all recurring events in the calendar, only the base
event.

This is following odoo/odoo@9920f20e4c

closes odoo/odoo#35919

Signed-off-by: Denis Ledoux <beledouxdenis@users.noreply.github.com>
2019-08-21 13:44:56 +00:00
Arnaud Baes 78619cbe7e [IMP] stock: sequence duplication on picking types.
When a picking type is duplicated, the sequence was by default copied into
the new picking type. This behaviour has become misleading since the sequence_id
is shown only on debug mode. We now simply prevent sequence_id of being copied.

TaskID: 2057311

closes odoo/odoo#35908

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-21 11:59:15 +00:00
RomainLibert 9a27710aa7 [FIX] lunch: fix lunch product report
closes odoo/odoo#35904

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-08-21 11:04:28 +00:00
Yannick Vaucher f3c1e6cfbe Move ISR subscription fields under res.partner.bank
An Inpayment Slip with Reference (ISR) subscription number is provided by the bank or by Postfinance
ISR When the ISR subscription comes from Postfinance it is a direct
subscription.
ISR (bank) When the ISR subscription comes from a bank it is the bank subscription
toward Postfinance.

Having the subscription number on res.bank has 2 drawbacks:

If you have multiple accounts at Postfinance
or
If you have multicompany and each company has a Postfinance account

you won't be able to emit with different ISR subscriber numbers.

This also renames the fields to be accurate on the meaning.
An ISR reference is a Payment reference that will apear on the invoice.
It is better to name it subscription number.

closes odoo/odoo#35873

Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-08-21 12:51:24 +00:00
Raphael Collet 1d2bccd0db [IMP] fields: stricter rules on selection fields overridings
One cannot override the attribute `selection`, and list selections can only be
extended with `selection_add`.

Adapt the bad extensions to be consistent with the new warnings

closes odoo/odoo#35663

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-21 14:36:19 +00:00
Raphael Collet 4cd093a001 [IMP] fields: extend selection with a given order
When extended with the selection_add parameter, a singleton (value,)
where `value` appears in the overriden selection, can be used.
The new values are inserted in an order that is consistent with the
overridden selection and this list.

selection = [('a', 'A'), ('b', 'B')]
selection_add = [('c', 'C'), ('b',)]
> result = [('a', 'A'), ('c', 'C'), ('b', 'B')]
2019-08-21 13:47:17 +00:00
Parth Choksi ebaa132d5d [IMP] various: Clean settings UX (back2basics)
TaskID: 2028958

closes odoo/odoo#35551

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-21 12:12:33 +00:00
wan 1576c91c9a [IMP] account_reports: add off sheets acount type
Task 1998268

closes odoo/odoo#35150

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-08-21 14:28:19 +00:00
Kaushalya MandaliyaandMohammed Shekha e8e3ba96dc [FIX] mrp: work order overlap issue when applying group by status
workcenter overview kanban view card width is not same for all cards,
also kanban card overlap in grouped view, to fix this apply width on
o_kanban_record class instead of inline css, also apply width in
o_kanban_group to have same width for all cards in grouped view

task-2052465

closes odoo/odoo#35803

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>


Co-authored-by: Mohammed Shekha <msh@odoo.com>
2019-08-21 12:53:49 +00:00
Kaushalya Mandaliya 03c2083890 [FIX] mrp: traceback while printing BOM structure report
From the commit: 36b976ccee
A traceback is generated while printing BOM structure
report, which is fixed in this commit.

task-2024247
closes: #34899

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-07-30 10:33:16 +00:00
Shreya Modi af80c68ae5 [IMP] mail: improve create_uid heuristics in mail gateway
PURPOSE

Currently mailgateway runner user is used to create most documents through
incoming emails. Purpose of this commit is to try to link document creation
and update to users, using the email to make the matching.

SPECIFICATIONS

New sudo implementation allow to bypass access rights while keeping effective
user as creator. Use this mechanism to create documents still using the
mailgateway runner user while linking creator to matching user.

Heuristic to use to match email_from and users

* if route is linked to an alias: check its owner record and check in its
followers;
* find users having this emails;
* if route is linked to an alias: use alias_user_id field;
* fallback on mailgateway user;

Other side effect is that creator and author of incoming email linked to the
new record will now better match the document creator when linked to an
existing user.

LINKS

Task 1919267
PR #30597

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-21 13:28:03 +00:00
Thibault Delavallée 109f390756 [IMP] mail: remove unnecessary decorators
Purpose of this commit is to lessen complexity of stack chain in mail main
methods. Removing decorators is a good start for this.

LINKS

Task 1919267
PR #30597
2019-08-21 13:28:03 +00:00
Raphael ColletandMartin Trigaux a9567a7f21 [FIX] base: allow to remove fields when the registry is not ready
When the registry is not ready, allow modifications of the selections

The following use case must reset the values:
- removing a selection on a custom field via studio
- changing the static selection definition and updating the module

The value must NOT be reset when:
- trying to remove manually a base field
- updating a module without all override being computed yet
(i.e. install)

Fully replacing the selections in an override should not happen

Instead of relying on the context, check if the registry is ready
before marking the selections as to remove.
If a static selection is removed and the module updated, it will be
removed correctly during the _process_end method as the selections
will not be present in pool.loaded_xmlids

Before this commit, updating a module A was doing a SET NULL for
selection values added by a module B via a selection_add

closes odoo/odoo#35871

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>


Co-authored-by: Martin Trigaux <mat@odoo.com>
2019-08-20 15:56:09 +00:00
Robot Odoo c2d4873e71 [MERGE] portal, website_{mail, rating}: fix frontend rating and reorganize portal chatter overrides
PURPOSE

Fix frontend rating and clean a bit module organization.

SPECIFICATIONS

Fix rating in frontend (website_slides, website_sale): rating is halved at each
update and new entries have no rating.

Also reorganize portal chatter overrides

* rename files to ease code reading and discovering;
* move assets in their own file to better understand modules;
* move rating widget in its own file;

LINKS

Task 2057301
PR #35870

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-21 17:25:47 +02:00
Robot Odoo 59ac728175 [ADD] pos_epson_printer: Use Receipt printer without IoT Box
Linked to odoo/enterprise#5182

Add possibility to print receipts and orders on an ePOS compatible
Epson receipt printer located in the same local network than the
browser running the pos.

TaskID: 2033442

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#35829

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-08-21 17:25:28 +02:00
Hetal Dhanak 9412695d08 [FIX] mrp: cast datetime from web interface
Updating a datetime field in a form view will fill the 'values' dict
with a string.
This commit casts the dates in mrp.production and mrp.workorder that are given to
their respective stock move into actual datetime object. This prevent any
converting error later in the process

Task : 2055912

closes odoo/odoo#35825

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-21 13:45:23 +00:00
Thibault Delavallée 532b1a5093 [FIX] portal, website_rating: re-allow rating from frontend
PURPOSE

Fix frontend rating and clean a bit module organization

SPECIFICATIONS

Broken since 3620cb68a0

LINKS

Task 2057301
PR #35870
2019-08-21 12:50:51 +00:00
Thibault Delavallée 26b7b0e286 [MOV] website_rating: rename portal files
PURPOSE

Fix frontend rating and clean a bit module organization

SPECIFICATIONS

In order to ease understanding of portal chatter dependencies let us name
files according to guidelines. In this commit we rename a bit files in
website mail to understand which widgets and portal parts are impacted by
website mail bridge module.

Assets are also moved in their own file to ease module discovering.

LINKS

Task 2057301
PR #35870
2019-08-21 12:50:51 +00:00
Thibault Delavallée d6ac39c6c3 [IMP] website_rating: remove useless templates
PURPOSE

Fix frontend rating and clean a bit module organization

SPECIFICATIONS

Remove unused template to lessen noise in this module.

LINKS

Task 2057301
PR #35870
2019-08-21 12:50:51 +00:00
Thibault Delavallée 241453aaec [MOV] website_mail: rename portal related files
PURPOSE

Fix frontend rating and clean a bit module organization

SPECIFICATIONS

In order to ease understanding of portal chatter dependencies let us name
files according to guidelines. In this commit we rename a bit files in
website mail to understand which widgets and portal parts are impacted by
website mail bridge module.

Assets are also moved in their own file to ease module discovering.

LINKS

Task 2057301
PR #35870
2019-08-21 12:50:51 +00:00
Thibault Delavallée 226e21c403 [IMP] website mail: remove useless public channel data
PURPOSE

Fix frontend rating and clean a bit module organization

SPECIFICATIONS

Remove useless mail.channel data as it makes noise without any added value.

LINKS

Task 2057301
PR #35870
2019-08-21 12:50:51 +00:00
ryv-odoo 57d51a4050 [FIX] website_rating: correctly take into account rating ratio in frontend
PURPOSE

Fix frontend rating and clean a bit module organization

SPECIFICATIONS

Currently when updating a review on slides, the rating value is divided
by 2 on each update as the rating ratio is not taken into account. In this
commit we correctly update the hidden input value during the start function
using the rating ratio.

LINKS

Task 2057301
PR #35870
2019-08-21 12:50:51 +00:00
svs-odoo 9ff7758c79 [FIX] mrp: can't open workorders from mrp overview
How to reproduce:
- Install mrp & mrp_workorder;
- Open Manufacturing and plan a workorder;
- Go on the Work Centers Overview;
- Click on "WORK ORDERS" button -> You got a "Something went wrong !".

closes odoo/odoo#35900

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-21 11:17:09 +00:00
Hardik Prajapati 8b495f3989 [IMP] mrp: better labels for the fields on the WO to consistency with the MO.
-hide the quantity done when the workorder has not start to work
-change the label of done to consumed when finish workorder

pad- https://pad.odoo.com/p/r.ed6d2ceefdd46214b72dc4e79552350e

task-1889396

closes odoo/odoo#34202

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-21 11:15:14 +00:00
Robot Odoo dc9c3aae96 [MERGE][ADD] project_expense: setting project on expense
This merge commit provide the possibility for project user to select
a project on an expense. Selectable project are only the one with an
analytic account set. Setting the project will set the analytic
account, so posting the expense will create analytic entries, and will
finally appear on the project overview.
If the analytic account still match an open sale order (and if the
product is reinvoicable), a new SO line will be added on the SO (this
flow does not change here).

Task-1843241 (previsouly Task-1911581)

closes odoo/odoo#29638

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-08-21 14:53:47 +02:00
jem-odoo f871908e86 [IMP] sale_expense: cost tracking and reinvoice flow for expense
Since 12.0, we wanted the employee to select directly the sales order on which
the expense should be reinvoiced. The goal was to avoid employee to select the
analytic account (too technical and usually unknown for employee). Problem is
that we had to give read access to SO to simple employee, breaking the access
rules "See your own document".

As we want to allow all internal employees to determine if the expense should
be reinvoice and on which sales order it should be, we need to allow them to
select that sales order.
This commit allows user to search on SO (simply get their name_get), no information
more to avoid breaking "See your own document" for salesman. Falty ir.rule and
access rights are now removed.

We now clearly split the cost tracking and reinvoicing flow:
- the analytic account field (visible only with group 'analytic' as considered
as advance feature) allows user to track their expenses in some accounts.
- the sales order is displayed for users or approvers to reinvoice the expense.
As this operation implies the tracking, if the AA is not give, the SO will create
its own AA in which the expense will be tracked.
This SO field is only relevant when the product has a reinvoice policy, so we hide
it if there is no reinvoice policy defined.

Reinvoicing an expense has now a different flow from reinvoicing a "Vendor Bill",
which still do magic to determine the SO from the AA set on its lines.

Technical:
to allow user to select SO from a m2o dropdown, the `name_search` is done in `sudo`
for internal user. This is a borderline 'feature' of the system. A few thing show
that the system does completely supports this ("Search More" gives access error, ...).
We still keep this solution, as we don't want a sub group giving access to SO to all
employee (aka an option allowing people to break the sales rights).

Task-1843241
2019-08-21 11:22:59 +00:00
jem-odoo 1f77ff3cd6 [FIX] sale: name get uniformize API
This commit makes the override of the `name_search` more
consistent the basic implementation of the ORM (using lazy
name_get and supports the `name_get_uid` parameters)

Task-1911581
2019-08-21 11:22:58 +00:00
jem-odoo 7c5ce75aeb [FIX] analytic: missing depends
This commit adds a missing `depends` on the `debit` and `credit` computed
field on analytic account model. Indeed, without that, the recompute is not
done when accessing thoses fields after adding lines in the same
transaction (like in tests).

Task-1911581
2019-08-21 11:22:58 +00:00
jem-odoo 00ac6c60f6 [FIX] project: portal user can not read AA
For historical reason (problably the inheritS between project and AA, removed in 12.0), portal
user can read Analytic Account. This makes no sense, as it is a purely internal resource
for companies. Removing the access rights don't change anything for portal user and make
those data secure.

Task-1911581
2019-08-21 11:22:58 +00:00
jem-odoo ba92261148 [FIX] sale_timesheet_purchase: correct action xmlid
Since the refactoring of the accounting model, some action changed
but their xmlid were not adapted everywhere.

Task-1843241
2019-08-21 11:22:58 +00:00
Denis Ledoux 4737e01691 [FIX] sale: fix _compute_quotations_to_invoice following odoo/odoo@9920f20e4c
closes odoo/odoo#35895

Signed-off-by: Denis Ledoux <beledouxdenis@users.noreply.github.com>
2019-08-21 09:59:06 +00:00
Alexandre Kühn 8de430d251 [FIX] base: update minifier regexp to rjsmin (1.1.0)
This version adds full support of string templates.
Before this version, rjsmin may produce wrong code with string
templates. For example:

```js
const url = `https://odoo.com`;
console.log(url);
```

was minified to:

```js
const url=`https:console.log(url);
```

Because `//` was wrongly handled as a comment inside the string
template.

closes odoo/odoo#35867

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2019-08-21 10:22:05 +00:00
jbm-odoo c230cfa0fe [ADD] stock_sms: Integration with stock pickings
The user can already send a confirmation email when the
Stock Picking is done. It'd be great to communicate the
same information by SMS.

In addition, the current mailing tool requires a manual
action. The idea is to automate the process via a
Setting instead.

id=1972567

closes odoo/odoo#35662

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-21 10:04:54 +00:00
Pierre Masereel 93be40e6eb [FIX] point_of_sale: download invoice from POS
When you are creating an invoice from the POS, the report route is
called to download the invoice, since changes made in rev: 118190f3b3

The values for ids where empty, so we give them now the correct id list.

closes odoo/odoo#35889

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-21 09:59:57 +00:00
Arnaud Baes 2408befc8d [FIX] sale_stock: wrong route computed on so lines
_compute_is_mto was based on the sequence of the routes,
as most of those sequences were hardcoded, some had the same values,
resulting in wrong calculations. Furthermore, the method was setting the so lines
as mto if the sequence of the MTO route had the priority on the other ones, even if
the mto route wasn't set on the product.

This simply ensure to check the mto route is set on the product,
sequences should be set manually to prevent any sequence conflict.

TaskID: 2053703

closes odoo/odoo#35740

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-08-21 09:51:17 +00:00
Christophe Simonis c1281f5795 [REM] remove empty module test_pylint
closes odoo/odoo#35892

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-08-21 09:10:02 +00:00
Florent de Labarre 2160db3376 [REM] stock: remove unused code
closes odoo/odoo#35877

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-20 19:54:13 +00:00
Antoine Prieels 380c933a1d [ADD] pos_epson_printer_restaurant: Use Order printer without IoT Box
Add possibility to print orders on an ePOS compatible Epson receipt
printer located in the same local network than the browser running the
pos.

TaskID: 2033442
2019-08-20 12:19:19 +02:00
Antoine Prieels 8ea5583b93 [ADD] pos_epson_printer: Use Receipt printer without IoT Box
Add possibility to print receipts on an ePOS compatible Epson receipt
printer located in the same local network than the browser running the
pos.

TaskID: 2033442
2019-08-20 12:19:19 +02:00
Nicolas Martinelli ddeb7b7cb0 [FIX] account: UK country code
The country code for United Kingdom is GB.

closes odoo/odoo#35828

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-08-20 07:34:37 +00:00
Gert Pellin 118190f3b3 [IMP] point_of_sale, pos_restaurant: multi-user sessions
PURPOSE
=========

When working in restaurants, there are often more than one waiter working on the same floor.
But Odoo doesn't support that.
There can only be one person working on one session for the same tables.
The purpose of this task to allow several people to work on the same session (while synchronizing sessions).

SPECIFICATIONS
===============

- MultiUser is active by default.
- Allow multiple waiters to login on one PoS Config.
- All waiters login to the same session, the waiter that does the paiment is the responsible for the order (same as now).
- Synchonize the information across the multiple instances running on same floors.

Syncronisation will take place at switch of table.
(close tables automaticly if no activity, to force sync)

- Syncro cannot be done if no internet : how do we manage it ? We should inform the user the internet connection has been lost and that synchro cannot be done. What impacts? To check

Useful links
https://github.com/it-projects-llc/pos-addons
https://apps.odoo.com/apps/modules/11.0/pos_bus_restaurant/

Related PR:
odoo#32789

TASK-ID: 1891130

closes odoo/odoo#33973

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-19 14:15:25 +00:00
Pierre Masereel 761f695e0d [FIX] pos_restaurant: fix typo
Forgot to remove unused function with pudb in a248171d96

closes odoo/odoo#35822

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-19 17:53:02 +00:00
Martin Trigaux 30ab0d3a89 [IMP] base: better default for translation overwrite
Following 43d355c208, same logic
Hide it but make it checked by default

closes odoo/odoo#35819

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-19 14:55:57 +00:00
Robot Odoo 9b6a5398df [REF] mrp_subcontracting
This PR modify the subcontracting process:
- Support extra quantity
- No more interaction with the subcontract order. Everything is directly accessible on the operation
- Dropshipping with subcontracting
- Bypass reservation process
- The partner type subcontractor is removed and every partner could be set on the BoM
- Update the initial demand will trigger the rules.
- Demo data
- Subcontractor is required on the BoM (no more BoM for all partners of type subcontractor)

Visually:
- Remove the stat button for linked operation.
- Register Components is only available when a subcontract component is tracked
- Button on operations in order to correct tracked components
- Show Operation button will ask to record components until the total quantity is provided(correction on finish lines are allowed after)

More details available in each commit
Task 1962187

closes odoo/odoo#35738

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-19 18:48:35 +02:00
Arnold Moyaux 4055293873 [IMP] mrp_subcontracting: bypass reservation
A subcontracting receipt should be always assigned even
if the components are not deliver. It depends on the partner
and not our company.
2019-08-19 15:03:59 +00:00
Arnold Moyaux c7b947364d [IMP] stock: Hook for reservation
Before a modification on a quant, stock.move and stock.move.line
check if they satisfy the condition to impact the quant.
However in a new module this condition is hardly editable.
The purpose of this commit is to easily add condition to bypass
reservation.
2019-08-19 15:03:59 +00:00
Arnold Moyaux 673450df40 [FIX] mrp_subcontracting: return to subcontract location
Before this commit a returns would select the classic
partner location. However in the case of a subcontractor return
it should be returned to the subcontract location
2019-08-19 15:03:59 +00:00
Arnold Moyaux 5d809fd6b4 [MOV] purchase_mrp_subcontracting -> mrp_subcontracting_account 2019-08-19 15:03:59 +00:00
Arnold Moyaux a684372fdd [IMP] mrp_subcontracting: subcontractors required
Force to set subcontractors on subcontracting BoM since
it's always used in order to determine if a subcontracting
should be apply on a receipt or not. Also there is not magical
behavior has 'if there is no subcontractor on the BoM then it
means all partners...'
2019-08-19 15:03:59 +00:00