Commit Graph
105657 Commits
Author SHA1 Message Date
Yannick Tivisse f896afcc8a [FIX] web: Call 'toggle_active' instead of 'write'
Purpose
=======

Currently when clicking on 'Archive' or 'Unarchive' on the list view,
we write directly on the record {'active': False}, instead of calling
toggle_active. Missing that way implementation of numerous business cases.

Example
- Archive a record --> archive its next activities
- (Un)Archive a user --> (Un)Archive its partner
- (Un)Archive a product variant --> (Un)Archive its template if
  there is only one variant
- Archive an employee --> Open a wizard to choose an exit plan + describe
  the departure reason
- Archive a route --> Archive its procurement rules
- ...

Specification
=============

- Call toggle_active instead of write when calling toggleActive in the web
  client.
- On the other hand, use actionArchive and actionUnarchive to apply the
  toggle action on the related records only.
2019-07-12 13:01:36 +02:00
Yannick Tivisse ba03089230 [IMP] all: Remove active stat button on all views
Purpose
=======

While cleaning the stat buttons across all modules, we
decided to move the (un)archiving from stat button to
actions in the 'Action' dropdown.

Specification
=============

Remove the 'active' stat buttons in all views
2019-07-12 13:01:36 +02:00
Yannick Tivisse ee5e972586 [IMP] web: Always display (un)archive buttons in Action on form views
Purpose
=======

While cleaning the stat buttons across all modules, we decided to move
the (un)archiving from stat button to actions in the 'Action' dropdown.

Specification
=============

If the record has an 'active' field, display an action 'Archive' in the
dropdown if the record is active, else display an action 'Unarchive'.

The 'Archive' action should ask to the user if he's sure he wants to
make this action.
2019-07-12 13:01:35 +02:00
Mitali Patel dbf9aac272 [IMP] sale(_management): ux improvements on preview quotations
Purpose of this commit is,
-To hide taxes column in preview quotations if no taxes on any SO line,
-Change the size of fa-cart to be bigger for optional products,
-Change the lable of optional product as its compitibale with b2b and b2c tax display mode
-Fix the glitch of optional product quantity update

task-2002587
Closes: #34009

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-06-24 10:28:55 +00:00
Mitali Patel 7e298c86e6 [IMP] sale(_management): remove the useless colspan
In e2e27b4 variable `colspan` and several `<t t-set="colspan"/>` were
removed replacing `t-att-colspan="colspan"` with `colspan="99"`.

but due to xpath behaviour reveted in commit https://github.com/odoo/odoo/commit/a540f7864af5fd46cc30ea8c99b2f404cbf58dd7
so now in master remove the useless colspan code.

task-2002587
closes: #34009
2019-06-24 09:15:27 +00:00
Hetashree Chauhan 49fb56a8d3 [IMP] stock: pass tests without demo data for file test_inventory.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
Hetashree Chauhan 9bf453acb8 [IMP] stock: pass tests without demo data for file test_quant.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
Hetashree Chauhan e7e7284b86 [IMP] stock: pass tests without demo data for file test_wise_operator.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
Hetashree Chauhan 0dff7da0b4 [IMP] stock: pass tests without demo data for file test_warehouse.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
Hetashree Chauhan 7c70fbe5b8 [IMP] stock: pass tests without demo data for file test_stock_location_search.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
Hetashree Chauhan a90fe83dba [IMP] stock: pass tests without demo data for file test_stock_flow.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
Hetashree Chauhan 5262be0a43 [IMP] stock: pass tests without demo data for file test_quant_inventory_mode.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
Hetashree Chauhan a31ee1c0c6 [IMP] stock: pass tests without demo data for file proc_rule.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
Hetashree Chauhan 3f02ae8996 [IMP] stock: pass tests without demo data for file test_packing_neg.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
Hetashree Chauhan 0ff7d7840d [IMP] stock: pass tests without demo data for file test_move2.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
Hetashree Chauhan 58bfeb6f36 [IMP] stock: pass tests without demo data for file test_move.
pass all test cases without any demo data.
If a user has not installed any demo data, then also test cases must not be break.

task-2024202
closes : https://github.com/odoo/odoo/pull/34258
2019-07-11 13:12:09 +00:00
lejeune quentin 3c66ed1405 [FIX] hw_drivers: Avoid duplicates identifiers in devices
Before this commit the identifier integrate the BUS and port to identifiate USB devices
Now we check if there are duplicates devices before increment the identifier

For other loop we add identifier in the iot_device object

task: 1963500

closes odoo/odoo#32737

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-07-09 08:08:16 +00:00
Thibault Delavallée d8deacfdc3 [FIX] mail: set email_from in composer only if set
Some functional flows use sudo() to create records as current user is the
public user. This user has no email. Since 1e6c3bec2c using sudo does
not take superuser identity completely as it only bypasses access rights.
It means some messages are created with public user as author, meaning no
email_from.

In this commit we fix some functional flows by setting a default email_from
in the message composer only if a real email is found. Otherwise it will have
to be set either by the template, either later in the process when creating
messages or emails.

closes odoo/odoo#34742

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-07-11 07:46:57 +00:00
Thibault Delavallée 715834c6e7 [FIX] mail: allow message_log to store a void email_from
Some functional flows use sudo() to create records as current user is the
public user. This user has no email. Since 1e6c3bec2c using sudo does
not take superuser identity completely as it only bypasses access rights.
It means some messages are created with public user as author, meaning no
email_from.

In this commit we fix some functional flows by allowing message_log to store
messages with a void email_from. Indeed message_log does not propagate any
notifications, meaning email_from is not required in any email notification
or to compute a reply_to.
2019-07-11 06:53:28 +00:00
Thibault Delavallée 560e03e3b0 [REV] Revert "[FIX] mail: avoid crashing for users without email address"
This reverts commit 6230f72d2b.

Crashing when user have no valid email is the expected behavior. Flows sending
emails must ensure either current user has valid login / email, either it
uses an user OR author_id / email_from that has a meaning in the functional
flow. Notably when public user is involved. Hiding functional issues is not
what we want.
2019-07-11 06:53:28 +00:00
Raphael Collet 97392bcf19 [FIX] base_gengo: method get_gengo_key not aimed at being public 2019-07-08 13:51:35 +00:00
Raphael Collet c552fb7a61 [IMP] api: remove deprecated decorators 2019-07-08 13:51:35 +00:00
Hetal Dhanak fa5037650d [IMP] stock, mrp: company dependant scrap orders.
This commit adds fields 'company_id' on stock.scrap model.
The company will filter locations and stock moves linked to the scrap
document.

We add also a specific sequence by company.

Task-1930055

closes odoo/odoo#30498

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-07-11 08:15:22 +00:00
Hiral Bhavsar d3abf5c9fb [IMP] product_margin: remove actions from the controlpanel action menu
Here remove the 'binding_model' attributes from 'act_window' to
remove the action menu 'Product Margins' from the 'product.product'
model

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar b7c8cf1b60 [IMP] hr(_*), website_hr: replace actions menu by stat button
* attendance, contract, fleet, holidays, maintenance, presence,
  timesheet.

For the model 'hr.employee', replace the actions menu 'Archive/Restore'
by the stat button. That's why adapted changes regarding xpath.

Also rename the actions menu 'Time Off' by 'Time off'.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar 2b7d899124 [IMP] account(_*): clean the controlpanel actions
* check_printing, voucher

For the model 'account.account',
- Replace the action menu 'Journal Items' by the stat button.
- Hide menu 'Journal Items for Tax Audit' from actions menu.

For the model 'account.invoice',
- Set action menu 'Share' only for the form view.
- Rename the action menu 'Confirm Draft Invoices' by 'Validate'.
- Rename 'Register Payment' by 'Register payment'.
- Rename 'Send' by 'Send & print'.

For the model 'account.move',
- Remove the menu 'Journal Items'.
- Rename 'Reverse Moves' by 'Reverse' and set it only for the list
  view.
- Rename 'Post Journal Entries' by 'Post entries' and set it only for
  the list view.

For the model 'account.move.line',r ename 'Reconcile Entries' by
'Reconcile' and 'Unreconcile Entries' by 'Unreconcile' and set it only
for the list view.

For the model 'account.payment',
- Rename 'Send Receipt By Email' by 'Send receipt by email' and set it
  for both form and list views.
- Rename 'Post Payments' by 'Confirm' and set it for the list view only
- Rename 'Print Checks' by 'Print checks' and set it for the list view
  only.

For the model 'account.journal', remove the menus 'Unpaid Invoices',
'Bank statements' and 'Voucher Entries'.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar 6eef0ea0b7 [IMP] lunch: clean the controlpanel actions
- For the model 'lunch.order', rename the actions menu
  'Lunch: Receive meals' by 'Mark as received' and 'Lunch: Cancel meals'
  by 'Cancel'.
- For the model 'lunch.product', remove the action menu
  'Lunch: Archive/Restore products'

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar 5a2c3286ea [IMP] hr_expense: clean the controlpanel action menu
For the model 'hr.expense', rename the action menu 'Submit Report' by
'Submit report' and set it only for the list view.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar 32c01d1850 [IMP] hr_timesheet: remove the action menu 'Timesheet Entries'
For the model 'project.task', remove the action menu 'Timesheet Entries'

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar cba58475b2 [IMP] repair: rename the action menu 'Create Invoice'
Rename the action menu 'Create Invoice' by 'Create invoices' for the
model 'repair.order'.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar 2456f673de [IMP] purchase: set the action menu 'Share' only for form view
For the model 'purchase.order', set the action menu 'Share' only for
the form view.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar 9f3d3eb8f5 [IMP] mrp(_account): clean the controlpanel action menu
For model 'mrp.production', rename the action menu
'Mrp: Plan Production Orders' by 'Plan orders' and set it for the list
view only.

For the model 'product.template' and 'product.product', rename the menu
'Compute Price from BoM' by 'Compute cost from BoM' and set it for the
list view only.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar 1574861e48 [IMP] stock(_picking_batch): clean the controlpanel actions
For the model 'stock.picking'
- Rename the action menu 'Assign a Responsible' by 'Assign responsible'
  and set it for the list view only.
- Rename the action menu 'Add to Batch' by 'Add to batch'

For the model 'stock.warehouse', remove the action menu 'Reordering Rules'

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar c2bc4ee7cd [IMP] point_of_sale: clean the controlpanel actions menu
For the model 'pos.session'

- Remove the actions menu 'Put Money In', 'Take Money Out' and 'Orders'
  from the controlpanel actions menu.

For the model 'pos.config', remove 'Sessions' action menu.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar 9df284f5b5 [IMP] (website_)sale: clean the controlpanel actions
For the model 'sale.order'

- Set the action menu 'Share' only for the form view of model.
- Rename the action menu 'Invoice Order' by 'Create invoices' and set
  only for the list view.
- Rename the action menu 'Send a Cart Recovery Email' by
  'Send cart recovery email' and set it only for the list view.
  Also improved tour 'shop_cart_recovery' as now action menu only
  available on the list view.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar 701f26ce79 [IMP] crm, website_crm_partner_assign: clean the controlpanel actions
For the model 'crm.lead'

- Rename the action menu 'Send an email' by 'Send email'.
- Remove the action menu 'Mark Late Activities as Done' and
  'Mark All Activities as Done'.
- Set 'Mark as lost' menu action only for the list view.
- Remove the action menu 'Assign salesman of assigned partner'.
- Rename the action menu 'Forward to Partner' by 'Forward to partner'
  and set it for both form and list view.

For the model 'res.partner', remove the actions menu 'Meetings'.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:57 +00:00
Hiral Bhavsar 69cf2c0f82 [IMP] portal: rename the action menu 'Grant Portal Access'
Rename the action menu 'Grant Portal Access' by 'Grant portal access'
for the model 'res.partner'.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:56 +00:00
Hiral Bhavsar 3b08cf1d17 [IMP] membership: remove the action menu 'Invoice Membership'
Remove the action menu 'Invoice Membership' from the model 'res.partner'

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:56 +00:00
Hiral Bhavsar b366c554e6 [IMP] mail: rename action menu 'Send Email' by 'Send email'
Rename the action menu 'Send Email' by 'Send email' for the
'res.partner' model.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:56 +00:00
Hiral Bhavsar 29bb709844 [IMP] sms: set action menu 'Send SMS' only for list view
Set action menu 'Send SMS' only for list view of 'res.partner' model.

Linked to task 1984526
Related to PR #33720
2019-07-10 15:07:56 +00:00
mgh-odoo b133091728 [IMP] stock: clarify procurement rule message
message help user in case of misconfiguration.

Task-1960746

closes odoo/odoo#34000

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-07-10 11:35:13 +00:00
Hetal Dhanak 14ccea24e0 [IMP] website_crm: made company name field optional in contact form
Previously, 'company' field in the 'contact us' form was a required field
which wasn't ideal to accommodate B2C flow.

When applied this commit will make company field optional by default. Note
that users can customize the form to make it required again if necessary.

Linked to task 1965839

closes odoo/odoo#33005

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-07-10 15:18:42 +00:00
Parth Choksi d59fd862f1 [IMP] auth_signup : send a reminder for pending users
Purpose of this commit is to send a mail template to the user
who invited other user(s) in Odoo.

It informs the user about the details of user(s) who have been
invited by him but have still not registered after the given days
of creation (default set to -> 5days)

task-1912449
Closes #31582

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-07-10 15:12:02 +00:00
Romain DerieandXavier Brochard 41334ca2a5 [FIX] portal: show only real partner on access portal wizard
Before this commit, when granting portal access to a res.partner through the
wizard, it would show all the partner + its child_ids, including shipping
addresses partner, billing addresses, private (hr) addresses etc, which makes
no sense.

This commit hide contact-address from the list.

Fixes #32848

closes odoo/odoo#34522

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>


Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Xavier Brochard <xavier@alternatif.org>
2019-07-04 09:34:02 +00:00
Yenthe666 ebb755a95d [IMP] sales_teams: improve term and comments
Cateamions?

Fixes odoo/odoo#34045

closes odoo/odoo#34057

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-07-08 12:29:38 +00:00
mgh-odoo 180f237907 [FIX] stock, purchase_stock: activity type to exception
When the system generate an activity the standard is to define it
as an exception type. Todo works as well but we would keep it for
the user and avoid a mix between exception from the system and created
manually.

Task-2007559

closes odoo/odoo#34006

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-07-10 11:36:30 +00:00
William Henrotin 671c71d7d8 [FIX] stock: avoid false-positive in tests
As next activities are ordered by date, having the same date can implies
the order is not always the same.

closes odoo/odoo#34753

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-07-10 13:00:58 +00:00
Simon Lejeune 14812f4171 [REF] sale_stock: invoice_policy shouldn't impact valuation
The invoice status of a sale order line depends on its product's
`invoice_policy` and `qty_delivered` fields.

`invoice_policy` is also used to compute the "anglo saxon price
unit" which is, once multipled by the invoiced quantity, the
amount we will take from the stock delivered account to put into
the cost of goods sold account if we are in anglo saxon mode.

The default `invoice_policy` is set as "ordered". In this mode and in
anglosaxon, the "anglo saxon price unit" will always be standard price
of the product, resulting in unbalanced accounts.

In this task, we chose to use the real delivered price if something was
delivered, whatever the value of `invoice_policy`. We fallback on the
standard price if nothing or not enough things were delivered.

test_dropship_fifo_perpetual_anglosaxon_ordered and
test_dropship_fifo_perpetual_anglosaxon_delivered do have the same
result now.

task-2003196

closes odoo/odoo#34644

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-07-09 14:56:43 +00:00
Aaron Bohy 3db2f7f73d [FIX] web: tab navigation in editable list with only readonly fields
Let's assume an editable list with a row containing only readonly
fields. Before this rev., if the user clicked on this row and then
pressed TAB, it crashed. The crash occurred in historical code that
now seems to be useless, so we simply removed it.

closes odoo/odoo#34696

Signed-off-by: Julien Mougenot (JUM) <Arcasias@users.noreply.github.com>
2019-07-09 12:15:03 +00:00
Hetal Dhanak c0734817b9 [FIX] account: display tag properly on payments
Removed classes "default-label" and "label" as they weren't required and
were giving a bad look to tag.

Task-2033286

closes odoo/odoo#34646

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-07-09 09:17:44 +00:00