Commit Graph
18 Commits
Author SHA1 Message Date
Xavier Morel 482de91bfd [FIX] core: use proper break (hr) in PR template footer
A "thematic break"[1] is composed of 3 or more characters (-, _,
or *). The current separator using only 2 characters between the main
body of the PR and the footer / addendum makes it more difficult to
interpret the message.

Update to 3 so e.g. the mergebot can strip the footer.

[1]: https://spec.commonmark.org/0.30/#thematic-breaks

closes odoo/odoo#101148

X-original-commit: c7bf932c9eb2fc9bc34c653c51bce1552d6afb54
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2022-09-26 16:55:17 +02:00
Xavier-Do 4e3817c0dc [REM] codeowner: remove github codeowner
Github codeowner is replaced with a runbot version of codeowners for
multiple reason:

- github codeowners is difficult to maintain, the precedence rule will
sometimes remove teams from some file because of a more specific rule
added by another team.

- github codeowner does not support version specific rules, especially
the "all except master" rule. For this use case teams needs to adapt
the new codeowner when freezing a new version.

- github will trigger codeowner on failed rebase, and add almost all
teams as reviewer. Runbot has specific commit and file limit to avoid
this problem.

- runbot codeowner is centralised and does not need to be managed cross
repo/version

- runbot codeowner works for enterprise

Any mofification on codeowner should be requested to runbot team.

closes odoo/odoo#74304

X-original-commit: 390dc53054ef9c5602826f4c591fd775fc1d54e4
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
2021-07-28 06:46:40 +00:00
Simon Genin (ges) bc5e219c76 [IMP] codeowners: add framework js codeowners
closes odoo/odoo#72586

X-original-commit: 9ad46806804862d2bc4cf331c00530763a055e67
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Signed-off-by: Simon Genin (ges@odoo) <SimonGenin@users.noreply.github.com>
2021-06-22 21:01:02 +00:00
Olivier Dony af9c6a1a20 [IMP] codeowners: add rd-security watch for auth_* modules
In order to also match ir_http.py and qweb files inside auth modules,
the generic rules for those now also notify rd-security.

closes odoo/odoo#72537

X-original-commit: cf50e37992381d0db8ff886900e154d3f57eadd8
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2021-06-22 12:59:11 +00:00
Victor Feyens 0c132e265b [ADD] codeowners: maintainers of payment & sale scopes
closes odoo/odoo#71589

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2021-06-02 09:30:37 +00:00
Rémy Voet (ryv) a31f57a002 [IMP] codeowners: add codeowners for logistics team
closes odoo/odoo#68954

X-original-commit: 2d114f8722ca4be1d81ac2f221ee45aa927c76dd
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>
2021-04-08 11:14:19 +00:00
Thibault Delavallée cbb5c8c23c [IMP] codeowners: add some apps to RD SM
closes odoo/odoo#68290

X-original-commit: 6b332a8b8b8ab230fb1b49d24dfe4c0ebab7daa9
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2021-04-02 08:42:40 +00:00
wan 81bf7d266c [IMP] codeowner: disable codeowner for accounting in master
We keep the codeownership in stable versions but disable it in master to
reduce the spam.
Will be added back at each freeze.

closes odoo/odoo#66150

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2021-02-15 10:48:50 +00:00
Jeremy Kersten c6f6f87107 [IMP] codeowners: exclude some files for RD-Website
Using a new team rd-notif-muted

closes odoo/odoo#66020

X-original-commit: 157ac9a5bb034dec5edd630ea5d1c929e80ca7ea
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2021-02-11 18:48:15 +00:00
wan b14e5926ae [IMP] codeowners: add accounting
closes odoo/odoo#65571

X-original-commit: 41ac5b0ea7429f11b554a822287b37d635103a34
Signed-off-by: William André (wan) <wan@odoo.com>
2021-02-04 16:52:01 +00:00
Ivan Yelizariev e037852ce7 [IMP] .github: add ticket number to issue template
This should avoid situations when customer reported the same issue via two
channels (github and odoo.com/help), which makes two group of people work in
parallel on the same issue

closes odoo/odoo#62996

X-original-commit: 714cb64595fef08a79bd25b11de51293de7203e5
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2020-12-08 09:56:16 +00:00
Sébastien Theys 5980ebf0dc [IMP] .github: remove rd-images from portal in CODEOWNERS
This rule was generating a lot of noise for very little gain.

closes odoo/odoo#62611

X-original-commit: 1557a648d96bfa725aa7bfa44773e6bb92d41112
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-11-30 12:55:55 +00:00
Thibault Delavallée 42b6bc0392 [IMP] codeowners: target python files only for SM team
closes odoo/odoo#60362

X-original-commit: aa287dc0f2316277d1e509b0c9033431a76d6590
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-10-20 10:54:49 +00:00
Sébastien Theys 87f49b0616 [REM] im_support: remove im_support module
The goal of the module was to communicate with livechat operators on our
production server, except the feature is disabled on our prod and we don't plan
to reactivate it any time soon.

closes odoo/odoo#52691

Related: odoo/upgrade#1313
Signed-off-by: Christophe Simonis <chs@odoo.com>
2020-06-09 10:58:52 +00:00
Sébastien Theys 17c89c0709 [IMP] .github: slightly adapt CODEOWNERS (rd-discuss rd-images rd-sm)
`**` rules for `py` files in `mail` and `sms` were not working as expected: they
only matched files directly inside the folder, without any depth. Indeed
`gitignore` syntax specifies that a slash must follow the double asterisks.
Doc: https://git-scm.com/docs/gitignore#_pattern_format

Added `rd-sm` to the various mail test folders, and removed `rd-discuss` from
`test_mass_mailing` specifically.

Specified which files are to be observed in `tools` for `rd-images`, as it would
otherwise generate too much noise.

closes odoo/odoo#51019

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2020-05-11 10:26:23 +00:00
Sébastien Theys f0a66d05e7 [ADD] .github: introduce CODEOWNERS
Code owners are automatically requested for review when someone opens a pull
request that modifies code that they own.

Code owners are not automatically requested to review draft pull requests.

https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

closes odoo/odoo#47388

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2020-04-20 11:41:39 +00:00
Martin Trigaux cc5dc8bfc5 [IMP] .github: avoid to titleize the PR content
Avoid reports like #23893 where the text is too close to the -- mark
2018-04-04 12:23:41 +02:00
Martin Trigaux e701e566f8 [ADD] Github template files for issues and PR 2016-02-19 09:44:32 +01:00