Commit Graph
129594 Commits
Author SHA1 Message Date
Jitendra Prajapati ee5649cdff [IMP] survey: improve user answers model and display in backend
PURPOSE

Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.

SPECIFICATIONS

Order answer lines following question order.

Display section in answer lines form view to better understand question and
answer organization.

Add a correct flag on answer lines and display it in user input embedded
view in order to know which line are correct.

LINKS

Task 2039068
PR #36229
2019-08-29 15:36:48 +00:00
Thibault Delavallée 0636347099 [IMP] survey: reorder some code to ease understanding
PURPOSE

Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.

SPECIFICATIONS

Reorder some code to better understand module organization.

LINKS

Task 2039068
PR #36229
2019-08-29 15:36:32 +00:00
Jitendra Prajapati 4fbd4a8c6a [IMP] survey: improve wording and labels
PURPOSE

Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.

SPECIFICATIONS

Improve labels of fields and wording in actions. See commit content for proper
specifications.

LINKS

Task 2039068
PR #36229
2019-08-29 15:36:13 +00:00
svs-odooandjip-odoo 25946bd3b4 [IMP] stock: empty inventory report
Before this commit, if user tries to create a new record from a empty
grouped editable list in 'Inventory Report', he/she will get the form
view open which isn't editable.
To avoid that, we remove the group filter if there is no quant, so user
can create a new quant directly in the editable list.

Task #2056651

closes odoo/odoo#36221

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>


Co-authored-by: jip-odoo <jip@odoo.com>
2019-08-30 08:12:12 +00:00
William Henrotin 3b0cc4861a [FIX] sale_stock: uses line route or category route
Commit 2408bef fixed the way a sale order line is considered as mto or
not but did not took the line route or product category route into account.

closes odoo/odoo#36064

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-29 08:02:48 +00:00
Meghna Jaswani 4670991d5b [FIX] account: Changed zip_from and zip_to fields into type char as 0 was passed by default
closes odoo/odoo#35957

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-08-22 09:30:38 +00:00
wan 5aeec0c3dc [IMP] account: Hierarchy in account type selection field
Task 2041865

We want to show a hierarchy to ease the account type selection (hack in the select widget)
BALANCE SHEET
ASSETS
Fixed Assets
Non-current Assets
Current Assets
Prepayments
Receivable
Bank and Cash
LIABILITIES
Equity
Current Year Earnings
Non-current Liabilities
Current Liabilities
Credit Card
Payable
PROFIT & LOSS
Income
Other Income
Expenses
Cost of Revenue
Depreciation
OTHER
Off-Balance Sheet

closes odoo/odoo#36170

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-08-29 15:07:47 +00:00
Julien Castiaux 33354f71e1 [FIX] payment_paypal: external tests
All dates in the backend must be naive (=in utc, without timezone)

closes odoo/odoo#36230

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-08-29 12:21:54 +00:00
Priyanka KakadiyaandMohammed Shekha 135079044c [IMP] web: removed autocomplete filters and groupbys
purpose of this commit is:
- to remove filter and groupby option which are added at the time of fuzzy
search, it was useless as we have separate groupby and filter menu
also it generates the big dropdown menu so it is more confusing.
- align caret icon with the label.

After this commit:
- when user do the fuzzy search then filter and groupby option will not be shown
in the dropdown

task-2036351

closes odoo/odoo#35092

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>


Co-authored-by: Mohammed Shekha <msh@odoo.com>
2019-08-30 05:06:47 +00:00
Xavier Morel ae8770e704 [FIX] core: gevent / longpolling logging
* fix the gevent worker "logging" everything to stderr and ignoring
the logging configuration: passing loggers to WSGIServer means it
uses those loggers instead of writing directly to stderr
* fix the gevent worker logging the wrong client address when behind a
reverse proxy: it would log the client_address, immitate the
behaviour of werkzeug which goes and gets whatever REMOTE_ADDR is
set on the environment, that way it gets whatever update were
performed by ProxyFix (if any)

Fixes #32914

closes odoo/odoo#36233

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-08-29 13:17:02 +00:00
Victor Feyens e00e2805a3 [FIX] sale_coupon: view coupon buttons in draft sent and sale states
closes odoo/odoo#36236

Signed-off-by: vfe <Feyensv@users.noreply.github.com>
2019-08-29 14:38:03 +00:00
Victor Feyens 16cf2ec5a2 [IMP] product_matrix: UI 2019-08-29 11:33:36 +00:00
Pierre Masereel def4acae20 [FIX] point_of_sale: make partner creation work
Since changes made in the ORM, we cannot pass anymore string of integer
to many2One. We are now parsing the fields from the formular to
reprensent the integer as integer.

Since changes made on image fields, the "image" field name was not
correct so we renamed it in imgage_1920.

TASK-ID: 2058650

closes odoo/odoo#36219

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-29 14:15:52 +00:00
Pierre Masereel 82e3bd4326 [FIX] point_of_sale: tip value not a discount
When we are adding a tip, the unit_price of the tip product is changed
on the line, but not the lst_price, that lead to show the difference
between the lst_price and unit_price as a discount on the receipt if the
pricelist is configured to show its price difference as a discount.

So we are now also changing the lst_price.

TASK-ID: 2058650
2019-08-29 11:38:35 +00:00
Pierre Masereel f84973578e [FIX] point_of_sale: total discount computation
When the total discount is computed on a receipt, it is computed based
on the the discount applied on lines, and the difference between the
pricelist price and the unit price. But there is an option on the
pricelist that say if you want to show or not the difference. Which is
not respected in this case because in total we always show all discount.

So we are now respecting the policy of the pricelist.

TASK-ID: 2058650
2019-08-29 09:16:45 +00:00
Pierre Masereel d4bfeec9ea [FIX] point_of_sale: get tip product if needed
When we are setting a tip product and restricted categories, the tip
product is not available in the POS, so we now force to download the tip
product if tips are set on the POS.

TASK-ID: 2058650
2019-08-29 09:16:10 +00:00
qsm-odoo 367813c98c [FIX] web_editor: implement better name attribution for snippets
When a snippet is selected, its options are shown in a section named
after the snippet. The name is guessed from the block classes if it
matches those of a snippet or is simply retrieved from the data-name
attribute. The problem is that that data-name attribute was not written
on the DOM but as jQuery data in some case which make them disappear
under some circonstances (like cloning a whole snippet thanks to the
keyboard, etc).

closes odoo/odoo#36217

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-08-29 12:22:15 +00:00
qsm-odoo d73b9b0cb1 [IMP] web_editor: add better visualization of opened block options
Now, the snippets options of the selected snippet use a blue color to
match the overlay color. When a block does not have any other option
than being removable or resizable, this helps a lot to see which option
is opened.
2019-08-29 12:21:21 +00:00
qsm-odoo ddcc97a481 [FIX] web_editor, *: review editor elements zindex
* website_mass_mailing

The overlay has to go over content dropdowns and modal but below
technical modal and dropdowns.
2019-08-29 12:21:21 +00:00
William Henrotin 238e5ed9ca [IMP] stock: assign quantities to services in batch
Since 2137e45bb5, services have their stock
quantities computed to 0. As it's the same value for all of them, we can
do it in one batch instead of iterating over products.

closes odoo/odoo#36214

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-08-29 08:05:37 +00:00
ryv-odoo 695c65131b [FIX] elearning: fix invisible kanban view label
In the the kanban view of slide.channel, text belong numbers
was invisible (white on white) on the community version.
We change the class to be visible for each version.

TASK-ID : 2049115

closes odoo/odoo#35858

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-20 13:25:37 +00:00
qsm-odoo 3daed421f4 [FIX] website: restore edit menu dialog
Since saas-12.5, with recent ORM changes, writing on non-existing fields
does not trigger a warning anymore but instead crashes. This revealed
that the 12.0 "Edit Menu" dialog was doing some of that. Indeed,
depending on what was edited, we ended up writing on the 'is_homepage'
field, the 'text' field, the 'isNewWindow' field, ... which do not
exist.

This commit takes advantage of the fix to also lint the dialog code and
convert some of it to ES6.

Discovered while working on task-1925319

closes odoo/odoo#36204

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-08-29 07:24:16 +00:00
Victor Feyens 4e9416b4d5 [FIX] account: product view
Minor revert of https://github.com/odoo/odoo/pull/35381

closes odoo/odoo#36203

Signed-off-by: vfe <Feyensv@users.noreply.github.com>
2019-08-28 15:50:22 +00:00
Odoo's Mergebot 4953b79484 [MERGE] website_slides: add UI and frontend tests
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Introducing eLearning test tours

* a tour in website_slides that tests a tour taken by a member notably
using the fullscreen player;
* a tour in website_slidesthat tests a course creationg by a publisher;
* a certification tour in a new test_website_slides_full module that tests
a payment-based certification tour;

In this merge we also

* improve and adapt demo data, notably to have a tour testing various
use cases;
* provide fixes due to bugs spotted when developing those tours;

See sub commits for more details.

Thanks @awa-odoo and @lul-odoo for their input.

LINKS

Task ID 1937768

closes odoo/odoo#36059

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-28 18:18:58 +02:00
jbm-odoo 58cf9b6754 [FIX] base: Open One2many with not yet updated values
When we have an onchange that modify items in One2many's lines (for
example the quantity of each line based on general quantity) and
we click on a record immediately after changing the field that
trigger the onchange, we have the the old value in the dialog box.
Indeed the dialog opens before the onchange has return the new
values, so the old one are used. This case appears only if the
One2many's line was never saved.

With this fix, we wait that the model is free of mutex, and so the
onchange is terminated before displaying it.

closes odoo/odoo#35306

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-28 13:51:40 +00:00
jbm-odoo cf7c9bd9b7 [FIX] mrp: Avoid creating new line when changing qty to produce
When we change quantity to produce in mrp, all component lines are
removed and new line with the updated amount to product are created.
The problem appears when we change the quantity to produce and directly
click on a component line, because we open the line that will be
deleted. So if we change the quantity for this component manually,
this suppressed line will be added with the new value. And the computed
line will be also be added. So the line for one component will be
present twice (one with computed value and one with manual entry value).

To avoid this problem, when we change the quantity to produce, we update
information of each line (instead of deleting and creating new one).
So if we click on a component line just after changing the quantity,
we open the updated line (and not de deleted one).
2019-08-28 13:51:40 +00:00
RomainLibert d6c65aa4d4 [FIX] base: allow users to read themselves in multicompany
You should always be able to read your own user whatever the company you
are logged into

closes odoo/odoo#36190

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-28 13:47:39 +00:00
Thibault Delavallée fe0f5a8b04 [FIX] website_sale_slides: fix demo data about optional products
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

This commit move commented demo data due to dependency issues (see 9920f20e4c).
Optional products are now installed with the "full elearning setup" module
introduced recently.

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Aurélien Warnon 4bd598e0c1 [ADD] test_website_slides_full: add a full certification testing flow
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

This commit adds a new module whose purpose is mainly to add tours on a
full eLearning configuration. It depends on

  * website_sale_slides: eCommerce integration with checkout process and
    on-payment channels support;
  * website_slides_forum: forum integration in eLearning;
  * website_slides_survey: certifications support in eLearning;

This module adds a first test tour that tests the certification course.
It is composed of a single certification lesson customers have to buy.
Failing and being removed as well as succeeding and gaining completion are
tested.

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Aurélien Warnon e7c4761464 [ADD] payment_test: add a payment acquirer to be used for testing only
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

This new module implements a simple test payment acquirer in order to allow
testing successful payments behaviors, notably on eCommerce. Its usage is
prevented in other state then test to avoid any potential misuse.

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Thibault Delavallée ff768a0642 [IMP] website_slides: add a publisher tour
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

This commit adds a course tour that test a flow for course publishers. Main
steps of this tour are :

  * a user (website publisher) creates a course;
  * he updates it;
  * he creates some lessons in it;
  * he publishes it;

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Aurélien Warnon 215af4e1de [IMP] website_slides: add a member course tour
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

This commit adds a course tour that test a flow for course members. Main
steps of this tour are :

  * an user (either employee, website publisher or portal) joins a public
    course;
  * he has access to the full course content when he's a member of the
    course;
  * he uses fullscreen player to complete the course;
  * he rates the course;

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Thibault Delavallée e9a5dcff74 [IMP] website_slides{_*}: improve demo data
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Add some demo data to allow demonstrating various flows: training, lessons,
public, private, quizzes, ...

Also prepare future test tours by improving courses that will be used for
tours, notably the public one.

LINKS

Task ID 1937768
2019-08-28 13:27:59 +00:00
Aurélien Warnon 5862f1d91f [IMP] tests: allow auto play in chrome headless
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Purpose: allow video auto play without any required user action. It allows to
have test tours using youtube autoplay feature like future website slides
tours (spoil, spoil).

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Thibault Delavallée 5252f9e8cd [FIX] website_rating: correctly trigger click on stars
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Current implementation of rating using stars is a bit strange and may miss
some clicks, notably in testing tour. Let us fall back on a classic simple
implementation based on clicking on a star.

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Lucas Lefèvre a9462adfcb [FIX] website_slides: allow portal users to rate
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Portal users cannot post reviews as they have no write right on channels.
When trying to post a review on a channel this leads to a 403.

In this commit we correctly propagate channel access token to the composer
in order to allow rating.

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Thibault Delavallée 608ea7f85d [FIX] website_slides: lessen concurrent update by waiting slide completion
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

When switching through slides using the fullscreen player it is quite
common to have concurrent updates on slide.slide.partner model as it is
used to store the viewed and completed. By correctly waiting for the
completion to be done we lessen potential concurrent errors.

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Thibault Delavallée 9b12a8b9d7 [FIX] website_sale: fix access right issue when paying
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Commit fe518f1fea introduced a search on sale order model in checkout
process. However this may fail as access rights are not always granted

  * portal users can see orders linked to their company;
  * salesman and a lot of specific groups (accounting, ...) can see their own
    orders, all orders, or depending on some condition;
  * BUT standard users (employee only for example) cannot see any sale order.

Indeed they do not even have right to read, meaning a search fail. Let us
sudo the search as this is contained in a sub method used to fetch some
data.

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Thibault Delavallée f93064606f [FIX] website_slides{_*}: fix completion computation, notably with certifications
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Since 9920f20e4c course completion when finishing a certification survey
is broken. Indeed channel completion is not correctly recomputed. A
certification course can therefore never be completed and awarded. This
commit fixes that and correctly update channel completion based on survey.

In this commit we also rename some methods

  * _compute_completion: renamed to _recompute_completion to avoid naming issue
    with computed field convention;
  * _post_completion_hook is not unnecessary as code in hr_skill can be done
    after calling super of _recompute_completion;
  * _completed_callback is renamed to _set_completed_callback to be coherent
    with slides naming;

LINKS

Task ID 1937768
2019-08-28 13:27:58 +00:00
Jeremy Kersten c712e49b74 [FIX] website_blog: remove ranking computed field
No more used

closes odoo/odoo#36188

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-08-28 12:56:25 +00:00
Yenthe666 89a59558aa [FIX] hr: fix typo in OdooBot notification
closes odoo/odoo#35971

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-28 13:06:07 +00:00
Martin Trigaux 8430da8f3f [I18N] base: export saas-12.5 source terms
closes odoo/odoo#36145

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-28 10:19:31 +00:00
Martin Trigaux f49e8879b5 [IMP] *: unify module manifests
The description should be an action for the user (i.e. "with this
module, you can ...")

Correct English errors
2019-08-28 09:55:34 +00:00
Martin Trigaux 95620bb03c [IMP] base: rephrase sentence
Was not clear groupby is the attribute
2019-08-28 09:55:34 +00:00
Martin Trigaux b4faa5d70c [FIX] base,web_editor: fix typo
Remove redundant _description
2019-08-28 09:55:34 +00:00
Martin Trigaux e212099d39 [FIX] mass_mailing: use better wording 2019-08-28 09:55:34 +00:00
RomainLibert 6aaef4a3d9 [FIX] website: fix ctx argument
In the call to Chart.js we pass a ctx which should be a DOM element,
however we pass `null` as the ctx.

It seems that what happens is that we look for the DOM element inside
the `document` (via getElementById) but this element is not yet inserted
into the document, hence this returns `null`.

Since we already have a reference to the canvas element which should be
used as ctx, we can probably just reuse this reference

closes odoo/odoo#36072

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-08-28 11:13:18 +00:00
Jinal Patel 85b5c9bbb4 [ADD] mrp: add BOM Type field on BOM tree view
task-1949618

closes odoo/odoo#32785

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-28 12:17:39 +00:00
Jinal Patel 59463c6a35 [IMP] mrp: 'Quality' option always visible in settings
task-1949618
2019-08-28 12:17:39 +00:00
Jinal Patel 3b520ed4f1 [IMP] mrp: rename filters
-'Waiting for Material' > 'Waiting for Component'
-'Material Available' > 'Component Available'

task-1949618
2019-08-28 12:17:39 +00:00