The purpose of this commit is, remove "our order reference" because it is already in the title, replace purchase order confirmation by purchase order and add the purchase representative.
Task Id #1902886closesodoo/odoo#31099
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
The next test was identical to the removed one, with the exception that
it inserts a character at the end, which really is the behavior we want
to test. The removed test was broken because it expected the range on
the parent, which is anyway equivalent in this case. This is confirmed
by the fact that inserting a character at either ranges indeed inserts
the character where it is expected to do so.
Deleting all the contents of a block node replaced it with a blank
paragraph node. To restore v12 behavior, it should only do that when
pressing backspace in an already empty block, which is now what it does.
In the user preference, change the timezone of the user to blank (False value)
Save
Before this commit, a cryptic error was raised because the field tz in
resource.resource is required
Note that when writing on res.user, we write some fields (including tz)
on hr.employee, which is a resource.mixin, and therefore uses resource.resource
After this commit, we make the field required in the view
OPW 1934462
closesodoo/odoo#31312
When in the media modal, if one selected no media but clicked the "ADD"
button it resulted in an error and a failed RPC instead of simply
closing the modal without doing anything. v12 behavior is now restored.
closesodoo/odoo#31308
Purpose of this merge is to provide several fixes related to new elearning
application. Those are mainly fixes for front-end templates and first
design improvements / fixes.
See sub commits for more details.
Merge linked to task ID 1941250 and PR #31279.
closesodoo/odoo#31306
- slidesChannelDropdownSort : dropdown items back to visible (was white on white)
- Featured lesson : change icon to bullhorn instead of + icon
- Pass certification fullscreen button : btn primary
- set max height to fullscreen content to 100% minus header
- Fix 'infographic' slide type image view
- change image for 'Furniture Technical Specifications' course
- fix fullscreen presentation mode: The condition to add the iframe that
contains the presentation of the document was wrong and, so, never met.
Those conditions are evaluated in javascript and not in python as it's part
of t-name template linked to a javascript widget.
Commit linked to task ID 1941250 and PR #31279.
The main condition to be able to see a profile is that the user we want to
see the profile is website_published.
But if a new user sign up and wants to access his own profile, he must
get access to his own profile, even if he is (not yet) website_published.
Commit linked to task ID 1941250 and PR #31279.
* remove useless slide management buttons. This commit removes the frontend
edit/publish/unlink buttons on slide cards (for the 'document' channel view)
as they were not handled on the backend side.
* hide slide type filter for documentation channels. The slide type filter
(including statistics) on the left side of the channel frontend view
was only handled for channels of type 'documentation'. This commit hides
the slide type stats/filters if the channel is not of type documentation.
* display add content/section buttons based on user rights. Fixes two channel
frontend issues with user rights management:
* Users that have the right to upload (can_upload field) should have the
"Add content" button available.
* The "Add section" button should only be available to website_publisher
accordingly to ACLs
Commit linked to task ID 1941250 and PR #31279.
Force white background + add the default bootstrap shadow. Do not use <h4>
tags to keep the right font-size on mobile. Simplify layout, add a second
navabar to handle content supposed to be moved to the right.
Commit linked to task ID 1941250 and PR #31279.
Various fixes linked to homepage of courses
* move channel navigation in its right container, clean its display and
related templating;
* display a Completed badge for completed courses;
* display a cropped image for channel image card in order to avoid blank lines
around image not having the right aspect ratio;
* use standard qweb widgets, notably float_time;
* make header and footer of /slides and /slides/all editable and improve
their styling;
* remove old and unused css linked to previous versions of homepage;
* various small code cleaning;
Commit linked to task ID 1941250 and PR #31279.
Co-Authored-By: Thibault Delavallée <tde@odoo.com>
Co-Authored-By: Stefano Rigano <sri@odoo.com>
This commit puts the certification slide from the demo data into a category
so that it's correctly displayed on the channel frontend view.
Commit linked to task ID 1941250 and PR #31279.
- Go to Accounting > Reports > Invoices
- Go to the pivot view
- Enable 'Total' and 'Untaxed Total' in the measures
The Total is wrong.
`amount_total` is retrieved on the invoice, unlike the subtotal which is
retreved on the invoice line. We apply the same logic than
`residual_company_signed`.
opw-1950663
closesodoo/odoo#31991
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
When used with a mutable default value, `dict.fromkeys()` builds a dict
where each key references the same value:
>>> r = {}.fromkeys(['foo', 'bar'], {})
>>> r
{'foo': {}, 'bar': {}}
>>> r['foo']['val'] = 1
>>> r
{'foo': {'val': 1}, 'bar': {'val': 1}}
Updating one key's value will change the value for all keys.
closesodoo/odoo#31659
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
Import a list of partners with their addresses.
The state_id field is usually filled with the state codes.
E.g. 'CA' is used for California, but also for Cádiz (Spain), etc.
The import function (db_id_for) uses a name_search on the res.country.state,
and takes the first matching result.
It follows that the state does not necessarily match the country.
Therefore we add a _check_import_consistency in the create.
Here we check that the country matches the state's country,
try to find a correct match, and if we can't we put the state to False.
Note that if the country is not set both fields will end up set to False:
this is because only a state would mean using a code could give an abitrary
country.
opw 1943904
closesodoo/odoo#31599
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
make sidebar filter generic
Adding `res_model` and `res_fields` attributes on a field of
a calendar view adds a filter in the sidebar.
It saves the result as the defined model and should save it
in the defined field.
However `partner_id` has been hardcoded in the rpc call that creates
the record. This breaks genericity, it cannot be used with another
field than `partner_id`.
This commit makes this generic by correctly setting the field name
in the rpc call.
closesodoo/odoo#31858
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Co-authored-by: Ildar Nasyrov <iledarn@gmail.com>
In a report a lot could be opened with an action that was a number
instead of expected string or falsy value.
In web and web_studio, we sometime expect the action name to be a string
or falsy (calls to `bc.title.trim()` in breadcrumbs code).
opw-1951174
closes#31816
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
When creating a new PO from a purchase requisition, the order date of
the PO is the last date of the contract. There is no reason for this,
and althoguh the date can be manually changed, it is error-prone.
opw-1937141
closesodoo/odoo#31969
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
A recent fix c41d1d2 was made to select the related pricelist
to show the correct price of an event product.
This fix creates another bug in case of Ecommerce app
not installed, because the method get_current_pricelist
is defined in website_sale module.
We need to move the fix from website_event to website_event_sale module.
closesodoo/odoo#31953
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Install accounting in a multi company environment.
Configure email server.
Configure an alias for the vendor bill journal per company.
Before this commit, all the invoices were created in the same company,
regardless of the alias used.
Now, the invoice is created in the company of the used alias.
opw-1939909
closesodoo/odoo#31948
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
- Create a SO with a dropship product, set a qty of 1.0
- Validate the SO
- Validate the corresponding PO
- Change the qty to the SO to 2.0
2 PO are created: the first one with a qty of 1.0, another with a qty of
3.0.
There is an overlap of functionality between:
- `_purchase_increase_ordered_qty` from `sale_purchase` (first PO)
- `_action_launch_stock_rule` from `sale_stock` (second PO)
The quantity is incorrectly computed since the quantity on the PO is
taken into account only if the no stock move exist.
We remove the latter condition, so the procurement quantity is computed
correctly.
opw-1950076
closesodoo/odoo#31963
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Step to reproduce:
- Install sale (sale_management) and studio (web_studio)
- Change the document template (settings > configuration > general
settings) to select the second one
- Go to an order form
- Enable studio, select "Reports" in the right tab
- Edit the "Quotation/Order" report, add a new colomn
- Back to the order form, enable dev mode and add a section to the order
lines.
- Print the report => the section is not using all the available place.
The section/subtotal are using a colspan to use all the place in the
table, this colspan is hardcoded to 5, the number of columns without
customization. Adding a new column doesn't change that value.
The fix has been to force the colspan at 99, the maximum value for
colspans. Using that value will always render the row to fill the table.
opw-1936088
closesodoo/odoo#31951
Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>
The activities "Document Name" (res_name) are computed and stored by
getting them on original document, so if we change name of original
model => the activity names are not updated.
Thus the document name we see we showing the "Activity" view is the one
that was used when activities were created with an odd heuristic (by
inverse order of activity type and max alphabetical value) and not
translated.
With this changeset we ignore "Document Name" and directly get names of
records when display "Activity" view.
note: the changeset also filter out activities on document we can reads:
this was done when a domain was set but not otherwise so access error
could be easily gotten.
opw-1949437
closes#31850
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
The name_search of account.analytic.account do not find records that
have no partner set.
This is because some ORM search may breaks when it contains a
auto_join relational field. We will try to fix this (at least in master
version).
In this changeset, we avoid the issue by combining 2 searches instead.
opw-1941547
opw-1950010
closes#31881
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Currently, when creating `resource.calendar.leaves` for a
`hr.leave` it creates one in the employee's calendar and one
in the contract's calendar if it's different.
But if both calendar are the same, it does not associate
the benefit type to the resource leave.
This commit fixes the issue and add unit tests for this use
case.
closesodoo/odoo#31288
This reverts commit f735951d5c.
Revert payment acquire due to the fact that the encryption scheme
is broken by design and therefore cannot be trusted.
closesodoo/odoo#31281
Part 1: Backend
Changing an option's variant now change the product name and the image
Part 2: Front end
The behavior is the same as in the backend.
For that part though, there is a huge design problem:
the modal dialog has the class .oe_website_sale, so the widget website_sale
reacts to events triggered in the modal.
It is understandable given the history of the module, but a proper refactoring
that will implement inheriting of business behaviors through OdooClass extension/overrides
is necessary in master
OPW 1938217
closesodoo/odoo#31201
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
The holiday_type can be 'employee', 'company', 'department' or 'category'.
However in the onchange of holiday_type, for some reason nothing was done
in the case of the 'company' value.
As a result, the default 'employee' would set the employee_id,
but then changing the type to company would not remove the employee_id.
It follows that the lucky employee would get two allocations instead of one.
opw 1938498
closesodoo/odoo#31656
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
Before this commit, there was a possible race condition in the
`tour_shop_dynamic_variants` tour. Indeed, the `click add to cart` would be
triggered before the `click on the second variant` RPCs are done.
Trigger on `.oe_price .oe_currency_value:contains("0.00")` was supposed to
check that condition but it was not strong enough.
Then, clicking on add to cart would not call `create_product_variant` as it
would still have the first variant id in the hidden input instead of "0".
closesodoo/odoo#31670
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Searching on website is enough. Plus, it will avoid bugs if admin
change sale team of the order or the sale team type.
closesodoo/odoo#31669
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Before this commit, when doing `<t t-raw="0"/>` to print the t-called
content, it was printing "[]" if the content was left empty.
closesodoo/odoo#31668
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
State from the template was 'CA' for California - not recognized on import
Changed it to 'California' to match with the db data
opw 1943904
closesodoo/odoo#31556
Signed-off-by: Richard Mathot (rim) <rim@openerp.com>
Commit 5a81d8883 fixed the COW view deletion on module update but introduced an
error when installing a theme.
Indeed, when installing a theme, the first step is to remove the currently
installed theme from the website (by unlinking its ir.ui.view).
Commit 5a81d8883 introduced the fact that deleting an ir.ui.view during a
module uninstall also search and delete the COW views, calling
`_get_specific_views` (that expects a singleton).
When installing a theme, it calls `_theme_cleanup` which search COW views and
unlink them. If not cow view, unlink is called with an empty record set raising
the singleton error.
closesodoo/odoo#31662
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Commit d139e92c62 set the force_send to True
unless there is an explicit mail_notify_force_send set to False in the context.
The _get_eval_context puts mail_notify_force_send to False in the context,
but it might be lost before reaching that method call.
Launch a cron that starts a transaction, see if it goes through,
and rollback if it didn't,
then the mails send inbetween will be sent every time the cron restarts.
E.g. _cron_post_process_after_done.
opw 1921112
opw 1945953
closesodoo/odoo#31605
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
uom_po_id is the 'Purchase Unit of Measure' and is required so should be used
here.
This way, the onchange matches the behaviour of purchase module or the reset of
the purchase_requisition code
closesodoo/odoo#29717
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
The widget has been moved in rev. odoo/odoo@15f3bbe but was not very generic.
In particular, there was a traceback when clicking on the button if the field
had no value (the button was displayed for readonly fields in create mode).
The button is now only appended in readonly mode (a `button` inside an `input`
or a `textarea` is not very DOM friendly) if the field has a value.
Task 1941996
closesodoo/odoo#31635
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
The style of a link (color) of a many2one is only applied over the
first line (probably for eg. the partner on an invoice that has the
partner name and on following lines the address).
In some instance this make some sense, but on other (the name of a
product is too long from where it is) it makes no sense and seems buggy.
With this change, we have the link style over the whole link which seems
good enough.
opw-1947113
closes#31568
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Before this commit, when a view was removed during a module update (eg: the
record was deleted from the file), its COW views would not be deleted.
This could lead to unwanted behaviors including tracebacks(1).
This commit is somehow related/an extension of b5fe23055d that handle COW view
write during module update and 2e32cc5aa3 that remove COW views during module
uninstall.
task-1931683
Note: Some existing tests had to be run post install
(1) A view doing a t-call is COW'd, then that view and its t-called view are
removed. If the cow view is not removed, the t-call will crash (see tests
in this commit for detailed case).
closesodoo/odoo#31295
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Rishabh Jadia