Commit Graph
126133 Commits
Author SHA1 Message Date
Kirti Choudhary 2aa36dd6a2 [IMP] stock: reordering rule hint to run scheduler
Add a warning on the reordering rule to inform the user he may have to run the scheduler manually.

TASK-ID: 1850406
2018-08-24 13:07:06 +02:00
Kirti Choudhary 6f6e262e7f [FIX] sale_order_dates: Adapt error message
The labels of the fields have changed so the error message is not valid anymore.

TASK-ID: 1850406
2018-08-24 13:07:06 +02:00
Cedric SnauwaertandAdrien Dieudonné f7ead5fd50 [FIX] account: reconciliation tour, set the url to use in python
Continuation and ending of 1f848bf.

Before this commit, the bank statement reconciliation still sometimes
crashed.
Each step of the tour waits 10 secs before timeout and in this case,
changing URL may take more time since this commit b0a29c9b because
we added 'debug=assets'. It was probably a mistake.

So, removing this from the URL would probably solve the error but
the second step would always be dependent on the first.
It's why we decided to load the tour with the correct URL defined
in Python.

Co-authored-by: Adrien Dieudonné <adr@odoo.com>
2018-08-24 13:03:30 +02:00
qdp-odoo 206a0eef72 [FIX] account: usability of bank accounts 2018-08-24 12:12:07 +02:00
Yannick Tivisse 89130b51b4 [FIX] base: Set a default email address for admin
Purpose
=======

Currently, as the admin as no email address, it's now impossible to install
the mail module without demo data, because of the following data:

        <record model="mail.message" id="module_install_notification" context="{'mail_notify_noemail': True}">
            <field name="model">mail.channel</field>
            <field name="res_id" ref="mail.channel_all_employees"/>
            <field name="message_type">email</field>
            <field name="subtype_id" ref="mail.mt_comment"/>
            <field name="subject">Welcome to Odoo!</field>
            <field name="body"><![CDATA[<p>Welcome to the #general channel.</p>
            <p>This channel is accessible to all users to <b>easily share company information</b>.</p>]]></field>
        </record>

Because when creating a mail.message a user error is raised if no email address is found.

    @api.model
    def _get_default_from(self):
        if self.env.user.email:
            return formataddr((self.env.user.name, self.env.user.email))
        raise UserError(_("Unable to post message, please configure the sender's email address."))

In a general way, all the users should have an email address.
2018-08-24 11:58:26 +02:00
Christophe Simonis aeb3391a2d [MERGE] forward port branch 10.0 up to b50958c40f 2018-08-24 11:42:33 +02:00
qdp-odoo 21ab939b4c [FIX] account: access rights on account.account.tag
Accountants should be able to edit, create or unlink tagsµ
2018-08-24 11:36:26 +02:00
Toufik Benjaa f12287c356 [FIX] website_crm_partner_assign: display partner ordered by sequence
- Fix for e2310eec60
2018-08-24 11:13:47 +02:00
Cedric SnauwaertandAdrien Dieudonné ee5c316817 [FIX] account: reconciliation tour, set the url to use in python
Continuation and ending of 1f848bf.

Before this commit, the bank statement reconciliation still sometimes
crashed.
Each step of the tour waits 10 secs before timeout and in this case,
changing URL may take more time since this commit b0a29c9b because
we added 'debug=assets'. It was probably a mistake.

So, removing this from the URL would probably solve the error but
the second step would always be dependent on the first.
It's why we decided to load the tour with the correct URL defined
in Python.

Co-authored-by: Adrien Dieudonné <adr@odoo.com>
2018-08-24 11:06:24 +02:00
Yannick Tivisse 265263dbce [FIX] base: Set a default email address for admin
Purpose
=======

Currently, as the admin as no email address, it's now impossible to install
the mail module without demo data, because of the following data:

        <record model="mail.message" id="module_install_notification" context="{'mail_notify_noemail': True}">
            <field name="model">mail.channel</field>
            <field name="res_id" ref="mail.channel_all_employees"/>
            <field name="message_type">email</field>
            <field name="subtype_id" ref="mail.mt_comment"/>
            <field name="subject">Welcome to Odoo!</field>
            <field name="body"><![CDATA[<p>Welcome to the #general channel.</p>
            <p>This channel is accessible to all users to <b>easily share company information</b>.</p>]]></field>
        </record>

Because when creating a mail.message a user error is raised if no email address is found.

    @api.model
    def _get_default_from(self):
        if self.env.user.email:
            return formataddr((self.env.user.name, self.env.user.email))
        raise UserError(_("Unable to post message, please configure the sender's email address."))

In a general way, all the users should have an email address.
2018-08-24 11:05:22 +02:00
Raphael Collet d72ca98593 [FIX] odoo: db manager configures user_admin 2018-08-24 11:03:24 +02:00
Christophe Simonis 3a95d2fdf8 [FIX] base: force comparison between strings
When using another login method than stored password (ldpa,i oauth...),
user's password is NULL in database. Passlib < 1.7 expect the encrypted
password to be a string, leading to an uncaught traceback, forbidding
login.
2018-08-24 10:58:18 +02:00
sed-odoo 4015c84633 [FIX] web: Disable keyboard shortcuts on BlockUI
Related to the bug: 1874270

Purpose
=======

Keyboard shortcuts working on BlockUI and can cause some issues when used.

Specification
=============

It should not work and should not be display while some process is being executed.

- add function to remove the "accesskey" attributes to avoid the use of the
  access keys while the blockUI is enable.

- add function to reset the "accesskey" attributes when the blockUI is disable.

- add condition to avoid the "Alt" key to reattribute access keys.
2018-08-24 10:49:30 +02:00
Sébastien Theys 46846d8176 [FIX] various: replace t-field-options by t-options
The syntax changed but those occurrences were not updated.

Task: none
PR: none
2018-08-24 10:46:37 +02:00
Jeremy Kersten ceef32500d [FIX] website_theme_install: mode field in template.ir.ui.view are optionnal
+ remove duplicated arch
2018-08-24 10:42:37 +02:00
Lucas Perais (lpe) b50958c40f [FIX] account: allow range amount search for reconciliation widget
In the reconciliation widget, search for an amount like 5361.61

Before this commit, if the targetted line that you want to see was represented as 5361.61000001
you did not see it in the results of the search

After this commit, you do!

OPW 1872543
closes #26523
2018-08-24 09:43:51 +02:00
Romain Derie f6e4f3aa0f [FIX] website: don't suffix cloned menu/page with 'Copy'
This behavior is useless in the front end (`clone_page`) as people cloning a
page will leave the page with copy in the page name without even noticing it.

Furthermore, creating or copying a website will bootstrap (clone) some pages,
suffixing all of these page by 'Copy'.
2018-08-24 09:21:46 +02:00
Romain Derie 8c701f2c9b [FIX] website: move main_object_request event in website_root
`main_object_request` was added in the navbar widget.
It would not work with `PageManagement` widget as it is added in the
website_root widget and not the navbar.

Moving it to the website_root will make the event accessible when triggering up
the event.
2018-08-24 09:21:46 +02:00
Jeremy Kersten 0cdfc84be8 [FIX] base: fix authentication, wrong login/password raise an error 500
During rebase of 4f6ec1c, we remove accidently a part of aac21e4.
Side effect is that uid was False but success_login True.

Courtesy of @xmo-odoo for help
2018-08-24 09:21:46 +02:00
Christophe Monniez f00f4f3852 [REL] saas-11.5 2018-08-24 08:10:38 +02:00
Raphael Collet 7efa669b49 [FIX] website_form_editor: tour
Use `search_count` instead of `search_read` to determine the presence of a
mail, because:
 - reading all fields is not useful;
 - reading all fields causes access errors for user `admin`.
2018-08-23 21:39:16 +02:00
Raphael Collet c3e8fe5da1 [FIX] test_mail: count for unread notifications 2018-08-23 21:38:57 +02:00
Raphael Collet f67649a6d1 [FIX] website: side effects in get_current_website() 2018-08-23 21:38:57 +02:00
Xavier Morel 568dd8f4c6 [FIX] product, uom: add access rights to system group 2018-08-23 21:38:57 +02:00
Raphael Collet 2f7c03d9ca [IMP] base: add regular user admin as uid 2
User 1 simply becomes a technical user (inactive, no password).
2018-08-23 21:38:57 +02:00
Raphael Collet 7ba9acea18 [FIX] fields: context on Many2many field 2018-08-23 21:38:57 +02:00
William Henrotin d78b6f5e25 [IMP] mrp: block updating live BoM
When modifying a BoM that is used in a MO not done, raise a blocking
warning to avoid inconsistenties at production.

Proudly pair programmed with pim <pim@odoo.com>.

Some mrp tests has been adapted to not raise the new error. They used
demo data while they should created inside the test.

This commit is related to task id : 1855566
2018-08-23 20:32:27 +02:00
RomainLibert dc91e3cb0e [FIX] sale: use m2o instead of integer
The field order_id is a many2one on sale.order and not an integer
2018-08-23 17:44:13 +02:00
jem-odoo 02645a6005 [IMP] uom: sql constraint is better than python one
Since we got 2 constraints checking the same
thing (one python, one sql), it is better
to remove the python one, which is not
very performance friendly in case of huge
import.
2018-08-23 17:28:07 +02:00
jem-odoo 69a898cf8b [IMP] uom: add constraints to force reference factor
When importing big amount of data, user can import
a list of uom. There is no constraint in Odoo to
force the factor to be equal to 1.0 for the reference
UoM in a category.
Onchange is not enought to ensure that constraint,
so this commit adds one in SQL for data intergrity
and to avoid problem in '_compute_quantity'
method.
2018-08-23 17:20:47 +02:00
jem-odoo aa1b7072f7 [IMP] hr_timesheet: Analytic account implies UoM
Since the employee is not required on a timesheet, and that
the employee implies the uom, and that the UoM is required
for the timesheet unit amount to be included in the delivered
quantity of a SOL, we now deduce the uom from the company of
the AA, and not from the company of the employee anymore.
2018-08-23 17:20:47 +02:00
Raphael Collet 5701d93624 [FIX] *: decorator returns on message_post 2018-08-23 17:01:22 +02:00
qsm-odoo 883da1d4d7 [FIX] hr_attendance: fix mistake in linear-gradient rule 2018-08-23 16:45:40 +02:00
jpr-odoo 966a13d03f [FIX] website_forum_doc: BS4, restore search bar design 2018-08-23 16:45:40 +02:00
qsm-odoo 9fc771dd5d [FIX] web: BS4, restore slider checkboxes
Take advantage of the new BS4 checkbox structure to simplify the
widget too.
2018-08-23 16:45:40 +02:00
Christophe Simonis 6fd68c28cd [FIX] core: use actual chrome/chromium executable on macOs. 2018-08-23 16:37:17 +02:00
Florent de Labarre d5357e4488 [IMP] uom: force factor to be 1 if reference unit
The _onchange_uom_type was already making sure it was the case but this
constraint ensure it is always the case.

Closes #25465
2018-08-23 16:29:21 +02:00
Aaron Bohy f6e5bd13d4 [FIX] web: Kanban QuickCreate: create on 'ENTER'
Rev. 241704536d highlighted a bug in the Kanban RecordQuickCreate
widget, when a form view is used inside the widget.

Let's assume a quick create form view with a char field. The user
fill in this field and press 'ENTER' (without focusing out). The
record is about to be created. But first, we have to ask all fields
to commit their value (through 'commitChanges'), in case they
wouldn't have yet. The char field thus notifies its parents of its
new value at that moment. The form controller handles this request
in its '_applyChanges' function, but this is done in its mutex (to
prevent overlapping onchange RPCs). Unfortunately, this leads to a
deadlock as the quick create form controller already executed the
'commitChanges' request in this mutex.

Actually, there is no need for the quick create form controller to
execute the 'commitChanges' request in the mutex, as it is already
properly mutexified upstream. This rev. thus remove the use of the
mutex at that spot.

Note that before rev. 241704536d, the bug didn't occur because the
'commitChanges' function of InputField didn't return a deferred,
and thus the mutex was unlocked directly.

To be complete, let us mention that there are still some
concurrency issues with the quick create widget (like multiple
records creation on double clicks or double 'ENTER' keypress).
Those issues will be tackled in a future commit.

Task 1878977
2018-08-23 16:18:32 +02:00
RomainLibert 3f2bc7b11f [FIX] various: adapt code to new datetime fields
Some code was still using the date and datetime fields as if they were
strings, but they are now dates and datetimes
2018-08-23 16:03:55 +02:00
Swapnesh Shah 0562fc0ffd [IMP] point_of_sale: add domain on field
Make sure the selected tip product is one available in the point of sale

Closes #25406
2018-08-23 16:00:26 +02:00
Mitali Patel ac41cd8195 [IMP] mrp: Change the condition 'and' to 'or' in product variants having the same attribute value
For example: I want to consume a component A if the product is grey OR yellow.
Currently,the component A will be consumed if the product is grey AND yellow. But this variant never exists as grey and yellow are values for the same attribute. So if the values are for the same attribute, odoo should check for a product that is GREY OR YELLOW (and not GREY AND YELLOW).

TASK-ID: 1865604
2018-08-23 15:54:23 +02:00
Invitu a19d2c98f4 [FIX] point_of_sale: consider timezone in return orders
Similar to 21575407 for returns
payment_date is a date field, make sure the day is the one of the user

Closes #25342
2018-08-23 15:52:55 +02:00
Nicolas Lempereur 01b1830219 [FIX] mail: access token in received cid images
Following 50ab18176 an access token is added in the URL, but there may
not be an existing access token. If so this commit generate one.

opw-1877347
closes #26526
2018-08-23 15:38:34 +02:00
jem-odoo 5e73d121be [IMP] hr_timesheet: use correct view
When coming from project form view, the user can see
the list of timesheet. Before this commit, the employee
does not appears in the columns, which makes the view
less usefull for users.
2018-08-23 15:32:42 +02:00
Hiral Bhavsar c7899279a2 [IMP] account: usability improvements
- "Balance in GL" renamed "Balance in General Ledger" on dashboard
- "Entries to review" button on dashboard adds 'draft' filter by default
- streamline hover effect of 'import statement' option with other bank journal buttons' on dashboard
- better look for l10n_eu_service setting

Was task 46188
Was PR https://github.com/odoo/odoo/pull/22698
2018-08-23 15:28:35 +02:00
Hiral Bhavsar f3b513303c [IMP] l10n_de: rename "Deutschland" to "Germany"
Was task 46188
Was PR https://github.com/odoo/odoo/pull/22698
2018-08-23 15:28:24 +02:00
Raphael Collet 3ea11e6e6f [IMP] server: flag thread as testing when test-file runs 2018-08-23 15:21:06 +02:00
Divyesh Patel 5ecc390a80 [IMP] stock_account: change account move line description
This commit changes the account move line description created
by changing the cost of a product where inventory valuation is
'automated'. The new message contains the user name, the price before
and after.

Task Id: 1860578.
2018-08-23 15:20:32 +02:00
Toufik Benjaa 61d790d6e2 [FIX] base: avoid crash when acessing image without access_token
- When accessing an image from an "ir.attachment" which doesn't have an
  access_token, the code crashes if you provide the argument access_token
  on the URL.

  This is due to a comparison between a boolean and a string using the
  consteq function.
2018-08-23 15:20:24 +02:00
Kirti Choudhary a6557a2306 [IMP] product: easy creation of packaging from product form
The product.template form view lists all product.packagings containing it.
When we create a new packaging from the product. We don't need to specify
and display the product again.

Task ID - 1862041
2018-08-23 15:20:08 +02:00