Commit Graph
122797 Commits
Author SHA1 Message Date
Nicolas Martinelli ebc09694f5 [FIX] project: outdated message
Issues has been removed some time ago.

opw-1920007

closes odoo/odoo#29837
2018-12-31 14:25:00 +00:00
Paulus Pamungkas 6e1ca5bcf2 [IMP] auth_ldap: hide password in interface
Set ldap password as password field

closes odoo/odoo#29662
2018-12-31 12:51:49 +00:00
Paulus Pamungkas a84422f88d [CLA] signature for ppamungkas 2018-12-31 12:51:36 +00:00
Yenthe V.G 201bd9101d [IMP] base: Add sheet of several basic form views
Add <sheet> tag on the form view for the following models:
- res.bank
- res.country
- res.country.group
- res.country.state
- res.partner.title
- res.partner.category
- res.partner.industry

[IMP] base: add sheet to countries form and add group names for clean xpaths

[IMP] base: add sheet to contact tags form

[IMP] base: add sheet to parter title form

[IMP] base: add sheet in sectors of activity form

[IMP] base: add sheet to federal states form

[IMP] base: add sheet to country group form

[IMP] base: add sheet to bank view and add group names for cleaner xpaths

closes odoo/odoo#27324
2018-11-22 10:47:08 +00:00
Yenthe666 78182af799 [IMP] resource: allow easy xpath on forms
closes odoo/odoo#29817
2018-12-31 14:17:34 +00:00
Andrea 59289eda05 [FIX] link_tracker: _sql_constraints not applied
The unicity was not applied

closes odoo/odoo#29793
2018-12-31 09:16:39 +00:00
Yenthe666 7ca17c402f [FIX] website_forum: fix typos in goal definitions
closes odoo/odoo#29819
2018-12-29 19:26:02 +00:00
Yenthe666 1341877ec9 [FIX] account_test: fix typo in report
closes odoo/odoo#29795
2018-12-28 15:05:37 +00:00
David Tran 784d3cbbcf [IMP] point_of_sale: more convenient in refund extending and inheritance
When creating refund order, Odoo copies the original order and put
some default copy data. All these things were put in the same method
which causes problems for extensions.

This commit split the refund method into multiple dedicated methods so
that others can modify/inject more data easily

closes odoo/odoo#29792
2018-12-28 14:47:01 +00:00
Yenthe V.G 123a77c160 [IMP] analytic: add sheet to form view
For a better rendering

closes odoo/odoo#27345
2018-12-28 15:20:58 +00:00
lul-odoo 68ba96760f [IMP] hr_recruitment: Add application history for same applicant
Purpose
=======

HR users wants to know if an applicant applied to multiple jobs
or if he applied in the past.

Specification
=============

Keep an history of applications based on email.
Add a stat button on the applicant form to display
other applications with the same email.

closes odoo/odoo#29613
2018-12-28 13:21:22 +00:00
Yenthe V.G d4e3b57c76 [IMP] mail: add group names for clean xpath expressions
closes odoo/odoo#27342
2018-12-28 13:03:53 +00:00
sed-odoo ea5c10a11c [IMP] base: Add a new 'Approvals' module category
Will be used in a new module in the enterprise repository

closes odoo/odoo#29384
2018-12-28 10:58:50 +00:00
sed-odoo fd1c610839 [IMP] mail: Pass the session uid on activity renderer
Purpose
=======

We could want to retrieve the session user id when rendering the next
activities on the chatter (For example in the new approvals module on the
enterprise repository).

At the same time, we used 'web.session' to retrieve this valued instead
of 'self.getSession().uid' which is deprecated.
2018-12-28 10:58:50 +00:00
sed-odoo df43defe84 [IMP] mail: Modify activity templates to ease inheritance
These templates are supposed to be modified by a new approvals application
in the enterprise repository.
2018-12-28 10:58:50 +00:00
Cas Vissers e502423f2b [FIX] resource: Rename 'Evening' into 'Afternoon' in default attendances
Evening is not the common way to describe the second shift of the day.

Closes #28253

Co-authored-by: Cas Vissers <c.vissers@brahoo.nl>

closes odoo/odoo#28950
2018-12-27 13:21:36 +00:00
qsm-odoo 52ec536cef [REF] *: make stronger bootstrap assets
* portal, theme_bootswatch, web, web_editor, website

With less2sass and bs3tobs4 tasks, the assets structure was reviewed to
handle the specificities of both framework and to prepare for our next
odoo tasks. In particular, the assets_helpers and bootstrap overrides
were basically split into 4 parts: utils, primary variables, secondary
variables and bootstrap variables.
(see https://github.com/odoo/odoo/commit/6e4db7d13a926845bf82f5b035afede42d6d5a89)

Using the !default system for the bootstrap variables parts seems now
a good improvement. This is part of what this commit does: adding the
default flag for all bootstrap variables overrides and inverting the
order of the files in the _assets_backend_helpers and
_assets_frontend_helpers templates. This allows to avoid code like this:

portal:
```
$body-bg: white;
```

website:
```
@​if $var != null {
    $body-bg: $var;
}
```

This code makes the body white with portal or equal to $var with website
if $var has a value. The same behavior in the new file order is achieved
with:

website:
```
$body-bg: $var !default;
```

portal:
```
$body-bg: white !default;
```

This order is now also followed for the _assets_secondary_variables
templates (there are only a few).

This commit also make better assets hierarchy by making website inherit
from portal assets (instead of web) and portal inherit from web_editor
assets (instead of web) (thus relying on strong dependencies instead of
installation order which is not always right for migrated databases).

closes odoo/odoo#29757
2018-12-26 17:25:23 +00:00
Denis Ledoux ec48392e39 [TODO] service/server: note to remove override that will become useless
The method override `_handle_request_noblock`
is there to solve a bug in Python socketserver library
which has been solved in
- Python 3.6: python/cpython@8b1f52b5a9,
- Python 3.7: python/cpython@9080824513,

through PR python/cpython#9952.

These revisions will be included in Python releases 3.6.8 and 3.7.2,
and the override will then become useless.
We therefore can remove the `_handle_request_noblock` override
as soon as the Python 3 releases installed on operating systems
supported by Odoo are above
- 3.6.8 for Python 3.6
- 3.7.2 for Python 3.7

closes odoo/odoo#29706
2018-12-21 11:27:44 +00:00
Florent de Labarre e0d1fd7ec7 [IMP] base: allow to group modules by state
To easily identify the one installed or in error state

closes odoo/odoo#28938
2018-12-20 15:11:10 +00:00
Yannick Tivisse 89b12e9857 [IMP] hr_payroll_account: Remove unused field
This field seems to be never used.

closes odoo/odoo#28737
2018-11-15 15:20:19 +00:00
RomainLibert 1009a0a850 [IMP] fleet: set reminder to 30 days instead of 15
closes odoo/odoo#28643
2018-11-13 10:27:55 +00:00
Arnaud Baes 55d460b5d5 [REF] stock, sale_stock, purchase_stock: stock.uom_propagate config parameter refactor
Avoid duplicate code and instead use a new private function

closes odoo/odoo#29266
2018-12-19 13:57:16 +00:00
Arnaud Baes efb255246b [REF] mrp, purchase_mrp: find bom depending on its type
This commit refactors the method '_bom_find' in order to search bom based on their type.
This allows to handle the cases where a Kit has the route 'Manufacture' set.

TaskID: 1863856
2018-12-19 10:50:29 +00:00
Arnaud Baes 45e53ff7a5 [IMP] mrp, stock: route applied on kit's components
With this commit, the routes of the components of a kit are applied instead of the routes on the kit itself.
To do this, a refactor of '_adjust_procure_method' was made in order to use it on stock.moves

The method '_adjust_procure_method' was moved to the stock module in order to be used in a future task concerning repair orders ( TaskID: 1887961).

TaskID: 1863856
2018-12-19 10:50:29 +00:00
Xavier Morel 52645a7b43 [IMP] calendar: convert mail cron to lastcall feature
Avoids querying and updating an ir.config_parameter which (according to
rco) blows the caches (of all workers) every time it happens, which is
inconvenient.

closes odoo/odoo#29066
2018-12-18 12:07:54 +00:00
Xavier Morel 2c4b9b5c06 [ADD] base: lastcall field to cron, provided to jobs
While many crons will process some sort of queue and can either delete
or mark items as processed, others are more concerned with time ranges
and may not want (or be able to) write on the objects to mark them as
processed. In that case, crons maintaining a processed date range is
useful.

Task 1912648
2018-11-27 12:49:08 +00:00
Haresh Shyara 7997f3b00f [IMP] mrp: replace _get_bom_reference by an xpath
In the BoM structure and cost report the purpose of _get_bom_reference
was to add content with an override in order to display it directly in
the column BoM. It could be improved by using the classic display name
and add a name to column in order to use an xpath in another module.
The function _get_bom and _get_bom_line can also be used in order to
introduce extra content directly in the column added with an xpath.

Task ID : 1875677

closes odoo/odoo#26493
2018-12-11 16:21:05 +00:00
Aurélien Warnon 8b54088cd2 [REF] mass_mailing: clean JS views overrides
Task #1909424

The mass_mailing module used a lot of JS "include" to override
the behavior of the kanban view and the html_frame widget.

This commit cleans the overrides by using proper inheritance with "extend"
instead of "include".

It also slightly changes the current behavior of the mass_mailing kanban view
to disable the drag and drop feature only when the view is grouped by "state" or "email_from".
(Before this commit, the drag and drop feature was disabled for ALL fields).

closes odoo/odoo#29452
2018-12-19 09:10:34 +00:00
Aurélien Warnon e3246845c3 [FIX] web: fix KanbanRenderer state management for date/datetime fields
In the KanbanRenderer, the _setState method extracts the groupBy field name and tries
to get the field information from that string.

When the field is a date/datetime grouped by day/week/month/..., the field name becomes "my_date:month".
This prevents the gathering of state information since those information are stored in a dictionary with a 'my_date' key.

This commit will detect if the field has additional grouping info (:month, :week, ...) and clean the name
with a substring before accessing the state dictionary.
2018-12-19 09:10:34 +00:00
Aurélien Warnon 06c05983e3 [FIX] web: fix KanbanRecord config in KanbanRenderer
The KanbanRecord config was not correctly taken into account when
initializing the columnOptions (for the KanbanColumn).

This completely prevented overriding the KanbanRecord in the kanban view if the KanbanColumn
was used for rendering (= when the view was grouped by a field).
2018-12-12 07:39:40 +00:00
RomainLibert a03faab03f [IMP] event, website_event: Make ics file generation available in event
Ics file generation should be possible even when only event is
installed as it is a basic feature of events.

Moreover we need to be able to generate such files in order to replace
the old outlook api used in the event templates, api which is not
supported anymore.

We decided to use ics files because it is supported by most calendar
schedulers hence working with outlook.

Linked to task #1853063

closes odoo/odoo#28477
2018-12-17 11:46:48 +00:00
jbm-odoo 496920a8f5 [IMP] base: Allow js-class attribute for graph/pivot/calendar views
Add in the RNG file the attribute "js-class" for the calendar, graph and pivot view.

closes odoo/odoo#29609
2018-12-18 16:35:55 +00:00
XavierDo 4682c8a759 [IMP] mail: improve activity done message template
Feedback should be the first part of the message without title
to make it more concise.

If the activity has a note, the note should be displayed
but after the feedback.

We can also remove the field feedback that was not so useful
since it was only written just before unlink. Feedback is now
passed as another parameter to the template.

Task: 1918392

closes odoo/odoo#29605
2018-12-18 15:02:42 +00:00
Yannick Tivisse fd23d93be2 [IMP] hr_payroll_account: Don't erase journal_id if already set
If the journal_id is already set on the payslip and if there are
no journal_id on the contract, don't erase the value on the onchange
method

closes odoo/odoo#29616
2018-12-18 15:04:22 +00:00
RomainLibert 939f8e0534 [IMP] hr_payroll: add legal information to payslip report
This commit adds two fields:
	- compute_date on payslip (set once computed)
	- registration_number on employee (used to identify the
	  employee)

These fields are displayed in the payslip_report
It also adds the worked_days to the same report

These fields are a legal obligation in some countries (like Belgium)
2018-12-18 15:03:27 +00:00
RomainLibert d5fd84b89a [IMP] hr: add onboarding/offboarding activity plannings
Purpose
=======

Give the possibility to elaborate plans through Odoo. For instance, in HR,
you could create an onboarding plan when a employee is created. Someone manages
laptop and other equipment, someone check hr stuff, ... This feature is generic
but in a first time we will apply it only on the hr module.

Ease HR process in a company by creating plans: a plan is an assembly of Next
Activities that will be launched together whenever you need it.

Example of plan for an employee onboarding:

Activity: Prepare materials
Responsible: Alain
Deadline: At the contract signature

Activity: Manage Cars
Responsible: Cécile
Deadline: at the contract signature (both signature)

Activity: Plan Training
Responsible: Caroline
Deadline: After signature

Activity: Training
Responsible: Employee
Deadline: 1 week after the employement date

Specifications
==============

On HR Configuration: Add a menu "Activity Plans"

Activity plan object:
 - Name
 - Model (debug mode) (hr by default)
 - Activity Template o2m
    - Activity Type (only the one related to hr)
    - Deadline (come from Activity Type)
    - Responsible \/
        0  Coach
        0  Manager
        0  Other
        [Responsible_name] \/  (coach, manager or manually set if other)

Add datas, 2 plans:

Onboarding
    - Name: Onboarding
    - Plan lines:
        Activity: Setup IT Materials
        Responsible: [a user] (manager)
        Deadline: At the contract signature

        Activity: Plan Training
        Responsible: [manager]
        Deadline: After signature

        Activity: Training
        Responsible: [Employee]
        Deadline: 1 week after the employement date

Offboarding
    - Name: Onboarding
    - Plan lines:
        Activity: Compute Out Delais
        Responsible: [a user] (manager)
        Deadline: today

        Activity: Take Back HR Materials
        Responsible: [manager]
        Deadline: today

        Activity: Manage Car
        Responsible: [manager]
        Deadline: today

When to trigger it ?

HR specific use case:

1/ On employee, from the employee chatter:
when you create an employee, Odoobot will log a note with the following message:
"Congratulations ! May i recommand you to setup an onboarding plan?", with a link
create a plan from it.

2/ Add a button 'launch plan' to open a wizard to select the plan

3/ When archive an employee
Open a wizard with:
    - Reason (selection)
    - Action plan (m2o not required)

Error if employee not linked to a user.

Task : 1912681

closes odoo/odoo#29151
2018-12-18 11:20:54 +00:00
Olivier Colson e230050562 [IMP] account: remove useless payment term option
'after_invoice_month' and 'day_following_month' options did the same thing.

closes odoo/odoo#29603
2018-12-18 11:06:57 +00:00
jem-odoo c33ac778bd [IMP] project_timesheet_holidays: change test class
We try to define common classes in test with helpers to
set testing data. Here, we had a test extended a class
with test methods, making those tests executed twice:
when hr_timesheet was installed, and on project_timesheet_holidays
installation.
This is not very stable, as some behavior might change when
other are installed.

closes odoo/odoo#29538
2018-12-13 14:46:20 +00:00
Robot Odoo 1cb506c418 [IMP] account: non deductible taxes to inventory
Non deductible taxes (ones without an account set), increase the target
account of the product.

In case of a inventory operation, this means the inventory account.

To reflect this stock valuation wise, we need to calculate this incremented
values and rely on it during the inventory move price calculation.

This commit does exactly that.

**Description of the issue/feature this PR addresses:**
- Inventory value and accounting value diverge on taxes which are summoned upon the target account
- This is due to a inventory valuation based on the subtotal amount
- Meanwhile balance accounts are charged with subtotal + value of taxes without accounts

**Current behavior before PR:**
- Inventory valuation and accounting valuation diverege
- Consecutive accounting moves originated by stock moves do not reflect the accounting value at which the first move was charged (eg. by an invoice).
- There is always an "inexplicable" price difference when working with taxes that don't have an account set (cost increasing taxes)

**Desired behavior after PR is merged:**
- The stock move will take exactly the same valuation as has been accrued on the taxed accounting move.
- Balances do not diverge
- No "mysterious" price differences appear.

**Note:** Please do not close, even if not immediately accepted (`wishlist` tag). This PR is meant to be carried along and actively maintained, until this semantic will be completed this way or another.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@xoe-labs

closes odoo/odoo#26367
2018-12-13 16:50:22 +01:00
Thibault Delavallée e226ca4460 [IMP] test_mail: update counters to current runbots state
Some counters are a bit higher than real counters; test_mail help counters
are not up to date in some cases.

closes odoo/odoo#29518
2018-12-13 13:33:09 +00:00
Robot Odoo ff0c71f373 [MERGE][REF] mail: clean access right check on activities
This merge improves code of access rights checks when creating or updating
activities. Several points triggers this commit

 * we would like to use _filter_access_rules and override it on activities
   model in order to be more standard;
 * we would like to get rid of sudo used in various CRUD overrides as using
   standard ORM method allows to correctly use current user;
 * we would like to get rid of create_user_id field once we can keep the
   current user as create_uid;

Access rights are a bit updated. They are now the following

 * you can create activities for documents like posting messages (using
   _mail_post_access attribute; if not defined, write access on document
   is required);
 * you can read activities for documents you can read;
 * you can write and unlink activities either following the defined access
   rule (created OR assigned), and otherwise like posting messages (
   using _mail_post_access attribute; if not defined, write access on
   document is required);

In this merge we also hide edit / mark as done / cancel buttons for
activities the current user cannot modify.

Finally create_user_id field related to activities is replaced by create_uid
everywhere.

This commit is linked to task ID 1856417.

closes odoo/odoo#27619
2018-12-12 18:35:02 +01:00
Thibault Delavallée abc212f59a [REF] mail: remove create_user_id field on activity
As activities are created using the current user there is no need anymore to
have another field to store the activity creator. We can therefore remove
create_user_id and replace its use by the magic create_uid field.

This commit is linked to task ID 1856417 and PR #27619.
2018-12-12 12:45:24 +00:00
Sébastien TheysandThibault Delavallée b9c8ba83e6 [IMP] mail: clean activities access rights
This commit improves code of access rights checks when creating or updating
activities. Several points triggers this commit

 * we would like to use _filter_access_rules and override it on activities
   model in order to be more standard;
 * we would like to get rid of sudo used in various CRUD overrides as using
   standard ORM method allows to correctly use current user;
 * we would like to get rid of create_user_id field once we can keep the
   current user as create_uid;

Access rights are a bit updated. They are now the following

 * you can create activities for documents like posting messages (using
   _mail_post_access attribute; if not defined, write access on document
   is required);
 * you can read activities for documents you can read;
 * you can write and unlink activities either following the defined access
   rule (created OR assigned), and otherwise like posting messages (
   using _mail_post_access attribute; if not defined, write access on
   document is required);

In this commit we also hide edit / mark as done / cancel buttons for
activities the current user cannot modify.

This commit is linked to task ID 1856417 and PR #27619.

Co-Authored-By: Sébastien Theys <seb@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>
2018-12-12 12:44:03 +00:00
jem-odoo 13eb9b9c5b [IMP] crm: filters for activity reporting
This commit improves the CRM reporting by:
- adding new field on the report model
- providing new predefined filters for users
- renaming labels to be more precise
- reorganizing filter and group by
- remove wrong measure in report (probability and days
to close), as they were not correct when multiple
activity on a lead.

Main purpose is to ease finding usefull KPI for the
user, and make the activity reporting a bit less
confusing and limited.
It also now include all user messages (discussion
subtype) and note from activity (when marking activity
as done) in the reporting, so we can have a complete
analysis of action taken on the leads.

Task-1862209

closes odoo/odoo#27767
2018-12-12 11:01:51 +00:00
Xavier Morel 43e062fabf [FIX] *: JS doc/docstring errors & warnings
closes odoo/odoo#29439
2018-12-11 15:24:09 +00:00
Tejas Shahu 448ba01ae9 [IMP] stock, sale_stock: label & tooltip clarification
Rename shipping policy in the UI. Also adapt the stock picking
state's tooltip in order to explain the reservation process
according to shipping policy

closes odoo/odoo#24039
2018-12-11 16:09:55 +00:00
Tejas Shahu c1a5221ba2 [IMP] product: Dyanamic d.p. on Volume field
Decimal precision for volume on products is always set to 2.
Some users that work on more precise volume would like to increase it.
In order to do it without customisation we add another system parameter
for Volume.
2018-12-11 16:09:55 +00:00
Tejas Shahu 2590cf2e6d [IMP] mrp: Produce wizard save and produce another
When a user produces multiple finished products with SN/lots, he has to
save the wizard go back to the production order and click again on produce
button for the second SN/lot. It could be annoying with a huge number of
SN/lots to encode.

This commit adds a 'Continue' button that saves the wizard and directly
opens a new with the new lot/SN.
2018-12-11 16:09:55 +00:00
Tejas Shahu 38b1debece [IMP] maintenance: Duration tooltip improvement
The view on maintenance show the duration with the hours as
UoM. However the tooltip explains that the duration is set
as minutes and second. This commit modify the tooltip in
order to be coherent with the view.
2018-12-11 16:04:35 +00:00
Robot Odoo b57f4411b8 [MERGE] mass_mailing: improve click / link demo data
Purpose of this merge is to ease first steps with mass mailing application by
improving demo data about links and clicks. Demo data now call convert links
and add click in order to generate statistics.

Small improvements are also done on mass mailing views, adding responsible
field and grouping by default in kanban.

This merge is linked to task ID 1907994 and closes PR #28533.
2018-12-11 14:44:49 +01:00