Commit Graph
106440 Commits
Author SHA1 Message Date
Martin Trigaux 245e38d242 [FIX] doc: remove statusbar_color reference
This attribute has been removed from the web framework since b4c28050
and should not keep example of code with it.
Related to #5987
2016-07-26 14:54:25 +02:00
Nicolas Martinelli 4326d864d8 [FIX] purchase: do not reset expected date
A misleading behavior occurs with the recomputation of scheduled date.
Here is the use case:
- Create a PO with 2 products
- For the product 1, set the scheduled date to today + 7 days
- For the product 2, set the scheduled date to today + 14 days

When saving, the scheduled date of product 2 is reset to today + 7 days.

This is of course unexpected, but moreover, a different behavior can
happen depending on how the scheduled dates are modified. In the
previous case (both products have now the same scheduled date), one can
observe 2 situations.

Case 1.
For the product 2, set the scheduled date to today + 14 days and save.
In this case, the scheduled date of product 2 is not reset.

Case 2.
- For the product 1, set the scheduled date to today + 8 days
- For the product 2, set the scheduled date to today + 14 days

In this case, the scheduled date of product 2 is reset to today + 8 days
when saving

The reason of a different behavior in the 2 situations is that the
scheduled date of the PO is changed in case 2 and not in case 1. Since
the scheduled date of the PO is changed, it triggers the inverse
function `_inverse_date_planned`.

When saving, it is not possible to know whether the scheduled date of
the PO was changed on purpose by the user or recomputed. There are 2
solutions to get a consistent behavior:

- Force the scheduled date of each line to be the same than the
  scheduled date of the PO. However, this makes the scheduled date of
  the line useless.
- Do not change the scheduled date of the lines when the schedued date
  of the PO is changed. However, this removes the ability to reset
  automatically the scheduled date of the all lines at once.

This is the second solution which is chosen with this commit.

opw-682934
opw-684063

Closes #12904
2016-07-26 14:14:24 +02:00
Jeremy Kersten 077dde3a69 [FIX] calendar: don't duplicate all the calendar_contact
Before this patch, add_filter was called 2 times.
Once when we select a partner in the drop down, we trigger a onchange value
to change from false to the partner id.
Once to reset to false the value after the first add_filter()

This commit closes #9758
2016-07-26 13:35:11 +02:00
Goffin Simon 7e1b0792da [FIX] portal: creating a user portal for a partner
Steps to reproduce the bug:

-Create two companies A and B where A is the parent of B
-Admin is in A
-Demo is in B
-Create a partner P with Demo
-Create a user portal for P with Demo

Bug: Access error due to the fact that the user portal created for
P was created in SUPER_USER with company_ids and company_id set with
the same inforamtions as with Admin.

Fix: company_ids and company_id must be set with the company of Partner P

opw:682930
2016-07-26 13:26:59 +02:00
Jeremy Kersten e1c55b2d2d [FIX] calendar: avoid local variable referenced before assignment
When the get_one_event_synchro crash, the status variable is not initialize.
So the return status, content, ...  raise an error:
    "local variable 'status' referenced before assignment"

This commit closes the issue #11513
2016-07-26 11:00:51 +02:00
Jeremy Kersten 78f00700e3 [FIX] product: keep precision in historized cost field.
Now we use the same decimal precision for cost in table 'Historization cost'
and 'product'.

It is one fix, but that will not fix the case where decimal precision has been
updated between 2 historizations.

This commit closes #12861
2016-07-26 10:07:20 +02:00
Christophe Simonis cfb0c0dead [MERGE] forward port branch saas-11 up to 7ae5121 2016-07-25 17:17:15 +02:00
Martin Trigaux 64c80ddb4a [FIX] product: add missing argument in read
The list of fields was not present, making the call to fail.

Closes #11716
2016-07-25 17:01:03 +02:00
qsm-odoo 28ac3a369f [FIX] web_editor: secure the paddings of btn in the editor
Prevent the padding of editor .btn's to change when a theme modifies
them (by mistake or not).

Once again, this is a problem of css isolation between the editor and
the website customization. A theme cannot safely, at this time, do
"#wrapwrap .btn" to isolate its rules because it may override some
bootstrap rules like ".btn-group .btn" which would became less
important. It cannot changes the bootstrap variables either as it is
still used by the odoo ui in some places.
There is no safe good solution to "share" bootstrap theming between
odoo ui and website ui. The safest solution is to force the design
of odoo ui elements that may be overridden by themes (in the end,
it's the same as progressively removing bootstrap from odoo ui).
2016-07-25 17:00:24 +02:00
qsm-odoo 3fe3f55cf5 [FIX] web_editor: allow adding options on predefined bg classes
The editor allows using background image options on snippets which
use a background-image. For this to work, the oe_img_bg css class
has to be on this snippet. The problem is that the class is absent
when using some themes as the select_class method removes it to place
its own value.

Now, the oe_img_bg class is (re)added when a select_class method is
used within the background image option.
2016-07-25 17:00:24 +02:00
Christophe Simonis 7ae5121877 [MERGE] forward port branch saas-10 up to fc0f023 2016-07-25 16:06:15 +02:00
Damien Bouvy 8d4b97ef3c [FIX] website_portal: fix typo
No crash, but better to take the value after whitelisting for code
consistency.
2016-07-25 15:59:13 +02:00
Goffin Simon 19e3757ffb [FIX] product_visible_discount, sale: compute the right unit price
When the module product_visible_discount is installed, the field
'discount_policy' allows to display the discount in the sale order or
allows to consider the discount as include in the price_unit.

The field price on product.product always compute the price according to
the pricelist then it always includes the discount in the price.

The field lst_price on product.product never compute the price according to
the pricelist then it always gives the sale price.

According to the discount_policy, the price or the lst_price must be taken.

opw:683771
2016-07-25 15:57:34 +02:00
Stefan Rijnhart 4712fddd88 [FIX] account: never allow modification of posted entries
Posted moves are not protected from modification if the journal is set
to 'autopost'.

If an account move is posted in a journal with 'Autopost' set, it is
possible to modify the associated move lines without any restriction.
This can for example lead to the creation of unbalanced moves.

The original issue fixed by this extra condition
(https://bugs.launchpad.net/openobject-addons/+bug/615268) does not
occur if the commit is reverted.

This reverts 4e95e4223

Closes #12014
opw-683165
2016-07-25 15:50:47 +02:00
Ben17000 d94183ff97 [FIX] delivery: assign the result correctly
as inside a for loop
Closes #12503
2016-07-25 15:50:43 +02:00
Jeremy Kersten 3418b9f8aa [FIX] calendar: avoid infinite recurrent event
Old check was always ignored since 0 is False.

This commit closes #12715

Other fix; when we detach an event, we reset the rrule_type to avoid to have a
warning popup (about empty final_date) if the old one value was end_date.
2016-07-25 15:48:25 +02:00
Christophe Simonis fc0f023053 [MERGE] forward port branch 9.0 up to 1089dcf 2016-07-25 15:07:47 +02:00
Nicolas Lempereur 41ba673524 [FIX] account: popover payment information unclickable
In the account invoice the payments are shown and a popover with more
information is displayed when clicking on an (i) icon.

In this popover two buttons are available, but the used type of popover
disappear immediately when clicking on them, thus the buttons were
directly removed and would not work.

This commit add a delay when hiding the popover so the buttons
functionnality is not lost.

opw-680095
2016-07-25 15:00:27 +02:00
qsm-odoo 77d231546d [FIX] website: correct design of welcome message
The welcome message was using the mt/mb classes to add some space on
top and bottom of it. This is fine when the background-color of the
website is white, but this is not the case with every theme.

To fix the problem, add padding in LESS instead. Also move the inline
style in LESS to prevent theme extension problems.
2016-07-25 14:43:53 +02:00
Christophe Simonis 1089dcf15c [MERGE] forward port branch saas-6 up to 7df4ea5 2016-07-25 14:33:15 +02:00
Martin Trigaux 880df4e8b6 [IMP] doc: clarify web client terminology
To avoid confusion such as in #12884
2016-07-25 14:30:20 +02:00
Nicolas Martinelli 150bf7dba6 [FIX] point_of_sale: missing tax in accounting entry
The accounting item generated from a PoS order does not contain the
related taxes. Although the accounting entry is globally correct since
the tax line is created manually, the tax should still be written on the
accounting item for reporting purpose.

Note that this is already the behavior when the accounting entry is
generated directly from an invoice.

Fixes #10855
2016-07-25 14:08:19 +02:00
Christophe Simonis 7df4ea5b57 [MERGE] forward port branch 8.0 up to 43cff22 2016-07-25 14:07:50 +02:00
Damien Bouvy 16f7485783 [IMP] website_portal_sale: prevent partner changes if invoices exist
We should not allow a partner to *easily* change its invoicing data
if invoices have already been issued to him.
2016-07-25 13:59:11 +02:00
Damien Bouvy 259e778404 [IMP] website_portal: whitelist values in submitted in post 2016-07-25 13:56:50 +02:00
Martin Trigaux b85ef7ff1b [FIX] doc: indendation
Otherwise the text is considered as a quote
2016-07-25 13:56:33 +02:00
Olivier Dony acc531a9d7 [FIX] portal: avoid users sharing non-portal groups 2016-07-25 13:07:29 +02:00
Olivier Dony 8245c1d1d8 [FIX] service.server: drop idle connection attempts
Avoid wasting HTTP workers (in prefork server mode)
for pending/idle connections.
HTTP connections that have not sent anything for 500ms
will be dropped.

In particular, wkhtmltopdf uses a connection pool
to load remote resources. It opens more HTTP connections
than necessary and uses a random subset of them, leaving
the other idle.

On a server that has little available workers this
may significantly delay report rendering, and could
even lead to a deadlock.

OPW-667870
2016-07-25 13:06:31 +02:00
Olivier Dony 43cff22950 [FIX] base: fix broken URLs when redirecting
Similarly to werkzeug.urls.url_fix(), attempt to
correct some leftover special characters that
should have been URL-encoded.

We cannot actually use `werkzeug.urls.url_fix` or
`werkzeug.urls.url_quote`, as they expect more/most
characters to be un-encoded.
We have many existing cases where the redirect URL is
already fully encoded or mostly encoded, and those
functions would cause double-encoding, breaking the
final URL.
2016-07-25 13:06:31 +02:00
Olivier Dony 8596a4ccaa [FIX] portal: avoid users sharing non-portal groups 2016-07-25 13:06:31 +02:00
Olivier Dony 01acb8a497 [FIX] base: fix broken URLs when redirecting
Similarly to werkzeug.urls.url_fix(), attempt to
correct some leftover special characters that
should have been URL-encoded.

We cannot actually use `werkzeug.urls.url_fix` or
`werkzeug.urls.url_quote`, as they expect more/most
characters to be un-encoded.
We have many existing cases where the redirect URL is
already fully encoded or mostly encoded, and those
functions would cause double-encoding, breaking the
final URL.
2016-07-25 13:05:01 +02:00
Olivier Dony 3ff242ec0c [FIX] portal: avoid users sharing non-portal groups 2016-07-25 13:05:01 +02:00
Olivier Dony 4c9a0682b3 [FIX] pos_cache: fix rare deserialization problems
Fixes opw-683800
2016-07-25 13:05:01 +02:00
Olivier Dony bb1c6bd5ae [FIX] mail,delivery: fix incorrect imports 2016-07-25 13:05:01 +02:00
Olivier Dony 0e104a1f21 [FIX] payment: restrict field visibility to users who need it 2016-07-25 13:05:01 +02:00
Josse Colpaert 91e2dca945 [FIX] mrp: working_state should depend on time_ids when we just add one, OEE: efficiency -> effectiveness 2016-07-25 12:35:44 +02:00
Pedro M. Baeza 7e162e8993 [FIX] account: total_invoiced field should be only for customer
"total_invoiced" must only take customer invoices into account because
when you click on the button "invoiced" in the partner view form
you just see the customer invoices.

Adaptation for 8.0 of 9.0 fix made at 37569695

Closes #12044
2016-07-25 11:29:05 +02:00
Nicolas Martinelli aa1c3946da [FIX] product: rounding in pricelist report
The pricelist report might show price incorrectly rounded. For example,
a calculated price of 20.625 will be displayed as 20.62 in the report
since `formatLang` does not apply a rounding but simply truncate the
value.

Fixes #12875
2016-07-25 10:56:06 +02:00
Christophe Simonis eff0a3b049 [MERGE] forward port branch 8.0 up to 84f9cdd 2016-07-25 10:24:33 +02:00
Richard deMeester 5e7650204b [FIX] l10n_nz: Tax template name conflict (AU/NZ)
Rectify name conflict in tax templates between NZ and AU chart of
accounts. Otherwise, it's impossible to install both charts of accounts
at the same time.

Fixes #12600
Closes #12758
2016-07-25 09:31:49 +02:00
Goffin Simon d014940d1c [FIX] account: Fiscal position - mapping tax
The fiscal position is only mapping the first line,
if you need to replace one tax with 2, it doesn't work.

opw:683372
2016-07-25 09:19:03 +02:00
Odoo Translation Bot 84f9cdd1d9 [I18N] Update translation terms from Transifex 2016-07-24 02:59:48 +02:00
Odoo Translation Bot 6dcaffa3e0 [I18N] Update translation terms from Transifex 2016-07-24 00:30:28 +02:00
Adrien Peiffer (ACSONE) 611eae7959 [FIX] account: remove duplicated field in view
The account_analytic_id field was present twice.

Closes #12882
2016-07-22 16:39:31 +02:00
Martin Trigaux d1cdb4f4b8 [I18N] mail: outdated source terms 2016-07-22 15:11:31 +02:00
rgeleta 794459ade6 [FIX] doc: correct spelling mistake in reference
Closes #12865
2016-07-22 14:11:27 +02:00
Flavio Corpa 43c181926e [CLA] Signature for kutyel
Closes #12866
2016-07-22 14:10:17 +02:00
Martin Trigaux 1094c221fa [I18N] portal_sale: outdated translation sources 2016-07-22 13:26:26 +02:00
Stéphane Bidoul (ACSONE) 862e4c42ba [CLA] Add Thomas Binsfeld in ACSONE CCLA
Closes #12810
2016-07-22 10:51:55 +02:00
Pedro M. Baeza c3b1a0eca7 [FIX] purchase: retrieve product full name in dropshipping
The name field is the name of the product.template while the display_name will
contains the variant description and product code to allow to identitfy which
product.product is moved.

Closes #11311
2016-07-22 10:37:57 +02:00