Commit Graph
155376 Commits
Author SHA1 Message Date
luvi e4ff2afaec [FIX] web: correct form style in x2ManyDialog
Since o_form_view class was not placed on the right element, as the
form is displayed in a dialog, some styles were not applied in x2Many
dialogs using a form view. Now, the selector matches all cases and
dialogs will be stylized as expected, since the class is placed on the
dialog container instead of the first div.

Now, we are consistent both for dialogs and standard form views.

Tests have been adapted to work as expected.

closes odoo/odoo#102953

X-original-commit: af67305b43d51e1669df19d376d9bda7418ba863
Signed-off-by: Michaël Mattiello <mcm@odoo.com>
Signed-off-by: Luca Vitali <luvi@odoo.com>
2022-10-11 13:16:02 +02:00
Odoo's Mergebot 740dd7fb8a [FW][IMP] web,*: dark-mode
Introduce dark-mode for enterprise odoo webclient.

enterprise:
- https://github.com/odoo/enterprise/pull/31128

task-2710677

closes odoo/odoo#102868

Forward-port-of: odoo/odoo#99755
Related: odoo/enterprise#32617
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
2022-10-11 13:15:57 +02:00
Pierre Paridans dd9877e080 [REF] web,*: each module handle its own dark mode variables
Instead of having a dedicated module for all-things dark mode related,
this commit moves the (S)CSS files into their respecting modules and
uses `web` and `web_enterprise` to provide the base infrastructure for
the dark mode (cf. dedicated assets bundle).

Note:
Don't forget that you have to handle 2 cases:
1: SCSS variables must be placed BEFORE bright ones
2: CSS variables must be placed AFTER

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:56 +02:00
Pierre Paridans efc30998a4 [MOV] base,web: move onboarding variables in a dedicated file
Commit preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:56 +02:00
stefanorigano (SRI) c8f6bbea46 [FIX] web, mail, lunch: remove the 'default-badge' border
Prior to this commit, the border of any badge was set to "1px
$o-brand-primary" in order to achieve the default badge design that
comes with transparent background.

Unfortunately this rule was affecting colored badges too, leaving no
choice rather then either remove the border (causing misalignment with
siblings default badges) or hide/re-color/keep the undesired decoration
, but with mixed results.

These commit will review the behavior applying an outline (that doesn't
affect badge's placement) to "default badges" only.

Commit preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:55 +02:00
Brieuc-brd 51b51c04a8 [IMP] web: select2 : redefine and adapt colors
Prior to this commit, there was no common custom file to easily handle
select2 color values (e.g., dark mode).

This commit fixes this issue by redefining the values in webclient.scss.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:55 +02:00
Brieuc-brd ce235f8b03 [IMP] web: Tooltip: adapt for dark mode
Commit preparatory to the introduction of dark-mode.

note: Tooltip variables should be reworked in order to correctly handle
different scenarios. For simplicity this commit will just match popover
colors.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:55 +02:00
Romain Estievenart 06948a763e [IMP] *: adapt bundle to support dark mode switch
This commit adapt all bundle to support dark mode

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:54 +02:00
stefanorigano (SRI) 857a7a3b84 [IMP] web_editor: adapt for dark-mode
This commit adapts the module in order to correctly handle color-scheme
variations.

Commit preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:54 +02:00
stefanorigano (SRI) f37e92a0ba [MOV] web_editor: move floating toolbar variables in a dedicated file
Commit preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:54 +02:00
stefanorigano (SRI) d53d432361 [IMP] *: adapt for dark-mode
*: hr, hr_holidays, project, purchase, point_of_sale, rating,
spreadsheet_dashboard, stock, survey

This commit adapts modules and components in order to correctly handle
color-scheme variations.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:54 +02:00
stefanorigano (SRI) f84b9b7ef3 [IMP] website: adapt for dark-mode
This commit adapts several components in order to correctly handle
color-scheme variations.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:53 +02:00
stefanorigano (SRI) 45cfe93166 [MOV] website, web: move odoo logo in web module
Move the file in a more convenient place to be shared and customized to
match different color schemes.

Commit preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:53 +02:00
stefanorigano (SRI) 3fb351e4de [IMP] mail: adapt for dark-mode
This commit adapts several components in order to correctly handle
color-scheme variations.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:53 +02:00
stefanorigano (SRI) 5234fad374 [IMP] web, base: adapt for dark-mode
This commit adapts several components in order to correctly handle
color-scheme variations.

It also allows user_menu to handle switch entries 

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:53 +02:00
stefanorigano (SRI) 1ced9f10aa [IMP] web: add 'odoo' fine-tuned text-color
The '$o-theme-text-colors' provides a list of fine-tuned text-color that
differ from the bg ones since used for text.
This commit adds `$o-brand-odoo` in the list.

Commit preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:52 +02:00
stefanorigano (SRI) cb8677eb05 [IMP] web: introduce 'border-transparent' utility-class
Since the view's backgound-color has been historically white, white
borders have been used to adjust layout discrepancies between
components.

This commit introduces 'border-transparent' to handle the scenario
regardless by the view background color.

Commit preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:52 +02:00
stefanorigano (SRI) 9622839cc9 [IMP] web: PivotRenderer, after BS5 cleanup
Commit preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:52 +02:00
stefanorigano (SRI) 17ec20ca75 [IMP] web, mail: introduce bg-view class
Since the view's background-color has been historically white, the
`bg-white` class has been used to make match several UI components.

Despite working for the default color-scheme, this approach leads to
inconsistencies when the default view's background-color changes, eg.
dark-mode.

This commit introduce 'bg-view' to set any element to match the view's
background-color, whatever it is.

Commit preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:52 +02:00
stefanorigano (SRI) 9c923d68b8 [IMP] web_editor: preserve backend's black and white colors
Add 'black' and 'white' color in the list of backend's $theme-colors to
preserve during website's customization.

This commit is preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:51 +02:00
stefanorigano (SRI) 74e6de03be [REF] web: use $input-bg for o_inputs
Partially remove visual discrepancies between odoo and Bootstrap fields,
allowing to use BS variables to control fields' design across versions
and color-schemes.

This commit is preparatory to the introduction of dark-mode.

task-2710677

Part-of: odoo/odoo#102868
2022-10-11 13:15:51 +02:00
Guillaume (guva) 23f63a5aae [FIX] l10n_nz: GST tax on tax report
Items with tax "GST Only - Import" does not
appear on tax report

Add "BOX 11" tag to "GST Only" tax.

opw-2919731

closes odoo/odoo#102784

X-original-commit: 0cec2ec8b090cde5fc1c3fe46c1fb093217368d4
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Guillaume Vanleynseele (guva) <guva@odoo.com>
2022-10-11 13:15:23 +02:00
Habib (ayh) 9042101413 [IMP] account: analytic distribution validation
Analytic distributions that contain mandatory plans should be blocked from posting.
However, automatic flows (for example subscription invoices) should not be blocked.
For this reason, the context is used to determine whether the distribution should be validated.

closes odoo/odoo#102720

X-original-commit: 7b11af76598c0782ac2097d3cbeb718962be2537
Signed-off-by: William André (wan) <wan@odoo.com>
2022-10-11 13:15:20 +02:00
Damien Bouvy c7f804a4f5 [IMP] web: print/action menu styling
closes odoo/odoo#102322

X-original-commit: a41094e772d6bcefbc7764213b1795a06a2fd959
Signed-off-by: Bouvy Damien (dbo) <dbo@odoo.com>
2022-10-11 13:15:15 +02:00
Damien Bouvy e647a2de09 [IMP] *: adapt to grid form views
The recent switch from tables to css grids for form views `group` nodes
has introduced several inconsistencies/issues with several views accross
modules - these will not be the last fixes.

closes odoo/odoo#102174

X-original-commit: 836568dfd59886a6d52f15e0e2109709903b6803
Related: odoo/enterprise#32295
Signed-off-by: Bouvy Damien (dbo) <dbo@odoo.com>
2022-10-11 13:15:12 +02:00
Damien Bouvy 0d683bf982 [IMP] web: clearer contrasts between readonly and editable form fields
X-original-commit: f86836af3d1bae533580bc901289a170f094bd9e
Part-of: odoo/odoo#102174
2022-10-11 13:15:12 +02:00
Damien Bouvy 3a09287357 [IMP] web: tooltips & copy
- remove redundant tooltips
- m2o links are internal, not external

closes odoo/odoo#101205

X-original-commit: 664c36af56e1cfc390d007f2ab2ef9eefef48bfb
Signed-off-by: Bouvy Damien (dbo) <dbo@odoo.com>
2022-10-11 13:15:06 +02:00
Michael (mcm) e19ba30650 [IMP] web: confirm on closing tab/browser
Before this commit, the user was not notified when he
closed the tab or the browser while modifying a record.
Now, the user will be asked to confirm the close if there
is at least one invalid field.

task id: 2994132

closes odoo/odoo#102990

X-original-commit: 3fcc36786453f3006974f5fd0fa395ad5d07d9a2
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2022-10-11 12:13:45 +02:00
Nicolas Bayet 530738870b [FIX] web_editor: deactivate collaboration conflict detection
For demo purpose, temporarily deactivate collaboration conflict
detection.

closes odoo/odoo#102980

X-original-commit: d8d23148c9a45e9a543e4d908ccb9eec0fd36e3b
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
2022-10-11 12:13:42 +02:00
Antoine Guenet a101dfd35e [FIX] web_editor: prevent removal of trailing space on remove last char
This fixes a bug that occurred when using BACKSPACE to remove the last
character of a text node, if said character was preceded by a space and
said text node was succeeded by a <br>. The space was removed along with
the character. This was simply due to a missing state restoration rule
to handle this specific case.

task-2990229

closes odoo/odoo#102974

X-original-commit: 5e90529388095321da8b504ebf543c4c3054845e
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
2022-10-11 12:13:39 +02:00
Antoine Guenet b731ae7bb1 [FIX] mass_mailing: prevent dropping snippets outside mailing
The fix at [1] had to be adapted anyway since the conversion to OWL. As
a result it was possible to drop snippets below the mailing area.

[1]: https://github.com/odoo/odoo/pull/77724/commits/65b67d66de72fab390b8887c12532b840d47c95f

task-3002441

closes odoo/odoo#102972

X-original-commit: fe4006997daeb5d323b364821fc2815a45e78495
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
2022-10-11 12:13:37 +02:00
clesgow d31c94a780 [FIX] mrp: production wizards layouts
Adapts the layouts of the immediate production and the production's
backorder to match the new grid css for groups.

Part of task-2985735

closes odoo/odoo#102958

X-original-commit: 5b999ee40e02647c0d2edfbce7081f6f8cf05857
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
2022-10-11 11:07:48 +02:00
Pierre Masereel f5c31545db [FIX] point_of_sale: fix electronic payment style
When an electronic payment is done in the POS, the payment lines
contains the status of the electronic payment and the corresponding
button to perform actions.

We are now correctly display those informations.

closes odoo/odoo#102957

X-original-commit: 7e237dd6282ecd9ebe95690e445466acbab26ca5
Signed-off-by: Masereel Pierre <pim@odoo.com>
2022-10-11 11:07:45 +02:00
oco-odoo 9ad7f2727b [IMP] account_reports: better helpers for report fields
closes odoo/odoo#102886

X-original-commit: 91e1c588cb4616af3f457191b787ca8e617f6d17
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
2022-10-11 11:07:42 +02:00
FrancoisGe d0e995ba61 [FIX] web: use the correct colspan in the group header
Before this commit, in a grouped list view with at least one
group_operator and optional fields, the aggregated values in the header
are shifted one column to the right.

Why is this?
Adding the +1 to the colspan in the group header for optional fields
is always added on the left side (group name).

Solution:
The +1 should be added on the left side (group name) if there is
no aggregated value otherwise on the right side (pager).

Before:
TH TH TH TH TH AGG AGG TH AGG AGG TH TH TH OP
0  1  2  3  4   5   6   7  8   9  10 11 12 13
[      TH 6      ][TH][TH][TH][TH][TH][ TH 3 ]
[   group name   ][ aggregate cells  ][ pager]

After
TH TH TH TH TH AGG AGG TH AGG AGG TH TH TH OP
0  1  2  3  4   5   6   7  8   9  10 11 12 13
[    TH 5    ][TH][TH][TH][TH][TH][  TH 4   ]
[ group name ][ aggregate cells  ][  pager  ]

closes odoo/odoo#102754

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Georis François (fge) <fge@odoo.com>
2022-10-11 11:07:40 +02:00
Adrien Widart 3036cad27d [IMP] stock_picking_batch: add tests
OPW-2976150

closes odoo/odoo#102943

X-original-commit: 794ce1bc1e5b15f666dbdb378b95e5a63e904850
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>
2022-10-11 09:09:59 +02:00
Atul Patel 8d18c9c2d9 [FIX] doc: link to the right repository
GitHub has changed the way it forms absolute URLs

closes odoo/odoo#102523

X-original-commit: 181a1a10451f20c7c0b44aba44addc7a9127c219
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2022-10-11 09:09:56 +02:00
Jorge Pinna Puissant 375b969e99 [FIX] crm: remove field crm_statusbar
Remove the field `crm_statusbar` as it dosen't have a specific
behaviour, and we can use the classic `statusbar` field instead.

closes odoo/odoo#102992

X-original-commit: 386fa0a5e448f149e75da68a02ad94dd88cc4d08
Related: odoo/enterprise#32669
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
2022-10-11 08:07:49 +02:00
Jorge Pinna Puissant f00e544930 [FIX] web, crm: override of form controller save function
Before this commit, some functions overrode the save function of the
form controller. The issue is that this function is only called when the
button save is clicked, and not when we save differently (for example,
when clicking on the breadcrumb).

To avoid this mistake the save function on the form controller was
renamed to: `saveButtonClicked`, and the code that overrode the function
now override the save function of the Record, that it's called at each
time a save is perform.

X-original-commit: b6e3d833e6131562084eb13b2955c22f50ad1e79
Part-of: odoo/odoo#102992
2022-10-11 08:07:49 +02:00
Younn Olivier d6bf2c0cbf [FIX] website, *: redirect to the WebsitePreview using ir.actions.client
*: website_forum, website_hr_recruitment, website_sale

Before this commit, most of the backend redirections to the
WebsitePreview, introduced in [1], were using ir.actions.url with the
get_client_action_url util, which was not optimal.

This commit changes that to use a new get_client_action method, which
returns the ir.actions.client record. It will execute the action
directly, avoid to redirect the router before, and improve performances.
Also, it allows to solve bugs, as:
- The back navigation from the WebsitePreview to the ListViews.
Going through the /web controller would add an entry in the history, and
going back on it would reload the client action.

[1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b

task-2687506

closes odoo/odoo#102991

X-original-commit: 30fb11e479fb7b3db3649e55fcbdb06bfcdb398c
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2022-10-11 08:07:46 +02:00
qsm-odoo 2f53a7e7b5 [FIX] website: restore creating special pages via "add page" dialog
Commit at [1] factorized some code and in the process used a service
that was not declared. This prevented to use the "add page" dialog
(which allows to create pages via the "+ New" button) to create special
pages ".js", ".css". That feature will likely be removed or reworked
in a future update though.

[1]: https://github.com/odoo/odoo/commit/58698f848703395ff680bc7586ecc8eec4fb61ae

X-original-commit: 21b90ff8bdad22b6beea1b6b5a6d70276817c00e
Part-of: odoo/odoo#102991
2022-10-11 08:07:45 +02:00
Josse Colpaert c6279f31b4 [FIX] l10n_it_edi: detect fatturapa also if extension in upper case
Before: it won't work with extension in uppercase: .XML or .XML.P7M

We put ?i: in the regex so that part would be matched case insensitively

opw-2703669

closes odoo/odoo#102766

X-original-commit: 397e9f49c1806d2188a2e0d2e3cf32eeedf91e4b
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Josse Colpaert <jco@odoo.com>
2022-10-11 08:07:40 +02:00
Soukéina Bojabza 3485779e04 [IMP] website: improve the Masonry snippet templates
Since [1], the Masonry snippet is in grid mode only and its templates
have been modified to allow this mode. However, some of them don't look
good and have to be improved.

This is what this commit does:
- some text blocks were too small so their height has been increased
- the Masonry second default image has been replaced by another one
that looks better.

[1]: https://github.com/odoo/odoo/commit/85b352af319edec84407f2046cf795b4e5503460

task-3013055

closes odoo/odoo#102984

X-original-commit: ad8926eafd34c2743e1a5247f6171fd183e6e506
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2022-10-10 21:50:43 +02:00
Rémi Rahir fc520504a9 [FIX] spreadsheet: Ingore Pivot.HEADERS with measure field
Field `measure` in `PIVOT.HEADER` functions are not actual res.model
fields but are used to display the fieldName of the measured field.

closes odoo/odoo#102979

X-original-commit: 6de4b2c4c058babb4e3ee0b60212aa4a9ccec119
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
2022-10-10 20:52:25 +02:00
Adrien Dieudonné 7dcdf09a48 [FIX] web: add space above group separators
This commit reverts https://github.com/odoo/odoo/commit/0e0a2014b31e2fc6423e80971ac451a2dfe89de9

Before this commit, the string separator was too close to the
previous label/field.

We now have the same margins as in 15.3.

Steps to reproduce:
- Sales -> Orders -> customers
- Choose any
- Sales	& Purchase tab

closes odoo/odoo#102978

X-original-commit: 0510f5ed80bbffbee249e709d1df90192ee08f02
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2022-10-10 20:52:22 +02:00
Nshimiyimana Séna 6a3ab85c4f [FIX] mail: remove fallback to find a company for currency in mail tracking
BUE

Steps to reproduce
- go to Apps, switch to studio and create and create a new app.
- on the form view, add a Many2one field related to 'Sales Order'.
- add a Ralated Field, related to 'Sales Order > Total'. You will be
  presented with a prompt informing you that you need a currency field
  on the model. Click 'OK' to add the currency field.
- again, add a Ralated Field, related to 'Sales Order > Total'.
- close Studio, fill the form you just created and save.
- switch back to studio and, again, add a Ralated Field, related to
  'Sales Order > Total'.

You will be met with a traceback.

FIX

Actually defining a currency field on currency fields is mandatory. We
don't have to provide a fallback, hence we don't have to fix the fallback.
Simply remove it.

Task-3012648
opw-2951697
Closes odoo/odoo#94831
Closes odoo/odoo#94962

closes odoo/odoo#102918

X-original-commit: 899f3b4897f34576d502cf442ab7059c489870dd
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2022-10-10 20:52:17 +02:00
Antoine Vandevenne (anv) f4ad4f857e [FIX] payment_demo: use a custom module icon rather than Stripe's
closes odoo/odoo#102973

X-original-commit: 96836566c8e8b3a7d5545d228f47a9e19290d363
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
2022-10-10 19:55:45 +02:00
Valentin Vallaeys (vava) 9979334703 [FIX] sale_product_matrix: fix colspan of variant selection
closes odoo/odoo#102971

X-original-commit: f65044bf6ce753f9cab52a2b8a68e03728bc068f
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2022-10-10 19:55:43 +02:00
Victor Feyens 9ded78ede0 [IMP] core: docstring improvements
* clean and improve docstrings in orm
* fix typos found with codespell
* rely on the Environment class docstring instead of doc content (and
therefore move part of the doc inside the class docstring)

closes odoo/odoo#102969

X-original-commit: 8250cd4b210005d223a4cdb8afa4014425ca6fa3
Related: odoo/documentation#2803
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2022-10-10 19:55:37 +02:00
Anna Janiszewska e4f81af515 [IMP] website_sale: create hook for website_sale.product rendering values
closes odoo/odoo#102956

X-original-commit: 7ccb3380becfe7ff5a36f93288935ab3882c4542
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>
2022-10-10 19:55:31 +02:00