Commit Graph
117313 Commits
Author SHA1 Message Date
jem-odoo dafb9b2638 [FIX] sale_expense: expense count of SO should be compute in sudo
Without this commit, reading all fields of sales
order will raise an access error if user does not
have access to hr.expense documents. An since
the expense count is displayed on the form view, this
can be annoying.
This commit makes the computation of the expense
count done by 'sudo', as there is not critical
informations at stake.
2018-05-22 11:52:19 +02:00
stefanorigano b637b5aeb8 [REF] hr_attendance: revamp design
Improve mobile layout, uniform templates design, simplify and revamp SCSS

Related to task #1822709
Closes #24645
2018-05-22 10:43:10 +02:00
stefanorigano 716640bb67 [FIX] hr_attendance: invert icons for sign-in/out
Set the right employee's possible states.

Before the restyling, the main title was always “Welcome!” regardless
of the user state (checked_in or checked_out). Using conditional titles
has exposed the issue.
2018-05-22 10:38:05 +02:00
Josse ColpaertandNicolas Martinelli bf65cd83ab [IMP] mrp: add check for unproduced finished lots
- Create a Finished Product tracked by SN
- Add a BoM with routing (in several steps) to that product: component A
  should be consumed in 1st step and component B in 2nd step
- Create a MO, plan it, go on the first WO and produce the finished
  product with SN 0001
- Then go on the second WO and produce the finished product with SN 0002
- Back on your MO, you'll see that
    Finished Product = SN 0002
    Component A has been consumed for SN 0001
    Component B has been consumed for SN 0002
- Mark the MO as done

No blocking error is raised so I'm consuming a product for a finished
product I'm not really producing. Traceability report will be wrong too.

We raise a blocking error to avoid this use case.

opw-1832098

Co-authored-by: Nicolas Martinelli <nim@odoo.com>
2018-05-22 09:45:47 +02:00
qdp-odoo e2864c87a2 [FIX] account: tax cash basis for supplier vendor bill
Fixes #24743
2018-05-18 17:04:09 +02:00
Prakash Prajapati 3cd7cf96d1 [IMP] im_livechat: improve live chat rating screen
Currently, layout for rating a chat is not looking so well.
This commit improves the rating layout. It will
 - Center the content (including smileys)
 - Enlarge the fonts (a little bit)
 - Underline the link instead of using italics (more intuitive)

Task : 1838321
PR : #24413
2018-05-18 15:00:15 +02:00
Thibault Delavallée ec5885ae5b [REF] mail: remove unnecessary headers in notification emails
Several contextual data is added in notification emails in their headers.
We consider as not necessary to put some of them, notably db uid. It should
not be used outside of Odoo and having Odoo-Objects should be sufficient
for people that want to categorize their emails.
2018-05-18 13:09:56 +02:00
qsm-odoo 7e59d30d9c [MERGE] web_editor: add the image cropping feature
Thanks to this merge, users are now able to crop their images using the
editor. This is done by clicking on a content image and then the crop
button appearing in the editor bar. Cropping an image will only crop the
image at the location it was clicked by creating a new image for that
location. Cropped images do not appear in the media dialog.

task-43706
Closes https://github.com/odoo/odoo/pull/22473
2018-05-18 12:16:28 +02:00
Kishan Gajjar d66e260391 [IMP] web_editor: allow cropping content images 2018-05-18 12:15:42 +02:00
Kishan Gajjar fd5cffe235 [ADD] web_editor: add new cropper lib 2018-05-18 12:15:42 +02:00
Olivier Dony 406df78f43 [FIX] hr: make field-level groups consistent
a696f84f1f adds a few extra fields to the
Private information tab of the employee form. As a result, HR personnel
and employees could reasonably expect these fields to be protected in
the same manner as the other private fields. Make it so.

Cherry-Pick of odoo/enterprise@533db05b5e

Fixes #18610
2018-05-18 11:21:46 +02:00
Darshil Trivedi ffb79761c1 [IMP] stock: rework of immediate transfers.
The transfers are either 'planned' or 'immediate' but the process are sensibly the
same. This commit separate clearly the two possible pickings (with a new boolean field)
and simplify the view of immediate ones. This kind of transfer is pretty straightforward
so only the 'Done' column remains and the text stays written in black.
2018-05-18 08:28:11 +02:00
Darshil Trivedi d9feb74ae8 [IMP] mrp: set default product quantity and unit of measure
At the creation of a manufacturing order, the default values for product_qty
and uom is respectively 1 and the product's one. We now use the the values
given by the bom
2018-05-18 08:28:11 +02:00
Darshil Trivedi 142e8fca2e [IMP] purchase: create purchase order without any purchase order lines.
On purchase orders, the scheduled date is mantadory. This date is computed from
the purchase order lines and hidden. If there is no purchase order line, the date
stays empty and it's not possible to save the PO.
This commit uses the order date as scheduled date if there are no PO lines
2018-05-18 08:28:11 +02:00
Nirali Sapra 47c34d2932 [IMP] stock: hide the source and destination location
This commit hide the column source location if the type is incoming and hide the
destination one if the type is outgoing. When picking type is 'vendor' then no
need of source location. If picking type is 'custmomer' there is no need of destination location.

This commit is related to task ID 59417
2018-05-17 15:02:05 +02:00
Nirali Sapra 2d8607bea7 [IMP] purchase : remove stat button with link to PO on the reordering rules
This commit is related to task ID 59417
2018-05-17 15:02:05 +02:00
Nirali Sapra fcb9fafcad [IMP] stock: remove force_assign method
This commit remove force_assign method in every tests of point_of_sale, purchase, sale_mrp,
sale_stock, stock and stock_account . This method is not longer used since V11.

This commit is related to task ID 59417
2018-05-17 15:02:05 +02:00
Nirali Sapra ec37a48013 [IMP] stock: 'validate' button in primary mode
This commit change the validate button in stock picking. It's now primary only when the
picking is in ready stage. Before this commit, this button was primary on waiting stage too.

This commit is related to task ID 59417
2018-05-17 15:02:05 +02:00
Nirali Sapra dc151cbd1c [IMP] mrp: remove the work order messages
This commit removes work order messages menu as it's not used anymore since V11 in the new WO screen

This commit is related to task ID 59417
2018-05-17 15:02:05 +02:00
Xavier Dollé f555bfeca3 [FIX] mail: correctly filter needaction on unread notifications in message_format
Previously to this commit needaction used by JS was not taking into account
read notifications. It means notably Inbox counter could be higher than
expected as taking into account read messages while Inbox displays only
unread messages. This commit fixes that by checking notification state when
giving needaction_partner_ids to message_format result.

This fix has a small impact on performances as message_format is used in
notification process for chat or push. A better implementation of message
format and its postprocess could probably lessen this fix impact. As we
target stable version we avoid rewriting other part of the code. Optimization
will be done in development version.

Related to task ID 1841243. This is a manual forward port of commit 69714fbeee
done in saas-11.2.
2018-05-16 16:17:59 +02:00
Raphael Collet 6a601fe6dc [IMP] test-pylint: check for undefined variables 2018-05-16 13:58:39 +02:00
Thibault Delavallée 96a223a5f0 [IMP] mail: prevent creation of activities to users that have no access to document
This commit is related to task ID 58968 . Closes #24176.
2018-05-15 15:42:54 +02:00
Vincent Schippefilt 9148960174 [IMP] account_budget: complete review of the module
* budgetary position nor analytic account aren't required anymore (although one of the 2 have to be given)
* by extension, the computation of practical amount is not either based on the analytic lines or the account.move.line
* usability improved (for eaxmple: there's a button to open the list of items on which the practical amount computation is done)
* addition of a pivot and graph views of the budget lines

Was PR: #22342
Was task: 31995
2018-05-15 15:19:28 +02:00
qdp-odoo f53d9c369d [IMP] analytic: slightly improves demo data
by adding an analytic group to analytic accounts
2018-05-15 15:06:39 +02:00
Vincent Schippefilt 09125f78c3 [IMP] web: allow usage of computed unstored fields in pivot views 2018-05-15 14:55:00 +02:00
Vincent Schippefilt 32c6d129ca [IMP] web: add the Percentage widget in the registry as a basic field 2018-05-15 14:13:38 +02:00
Raphael Collet 7925abe3ce [FIX] hr_holiday: default date must be callable 2018-05-15 09:29:56 +02:00
Thibault Delavallée 6639a6e74d [FIX] fleet: fix traceback when going to vehicle activities from systray
Default group by is required in order to correctly display a kanban view on
vehicles.

By the way activities fitlers were missing. This commit adds them.

This commit is related to a recent commit adding activities in fleet, see
7356c3b5b6 for more details.
2018-05-14 11:37:41 +02:00
Thibault Delavallée 78c457e563 [IMP] mail: rename Todo activity into To Do
It seems better for people. . Related to task #1825295.
2018-05-14 10:40:51 +02:00
eco-odoo b19b9e756c [FIX] web: click on <a> with type="action" triggers the correct action
Without this fix, clicks on <a> with a sub html tag do not work.
2018-05-14 09:44:16 +02:00
Kishan Gajjar c1f04bef83 [IMP] hr_timesheet: make it easier to encode timesheets
In this commit, we do two small changes to make it easier to encode
timesheets.  The main issue is that we want to solve the following
situation: a user clicks on a cell in a timesheet grid view to open a
list view, then clicks on 'Create' to create a new timesheet. This will
open a form view, but some fields which could be prefilled are not
filled.

- do not reset task_id in some cases. This is important for the onchange
  call which comes after a default_get, when there is a default project
value set.
- do not set employee_id if there is default_employee_id in context
  This is useful when we open timesheets from the 'All Timesheets'
menu item, then add a new line, select a different employee, and open it
in the grid view (by clicking on the + icon from a cell).  This opens a
list view, which is editable, but when we create a new entry, it ignores
the employee value.

Note: a commit in enterprise adds support for properly passing contexts
in grid view, see
https://github.com/odoo/enterprise/commit/f23003917f18b52bb69483cdaac3cb2164230aa6

Task: #35414
2018-05-11 16:19:26 +02:00
Fabien Meghazi 02deb4a662 [FIX] server: fix typo introduced in 9ffb51e1c2 2018-05-11 15:42:29 +02:00
Viral Thakar d1c731e88c [IMP] pad: add mobile support for pad widget
In mobile devices, the pad widget did not behave in a satisfactory
manner.  Also, once it was in fullscreen mode, it was not possible to
come back to normal mode.

Task: #31545
PR: #15817
2018-05-11 14:36:57 +02:00
Ray Carnes 7ee2bfce9f [IMP] google_spreadsheet: Add widget="url" to the URL field on tree view
Users can now click this field, instead of having Odoo open the Form View to click it.

Benefits:
1. Saves the user from clicking TWICE (they only have to click ONCE with this PR)
2. Keeps the list view of all spreadsheets open (user has to GO BACK to see the list without this PR)
2018-05-11 11:55:05 +02:00
David f236b095cb [IMP] membership: Always display associate_member on members tree views
Whatever the state of the association the associate_member is
relevant in order to follow where the membership status of the partner
comes from.
2018-05-11 11:50:47 +02:00
Swapnesh Shah e293cdafb1 [IMP] project: Display tasks label on rating stat button
Added label_tasks in task form view for rating

closes #22895
2018-05-11 11:43:00 +02:00
Fabien Meghazi 9ffb51e1c2 [IMP] server: improve logging for ThreadedServer#server_bind 2018-05-11 11:37:16 +02:00
Romain Derie b65cb86697 [IMP] website: remove page creation in menu manager + menu container
This commit:
1. removed the possibility to create page from the menu manager.
   The usability of this feature wasn't great since create menu as a new page
   would redirect to that newly created page without saving the menu manager
   state.
   Plus, there is already the 'NEW' button on the navbar to create a new page,
   the menu manager should, as its name hint, only manage menus.
2. Handle a new case (officially at least) of menu: menu container.
   Those menu are simply menus with '#' as URL. It will be usefull to create a
   menu as a dropdown list container.
   Note: We should take care of a menu's URL being updated to '#' to avoid the
         menu's page URL to be also edited to '#'.

opw-1825883 & opw-1824263
2018-05-09 15:38:58 +02:00
Jairo Llopis 285ead28e3 [IMP] Handle XMLRPC calls from standard controllers
This way, XMLRPC calls can get request details form the standard
`odoo.http.request` system.

Move jsonrpc to the same controller while at it, for coherence.

Fix #24183
2018-05-09 09:46:15 +02:00
ppr-odoo e9e8fd24cf [IMP] mail: hide 'mark all read' buttton on mobile devices
This commit is related to task ID 1838321

PR #24412
Task #1838671
2018-05-08 15:26:06 +02:00
Samuel Piquet 2884f76488 [FIX] repair: remove useless rules
The manager had less rights than the user.
As the manager is also a user, this had no effect.

Closes #24523
2018-05-08 13:24:47 +02:00
Samuel Piquet 08cd80a315 [CLA] signature for Sa3m
Done at #24523
2018-05-08 13:24:42 +02:00
xmo-odoo 0767d35805 [IMP] base_automation: warn when using on_change trigger w/o "code" type
Task 37742

closes #21446
2018-05-07 13:31:45 +02:00
Thibault Delavallée 324ae5ed8f [REF] mail: get rid of thread_model context key
message_post and various mail.thread related code still support a thread_model
context key allowing to redirect message post on another model. Purpose of
this commit is to get rid of that context key and support model / res_id
fields coming from either the record on which we run, either parameters of
message_post. Indeed those parameter match the one used as fields on mail
message. It makes sense to support them for customization if necessary
instead of using a context key.

This context key exists since a lot of time. It is difficult to find the
source as history is quite complex when the mail was refactored in 2012.
See notably 6aa4f80b2d and 2c4ed841b9 for example.
2018-05-07 11:00:03 +02:00
Thibault Delavallée 282733cf8d [REF] mail: make notification methods semi-generic
mail.thread mixing class defines several methods used in notification process
that are not specific to mail.thread enabled models. It means some models
could override it while some other models do not even have a direct access
to that method.

When calling those methods we have to manually check for method being
available on a record or call a default implementation from mail.thread
even if the model does not inherit from the mixin.

In this commit we propose to hide this check in generic wrappers located
in mail.thread class. It checks for method existence on record and call
the model-specific implementation or falls back on standard behavior. It
allows to be sure the right method is called.

Functionally behavior should stay globally the same. However when updating
some addons code has been updated. Previous code could lead to records not
having correct alias which should not be the case anymore. This commit is
linked to task ID 47934.
2018-05-07 10:58:54 +02:00
Yannick Tivisse 6cb5052e85 [FIX] fleet: Fix the _name_search override on fleet.vehicle
Actually _search return a list of ids, not a browse record.
2018-05-07 10:11:58 +02:00
Yannick Tivisse 9e261d0f7d [IMP] l10n_be_hr_payroll: Store the Employee Budget 2018-05-07 10:11:58 +02:00
Yannick Tivisse 5731c10a69 Revert "[IMP] hr_contract: Improve the contract tree views"
This reverts commit ec929342eb.

This wasn't the expected result :)
2018-05-07 10:11:58 +02:00
Fabien Pinckaers a5c614db57 [IMP] account: name_search / name_get symetry on account.account
That way, pressing down on a many2one already filled will not propose
to create a new account: "20000 Sales Account" should name_search it.
2018-05-05 08:56:30 +02:00
dip-odoo 362613a2fa [IMP] auth_signup: change email invitation condition
Currently if a user has already been invited you cannot invite him again
via the web_settings_dashboard as it automatically tries to create a new
user.
This commit changes that behaviour in case you have the mail app
installed odoo will now send an invitation email to the invited user as
long as this user has never connected.

1) Mail app not installed:
   - if user is active     > display error (this email is already in use)
   - if user not active    > activate the user
   - if user doesn't exist > create new user

2) Mail app installed:
   - if user is active && state confirmed > display popup (this email is
   already in use)
   - if user is active && never connected > resend invitation mail
   - if user is inactive > activate the user
   - if user doesn't exist > create new user and send invitation mail

This commit is related to task #54023
Closes #23081
2018-05-04 18:07:31 +02:00