Commit Graph
119718 Commits
Author SHA1 Message Date
Martin Trigaux d97e69ff02 [FIX] mail: schedule activity with user's today
The activity was incorrectly scheduled with a deadline as the now in UTC while
the state was computed using "today" in the user's timezone.
This made the nightly test fail (run at 23:30 UTC with the user in UTC+2).

Use context_today instead of today for all activity_schedule calls
To make it easier, use on the context_today default value instead of setting
context_today everywhere (which is more error prone in the future)

Never use datetime, only date objects
add a warning to detect potential errors when passing a datetime

Closes #26411
2018-08-17 13:46:39 +02:00
Martin Trigaux c51cfbc58b [FIX] purchase: use date everywhere in report
account_invoice.date is a date field
purchase_order.date_order is a datetime field
2018-08-17 13:14:51 +02:00
XavierDo f83c313631 [IMP] mail_bot: improve answers, initialisation and others
1. Odoobot shouldn't talk to admin when demo data are installed
Odoobot will talk to a user on it's first connection, meaning that
a dev will see this chat window a lot. The state disabled is not a
real state but is explicit, the odoobot wont be initialized in this
case. It is still possible to test odoobot flow with demo user.

2. remove old odoobot image and update link

3. small improvements in odoobot answers
2018-08-17 13:06:43 +02:00
Mehul Patel dc5462db51 [FIX] web, google_spreadsheet: BS4, fix arrow issue in search filters 2018-08-17 12:46:14 +02:00
Hiral Bhavsar b0c4245df7 [FIX] web: BS4, restore calendar view's sidebar filters checkbox
Currently cross sign not appearing inline to checkbox while hovering
sidebar filters and checkbox tick/untick not working properly.
2018-08-17 12:46:14 +02:00
qsm-odoo 4895b542e4 [FIX] website_links: restore filter buttons (useless breaking rules)
Revealed with BS4.
2018-08-17 12:46:14 +02:00
mgh-odoo d187f37563 [FIX] base: use proper info alert for new team member message
Bug revealed with BS4.
2018-08-17 12:46:14 +02:00
Anshuman Sharma 13ebe69747 [FIX] website_forum: BS4, set a spacing between cards 2018-08-17 12:46:14 +02:00
Kishan Gajjar 9056e5a3cb [FIX] web_editor: BS4, mark proper active img-padding option 2018-08-17 12:46:14 +02:00
Deep Patel 0bcd71a54a [FIX] web: BS4, fix stat button color issue 2018-08-17 12:46:14 +02:00
Vandan Shah e31048f6a4 [FIX] mrp: BS4, restore report's links design 2018-08-17 12:46:14 +02:00
qsm-odoo 9d30113356 [FIX] web: BS4, restore dropdown active colors 2018-08-17 12:46:14 +02:00
qsm-odoo ed031d9085 [FIX] mail: BS4, restore discuss badge design 2018-08-17 12:46:14 +02:00
qsm-odoo 3bf3a40606 [FIX] website: BS4, restore facebook snippet UI
+ solve JS error introduced by a recent commit

Thanks to @kig-odoo for original fix
2018-08-17 12:46:14 +02:00
Alexandre Kühn ff4901e429 [DOC] web:tests: add docstring for testUtils.patchDate 2018-08-17 12:37:36 +02:00
Alexandre Kühn 75aef0106e [FIX] mail: misplaced translatable string
`_t()` must surround a static string in order to become a
translatable string.
2018-08-17 12:37:25 +02:00
RomainLibert 2d738f8563 [FIX] product_form: remove hs code and duplicate internal note
The hs code was only used in a single view, hence it was decided that we
wouldn't keep it
2018-08-17 11:47:28 +02:00
Simon Lejeune 3fa2ca0779 [FIX] web: no_open in field options no longer working
example: <field name="product_id" options="{'no_open': True}" readonly="1"/>

This has been broken by rev. 43d21dd9c due to misplaced parentheses
(an empty object in javascript being truthy).
2018-08-17 11:24:27 +02:00
Sébastien Theys 82a46db2de [FIX] portal,sale,sale_management: raise if no document
Before this commit, the method _document_check_access would succeed if it was called with a non-existing id.

Now it will raise a MissingError.

PR: none
Task: none
2018-08-17 10:40:07 +02:00
Sébastien Theys 02a73ed62c [IMP] sale,sale_management: fix minor bugs and rename strings
Sales Order report:
- fix Total table alignment (to the right)
- remove misplaced /> characters
- remove page-break before optional products

Sales assets:
- fix duplicate ID preventing assets files from being loaded

My Home:
- fix link to sales orders

Optional Products:
- renamed various strings
- made product_id required to prevent a traceback

PR: none
Task: 1838924, 1876864
2018-08-17 10:40:07 +02:00
Mathieu Duckerts-Antoine 3ec6624754 [FIX] web: time range menu flickering
The search view always instantiates a time range menu but hides it
when it is not used.

Now, when the time range menu is not used, every time the search view
facets are rendered, the time range menu is also rendered entirely
and becomes visible shortly before being hide again. This caused
a bad screen flickering.

This commit fixes that problem by avoidind the unnecessary rendering of
the time range menu.
2018-08-17 10:26:31 +02:00
Alexandre Kühn c995aa2cfd [FIX] mail: tests: remove phantomjs hack with discuss
Revision on https://github.com/odoo/odoo/commit/e0a51edd856b36bfdf1cacb4d7e8d70fad7884fa

In the commit above, we added an option to Discuss widget
to render threads specifically for PhantomJS. The reason
for this is that a test was failing, because it needs full
support of CSS flexbox to pass.

However, PhantomJS does not support flexbox very well. As
a result, it was messing with the rendering of threads.
We couldn't make the hack just in the test itself, because
it is already at the moment of rendering the thread that
PhantomJS messes the whole process of the test.

PhantomJS has been replaced with Chrome headless [1], So
the hack is no longer be necessary, as Chrome headless
fully supports CSS flexbox.

[1] https://github.com/odoo/odoo/commit/de84ad9c1f4853cb8a748ee1d0c880081dae9fe2
2018-08-16 22:26:50 +02:00
Rémi Rahir dd00a3d9f9 [FIX] snailmail: added missing dependency 2018-08-16 18:45:53 +02:00
Alexandre Kühn f1a0a32e46 [FIX] web:tests: do not rely on testUtils.patch in tests
Revision on https://github.com/odoo/odoo/commit/10f43955d81ff3e7b5ab050656b312ec19f927c5

Commit above uses `testUtils.patch` in the test.
However, this utility function does not seem to work.

That sucks...
2018-08-16 18:38:49 +02:00
Thomas Binsfeld f9644a7674 [IMP] purchase: split compute methods
No advantage to group a search on purchase.order and another one on
account.invoice.
Avoid potential access errors if a user has access to one model but not the
other one.

Closes #25761
2018-08-16 17:34:23 +02:00
Gustavo Valverde 89273f8d72 [IMP] hr_payroll: order salary rules by sequence
The most important part of building salary rules is having them in the right
sequence. Unsure all the rules are evaluated in a deterministic order.

This also makes it easier to know how the payslip will show the order of the
salary rules.

Closes #25756
2018-08-16 17:30:03 +02:00
qsm-odoo 8a85cb9ea4 [REF] website_sale, *: organize JS to use new system
* website_sale_comparison, website_sale_wishlist, website_sale_options
2018-08-16 16:59:25 +02:00
Alexandre Kühn 10f43955d8 [FIX] web: render JournalDashboardGraph when in DOM
The lib 'nvd3' renders graph when they are attached to the
DOM. However, widgets are rendered in fragments and
appended to the DOM when ready (to prevent flickering).

Before this commit, we used a `setTimeout(0)` and cross
fingers that the widget was attached to the DOM when the
`render` method was called.

With this commit, the render method is called when it is
attached to the DOM.

Task-ID 1868252

Closes #26410
2018-08-16 16:52:56 +02:00
Raphael Collet 2a2ff6eb5c [FIX] tools: serialize lazy to json 2018-08-16 16:39:20 +02:00
Christophe Monniez 49fb7a4682 [FIX] tests: avoid traceback when websocket-client is not installed
The account module needs to import Form from "tests.common" causing a
traceback when websocket-client module is not installed.

As this module is only required for the tests, there is no reason to add
it to the "requirements.txt" file.

With this commit, Odoo account can be installed even when
websocket-client is not installed, in that case, the HttpCase tests that
needs to run Chrome headless will be skipped with a warning.

Closes: #26404
2018-08-16 15:07:43 +02:00
Simon Lejeune f57bc96d32 [REF] stock: add a group to display/hide the lot name on the delivery
initial work by Alexandre Moens <mao@odoo.com>
task 1832574
closes #24299
2018-08-16 15:01:25 +02:00
Arnold Moyaux 6671725c3b [FIX] mrp: manufacture to resupply archive pbm/sam rules and routes.
Usecase to reproduce:
- Check manufacture to resupply and manufacture in 2 or 3 steps
- Uncheck manufacture to resupply
pbm and sam rules in global route(mto/manufacture) are still active

It happens because the condition to archive the rules was not complete
the check on manufacture to resupply was missing
2018-08-16 14:45:14 +02:00
Yannick Tivisse 9aaa32b6f6 [IMP] base: Better implementation of 8166eae 2018-08-16 14:40:46 +02:00
Thibault Delavallée b4715952cb [FIX] mail: fix server action view requiring not required fields
Some fields are required only when defining an activity-based server
action. Required domain was not correctly written leading to server
actions being blocked.
2018-08-16 14:34:50 +02:00
Yannick Tivisse 8166eae0bf [IMP] base: Don't set customer=True on new users
Purpose
=======

Create a user, then the partner is shown in Customers.

Most of the time, user is not a customer.
2018-08-16 14:19:37 +02:00
Rémi Rahir f710f6d5df [FIX] snailmail_account: wrong visiblity attribute on div 2018-08-16 13:41:03 +02:00
Adrien Dieudonne db6708c2f5 [FIX] web: warning: Some modules could not be started
warning: Some modules could not be started
Missing dependencies:     web.field_utils
Non loaded modules:       web.dataComparisonUtils

This commit moves 'data_comparison_utils.js' from 'assets_common'
to 'assets_backend' because 'field_utils' is only defined in
'assets_backend'.
2018-08-16 12:38:50 +02:00
Mathieu Duckerts-Antoine db1eec2851 [FIX] web: tooltips in filters menu
There were tooltips on period options in the submenus of
filters menu. With the switch to Bootstrap 4, the html
structure of filters menu has changed (no more 'ul') and has
altered the way the menu items are rendered causing the
disparition of tooltips. With this commit, the tooltips come
back.
2018-08-16 12:11:14 +02:00
antonylesuisse de84ad9c1f [REF] tests: replace phantomjs by Chrome headless
As the phantomjs project was suspended[1], there was a need to change the js test
engine. Moreover, the engine was rather old and leading to non
deterministic crashes.

Chrome headless was choosen for simplicity and the long term vision of
the devtools protocol [2].

The 'phantom_js' method still exists but will be deprecated in
favor of 'browser_js' with the same parameters.

In order to communicate with the browser, the python websocket-client package
is needed.

[1] https://github.com/ariya/phantomjs/issues/15344
[2] https://chromedevtools.github.io/devtools-protocol/

#closes 25991
2018-08-16 11:45:43 +02:00
David Monjoie 726a356045 [IMP] web: add/remove from favorite outside of i tag
When paced inside the i tag, the text used to inherit from the
style of the star, which means the text was yellow when starred.
2018-08-16 11:19:26 +02:00
David Monjoie d2e2d05f08 [FIX] web: BS4 fix modal footer buttons margin 2018-08-16 11:19:26 +02:00
David Monjoie 4bed2445f6 [FIX] base_import: fix formatting options structure
It used to work by chance with Bootstrap 3, but since we are now
using Bootstrap 4, the fake good appearance collapsed, revealing
the awful structure it used to have.
2018-08-16 11:19:25 +02:00
Mohammed Shekha 8fbadb9575 [ADD] base_import: debug option to create M2O/M2M records
Adds a checkbox to import columns (in debug mode) allowing a user to
create records M2O and M2M records not found (via name_search).

Task ID: 1850633

* uses a context key to avoid altering basically all the import callstack
* attempted to lift the creation in the `_str_to_*` functions and create
  m2m via commands, but that doesn't really work out
2018-08-16 11:10:35 +02:00
Stefan Rijnhart b3824aa6cb [RFR] Hide implementation of constraint definition storage, courtesy of Raphael Collet 2018-08-16 10:33:06 +02:00
Stefan Rijnhart 6327b8f97f [IMP] Store the original constraint definition as a comment on the constraint
and use it to determine if the constraint definition was changed. This prevents
endless readding of constraints that are reformatted by postgresql in an
unrecognizable way (in which e.g. "CHECK (credit*debit=0)" becomes
"CHECK ((credit * debit) = 0::numeric)")
2018-08-16 10:33:06 +02:00
Yenthe V.G 3e043ca49c [IMP] sale: add name on page elements for easier xpaths
Closes #25809
2018-08-16 10:25:54 +02:00
Samuel Piquet 0dc13eba62 [FIX] sale_timesheet: remove duplicate graph view
Was present twice

Closes #26062
2018-08-16 10:18:41 +02:00
David Arnold 5c95f71a34 [IMP] account: clarify error on bank statement
Before this commit, the error message was not very helpful as did not specify
which statement was problematic.

By giving the reconciled name/number, the users get's a chance to identify the
offending entry and correct it.

Closes #26356
2018-08-16 10:15:58 +02:00
Moises Lopez d790dfacb2 [ADD] sale: add menu to product categories
It was already present in the accounting and purchase application but not in
sale menus.
Apply the same logic as in purchase and use a group_no_one

Closes #22862
2018-08-16 09:59:01 +02:00
Alexandre Kühn 2ed4408e3e [FIX] mail: mark all messages as read from Inbox
Before this commit, there was a traceback when attempting to mark
all messages as read from the 'Inbox' of Discuss.

This is due to resetting the 'needaction' counter on threads that
do not not track 'needaction', such as the 'Starred' mailbox.
In fact, only channels do track them and handle a needaction counter,
so this should only be applied on channels.
2018-08-16 09:49:07 +02:00