As I was passing by I found some docstrings or helpers could be updated or
rephrased a bit more clearly. This is free as in free beers, without beers.
Some code about mail features (posting) may also be re-indented to ease
understanding of future modifications. Or just because we had to read
it and go through many files. Still free beers.
LINKS
Task ID-2477444
Prepares Task ID-2377974 (trace management cleaning task)
Prepares Task ID-2070632 (channel members main task)
Prepares Task ID-2419762 (channel members followup task)
COM PR odoo/odoo#67382
UPG PR odoo/upgrade#2245
Before this commit a cookie policy page was created every time the
website settings were saved with the "Cookies Bar" option enabled.
After this commit the policy page is created only if it does not already
exist for the website.
task-2454424
https://github.com/odoo/odoo/pull/67217closesodoo/odoo#67370
X-original-commit: 2f920e0023d29545d2957e5d6ca1619068af893b
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Before this commit the save snippet button appeared for the cookie bar.
But this makes no sense because the cookie bar is implicitly saved.
After this commit the save snippet button is not available for the
cookie bar.
task-2464233
https://github.com/odoo/odoo/pull/67217
X-original-commit: 439a7568b5b1e7d0aa53c63c7332dd22e3d6fc04
Issue
- Install 'website_event_track' module
- Go to settings and remove website favicon
- Save
Traceback is raised.
Cause
Trying to create image from favicon for app_icon,
but favicon not set anymore.
Solution
If no website.favicon, set website.app_icon to False.
opw-2451934
closesodoo/odoo#67367
X-original-commit: dfe1a6af4b7b740540270d38581f64aa37616222
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
If the company uses multi-step routes, when duplicating a MO, if the
user changes the BoM, one stock picking will be missing.
To reproduce the error:
1. In Settings, enable "Multi-Step Routes"
2. Go to Inventory > Configuration > Warehouse Management > Warehouses
3. Edit the warehouse "YourCompany"
4. Set Manufacture to "Pick components, [...] products (3 steps)"
5. Create a storable product SP
6. Create two non-empty BoM (BoM01 and BoM02) for SP
- (Hint: set a different reference for each BoM)
7. Create a MO
- Product: SP
- BoM: BoM01
8. Save, Mark as Todo
- (As you can see, 2 transfers have been created: one from WH/Stock
to WH/Pre-Production, and a second one from from WH/Post-Production to
WH/Stock)
9. Duplicate the MO
10. Set BoM to BoM02
11. Save, Mark as Todo
Error: Only one transfer has been generated. The transfer from WH/Stock
to WH/Pre-Production is missing. (The duplication step is used to
compare the result. If the user saves a new MO, and then edits this MO
to change the BoM, the same problem will occur).
When confirming the MO, the module runs both pull and push rules. When
running the pull rule, the modules assigns a stock picking to a stock
move. To do so, it checks if one stock picking already exists:
https://github.com/odoo/odoo/blob/7d9264c56ac725c8d19aebad55d5668df2a8c814/addons/stock/models/stock_move.py#L863-L873
Since such a stock picking does not exist, the module creates a new one:
https://github.com/odoo/odoo/blob/7d9264c56ac725c8d19aebad55d5668df2a8c814/addons/stock/models/stock_move.py#L887-L900
When changing the BoM, an `onchange` method is raised, deletes the stock
moves linked to the first BoM and creates some new ones. However, since
`group_id` is not a field required by the view
`view_stock_move_raw_tree`, this field will not be included in the
`onchange` response.
As a result, when saving the new MO, the `write` request does not
contain the `group_id` field, so the new stock moves do not have this
information. Therefore, when running `_search_picking_for_assignation`,
the module finds a picking and does not create a new one.
OPW-2444235
closesodoo/odoo#67356
X-original-commit: b810e5ff72b892983c52b24ca7efe5025c8a7142
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
Steps to follow to reproduce the bug:
-Go to sales
-Add a vat number with a '-' like: "123456789-5" to any customer
-Create a new SO
-Search the customer by entering their VAT number
Problem :
When the VAT number contains the character '-' you cannot find the customer with his VAT number.
The problem is the same if the vat number contains a '.'
Because, the "_name_search" method before creating the query to search clients by VAT number, removes all the special characters from user input
Solution :
Do not remove the characters '-' and '.' from the user input for the customer search by vat number.
opw-2457692
closesodoo/odoo#67355
X-original-commit: 3f54c1c7556c5d06759bf5ec74dd83872f0d24d2
Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>
Signed-off-by: Djamel Touati <DjamelTouati@users.noreply.github.com>
When a block is removed, the parent will be activated.
If the parent element is empty and removable:
1) It will be removed too.
2) In '_activateSnippet' method, we look for the right element to
be selected using the block's parent (removed from the DOM...).
The goal of this commit is to fix this behaviour by computing the
selected element before parent removal.
task-2431506
closesodoo/odoo#67354
X-original-commit: 1d483ab5e2f9bba0fd86c6fe4595a9959b2f125d
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Purpose
=======
Some computed stored editable fields are computed in the same method.
In that case, when one of the value is provided in a create / write call,
the computed method is not called and other fields computed in the same
method do not have the right value.
Task 2377119
COM odoo/odoo/pull/65772
ENT odoo/enterprise/pull/16221
closesodoo/odoo#67345
Forward-port-of: odoo/odoo#67017
Forward-port-of: odoo/odoo#65772
Related: odoo/enterprise#16894
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose
=======
Some computed stored editable fields are computed in the same method.
In that case, when one of the value is provided in a create / write call,
the computed method is not called and other fields computed in the same
method do not have the right value.
Task 2377119
COM odoo/odoo/pull/65772
ENT odoo/enterprise/pull/16221
X-original-commit: c9c64fa740fea31964f433a05d37a0f869b8e9d3
Purpose
=======
Some computed stored editable fields are computed in the same method.
In that case, when one of the value is provided in a create / write call,
the computed method is not called and other fields computed in the same
method do not have the right value.
Task 2377119
COM odoo/odoo/pull/65772
ENT odoo/enterprise/pull/16221
X-original-commit: c37ff784f2195325d770e41c70e24a0d1d0420c7
When we double click a form submit anchor, and depending on the selected
element before click, the selection range ("document.getSelection()") can
start from a parent of the targeted node. This will send a wrong range
to be used in LinkDialog widget.
The goal of this commit is to prevent this behaviour by adjusting the range
if it starts from anchor parent.
Note: the bug only occurred in Firefox.
Part of https://github.com/odoo/odoo/pull/62206
task-2381305
closesodoo/odoo#62206closesodoo/odoo#67171closesodoo/odoo#67176
X-original-commit: 9a16c313f131ed2e1017566a5f1bed134e22cc10
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
*: web_editor, website_mass_mailing
When we double click a link/button, a link dialog appears
to update the target properties, and since the current link dialog
can only handle anchor targets, using it on buttons leads to some
inconsistencies :
- visible href options for button & url required to save changes.
- missing preview when button style changed.
...
The goal of this commit is to add a fix (with minimum of code) on
summernote linkdialog to handle button elements using the same logic as
anchor nodes.
Also, update website form test tour to test those new changes.
Part of https://github.com/odoo/odoo/pull/62206
task-2381305
X-original-commit: 19fbbdc0327482b5d70bdbcf17c2a5a950327d63
currently, the expiration date of the coupon is checking based on quotation date
now in this commit, the expiration date of the coupon will be check based on the
current date and if the quotation date is before the starting date of the
coupon then it will show this coupon is not yet usable.
task-2229956
Closes#49187
Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>
create a SO;
Add a fiscal position;
Add a promotion of fixed amount kind.
Before this commit, the taxes of the promotion are the one of the
promotion product and not the one of the fiscal position.
Now, the taxes will be computed taken into account the fiscal position.
opw-2467966
closesodoo/odoo#67318
X-original-commit: 16dab7df5bb966219fa8798b77743149ad129572
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Before this commit, if we replaced an icon of the showcase snippet
with an image, this image was streched depending on title size (if too
long and on 2 lines). Its because the align-self default value of a
flex item is strech.
task-2447087
closesodoo/odoo#67244
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
When we want to send the invoice to the client, a hack was made in account_edi
to make sure that we put the XML of the electronic invoice formats as well, in
the case of web services such that the client has the XML we sent to the government.
For MX however, we also send the payment to the government. However when we wanted
to send the confirmation about the different changes, we still needed to add the XML
manually before this fix. Now it should be added manually even when manually composing
the mail to the customer with the payment receipt confirmation. (but we hope it dies)
closesodoo/odoo#67315
X-original-commit: 327852a6399a19191bd78c820971cc4108dc7821
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: Josse Colpaert <jco@openerp.com>
CONTEXT: Within a container, delete a block which has a sibling.
The actual behaviour is to select the container after deletion.
The goal of this commit is to select the previous sibling (if exists),
or next one. Otherwise the parent element will be selected (default behaviour).
task-2431506
closesodoo/odoo#64875
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
We only support int, following #c9edca7896e3096289936f5399a82f08a59b60ce
opw-2456796
closesodoo/odoo#67286
X-original-commit: a05a34366f6dc8c70b39c15c3441beaf6bbb72d2
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Before this commit, the states (collapsed/not collapsed) of the tabs
of the accordion snippet were not saved if it was the only changement
in edit mode.
After this commit, we trigger a content change when the states of the
tabs is changed.
task-2442237
closesodoo/odoo#67276
X-original-commit: 18af2ecade9482b5243059aefbfa79410ebf59a6
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Steps:
- Install account,payment
- Go to Invoicing
- Create an invoice
- Click Actions > Generate a Payment Link
- Follow the generated link
- Pay
Bug:
The transaction is not linked to the sale order in the link table
`account_invoice_transaction_rel`
Explanation:
This fix is broadly mimicking the behavior of the sales module regarding
the link of an order to a transaction, adding `invoice_id`s where they
are needed throughout the payment process in order to link the
transaction to the invoice.
opw:2451534
closesodoo/odoo#67296
X-original-commit: 7c6d06fa5858f79f3b22cdeaf74cdc26a642742f
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: backspac <backspac@users.noreply.github.com>
commit at each lead makes the system spend 80% of the time recomputing
bayesian probabilities. Avoid to commit too often speed up the process
while not altering final result.
Task ID-2475352
closesodoo/odoo#67275
X-original-commit: 34f6e38e68208b9509a429cdb09f8316a7ef566f
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Field vehicle_id is missing on the account.move.line view of refunds.
This fix updates the domain to make visible the field in in_refund.
Task ID: #2466914closesodoo/odoo#67269
X-original-commit: 97fb335e3f70a55b18685b9b6b08fe0162e1a17b
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
A previous commit (8dbd1efef899fb637acca3c318ae99cb23838b8f) fixed a
part of the basicmodel that used _.each to iterate on an object with
field names as keys, which does not work when a field is named "length".
To fix it, I simply used a native for ... in statement. However, I
missed the fact that there was a second 'return' statement in the body
of the closure given to _.each, so the onchange method returned
prematurely.
The fix is to simply use the continue statement in that case.
closesodoo/odoo#67267
X-original-commit: d9834e65ee57511f4850fa2d74287eb0b67087b9
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
The test is running in sudo mode, so we need to specify the company in
the search.
Also do not load the demo data when installing as we would do the work
twice for most localization.
closesodoo/odoo#67235
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
PR #66910 has been created so the MX can print their receipts.
Eventually, this needs to be reverted since printing a receipt is
actually illegal.
closesodoo/odoo#67209
X-original-commit: 7e9261cacd9f6963dca517fe7b1f3de067af1366
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
Currently, website_hr_recruitment(online job) is not auto
installed when hr_recruitment and website is installed.
So in this commit, auto install the online job(website_hr_recruitment)
when only website and hr_recruitment is installed.
so removed website_partner dependency from website_hr_recruitment as it's
not really needed. also make the website_hr_recruitment and
google_recaptcha auto install.
closesodoo/odoo#66737
Taskid: 2374617
Related: odoo/upgrade#2201
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Currently, user cannot group the timesheet by inv/so in portal view.
In this commit, add a group the timesheet by inv/so in portal view and
move the `view timesheets` button next th each sol to the top left pannel.
closesodoo/odoo#65932
Taskid: 2451359
Related: odoo/upgrade#2214
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
For example:
User A start a pos session.
Employee B, not related to User A, could close the session and have access to the back end as User A.
This commit also allows to display the select cashier popup correctly in mobile view.
Task-id: 2244289
Display a confirmation dialog when a user creates duplicate expenses.
Two expenses (or more) are considered duplicates when they share the same
date, amount, product, employee, company and currency.
closesodoo/odoo#64190
Taskid: 2368636
Related: odoo/upgrade#2061
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Before this commit, when the project is employee rate and the user sets
the sale order item to False in a task with this project, the linked
timesheets should have the sales order item to False, but if a
employee mapping is matched for this timesheet, the sales order item of
this mapping is given to the timesheet.
This commit checks if the sales order item in the task linked to the
timesheet and if no sales order item in the task then the sales order
item in the timesheet should also be empty (False).
closes odoo/odoo#67202
Forward-port-of: #67055
X-original-commit: a325e75a8565039d5120d169df67ef2d16c7fdc4
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
# Purpose
This PR's primary objective is to ensure that the timesheet uom is working in accordance with the company settings in a multi company environment.
Prior to this PR:
- The timesheet preferences sent to the front end were always those of the default
company of the user.
- The timesheet related widgets initialisation process (adding the correct ones in
the fieldRegistry) was performed before the front end treatment of cids and coockies
which prevented applying the front end selected company settings.
After this PR:
- A dictionnary is used in the session in order to structure the companies info.
- The company timesheet preferences are sent to the front end through the company dict.
- The uom info is sent to the front end through the session.
- The timesheet uom is now managed from the frontend and is now in sync with the settings.
- Timesheet widgets are initialised during the AbstractWebClient init and are in sync with
the multicompany front end settings
task-2168337
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
closesodoo/odoo#66551
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
# Purpose
General Marketing usability improvements based on what has been seen observing users on Fullstory.
As the changes are relatively minor and related to specific apps, the rationale and improvements will be explained in more details in each commit.
# Commits
##### [IMP] `base`: modify some displayed texts for res_partner
* Error messages when trying to delete/archive a partner linked to an active user
* Partner Form placeholders
* Update main_flow tour to be consistent with above changes
* Update test_orm to use a model with less functional constraints
##### [IMP] `mass_mailing_sms`: prevent raising an error in sms mailing
* Allow to launch a sms campaign without recipients without raising an error
##### [IMP] `mass_mailing`: add various usability improvements
* Mass mailing preview in a new tab (to prevent data loss when leaving the page)
* Data display adjustments (better wording...)
##### [IMP] `mail`: revamp the activity type form view
* Change "force_next" checkbox into "chaining_type" selection
* Update the Form layout and wording
* Renamed fields :
* default_next_type_id -> triggered_next_type_id
* next_type_ids -> suggested_next_type_ids
* default_description -> default_note
##### [IMP] `event`: improve the event form editor and update the tour
* Fix an undesired behavior with duplicate lines when switching event_type templates
* Remove steps from the event tour
##### [IMP] `web`: add an initial_date context key for CalendarView
* Add a context key ('initial_date') to the calendar view (to open it around a specified date)
##### [IMP] `crm`: add a reschedule action for activities
* Add a reschedule action alongside snooze 7d, for event-related activities
##### [IMP] `crm`: change the search order for a won stage
* In case "not won" stages are placed between "won" stages, put an opportunity marked as "won" in the correct stage (higher sequence if possible)
##### [MOV] `website_event`: move the website_event tour to tests/tours
* The scope of another tour (event_tour) include the scope of this tour and actually starts from the Event module. This smaller tour is thus disabled and kept as a test.
# Links
Task ID : 2410217
ENT PR : https://github.com/odoo/enterprise/pull/15406
UPGRADE PR : https://github.com/odoo/upgrade/pull/2167closesodoo/odoo#63370
Related: odoo/upgrade#2167
Related: odoo/enterprise#15406
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Prior to this commit:
- There were no tests on the timesheet_uom and the fact that the widget
that is loaded in the fieldRegistry is corresponding to the current
company preferences.
After this commit:
- Tests will be performed in order to check that the timesheet_uom that
is loaded in the fieldRegistry is corresponding to the current company
preferences.
task-2168337
Closes: #66551
This commit's primary objective is to ensure that the timesheet uom is working in accordance
with the company settings in a multi company environment.
Prior to this commit:
- The timesheet preferences sent to the front end were always those of the default
company of the user.
- The timesheet related widgets initialisation process (adding the correct ones in
the fieldRegistry) was performed before the front end treatment of cids and coockies
which prevented applying the front end selected company settings.
After this commit:
- A dictionnary is used in the session in order to structure the companies info.
- The company timesheet preferences are sent to the front end through the company dict.
- The uom info is sent to the front end through the session.
- The timesheet uom is now managed from the frontend and is now in sync with the settings.
- Timesheet widgets are initialised during the AbstractWebClient init and are in sync with
the multicompany front end settings
task-2168337
Closes: #66551
Before this commit:
- Some semicolon where missing
- There was a typo in the variable name
After this commit:
- The above problems are solved
task-2168337
Closes: #66551
Convert the override of method `power_on()` to an `@autovacuum` method.
closesodoo/odoo#67178
X-original-commit: f212223305a4d1da0f01f008c3874a72945fcae0
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Steps to reproduce the bug:
- Let's consider an included tax T (10%) and a product P (11€) with invoicing policy based on delivery
- Create a sale order SO with one line L with 2 P and T
- Confirm SO and deliver it
Bug:
The untaxed_amount_to_invoice was 40€ on L instead 20€
opw:2457660
closesodoo/odoo#67188
X-original-commit: 56d92277f20566d5b652ce713551970d0b7784c0
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Thibault Delavallée