Since saas-12.3, deferred actions use native promises. This has the
annoying side-effect of force-deferring promises even if they are
resolved at once... and we relied on the opposite behavior for some
call made in _setActive or option methods.
In master, we should review the async logic of snippet options. Right
now we will rely on the fact those promises are resolved at once but
that we need to avoid for their "async part" anyway. The _setActive
method and the option methods are thus still working synchronously in
stable, despite the new force-deferring promises.
Also, with old promises, when we waited for the resolution of multiple
deferred, the resolve handler received the multiple results as
individual arguments. Now it receives all the results in an array as
a single argument. The resolution of action demands had to be adapted.
closesodoo/odoo#39171
X-original-commit: 30d15315a73c1fa34ada86371b06c02b6375db89
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
The default `compute_sudo=True` makes sense for recomputing stored
fields that are indirectly related to a business operation. This
ensures that the recomputation of the field does not break an operation
that is not aware of the fields to recompute.
However, computing non-stored fields in superuser mode is usually not
necessary. It even leads to unexpected values: counting a partner's
sales orders does not give the same result in superuser mode as in
normal mode. That is why non-stored fields are not computed in
superuser mode by default.
[FIX] account, delivery, event, hr_recruitment, point_of_sale, stock:
adapt the model definition to make all fields with the same compute
method have the same value for `compute_sudo`.
[FIX] sale: split the computation of `invoice_ids`, `invoice_count`
(non-stored) and `invoice_status` (stored), as no code is actually
shared.
closesodoo/odoo#39195
X-original-commit: 843fd38a97f02b49dc09d7f55919072d272fd80e
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
The basic ORM methods should not silently discard unknown fields, as
they may be a sign of broken code.
X-original-commit: 9595dd06a1d349b2fb84969374d57c32a5faab74
Before this commit, having a `customize_show` on an ir.ui.view record in a
theme module would be ignored when creating the theme.ir.ui.view as the field
would not exists.
Actually it would log a warning on create (module install) and raise a
traceback on module update (theme update).
closesodoo/odoo#39216
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Was comparing b'0x02' and '0x02'
closesodoo/odoo#39214
X-original-commit: 838cb0e8c10de4229c8b04592aefa1808771bbb3
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
This commits fixes user duplication.
Suppose there is a monetary field, with a currency_field that is a related.
When going through model's _create, we do:
`if field.type in ('one2many', 'many2many'):
self.env.cache.set(record, field, ())`
knowing that thse values are false, with the intent to clean them later:
`for record, field in cachetoclear`
However, when setting the scalar values, we go through:
`accessing cache_value = field.convert_to_cache(value, record)`
In the case of the monetary field, this depends on another field value
(the currency_field). If it is a related, we can access its value.
However, at this point, if we check any access rights, we might use the value
of a relational in cache for which the value is incorrectly set to False.
In the case of the user, this is what happens: it inherits its currency_id
from partner, as well as its debit_limit which depends on it.
When the access if checked, company_ids is set to False in cache.
So when going through the rule 'user rule', which checks that the company_ids
intersects with the env.companies.ids, the result is always False.
In some way this is essentially hiding the problem, but the true fix is
probably not feasible in stable.
opw 2086661closesodoo/odoo#39017
X-original-commit: aa05a9359b42317261c8e7ffcadbeb9fe74dcd58
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
When marking as done a MO, we use SUPERUSER to create analytic line
as an MRP user does not always have access to analytic items. There
is however a default value for company analytic line defined to the
user's context company, so we need to use the current company of the
real user instead.
closesodoo/odoo#39209
X-original-commit: 14aade9341bf9d61cd21de948755fc339ae512ea
Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>
You need to provide a small part of the code, because to avoid fraud, google
make several request to be sure that you don't allow all codes :)
So the 'WPS' solution was dropped, now we take the first request from google
that match the part provided, as the good one, and refuse all others requests.
task-2086915
closesodoo/odoo#39186
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Chart of Accounts (COA) Template for Lithuania's Accounting (VAS-15).
Data is multi language (English and Lithuania).
This module also includes:
* List of available banks in Lithuania.
* Tax groups (to map different tax amounts).
* Most common Lithuanian Taxes.
* Fiscal positions for different countries/groups.
* Account Tags used for reporting purposes.
closesodoo/odoo#39187
X-original-commit: 888245f1a4307bd626cb5f55a3dff09898254790
Signed-off-by: Josse Colpaert <jco@openerp.com>
In deliveries slips, you can directly create a new serial number.
If you have multiples companies, a field "company" appears.
But if you have only one company, it doesn't appears and there is
no default value for it.
As the field is required, it returns an error "Company field required".
Before this commit:
- The company_id field in stock_production_lot model does not
have a default value.
After this commit:
- The company_id field has a default value which is the user
current company id.
OPW-2083099
closesodoo/odoo#39170
X-original-commit: 7b6d87519d3ba50688f9f49442cc3814ee427816
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Start odoo-bin using a tier module (like `python3 -m pdb odoo-bin`), the
odoo/addons __path__ contains the relative link to the modules instead
of the absolute link like when directly started (`python3 odoo-bin`).
This cause trouble importing modules because it reuses the relative path
from within other directories.
closesodoo/odoo#39182
X-original-commit: 941e051fc6b33e7a90400c77d63d589049b027a6
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Since commit https://github.com/odoo/odoo/commit/dba478332681dd21a39c4a183c002b1cf6e046d2, a survey can have questions with no section
associated, which means 'page_ids' field will be empty.
This prevents to display some questions of a survey, as we are
still expecting a structure page/questions. To solve it, we first
append questions with no sections, then all other questions.
closesodoo/odoo#39113
X-original-commit: 149657cfd696e5065b55519927973fa785cc0e22
Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>
This fixes a regression introduced by 291a0e99d137142bd24addd1054c1357ddd7125a.
closesodoo/odoo#39178
X-original-commit: 852ee32e3419c210a3844b0f943af8dd2bbdae88
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
With Anglo-Saxon accounting, invoices with stock_moves on a product
having 'real_time' valuation cannot be validated: there is a user error
when the interim account is not reconcilable.
We modify _anglo_saxon_reconcile_valuation so that we do not try to reconcile
when the account is not reconcilable.
OPW-2080180
closesodoo/odoo#39167
X-original-commit: 7174bd2f508f33454b7167de7d01ca8824404bf9
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Due to commit odoo/odoo@f4031c62f9
it was not more possible to scroll in a grouped kanban.
Steps to reproduce:
* Go to project app
* Select a project with a few numbers of task
* Create as need new task to have more task than visible on the screen
* Try to scroll (BUG)
Note: we also fix the swipe in empty column
opw-2080491
closesodoo/odoo#39168
X-original-commit: 023941e25cae34e60eaabcc54841b3d908a59414
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
set current assets or current liabilities type insted of Podatki
Fixes#38004closesodoo/odoo#38902
X-original-commit: d67f1397d1c018035412be9b3d9871183fbd8a1a
Signed-off-by: Josse Colpaert <jco@openerp.com>
As this wizard only shows the first product overprocessed and does nothing else,
we remove it completely for cleaning purposes.
task-1938108
closesodoo/odoo#39161
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
*:
delivery
hr_timesheet
mrp
sale
sale_coupon
stock
This commit makes the static strings / labels editable with studio
by wrapping them in appropriate tag (mostly span) whenever needed.
Task-Id 2030430
closesodoo/odoo#34685
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
The issue here is, for modal dialogs (eg newsletter popup), when we close
the dialog, the modal is destroyed and so after the delayed execution due to
timeout, the dialog will not be available and it will generate the issue.
removed delayed execution for the traceback, which is relevant to
the modal dialogs.
task-2075232
closesodoo/odoo#38914
X-original-commit: 93deb25f873f5c4aba239b050e543b23685f5ba0
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
The issue here is, the modal for the newsletter is part of the editable area,
and when we click on the 'close' button of that modal, it is destroyed but the
'summer note' tries to bind the events related to the button(because close is a button).
fixed the traceback, to disable invoking 'summer note' events on click of
the 'close' button on modal
task-2075232
X-original-commit: 110ea837903f3e6c67c1d0e0081073edea8852d1
The XML file homepage view record is not supposed to be deleted as it is used
to bootstrap newly created website.
If that view is deleted, everything's fine. But if that view's page is not
found (m2o link broken somehow), then the code would crash.
This would only appear if the user is playing in the backend in technical but
it seems to happen more than it should.
This commit will prevent the code to crash in such a case.
Step to reproduce:
1. Go to settings > technical > views (debug)
2. Find the xml homepage view (with xml_id)
3. Go to its website.page and break the m2o view_id
4. Try to create a new website, it will crash
opw-2081894
closesodoo/odoo#39149
X-original-commit: 1d4dd200c664b99dbdb3e65e3950be1cb5e79a0a
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Those tests were raising an assert error if the DB has other websites than the
data/demo ones.
As we have a new module in Odoo 13.0 (odoo/design-themes#178)
which is creating 25 websites, and since the design-themes runbot is now
running tests, we were having a red design-themes runbot.
closesodoo/odoo#39145
X-original-commit: 67df6b91ddb6cb83d558137691481f50834f7fca
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
With this commit, when an ecommerce order is judged abandonned (more than 4
days without being touched, and in draft), we remove its coupon so it is
available again.
task-2058666
closesodoo/odoo#37441
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
New performances test looks non deterministic, sometimes break with
28 queries instead of 25. This commit temporary pump up query count
to avoid staging fails, further investigation is needed.
closesodoo/odoo#39132
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Before this task, when the user arrived on his profile,
some empty sections didn't had any call to actions
task-2080615
closesodoo/odoo#38029
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
after paypal onboarding, merchant email and pdt token
is not required at all, for the new users.
They can accept payment with just email address.
closesodoo/odoo#39127
X-original-commit: 05533cd59fbfdafa79f57987f17a6761f8237a3b
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
Do not return a boolean but skip bad translations
Introduced at 19e50ea374Fixesodoo/odoo#39001
At least fix the error that is thrown, however, this does not solve
the initial error of trying to export the terms of a record that is no
longer present in the database.
As this issue is no longer reproducable, just log a warning as it was
expected.
closesodoo/odoo#39122
X-original-commit: 5c0677bf2fbf6d18978989f1ee70e4a0946da035
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Go on a kanban view with a scroll bar
scroll all the way down
Open a record in form view
Use the breadcrumb to go back to the kanban
Before this commit, the kanban was re-opened
but the position were we were before opening the record was lost
This was due to 40dd121938
which refactors the dom, puting the action manager on top of controllers
After this commit, when re-opening the kanban, we end up at the same position
we left it at
OPW 2074077
closesodoo/odoo#39120
X-original-commit: c0d48878c452b256859f067186567c126d8de27e
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Install l10n_it_edi, try to import an italian e-invoice (xml). Odoo will create
2 invoices, one draft with the attachment but empty, and another one
with the parsed content of the file.
This happen because the module responsible for the import systematically
create a new invoice instead of reusing the open one.
opw-2089521
closesodoo/odoo#39115
X-original-commit: 45984f8d83a2aa97714ffcca32f690a58cc6328f
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Fine tuning of c351f00
In the POS module there is the possibility to print receipts.
Before this commit:
- The currency symbol appears in the receipts but not in sublines
and discount
After this commit:
- The currency symbol appears in the receipts but not in sublines
OPW-2083188
closesodoo/odoo#39114
X-original-commit: 6a22bb1e4e917a27b41290824fec86718935d864
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
At the moment the weight is read from all scales automatically. The
problem is that Adam scales beep every time we read the weight, making
them almost unusable in a shop. We set the manufacturer on the IoT
Device to be able to identify those scales and get the weight manually
instead of reading it automatically.
closesodoo/odoo#39107
Taskid: 2089995
X-original-commit: 5bde93951b29c18d8361bd5ca759a8b2e190573a
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Lets say we have 2 payment references on our invoices:
* `45 RE34Y U0000 00000 02019 00014`
* `45 RE34Y U0000 00000 02019 00022`
A customer pays with the communication: `45 RE34Y U0000 00000 02019 00014`
Before this commit, the query in _get_invoice_matching_query was looking
at the invoice number, the invoice line label, and the vendor reference
all the same way; it was never looking specifically at the payment reference
(which is copied on the receivable line).
This was an issue because the matching was done by keeping only the
digits, grouped by word. If at least one group of digit matched, then
the statement matched with the line.
In our example, both invoices were proposed because `45`, `RE34Y`,
`Ù0000`, `00000` and `02019` matched. (one is enough).
The fix consists of ignoring the lines that match with the number, label
and vendor ref if we find an exact match with the payment reference.
closesodoo/odoo#39102
X-original-commit: 35339bc24b52788e18b57a49f3a0d948f9e466b8
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
- ensure a valid image was given or prevent to save it otherwise, instead of
allowing any file, which would then crash at display
- restrict to a reasonable size
PR: #38292closes#38026closesodoo/odoo#39098
X-original-commit: 92eafdf7e283e5474b1da2c88cfbdebbee17b48e
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, if `max_width` and `max_height` are 0, the image would not
be opened by Pillow at all (to gain a bit of CPU) however this was actually a
bad idea in this case because then we don't ensure the given value is actually a
valid image when we save it, only later at display we notice it and it crashes.
This optimization only made sense when `image_process` is called many times,
from the route displaying images every time a visitor is requesting an image,
for example. It doesn't really have an impact for one time operations such as
creating/writing.
So when size parameters are 0, which is the default, another parameter must be
passed to `image_process` to ensure image validity, and `verify_resolution` is
actually built for this, as it does the minimal amount of processing:
- loading the image
- making sure it is valid
- and ensuring the resolution is not completely crazy (`IMAGE_MAX_RESOLUTION`).
It doesn't alter the original image if no other operation was requested.
Pr: #38292
X-original-commit: e16c36bb4bfa3ae1739712c69c72849665a057dd
Binary fields are supposed to be saved as binary in cache, and not as string
which is also supported as an input value.
Pr: #38292
X-original-commit: 64e0d106adccd8132cbfeb6b60da74b3feaf05e1
The compute methods are always expecting the real value and not the bin_size.
The solution is to always compute with `bin_size=False`, and then manually
compute the `bin_size` and set it on the cache of `bin_size=True`.
PR: #38292
Co-authored-by Sébastien Theys <seb@odoo.com>
X-original-commit: 7744886d6141ca7971d91807d0444c707e10fdf8
Since commit https://github.com/odoo/odoo/commit/dba478332681dd21a39c4a183c002b1cf6e046d2, a survey can have questions with no section
associated, which means 'page_ids' field will be empty.
This prevents to display the analysis results of a survey, as we are
still expecting a structure page/questions. To solve it, if a question
does not have a section associated, we use an empty page instead.
closesodoo/odoo#39087
X-original-commit: 45c2964c1cfd07cabfa6a1a1b8e796bea4c521d7
Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>
This commit adds a button in the certification card in the profile page.
this button opens the share modal and allows to share to social networks
the course linked to that certification.
Task ID : 1950396
PR #31776
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
fw-bot