On browser refresh, the bus sends the last notifications for the last
50secs. This is really annoying to deal with, especially in the chat
applicatiion. This commits ensure that duplicate notifications are
ignored. This is done by saving the id of the last notif in the local
storage.
Note: it is also necessary to clear the last message id in the local
storage to prevent problems when a developer resets his db, and will not
receive any notifications.
The problem was that the tab_manager compared its last heartbeat value with an
old value stored in the local storage (when being elicted master, the tab
writes a new heartbeat in the locat storage).
This solution makes sure to compare the actual value in the local storage with
the heartbeat value stored in the tab_manager.
Marking a message as read in the inbox doesn't remove needactions on all
channels anymore.
When joining a channel (other than the inbox) in which there are needactions,
those needactions are automatically marked as read and removed from the inbox.
When the user clicked on Undo in the snackbar, the messages weren't correctly
re-inserted in the inbox (in the JS cache).
When a warning is triggered by an onchange, clicking on "Save & Close"
will cause the warning to be closed as soon as it is shown. This fix
prevents the saving and closing if a warning message is detected.
opw-653503
`_bom_explode` expects a `product.product`,
not a `product.template`
```
@param product: Select a particular variant of the BoM.
If False use BoM without variants.
```
This `product` attribute is used in the method `_skip_bom_line`,
which get the `attribute_value_ids` of this `product`.
This field `attribute_value_ids` is available on
`product.product` only, not on `product.template`
opw-656061
The policy regarding the editable lists is:
- In a one2many list, editable bottom
- In a list, editable top.
So, when you hit the add an item (one2many list) / create (list),
you do not have to scroll a lot if there are a lot of lines.
opw-656363
When unfollowing the last followed subtype, a confirm dialog is shown to the
user to confirm that it will unfollow the document. If he clicked on 'Cancel',
the unchecked subtype wasn't correctly re-checked.
When creating a team.user record, there was an error to generate an url
for the image because the attribute "__last_update" didn't exist
on the record.
opw:653725
- put the mentionned partners and the attachment above the composer
instead of below
- debounce some links in thread.js to prevent double loading views when
double-clicking
- readd the # in front of the channelname of the title of the client action
- give the channel_id to the thread in a chat window, so it does not
display the channel name everytime it displays a message
- correctly close dm chat window when the dm channel is closed in the
main sidebar
- simplify the help messages when a channel is empty
Mainly concern the client action:
- Display needactions per channels
- For all channels except Inbox, clear needactions when opening the channel
- Add snackbar to undo needactions clearing
- Display a separator between read and unread messages in threads
- Fix active channel (for Inbox and Starred) display in sidebar
Various minor changes in chat_manager:
- Code refactoring of bus notification handler
- get_channel() don't fallback anymore on first channel
When moving lots, we should also take into account the information on the
pack operation: specific location, package to take it from and owner.
Also, in the get_preferred_domain for the pack operations, when not giving any pack,
we should check the quant is not in a pack. It is also better to copy the list
to avoid that the constraints added to the list would get into the next call.
Make sure to unreserve all quants before assignment. Indeed, the method
makes this assumption and does not take into account any existing
reserved quants. Therefore, without this fix, there is a possibility to
reserve more than needed.
opw-653904
The method get_salenote does not exist anymore. It is not necessary
anymore since the note is already translated in the appropriate language
on the SO.
opw-653600
The POS will asks the user to confirm certain things that could be a
user error. Examples of this are attempting to validate an order with a
very big payment compared to the amount to pay on the order. Another
example is paying an amount of 0 for an order with a total amount to pay
that is negative (manual refund).
The issue was that pos_mercury overwrote validate_order(), and didn't
call _super() correctly, losing the user confirmation for these type of
actions.
ir.actions.wizard were removed in 8.0 with a32bf72 (oct. 2013), but
they were still present in the interface to add a menu.
This fix removes them for good, and is only done in 9.0 since the
remains of existing ir.ui.menu with an ir.actions.wizard action should
be minimal.
opw-654215
- display star/mark as read icon next to the message title instead on
the far right
- display unstar all message in channel starred
- enable/disable the 'unstar all' and 'mark read' buttons depending on
the number of messages in the corresponding channels
- display star on the left sidebar in 'squashed messages'
- tweaks to padding in client action
- display hash in channel name in lighter tone
- light opacity in sidebar
- star icon in message sidebar is clickable + small less refactoring
- message sidebar is aligned with the message now
- messages are not squashed in inbox/starred
When we refresh, the bus will send the last notifications since the last
50s, so, the browser will receive notifications from a channel that we
already left. This commits tries to fix the issue by sending
explicitely the information that a channel was unsubscribed.
Also, and this is touchy, it ignores messages received in a channel that
it is not subscribed to (before, it joined the channel)
Also, it will synchronize channels opened and closed in various
tabs/browsers.
The issue was that the chat_manager was an async js module, so it could
be loaded quite late. Then the client action was loaded only after the
chat_manager was ready, and possibly before the action_manager read the
value in the action registry.
This commits prevent this problem from happening by turning the chat
manager into a sync module, so the chatter and the client action needs
to wait for him to be ready before doing their magic.
The bus is somewhat tricky. (at least, the crosstab version). It needs
to elect a leader, and to communicate with the server through it.
However, several tabs have a different event loop, so, we need to be
careful to avoid race conditions. The current version was not
race-condition-proof, and this commits improves on this.
The idea is to allow the bus to detect if some other tab is also
considering himself master. In that case, it is allowed to unelect
himself.
This should allow the bus to self correct those situations in a short
time.
The color field of a product.attribute.value enable users to choose a
color with its HTML color value (hexa, named, rgb, rgba).
In the many2many tags the color field on the model has a magic feature
which color the tag in several instances. But these color are numbered
from 0 to 10 and are incompatible with HTML color values.
So with with the model product.attribute.value, the many2many tags
widget would use the color system (since a field name color exists), and
when setting a color with it, it would be invalid and erase the wanted
named or HTML value color.
This fix ignore the setting of the tag color for this particular model,
a following fix (in master) should rename the column to properly fix
this.
opw-653124
Add ACL on resource.calendar.attendance for HR Officer
according access right on resource.calendar
Otherwise, this isn't possible for HR officers to
manage Work Details (`resource.calendar.attendance`),
while they can manage Resource Calendar (`resource.calendar`)
Closes#9330
When clicking on button "add_to_cart" for a product with several options,
the user must be redirected to the product page. In this way, the user can
choose the options, he wants to buy with the product before adding the product
in the cart.
opw:653356
Generalizes the mention mechanism to allow mentionning partners (@) and
channels (#).
When a user clicks on a mentionned channel, it subscribes to it and joins it.
If the mention is in a chatter, the user is redirected to the Discuss client
action.
Moves the RPCs to get the menu and action id of the Discuss client action from
systray.js to chat_managaer.js as they are now needed in the chatter as well.
Also fixes the on_channel_clicked redirection for notification message
(created/joined/left #channel). Those three messages are now of type
notification, and correctly redirect on click.
The options dictionnary given when performing a do_action is now transmitted
to the client action initialization.
This was required for the mail client action, to correctly redirect to a given
channel.
- display hash before text in create channel input
- increase limit for message fetching from 20 to 100
- 'Show more messages' renamed ino 'Show older messages'
- remove border top and bottom on selected messages
The messages dates in the groups pages
- /groups/<model('mail.group'):group>/
- /groups/<model('mail.group'):group>/<model('mail.message):message/
Did not take into account the user timezone, and always displayed
the date in UTC time.
opw-653508
Currently server side there is two differents source for html content
displayed on a qweb rendered page:
1) ir.ui.view arch value
are stored as xml and are unescaped before being displayed, so we have
to escape the text nodes before saving.
e.g:
* should be stored as &nbsp; since it is an HTML entity but
not a defined XML entity,
* & should be stored as &amp; since when unescaping it, it
would become & which is invalid in HTML,
* < should be stored as &lt; since when unescaping it, it would
become `<` so HTML text node could become HTML element node.
The tag themselves can also be escaped but it often has the same result:
<em&;gt;blah</em> is the same as <em>blah</em> when unescaping
is applied to both.
But it is required is some instance, e.g <!DOCTYPE html> unescaped would
be invalid xml.
2) openerp.fields.Html value
are stored directly in HTML formatting and should, conversely, not be
escaped before being stored.
Thus when saving an ir.ui.view part modified thanks to the website
editor, an escaping of text node content is carried out to take this
into account, but the same was currently not done for the v9.0 new
translation system.
This commit apply the same logic when saving ir.ui.view as when saving
ir.translation values.
Géry Debongnie