Commit Graph
135729 Commits
Author SHA1 Message Date
Sébastien Mottet (oms) cd9dfc9da4 [IMP] base_setup: some changes in settings display
- Hide statistics section when empty
- Change order of two options in Integrations section
- Change label users to permissions to avoid duplicated label

Task ID: 2214425

closes odoo/odoo#48362

Related: odoo/enterprise#9491
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-05-06 12:54:39 +00:00
Urvi Soni 33f7a1f9a7 [FIX] hr_timesheet: Hide remaining hours tag on task kanban if allow_timesheet is false
Currently, when the project have the 'allow_timesheet' false even though
it will display the remaning hours tag in task kanban view.
so purpose of the task is hide the 'remaining hours' tag if
allow_timesheet is false.

So after this commit, Hide 'remaining_hours' tag on task kanban view
if allow_timesheet is False.

closes odoo/odoo#50754

Taskid: 2243305
Closes: #50357
X-original-commit: daa75ea5f217010deb4cb5937747f37ab533bcd6
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-05-06 12:31:07 +00:00
Swapnesh Shah 6054f60d51 [FIX] resource: display hours with float_time widget
closes odoo/odoo#50750

X-original-commit: 1bb0f50bf6a04c93b144d889fe1faecfca949c92
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-05-06 11:59:12 +00:00
Nicolas Martinelli a4b52411cc [FIX] stock: correct misleading tooltips
The tooltips are incorrect and lead to wrong expectations on the
behavior.

opw-2249152

closes odoo/odoo#50746

X-original-commit: bf1d83dd310983c3f3270bf7a7f5c03128fb0993
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-05-06 11:17:04 +00:00
Kevin Baptiste 14807da76e [IMP] project: hide 'View Task' in email
Hide the View Task button in the emails sent to a task's followers based
on the project's privacy settings.

closes odoo/odoo#49021

Taskid: 2230189
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-04-15 10:10:11 +00:00
Nicolas Martinelli 6bc3b30371 [FIX] mrp: Sub BoM
- Create products P1 & P2
- Create a BOM for P1
  Operation O1
- Create a BOM for P2
  Use 1 unit of P1
  Operation O2
- Open the 'Structure & Cost' report for P2

The BOM of P1 is not taken into account in the report.

This happens because a 'Sub BoM' must have the same Operation than the
parent (or no operation set).

There is no real functional reason for this, so we remove the
limitation.

opw-2246370

closes odoo/odoo#50743

X-original-commit: 5d3e88aa919a69ad54076637e72b880552e2a0be
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-05-06 11:14:35 +00:00
Adrien Horgnies 06c0600ba9 [ADD] l10n_fi: Finnish localization module
Task ID : 35180

closes odoo/odoo#50506

X-original-commit: 651a360881e99534f6ee9f8f14dd732519cbbe44
Related: odoo/enterprise#10324
Signed-off-by: Josse Colpaert <jco@openerp.com>
2020-05-05 10:35:05 +00:00
Urvi Soni 8f0f204afa [IMP] hr_timesheet: Remove default groupby from 'My/All Timesheets' menu
Currently, The 'My Timesheets' and 'All Timesheets' action has a
default groupby on project_id and task_id and the timesheet gridview
has the same grouping defined in the view architecture so the default
action grouping therefore only makes sense if we want the other views
of the action to be grouped as well, and we do not want that.

So in this commit we removed  the default_search_groupby* from action
of 'My Timesheets' and 'All Timesheets'.

Also remove the group by filter employee & department from
my timesheet menu.

closes odoo/odoo#49910

Taskid: 2230634
Closes: #49910
Related: odoo/enterprise#9694
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-05-01 07:10:04 +00:00
std-odoo 0ef207cff9 [FIX] mass_mailing: remove duplicated JS file import
If a user wants to unsubscribe from a mass mailing, he will get a traceback
when doing so. This is due to a file being imported twice. Indeed unsubscribe
file is imported in mass_mailing.layout that calls assets_backend that already
imports unsubscribe.

It seems there is no traceback in 13 but well in 13.2. However we can clean it
in 13. It has been introduced at f296992317 .

Task-2241443

closes odoo/odoo#50722

X-original-commit: 521eb273ce792eb99631fe34faf7d512e3b59a8e
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-05-06 09:17:56 +00:00
Swapnesh Shah c3184e7993 [FIX] hr_attendance: remove unnecessary view modes
Commit 6d11097a9b added view mode `tree,activity` in this action which is not necessary for Attendance Kiosk mode. (and also not working when selecting an employee from `tree` view)

With this commit, we remove extra view modes which are not required/working for this action.

closes odoo/odoo#50528

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-05-03 17:12:16 +00:00
Andrea Grazioso (agr-odoo) 5e94c70541 [FIX] sale_coupon: fix _remove_invalid_reward_lines check
Create a coupon program with:
- Minimum purchase in currency (ex 100$ tax excluded)
- Fixed discount applied on order (ex 100$)
Generate some coupon.
Go to shop. Fill an order with amount slightly above the minimum
required by the coupon (ex. 125$). Apply the coupon.

Nothing occur to the cart: the coupon is applied correctly,
but when the cart is refreshed it will check for any non-applicable
promotion against the current order state (125$ - 100$ = 25$, since
the coupon check is for orders above 100$ the promotion will be removed).

Fixing the condition in '_get_no_effect_on_threshold_lines' to detect
also coupon lines in order to make the fair computation.

opw-2224169

closes odoo/odoo#50694

X-original-commit: 2f733ba85320dd67c6892f6a56e3680a3b2fbb50
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-05-05 16:14:07 +00:00
Goffin Simon 57abcab99b [FIX] im_livechat: Traceback on Safari and Chrome mobile
Steps to reproduce the bug:

- Install website_livechat
- Go to login page on mobile with Safari
- Click on "Have a Question?"
- Close the chat by clicking on the arrow

Bug:

A traceback was raised

Ref:https://stackoverflow.com/questions/19359326/json-parse-fails-in-safari-when-a-string-value-contains-a-comma

opw:2243871

closes odoo/odoo#50715

X-original-commit: 99a5e7c2159f8db3e1ce65f9225f0ce18cc28d70
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2020-05-06 08:34:59 +00:00
Goffin Simon aa0444e3de [FIX] account: Wrong tax amount with Python tax code
Steps to reproduce the bug:

- Create a new tax T based on python code, leave the code how it is by default (result = price_unit * 0.10)
- Check included in price
- Create an invoice, add a customer, add a line with random label, assign unit price = 100 and select tax T.

Bug:

On the invoice, the Untaxed Amount =  90 and Taxes = -10 instead of 10 (like the behavior in 12.0)

opw:2242188

closes odoo/odoo#50567

X-original-commit: c704611f7cceee516718f16610838af930709022
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2020-05-04 14:56:55 +00:00
Ravi Singh c96edead36 [IMP] project: improve responsiveness of description.
In this commit- we have improved responsiveness of description when it's too long
in projects and tasks inside the portal.

task-2124829
Closes #48402

Related: odoo/enterprise#9497
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2020-04-16 06:21:51 +00:00
Ravi Singh 6ef2e1d3ec [IMP] account: invoice view improvement inside portal.
In this commit- we have added filter options like bills and invoices in
for invoice view(portal side) .

In addition, we have changed sort by option's string from 'Invoice Date' to 'Date'.

task-2124829
Closes #48402
2020-04-16 06:21:51 +00:00
Ravi Singh 9bfce9a999 [IMP] purchase: revamp of purchase order view inside portal.
In this commit- we have changed purchase order view(portal side) and included
sidebar and chatter just like so view.

task-2124829
Closes #48402
2020-04-16 06:21:51 +00:00
Nicolas Martinelli 1b70a132d3 [FIX] mrp: wo state when changing qty
- Create a product P
- Create a BOM:
  Use 1 unit of C
  Routing with 2 Operations
  Start Next Operation: 'Once all products are processed'
- Create a MO for 10 units
- Process the first WO
- Scrap 2 components, produce 8 units in the first WO
- In the MO, change the quantity to produce to 8

The first WO is done, the second WO is still waiting for the previous
one to finish.

We change the state of the next WO.

opw-2244166

closes odoo/odoo#50690

X-original-commit: 8a723f0f104e64d336764431ea15eb3166cc52b7
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-05-05 15:35:48 +00:00
Nicolas Martinelli 02ccba232e [FIX] mrp: putaway on byproduct
- Create a product P
- Create a BOM for P
  Use 1 unit of C
  Produce 1 unit of byproduct B
- Create a putaway strategy for C
  From: Stock
  To: Shelf 1
- Create a MO for P, perform until the end

The product C is sent to Stock instead of Shelf 1.

When the stock move line is created, the putaway strategy is simply not
applied.

opw-2242987

closes odoo/odoo#50687

X-original-commit: 49ffdfb6ecbdf11ee1dc85ef494df515f249466e
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-05-05 15:32:26 +00:00
Swapnesh Shah e3b4eac59b [IMP] hr: in plan, display activity name when raising the error about unassigned activity
Before this commit, the user was not aware of the activity for which
configuration is missing. In this commit, we display `Activity name` in the
warning to helpfixing configuration.

Based on Feedback at https://github.com/odoo/odoo/pull/44922#issuecomment-584057134

closes odoo/odoo#50529

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-05-06 06:24:51 +00:00
Goffin Simon 3c2a2f7aa3 [FIX] stock: Internal note displayed in Delivery slip
Steps to reproduce the bug:

- Let's consider a consumable product P with an internal note IN in Dutch
- Create a SO with dutch partner P and confirm it
- Process the delivery and validate it
- Print the delivery slip

Bug:

The internal note IN was displayed on the delivery slip.
The internal note must never appear on a delivery slip.

opw:2227613

closes odoo/odoo#50689

X-original-commit: 4b8d9806c6ee0a85812041f25080617daa7b10f1
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2020-05-05 15:35:26 +00:00
Goffin Simon 9b33848ad9 [FIX] website_crm_partner_assign: Traceback in Partnership Analysis
Steps to reproduce the bug:

Go to CRM > Reporting > Partnership Analysis
Group by > Add Custom Group and select Invoice Account Date

Bug:

A traceback was raised

opw:2249977

closes odoo/odoo#50688

X-original-commit: 00fb1d7972057451dd0c58eb12b70fead5944aa6
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2020-05-05 15:35:05 +00:00
jvm-odoo 0230d78cb0 [FIX] sale_product_configurator: fix mobile product template search
Issue

	1. Install Sales
 	2. In the Sales settings activate "Product Configurator"
 	3. Create a product with variant set as "dynamic" (with dummy attributes)
 	4. Switch your browser view to the mobile view (using dev tools)
 	5. Click the order line "Add" button
 	6. Click on the product form
 	7. Search for your product of step 3.

	-> The product of step 3. does not shows up !

Cause

	The view used for mobile is the order_line form view in
	the view "view_order_form"

	This view uses product.product instead of product.template
	because the widget is not the same than the tree view.

Solution

	Use the product_configurator widget instead when
	the module is installed.

OPW-2214095

closes odoo/odoo#50695

X-original-commit: 14a79045ee21a72d78f0fff0495552a8bd834ba4
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
2020-05-05 16:17:41 +00:00
Mathieu Duckerts-Antoine dda171300f [IMP] account: adapt search panels to new counters
Record counts are now also available for field with select="one"
attribute. In the module account, the counts should not be displayed
since the search panels have to be quite thin. We then disable them.

closes odoo/odoo#44490

Related: odoo/enterprise#8113
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2020-05-05 19:23:20 +00:00
2c102c292f [IMP] web: search panel counter changes
This commit introduces several changes in the search panel with
respect to record counts:

    - the record counts are now also available for
      the fields with select="one" attribute
      (if not disabled explicitely).
    - the record counts are better computed using the idea that
      selected values within a group should not impact the counts
      for the group values but only the counts for the other
      group values.

On the way we have changed two keys in the values returned
by the server:
    - 'count' becomes '__count'.
      It has been done to avoid a possible clash in case a model would
      have a field named 'count' and that the field values would be
      wanted for some reason.
    - 'name' (multi case) becomes 'display_name'.
      It has been done in order to make the select one and multi cases
      more similar and factorize some code.

TASK-ID: 2166814

Co-authored-by: Raphaël Collet <rco@openerp.com>
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Co-authored-by: Alexis Lacroix <laa@odoo.com>
Co-authored-by: Julien Mougenot <jum@odoo.com>
2020-05-05 19:23:20 +00:00
Mathieu Duckerts-Antoine c19dcf3983 [REF] web: search panel goes ESNext 2020-05-05 19:23:20 +00:00
Julien Mougenot d21c412985 [IMP] web: Standardize FALSE and TRUE leaves/domains
Add four static properties on the Domain.js class: (TRUE|FALSE)_(LEAF|DOMAIN).
This increases consistency for domains using these concepts.
2020-05-05 19:23:20 +00:00
Julien Mougenot 26491fcb4c [IMP] web: add sortBy to core.utils
Add a "sortBy" helper to core utils. This function takes an array and
an optional criterion as arguments and returns a new array sorted
according to the given criterion.
2020-05-05 19:23:20 +00:00
Swapnesh Shah d64c8fa304 [FIX] website_sale: display validation properly
Before this commit, This validation message was not displayed properly. (See https://nimb.ws/OwfLsH )

Now we are displaying Validation error Properly. (See https://nimb.ws/ji3N2h )

closes odoo/odoo#50704

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2020-05-05 18:46:18 +00:00
Jordi Ballester Alomar 8f34b34abd [FIX] product: Display weights and packages in product variants
closes odoo/odoo#50679

X-original-commit: ffa32607c15798a9bc6ea1f37b714e5dabfd0be4
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2020-05-05 15:10:03 +00:00
Laurent Smet 035fadb7d5 [FIX] account: Don't lock a fiscal year with unprocessed statement lines
closes odoo/odoo#50227

Related: odoo/enterprise#10226
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2020-05-05 07:16:39 +00:00
Dhruv Patel a599f1402e [IMP] web: FieldMany2one: reword and simplify dialog
This commit improves the dialog that opens when a user clicks out
of an 'un-commited' many2one. It is no longer possible to edit
the value, and the sentence has been reworded.

closes odoo/odoo#49528

Task: 2234212
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2020-05-05 15:19:45 +00:00
Jeremy Kersten 032dd00715 [IMP] web_editor: add autoscroll on autocomplete
To imp: auto size height based on position of the autocomplete

closes odoo/odoo#50684

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2020-05-04 13:37:33 +00:00
Samuel Degueldre e4c3f778cc [FIX] website: don't interpolate null values for css properties
In 29f02a37f0 we bumped the verion of libsass that we use. One
breaking change introduced by the new version is that if a css variable
is interpolated to the empty string, it is still emited in the compiled
css [1]

This commit fixes that by explicitly omitting null values from the map
before looping over it.

[1]: https://sass-lang.com/documentation/breaking-changes/css-vars

task-2248360

closes odoo/odoo#50668

X-original-commit: 6faf327706169bbe31e188a42805085b95b78052
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-05-05 14:40:18 +00:00
Jeremy Kersten d0946b3694 [FIX] website_blog: be more lax in perf test
Seems like randomly one request disappear. So 28 vs 29

Closes the eyes, while it is not 30 vs 29 ;)

closes odoo/odoo#50667

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2020-05-05 13:39:58 +00:00
Nicolas Martinelli 458b952d01 [FIX] account: balance not rounded
- Set the Product Price precision to 5
- Create an invoice with one line:
  No taxes
  Price Unit: 0.895
- Save

An error is raised because of an unbalanced journal entry.

The root cause is the `balance` which is not rounded. This is due to the
fact that the currency field (`company_currency_id`) is a related and
not set at the moment of computation. This leads to this being equal to
`0.01` instead of zero:

https://github.com/odoo/odoo/blob/ed1926cb12c830f383dbe540cb96e14d0804eb3d/addons/account/models/account_payment_term.py#L64

Note that if the line is saved with another value then the price unit
is modified, the error doesn't occur since the balance is properly
rounded.

opw-2209543

closes odoo/odoo#50655

X-original-commit: bd4bf1fe759a70d0b44606f1b2a3b27f8e71971d
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-05-05 12:52:56 +00:00
Osiris Roman a3e61f54d1 [FIX] l10n_ec: correct currency
The currency of Ecuador is USD, ECS is archived.
Add states of Ecuador
Signs CLA

Modificando la moneda oficial de Ecuador de sucre a dolar.
La moneda oficial del Ecuador cambió de sucre a dolar en el año 2000.

introducing Ecuadorian states

Correcting previous commit according to mart-e especifications
State codes follow the ISO 3166-2. Each code is compound by two parts separated by a hyphen "-". First part is "EC" (The ISO ecuadorian code), and the second part is the ISO state code.

Correcting res.country.state file according to mart-e especifications

Adding the states directly in the l10n_ec file

closes odoo/odoo#50653

X-original-commit: 1a6b70c6c3d8d739173de59d61563b0a7aad01c3
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2020-05-05 12:40:10 +00:00
Mathieu Duckerts-Antoine 9c2a0f1db7 [FIX] web: no confusion betweed false and 'false'
In the search panel, if a select multi was grouped by a field that can
take the value 'false' (like a char field), that value would be confused
with the value false and the group 'false' would never be
displayed (its values would be put in the group false).
This commit avoids that situation by using JSON.stringify instead of
the implicit stringification done when using a value as an object key.

closes odoo/odoo#50647

X-original-commit: 5b19e6c13b636d108e8aa1a09f01124fdb38a577
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2020-05-05 12:04:19 +00:00
qsm-odoo a8c54b40cd [FIX] web_editor: add access to all grays in bootstrap_overridden files
Before this commit, and in 13.0, you had access to gray colors in
bootstrap_overridden.scss files through the `palette-gray` function but
only if the gray was explicitely defined in the theme palette. This was
fine as only those were used at that time. Now, some themes want to use
the default BS gray values in those files to customize other variables.

The solution is to "force" all grays in the selected gray palette, using
the BS values by default.

closes odoo/odoo#50640

X-original-commit: fcb62edf3118d2d615296f293e6694b0e533bc99
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-05-05 11:23:07 +00:00
Julien Castiaux afcb734908 [IMP] ir_mail_server: IDNA and SMTPUTF8 capabilities
It has been a recurrent request from customers to be able to send email
messages to email addresses containing non-ascii characters. [IDNA] is a
domain extension to allow unicode characters in domain names. [SMTPUTF8]
is a SMTP extension to allow unicode in any header.

IDNA defines the [punycode] encoding which translates unicode to an
ascii representation. This encoding MUST be used to encode domains.

SMTPUTF8 is an SMTP extension that allow utf-8 in all headers on the
envelope.

[IDNA] https://tools.ietf.org/html/rfc5890
[SMTPUTF8] https://tools.ietf.org/html/rfc6531
[punycode] https://tools.ietf.org/html/rfc3492

Task: 2116928
opw-2229906
opw-2248251

closes odoo/odoo#47709

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2020-05-05 09:17:15 +00:00
Aaron Bohy 89c1d81b24 [IMP] *: update form views
*account,purchase,sale

Make them use widget mail_many2one_avatar.

Part of task 2195254

closes odoo/odoo#49345

Related: odoo/enterprise#10074
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2020-05-05 10:05:12 +00:00
Aaron Bohy b6d05f6015 [IMP] *: update kanban views
Use the new Many2OneAvatarUser field widget in some kanban views,
which allows to open a DM chat window with the corresponding user
by clicking on the avatar.

Part of task 2195254
2020-05-05 10:05:12 +00:00
Aaron Bohy 900d162809 [IMP] *: update list views
This commit adapts several views to make them use newly defined
widgets, the new decoration-xxx mechanism on fields, and to adapt
them to the new design of buttons.

Part of task 2195254
2020-05-05 10:05:12 +00:00
Aaron Bohy 841721ead9 [IMP] mail: add ListActivity widget
This commit adds a tweaked version of the kanban_activity widget
for the list view. This widget displays the summary of the next
activity (and fallbacks on the activity type if there is no
summary). It can be set by defining widget='list_activity' on
field activity_ids.

Part of task 2195254
2020-05-05 10:05:12 +00:00
Aaron Bohy a0c7284b66 [IMP] web: add 'label' attribute on AbstractField
If set, this value will be displayed as column name in list views.
This attribute could be used in the future in form view for the
same purpose.

Part of task 2195254
2020-05-05 10:05:12 +00:00
Aaron Bohy c54007f0e3 [REF] mail: lint activity.js 2020-05-05 10:05:12 +00:00
Aaron Bohy 22a66ae694 [IMP] hr: add Many2OneAvatarEmployee field widget
This widget is a variant of the Many2OneAvatarUser widget, designed
for many2one fields pointing to 'hr.employee'.

Part of task 2195254
2020-05-05 10:05:12 +00:00
Aaron Bohy 59641325c7 [IMP] mail: add Many2OneAvatarUser field widget
This widget is an extension of Many2OneAvatar, designed for
many2one fields pointing to the 'res.users' model, or a model having
itself a many2one field pointing to 'res.partner'.

With this widget, when the avatar is clicked, we open a DM chat
window with the corresponding partner. If the user clicked on itself,
we open a blank chat window for the sake of consistency.

In kanban views, this widget only displays the avatar.

Part of task 2195254
2020-05-05 10:05:12 +00:00
Aaron Bohy e63ffeab5a [REF] mail,hr: move openDMChatWindow to MailManager
It will be used by the Many2OneAvatarUser widget defined in the
next commit.
2020-05-05 10:05:12 +00:00
Aaron Bohy df4693e7ff [IMP] web: add Many2OneAvatar field widget
In readonly, this widget displays the image of the related record
next to its display_name. In edit, it behaves exactly like the
regular many2one.

Part of task 2195254
2020-05-05 10:05:12 +00:00
Aaron Bohy 4f8860e503 [IMP] web: add RemainingDays field widget
This widget can be used on date and datetime fields. In readonly,
it displays the delta (in days) between the value of the field and
today. In edit, it behaves like a regular date(time) widget.

Part of task 2195254
2020-05-05 08:48:34 +00:00