Commit Graph
109863 Commits
Author SHA1 Message Date
David Arnold cd6ff51bfa [IMP] lead: improve extensibility of partner create method
Before this commit _lead_create_contact actually constructed values AND
created the partner in one single step, making it difficult to override
in localizations that affect the partner model.

As containing method already existed, the partner creation was moved up
to this method, and the method was renamed to match with the file's
conventions. Now this method cleanly constructs the values.

Closes #16493 .
2017-05-29 18:19:43 +02:00
Luis González ed4b9064a1 [FIX] web: Properly label buttons which change views, with aria-label
Closes #16576

Description of the issue/feature this PR addresses:
According to HTML good practices, when an element is used but there's no text displayed on the screen, the attribute aria-label should be used to label that element.

This is the case in the buttons to change view types (List, Kanban, etc) since there's no text displayed, but an icon instead.

This HTML attribute is specially useful for screen readers, which usually are not able to figure out a button's functionality when that button is not properly labeled.

Current behavior before PR:
Buttons are not properly labeled

Desired behavior after PR is merged:
Appearance should be the same, but the produced HTML should be of better quality, because it would fit more HTML good conventions and it whould be more accessible

Related issue:
I had already reported this issue on the branch 10.0 at PR #16030. However, I decided to report it on this branch, because I believe this branch is the right place to be reported.
2017-05-29 18:14:00 +02:00
qsm-odoo 7dcb8fea64 [IMP] web: make backdrops appear on top of older modals
When opening a modal on top of another, we expect the associated
modal-backdrop to be over this another modal (so that it is grayed).
This was not the case as bootstrap forces the modal-backdrop z-index
to a lower value than the modal's one (see fix comments in the changes
below).
2017-05-29 16:53:02 +02:00
Yenthe V.G c8d132f751 [IMP] base: remove length of pass and user fields of ir.mail_server
Indeed in some cases those could be longer than 64 characters. As
there is no real constraint let us drop the limit to simplify it.

Closes #17269 .
2017-05-29 16:34:43 +02:00
Laurent Smet e06b039642 [FIX] account: fix traceback when resetting invoice to draft (#17262)
Due to a bad refactoring of this method during the remove of the
'report' module, a traceback occurs when resetting an invoice to draft.
This is due to the retrieve_attachment method that is used as an api.model
instead of api.multi.
2017-05-29 16:05:49 +02:00
Wolfgang Taferner 26e88569c5 [IMP] account: fields of refunds streamlined for better inheritance
Closed 17065
2017-05-29 14:21:33 +02:00
Moises Lopez - https://www.vauxoo.com/ ce44ad2440 [FIX] base_address_extended: default to Null instead of empty string
for computed street fields.

Qweb reports delete the node if the value is Null but won't if the value is an empty string. And then, l10n_mx_edi module has errors because there are nodes with empty string and the minimum value is one char.

Courtesy of Vauxoo. Was PR #17169
2017-05-29 09:31:53 +02:00
Xavier Morel 6c49715c56 [FIX] P3: leftover exception.message in template 2017-05-26 15:49:12 +02:00
Olivier Dony 345f1d4b86 [FIX] packaging: update dependency for pyPdf2
Complements 021de21e8c and #16918
2017-05-26 15:45:39 +02:00
Mehul Patel 904dcc0e06 [FIX] account: Fixed traceback when no payment on process_reconciliation
this bug is exposed due to the change,
https://github.com/odoo/odoo/commit/97c6dc77925090cb57e57b9edabcf81c93bea87c#diff-5f115361da1bcfdf42d3f2e0ad6e8661L476
2017-05-26 15:21:53 +02:00
Yannick Tivisse 7e008469e4 [IMP] base: Always load menuitem xmlids on templates
PURPOSE
=======

Currently we can choose to load the xmlid of a menuitem if web_tour is installed by setting the attribute `load_xmlid=True` on the view.

This is strange for 2 reasons:
- Searching all the ir.model.data on menuitems with load_xmlid=True to compute its xmlid, searching the related subtree on the returned structure of the method load_menus is quite complicated for the perfomance gain (if there is any perfomance gain to do it)
- This is not working in community in frontend, as only the root menuitems are loaded, thus it is the `load_menus_root` instead of the `load_menus` that is called. This issue prevent a tour step to be displayed correctly on community and enterprise on a menuitem.

SPECIFICATION
=============

Remove all the `load_xmlid` attributes and the related mechanism and move it into base to always load the xmlids for all the menuitems. It won't bee to heavy as the result is cached.

It's better the keep the current mechanism (Load the xmlids from ir.model.data and insert them into the tree) as we only make 1 search to the ir.model.data
2017-05-26 13:13:12 +02:00
Siddharth Gajjar 6110eb969d [IMP] website_sale: update create product tour
Purpose
=======

People who want to start an ecommerce expect to directly deal with products.
for now they are suggested to design a homepage first.

-> specific onboarding for ecommerce in order to start from shop page

Specs
=====

new tour for website_sale (start in /shop page):
Let's create your first product. https://drive.google.com/a/odoo.com/file/d/0B1uIL9E_zXrrT3VOZDk1V3Z0d0k/view?usp=drivesdk
same steps than now to create the first product
once product save, take to the backend:
https://drive.google.com/a/odoo.com/file/d/0B1uIL9E_zXrrMjI4TlRZdDBLWVk/view?usp=drivesdk
https://drive.google.com/a/odoo.com/file/d/0B1uIL9E_zXrrckNLZWthekFRSXM/view?usp=drivesdk

remove the 2 tips in pictures modal (because people don't follow them)  https://drive.google.com/a/odoo.com/file/d/0B1uIL9E_zXrrOEQxUlJDZk1vd3M/view?usp=drivesdk
suggest instead to upload a picture
2017-05-26 13:13:12 +02:00
Xavier Morel 5266708db5 [FIX] P3: syntax error in yaml file 2017-05-26 10:30:25 +02:00
Hiral Bhavsar 4a9471f155 [IMP] web: make 'default_name' work on kanban quick create 2017-05-25 13:25:47 +02:00
Hiral Bhavsar 332b83ef9e [IMP] project, *_timesheet: move subtasks to project
-> Move Subtasks mechanism from hr_timesheet to project.

-> Various functional improvements:
 - Add new 'Sub-tasks' setting and 'Sub-task Project' field based on
     this setting.
 - Relabel 'Team Collaboration' section to 'Task Management'.
 - Remove 'Customer Satisfaction' section and move setting
     'Rating on Tasks' into 'Task Management' section.
 - Add customer name on the project's kanban view.
 - Set default value of 'Sub-task Project' field is the same project.
 - Add 'Parent Task' stat button on task form view.
 - Make 'Sub-Tasks' stat button visible when no parent task
2017-05-24 11:39:54 +02:00
Fabien Pinckaers 7d99811a0f [IMP] website_event_questions: common questions --> questions 2017-05-23 11:56:44 -07:00
Aaron Bohy 7154d0769d [FIX] web: fix phone widget rendering
Cross-port of odoo/enterprise@135c02cbc5
2017-05-23 16:44:17 +02:00
Pragnesh Mistry e9ea504674 [IMP] mail: Replace the speaker icon by a bell for mail channel subtypes
Users get misguided
2017-05-23 16:37:24 +02:00
Nicolas Martinelli 7ba405a7b9 [FIX] purchase: show_purchase
In most cases, a user wants to see all fields of the PO. Hiding some of
them is only usefaul in draft state.

opw-743485
2017-05-23 13:25:01 +02:00
Darshan Kalola 118c7d0413 [IMP] website: added options to create a new page from the menu editor 2017-05-23 11:01:32 +02:00
Jeremy Kersten 15e1a65fb7 [IMP] website_blog: usability about confusing create date / publish date.
This commit closes #16742
2017-05-23 11:01:32 +02:00
Jeremy Kersten 8a99c7b143 [IMP] ir_http: remove _geoip_resolver on ir_http
It is no more used, it was just there for retrocompatibility.
No we share the resolver between thread
2017-05-23 11:01:32 +02:00
Akash Bhavsar 049cf42639 [IMP] base_import: improve import action
- Rename "Validate" button to "Test Import"
- unmatched columns are marked in red
- better column matching (show suggestions of the char field even if the imported values are of int type)

PR  #16881, close task 32894
2017-05-23 10:00:48 +02:00
Joren Van Onder f1767d5c88 [FIX] point_of_sale: is_unit has been removed
Removed and replaced with is_pos_groupable by
fe631a36a5.
2017-05-22 16:40:12 -07:00
Joren Van Onder f5f60599bf [IMP] point_of_sale: rewrite price access control logic
Introduced at 4e715dae94. Instead of
doing hacky things like self.pos.gui.screen_instances... in the
cashier widget to force the numpad UI to rerender itself it's better
to use Backbone.js because:

1. we're already using it everywhere else to handle UI updates
2. easier to extend for eg. adding more cashier related access rights

To do so cashier is turned into a Backbone attribute on PosModel. All
references to the cashier property are replaced with get_cashier to
ensure the Backbone attribute is used.

Note that this is not necessary for the user property on
PosModel. This contains the actual user logged into Odoo and thus
never changes.

This also removes the check in set_unit_price because:

1. it was wrong to begin with (no price change when
   restrict_price_control is enabled or you're a manager?)
2. even if fixed it would break the following for non-managers:
   1. tipping
   2. fix_tax_included_price
2017-05-22 13:47:21 -07:00
Prakash Prajapati 4308e692c5 [IMP] (website_)sale: Prevent users to create sales orders from invoicing menuitems
Purpose
=======

The menu "Sales -> Invoicing -> Orders to invoice , shows the orders which are confirmed and where the invoice needs to be created for those.
User should not be able to create SO from this menu.

===========
Specification
===========

Remove create Button in (Order to invoice and Order to upsell) menu  and in website -> order to invoice
2017-05-22 15:15:38 +02:00
Adrien Peiffer (ACSONE) 3f07567533 [IMP] hr: set name on attributes of filter
To make it easier to extend

Closes  #16912
2017-05-22 14:16:42 +02:00
fka-odoo 792b3a8737 [IMP] kanban: Hide Configuration->Stage menuitems in debug mode
Purpose
=======

As you can easily edit your stages via your kanban view, this menu item is not necessary

Specification
=============

Following configuration/stages menu Move to debug mode

List of menu:

Quality/Configuration/Quality Alert Stages
PLM/Configuration/ECO Stages
Events/Configuration/Track Stages
Project/Configuration/Stages
Maintenance/Configuration/Maintenance Stages
Recruitment/Configuration/Stages
Email Marketing/Configuration/Campaign Stages
2017-05-22 14:11:49 +02:00
stefanorigano 955a0e30ca [IMP] website: move divider on top of 'carousel' option 2017-05-22 14:05:35 +02:00
Xavier Morel 8411e227f2 [MERGE] P3: various things which break in Python 3
Not exactly clear why they don't work at all in Python 3, but they're
odd or mistakes so easy enough to fix.
2017-05-22 13:31:01 +02:00
Xavier Morel b897dcde15 [FIX] P3: import pattern which doesn't seem to work right
``import odoo.addons.foo as bar`` doesn't seem to properly trigger the
import hook in Python 3 (it blows up on decimal_precision and
base). Thus convert *all* examples of that pattern to the more
sensible ``from odoo.addons import foo as bar``.
2017-05-22 13:30:50 +02:00
Xavier Morel 13eb0bb1e3 [FIX] P3: incorrect format_exc call now blows up 2017-05-22 13:30:50 +02:00
Xavier Morel e5ef1c5917 [FIX] P3: don't resize the value False
Yields really strange errors in P3.
2017-05-22 13:30:50 +02:00
Laurent Smet 915aa9e4db [IMP] account: improve usability on journals.
This commit add computed fields that allow to easily change the next number that will be given by the journal's sequence.
Was PR #15163
2017-05-22 09:29:17 +02:00
Xavier Morel ee894b1384 [FIX] provide items method on lru so shim works 2017-05-19 16:46:42 +02:00
xmo-odoo 05abc1faed [FIX] test_pylint: pylint error output to failure
Sometimes PyLint itself blows up which fails the test but does not
provide any indication as to why, which is inconvenient.
2017-05-19 16:46:42 +02:00
Deep Patel b6660433c6 [IMP] mail : Display Log instead of Send in full mail composer
Purpose
=======

Improve label in full mail composer.

Specification
=============

In full mail composer if it's log than send button string should be "Log".
2017-05-19 15:50:00 +02:00
Nicolas Martinelli f57f133047 [IMP] account, l10n_*: remove dependency on base_vat
Localizations depend on the module "base_vat". It is therefore
impossible to remove base_vat without the localization. This causes
issues for users who simply want to deactivate the VAT check.

opw-743260
2017-05-18 17:05:22 +02:00
Yannick Tivisse 707e5ea861 [FIX] sale: Don't hide CRM menuitem when installing ecommerce 2017-05-18 16:51:53 +02:00
Yannick Tivisse 5dfd342d08 [ADD] sale_management: Separate sales menu items from sale app
Purpose
=======

Don't display sales app icon in Odoo homepage when installing ecommerce (only website should be visible)
it's confusing to have sales icon  -> where do I manage my sales? In sales or in website? -> in website

Specfication
============

We need one new modules to add Sales menus to the homepage. Currently they come with "sale". So when installing "website_sale", we get them (because sale and account are dependencies of website_sale). We don't want that anymore. Along with that you need to replace modules in Apps menu:
sales menu items must be in the new sale_management module, no longer in sale

- create new app "sale_management"
- Currently 3 app icons when installing ecommerce (Sales, Invoicing, Website) -> too many icons, where to start? -> GOAL: Only 2 icons > Website, Invoicing
- new module to display Sales Icon (like account_accountant): "sale_management"
- move menu items to sale_management
- sale, sale_management: move app description, rewrite the manifest file
- sale, sale_management: move tour from sale > sale_management
- Changes in some dependency module "sale" > "sale_management" modules: event_sale, mrp_repair, pos_sale, report_intrastat, sale_crm, sale_expense, sale_stock, sale_timesheet, website_quote

Menu items to move 'sale' --> 'sale_management'
===============================================

Sales
	Quotations
        Sales Orders
Invoicing
	Orders to invoice
        Orders to Upsell
Catalog
	Products
        Product Variants
        Pricelists
Reporting
	sales
Configuration
	Settings
        Products -Attributes, Attribute Values, Internal Categories
2017-05-18 14:41:48 +02:00
Yannick Tivisse 0f92eed8a0 Revert "[ADD] sale_management: Separate sales menu items from sale app"
This reverts commit 9ab421d99a.

We should use the active field on the ir.ui.menu with the root menuitem instead of moving all the menuitems into a new module
2017-05-18 14:41:48 +02:00
Raphael Collet afef71d6b9 [FIX] Always round monetary values in database (#17010)
Let `create` and `write` round monetary field values before sending them to the
database. Pass the values to be written to `field.convert_to_column`, so that
the currency can be retrieved from the values, and the value be rounded.
2017-05-18 14:15:07 +02:00
Fabien Pinckaers 440177f2fa [IMP] MRP: managers should be able to fix eroneous times 2017-05-17 11:42:17 -07:00
Pragnesh Mistry 1b8050a30a [IMP] sale: Move the Margin field below Total on a sales order
move margin field from the bottom left corner of sales order to below the total_amount field
2017-05-17 16:52:09 +02:00
Mahendra Barad 0982047101 [IMP] mail: better navigation when expanding chat windows
Before this commit, expanding a chat window would open the discuss application, which means that the current navigation state (breadcrumbs) is lost.  With this commit, it simply opens a new action in the breadcrumb, and does not lose the current action. (PR 16725, closes task 31767)

Note that this implies that it is possible to have two discuss client actions open at once.
2017-05-17 16:08:46 +02:00
qdp-odoo 6db235385a [IMP] account: replace bank_acc_number by bank_account_id on bank journal form view.
Was PR#16105
2017-05-17 15:35:06 +02:00
Jitendra Prajapati 6cd0f5c44c [MERGE] payment, website_sale: improve view and use of acquirers
Purpose is to ease user flow and understanding when configuring and
managing payment methods. UX of acquirers (form, kanban) and their
integration in ecommerce is improved. Please refer to individual
commits for more details.

This merges 'dev/master-clean-payment-views-jpr-tde'.
2017-05-17 14:45:30 +02:00
Pragnesh Mistry 22e0b857bb [IMP] hr_expense: Show expense date instead of creation date in reports
Purpose
=======

In Expenses > Reporting > All Expenses, the X-axis of this pivot by default is the creation date of expense report. It should be the expense date instead.
make the same changes in graph view.

Specification
=============

In "All Expenses" report by default "Expense Date" instead of "Create Date"  in pivot
Also rename "Date" to "Expnese Date"
Changes should be made in to graph view.
2017-05-17 14:42:37 +02:00
Jitendra Prajapati 9a9f9e1ab7 [IMP] website_sale: perform small UX improvements
* Display 'order confirmed' only if it is actually the case;
 * Display uom only if those are managed;
2017-05-17 14:41:00 +02:00
Jitendra Prajapati b6d636617c [FIX] payment: perform small code improvements
* add a constraints about authorized state for tx and authorize feature
   available on acquirer;
 * order acquirers first by publish, then sequence then name;
 * add a sequence on some provider data and use a default to have some
   popular acquirers first;
 * use update instead of write in an onchange;
2017-05-17 14:41:00 +02:00