Commit Graph
114167 Commits
Author SHA1 Message Date
Olivier Colson cd5ce3c7dc [IMP] account: payment terms usability
* Replace payment term lines options 'last_day_following_month' and 'last_day_current_month' by two new less specific ones allowing choosing the day directly, and thus not limited to the last one anymore (semantically different).
* Rename payment term line option value 'fix_day_following_month' into 'after_invoice_month' for more clarity (no semantic change).

Was task 24239. Was PR #15487
2017-11-30 16:08:30 +01:00
Alexandre Kühn f38ace8de2 [DOC] fields: improve doc for trim attribute 2017-11-30 13:00:36 +01:00
Alexandre Kühn 289582bc2a [FIX] test_main_flows: rename menu entry 'Catalog', workaround for the_flow.customer
Menu entry 'Catalog' has been renamed into 'Products' (see https://github.com/odoo/odoo/commit/941037194d0644a0f2d3348aedd888bce5b1eb74)

The step 'the_flow.customer' with enterprise fails due to an unexpected out-of-focus issue.
2017-11-30 10:23:28 +01:00
Dave Lasley 8226aa1db8 [IMP] http.py: Allow to use odoo if unmet dependencies on uninstalled module
Purpose
=======

If an external dependency is unmet on a module that is not installed, it's actually impossible to launch an odoo server and load the web client without getting a traceback.

This commit removes this constraint and allow to use odoo in that case. Obviously the install will crash if the external dependency is still unmet.

Close https://github.com/odoo/odoo/pull/17790
Coming from https://github.com/odoo/odoo/pull/14850
2017-11-29 16:21:12 +01:00
Yannick Tivisse 941037194d [MERGE] sales_management: Make the onboarding smooth
Purpose
=======

The flow for new users is still not smooth
The tour tips are not clear either

Specification
=============

1/ Rewrite the tour tips
- Organize your sales activities with the Sales Management app ==> OK
- Let's create a new quotation. Note that colored buttons usually point to the next logical actions. ==> OK but put it under the create button and not on the right
- Write the name of your customer to create one on the fly, or select an existing one. ==> OK but put it under the field and not above
- Click here to add some lines to your quotations. ==> Click here to add some products or services to your quotation.
- Select a product, or create a new one on the fly. The product will define the default sales price (that you can change), taxes and description automatically ==> Rename in into "Select a product, or create a new one on the fly."
- Once your quotation is ready, you can save, print or send it by email. ==> OK
- Use the breadcrumbs to go back to preceeding screens. ==> OK
- Use this menu to access quotations, sales orders and customers. ==> OK
- Click the Home icon to navigate across apps. ==> Remove that step
- Configuration options are available in the Settings app.==> remove that step
- Invite salespeople or managers via email. Enter one email per line. ==> remove that step
2/ Rename the menu entry "Invoicing" into "To Invoice"
3/ Rename the menu entry"catalog" into "Products"
4/ https://drive.google.com/a/odoo.com/file/d/0BxqHe5rtIxY0aEkxMURWeGtfSW8/view?usp=drivesdk
5/ In the order line, when you create a product on the fly: if set a price you store the price and the description on the product (not if you select the product, only if you quick create it) (only the first time, like in Purchase)
6/ Add 45 Days and 2 months in data of payment term
7/ http://nimb.ws/XPcUx3 Delete Invoice Order from Action menu in form view
8/ Settings : DHL, USPS, UPS, Fedex, bPost : Add the word connector (DHL Connector, USPS Connector,...)
9/ In Orders/Sales : remove the default filter Sales Order (doens't make sense) : https://www.youtube.com/watch?v=xOfidZapHs0&feature=youtu.be
2017-11-29 15:49:43 +01:00
Kinjal Mehta d8e70561e4 [IMP] sale: Set default product sales price and description
Purpose
=======

In the order line, when you create a product on the fly: if set a price you store the price and the description on the product (not if you select the product, only if you quick create it) (only the first time, like in Purchase)
2017-11-29 15:42:53 +01:00
Kinjal Mehta a2f618f96b [IMP] sale: Improve views
Specification
=============

- Rename the menu entry "Invoicing" into "To Invoice"
- Rename the menu entry"catalog" into "Products"
- Remove a part of the empty list message for quotations
- In Orders/Sales : remove the default filter Sales Order (doens't make sense)
2017-11-29 15:42:53 +01:00
Kinjal Mehta 3b3781110e [IMP] sale_management: Improve tour
Purpose
=======

Rewrite the tour tips

Specification
=============
- Organize your sales activities with the Sales Management app ==> OK
- Let's create a new quotation. Note that colored buttons usually point to the next logical actions. ==> OK but put it under the create button and not on the right
- Write the name of your customer to create one on the fly, or select an existing one. ==> OK but put it under the field and not above
- Click here to add some lines to your quotations. ==> Click here to add some products or services to your quotation.
- Select a product, or create a new one on the fly. The product will define the default sales price (that you can change), taxes and description automatically ==> Rename in into "Select a product, or create a new one on the fly."
- Once your quotation is ready, you can save, print or send it by email. ==> OK
- Use the breadcrumbs to go back to preceeding screens. ==> OK
- Use this menu to access quotations, sales orders and customers. ==> OK
- Click the Home icon to navigate across apps. ==> Remove that step
- Configuration options are available in the Settings app.==> remove that step
- Invite salespeople or managers via email. Enter one email per line. ==> remove that step
2017-11-29 15:42:53 +01:00
Kinjal Mehta 7b86a7beb8 [IMP] sale: Remove 'Invoice Order' from Action menu on sales orders 2017-11-29 15:42:53 +01:00
Kinjal Mehta 86ecdc88cb [IMP] sale: Improve labels for delivery connectors 2017-11-29 15:42:53 +01:00
Kinjal Mehta ae23e7f083 [IMP] account: Add '45 Days' and '2 Months' in payment terms data 2017-11-29 15:42:53 +01:00
Martin Geubelle 8d49a38f03 [FIX] *: replace incorrect view_mode
Some actions were using `list` as value for the attribute `view_mode`.
This value is not valid, the list view is named `tree` server-side.

This was causing issues when setting `view_ids` (`ir.actions.act_window.view`)
on the action because `tree` and `list` were not matching correctly.

Closes #21056
2017-11-29 14:46:12 +01:00
Thibault Delavallée cf32a1d202 [FIX] hr_holidays: make action_approve really work in batch 2017-11-29 11:19:19 +01:00
Thibault Delavallée adf27adc15 [REM] crm: so long mail.thread access rules
Thanks to ksa 87d531400f
2017-11-29 11:18:40 +01:00
Thibault Delavallée 21ad8d2588 [MERGE] mail: clean and move tests
This commit cleans mail tests in order to have less low-level tests and
to improve code coverage. It improves the tests of features and reduces
field-level checks. Some tests depending on implementation details are
wrapped inside methods. This way if implementation changes most tests
are still valid once assert methods are updated.

Common classes, tools and models are improved. More test models exist
in order to be able to test several features and prepare land to add
performance test. Each set of tests is updated in its own commit.

Finally tests are moved to test_mail. This way tables linked to test
models are not present in production database. Existing test_performance
module is split so that there is tests for base and tests for mail.
2017-11-29 10:54:02 +01:00
Thibault Delavallée 163725e3c6 [FIX] base, web: update comments to moved files from base 2017-11-29 10:19:07 +01:00
Thibault Delavallée 22cce3be9d [ADD] test_mail: add some performances tests 2017-11-29 10:11:15 +01:00
Thibault Delavallée d040bfde89 [MOV] (test_)mail: move tests into their dedicated module
Purpose: avoid having useless tables for test models in a
production environment.
2017-11-29 10:11:15 +01:00
Thibault Delavallée 7a136d6acc [REM] mail: tests: remove unnecessary common data 2017-11-29 10:11:14 +01:00
Thibault Delavallée 32c08fd73c [IMP] mail: tests: add activity tests 2017-11-29 10:11:14 +01:00
Thibault Delavallée 2b6d840822 [IMP] mail: tests: clean test mail template 2017-11-29 10:11:14 +01:00
Thibault Delavallée ac9103adbd [IMP] mail: tests: clean mail gateway tests
Purpose is to lessen noise and make tests less low-level. Including :

 * use of new models and data;
 * lessen low level tests;
 * some light cleaning;
2017-11-29 10:11:13 +01:00
Thibault Delavallée 53d65ed71a [IMP] mail: tests: clean and improve mail tracking tests
Purpose is to lessen noise and make tests less low-level. Including :

 * clean and remove most of old tests, low-level and not very useful;
 * add tests for several cases, like simple tracking, tracking linked to
   a mail.message.subtype, trackink automatically sending emails based
   on some template;
2017-11-29 10:11:09 +01:00
Thibault Delavallée 99ee2f344a [IMP] mail: tests: clean and improve mail followers tests
Purpose is to lessen noise and make tests less low-level. Including :

 * add test for the various auto subscription cases, notably through
   umbrella (like project -> task auto subscription);
 * remove low-level tests; there is no need to test the output of add
   followers method as it is only an implementation details;
2017-11-29 10:05:01 +01:00
Thibault Delavallée f8118d8c8b [IMP] mail: tests: clean mail message tests
Purpose is to lessen noise and make tests less low-level. Including :

 * move mail_mail model specific tests to its own file;
 * move feature specific tests to its own file;
 * add missing loggers to lessen noise;
2017-11-29 10:05:01 +01:00
Thibault Delavallée 846352f00d [IMP] mail: tests: clean and improve mail channel tests
Purpose is to lessen noise and make tests less low-level. Including :

 * tests should be more about channel listeners than followers as
   channels should not have followers;
 * test email_send that trigger the mailing list behavior;
 * currently add some join and leave channel methods are those are
   missing in the base model:
 * test joining and leaving channels that should not change
   followers but members;
 * use less preconfigured data;
 * add some mute loggers to lessen noise;
 * remove some old code about patching that is not necessary anymore and
   could actually create funny bugs;
2017-11-29 10:05:01 +01:00
Thibault Delavallée 9150443465 [IMP] mail: tests: clean server actions tests
Purpose is to lessen noise and make tests less low-level. Including :

 * remove unnecessary fail string;
 * remove unnecessary method return value test as this is low level;
2017-11-29 10:05:01 +01:00
Thibault Delavallée 15e131907f [IMP] mail: tests: clean invite wizard tests
Purpose is to lessen noise and make tests less low-level. Including :

 * remove test of emails content as this is too low-level and not really
   interesting. Purpose of test is to check followers have been added
   and not the content of a template;
 * remove unnecessary fail string;
 * remove unnecessary low level checks;
2017-11-29 10:05:01 +01:00
Thibault Delavallée 12fd198bcf [IMP] mail: tests: clean test discuss and test message compose
Purpose is to be less low level and improve code coverage by adding
tests if required. Duplicated or redundant tests are removed to lessen
number of tests. Notably content of notification emails, recipients and
specific chatter control through context keys are more tested.

Some more tests about buttons present in notifications emails should be
added. Maybe in a near future. I hope so.
2017-11-29 10:05:01 +01:00
Thibault Delavallée 50aaaa69be [REM] mail: tests: remove test message read
This is some remains of old message_read / message_fetch tests linked to
the old chatter using threaded display. Tests have been removed when the
feature was changed. Only the setup was left. Let us get rid of it.
2017-11-29 10:05:01 +01:00
Thibault Delavallée de25767ffc [IMP] mail: tests: improve / add common classes and data for mail tests
This commit improves common classes and add helpers for mail tests.
Future commits will use this new stuff to improve the tests.

 * improve existing models and add some of them. There are now several
   models

  * mail.test.simple: chatter-enabled record without any really advanced
    feature. Can be used everywhere standard chatter and communication
    tests are required;
  * mail.test.track: chatter-enabled record with basic value tracking
    and responsible tracking;
  * mail.test.activity: chatter-enabled record using activities;
  * mail.test.full: complete chatter-enabled record with advanced
    tracking, automatic subscription and automatic email send based on
    templates and tracking;
  * mail.test: chatter-enabled record having an alias. It can be used
    where umbrella record like projects or teams has to be used in
    tests;

 * add MockEmails test class: this class mocks the mail gateway so that
   tests can work on emails without actually sending them. It is taken
   out of TestMail class to clearly separate features from class;
 * improve created data in the various classes and prepare work to
   lessen created data during tests;
 * add helpers on base test class, notably

  * sudoAs: context manager to run a code snippet using a given user;
  * assertNotifications: assert notification content, aka Inbox or email
    notification and their content; may be subject to change depending on
    mail evolution;
  * assertEmails: check content of sent emails;
2017-11-29 10:05:01 +01:00
Thibault Delavallée 2a3ac4ce22 [MOV] mail: reorganize content of tests, separate tests from models and data
Purpose of this commit is to reorganize the mail tests. Containing

 * move test models into mail/tests/models/;
 * move data into mail/tests/data even if it is python code, as it is
   likely that some additional data will appear soon;
 * split test_mail_features into test for discuss app and test related
   to message post and composer, to better identify test target;
 * split and remove test_portal, those tests are now integrated in the
   other tests;

There is no change in this commit. Only some renaming and file move or
split.

mergeup: remove / split test portal
2017-11-29 10:05:01 +01:00
Thibault Delavallée 1cc1ef5058 [SPLIT] test_performance: split between base and mail performance tests
Test performance will now hold the base class for performance tests as
well as tests related to the ORM, depending only on base. A new module
test_mail is introduced at this commit that contains performance tests
related to mail module. This commit contains only code move and should
not impact anything.

Future commits will move mail tests into test_mail so that all mail
related tests are located in the same optional module. This allows
notably to avoid creating a lot of unnecessary tables when installing
mail module on production databases.
2017-11-29 10:05:01 +01:00
Thibault Delavallée ea6415bd90 [IMP] odoo: tests: allow to compare HtmlElement trees
addTypeEqualityFunc does not work for subclasses. Therefore if we want
to be able to compare html trees we have to add the equality check for
html elements which are children of _Element.
2017-11-29 10:05:01 +01:00
Alexandre Kühn 9cd1cae65f [FIX] odoo service: fix location of res_country_data.xml file
It has been moved inside base/data, instead of base/res.
We have to adapt code that is calling it.
2017-11-29 09:04:12 +01:00
Christophe Simonis 2b957f8d01 [FIX] web: correct test 2017-11-28 18:58:09 +01:00
Thibault Delavallée 6bd5033e7f [FIX] tools: fix location of res.lang.csv file
It has been moved inside base/data insteaf of base/res. Let us adapt code
calling it.
2017-11-28 18:16:24 +01:00
Christophe Simonis b998924ec9 [FIX] project: avoid recursive project creation
Correctly forward-port 3680e099a6
2017-11-28 17:50:11 +01:00
Christophe Simonis 29590a61cd [MERGE] forward port branch 11.0 up to 8fb25e185b 2017-11-28 16:57:58 +01:00
Simon Lejeune 8fb25e185b [FIX] barcodes: manage several barcode widgets
related to rev 0d19ee989d

It was broken following the refactoring done in saas16, resulting in
barcodes being handled on all the displayed forms and it was problematic
in the case of a form dialog openned over a "fullscreen" form view.

This was particularily problematic for the scrap dialog in the
stock_barcode module.
2017-11-28 15:17:59 +01:00
Simon Lejeune 0ca4b0f373 [REF] stock_account: warn when changing cost method 2017-11-28 15:17:59 +01:00
Christophe Simonis 5851a69aa3 [MERGE] forward port branch saas-16 up to 3f66814a0d 2017-11-28 15:12:31 +01:00
qsm-odoo 41d2470093 [FIX] mail: properly suggest users to chat with
Before this commit, it was not possible to choose the user you want to
chat with in a chat window anymore. This was because the dropdown that
suggest the users appeared under the chat windows since commit
https://github.com/odoo/odoo/commit/7b965a9673a9124e6e045b8a290a156eed402ad5

Indeed, the mentioned commit changed the z-indexes so that chat windows
are still usable when a modal is opened. This was done by making the
chat windows always have the greatest z-index... forgetting this would
make them appear on top of their own autocomplete dropdowns.

This commit restores the feature while keeping the ability to talk while
a modal is opened. See code comments for details.

opw-785162
2017-11-28 14:28:40 +01:00
Christophe Simonis 3f66814a0d [MERGE] forward port branch saas-15 up to 09badbed98 2017-11-28 13:37:35 +01:00
auyeung112002 ecbf7aa471 [CLA] auyeung112002 signs the CLA
Closes #21281
2017-11-28 11:56:23 +01:00
jem-odoo 85726e33b0 [FIX] sale_timesheet: do not create project/task when expense
When expensing a service product, an SO line is created
on the SO from the hr expense. This creation triggers
the service object creation (task and/or project), and
should not.
To avoid this, we check if the ordered quantity
is not zero to avoid use the expense policy (or
any expensable product will not be able to create
task/project).
The same mecanism is used in stock to avoid picking
creation when expensing stockable product.
2017-11-28 11:46:07 +01:00
Mehul Patel 3680e099a6 [FIX] project, sale_timesheet: analytic account and project creation
When we create an analytic account, a project is automatically
generate, and it should not. This is a bug coming from
the removal of 'use_tasks' field. See eb4ad33513.

We can now remove all the 'project_create' and
'project_creation_in_progress' context key.
2017-11-28 11:45:42 +01:00
Mehul Patel bf6894c5b1 [FIX] sale_timesheet : sale_line_id field not exist in sale.order.line 2017-11-28 11:45:22 +01:00
jem-odoo ef2a3b1342 [FIX] sale: name_search of SO line with its own name
When searching a SO line, we want to search on its own
description in case of 2 product with the same name
are present on the SO. This help user to differenciate
them.
2017-11-28 11:44:59 +01:00
qsm-odoo d66997dd39 [FIX] website_hr: restore employee publishing feature
Broken with https://github.com/odoo/odoo/commit/4ecbacaf59576a22ff45615a5aa5c67244e4fb93
2017-11-28 09:59:13 +01:00