Commit Graph
117030 Commits
Author SHA1 Message Date
RomainLibert 9717026dcc [IMP] Resource: Expand testing on timezones
We need to check if resource module takes into account the timezone of
the employee taking a leave and the timezone of the user asking to see
when this employee has taken some leave.

Basically everything should be done in UTC internally and then converted
back to the user's timezone.
2018-02-14 14:43:38 +01:00
Denis Ledoux 0db75089ef [FIX] base: prevent PhantomJS tests to send emails
The emails sending is skipped during the tests.
The mecanism to determine if the server was running tests
was to check if the attribute `testing` was set for the thread.

Unfortunately, this `testing` attribute is removed/set to false after the loading/installation
of the modules is done, and phantomJS tests are ran post-installation,
and therefore the emails that were potentialy sent following an action
performed in a PhantomJS tour were not skipped.

This occurred for instance in the tour `project.tour`,
when the responsible of a task was changed,
the sending of the assignation notification email was not skipped.

In the case the machine on which the tests are ran does
not have an smtp server (or mailcatcher) running on the port 25,
this resulted in a test fail.
2018-02-14 14:26:39 +01:00
Haresh Shyara 3a38080ff5 [IMP] account : change unit price according to UoM
It was already the case with the sale order but not on invoices

Task-id: 35387
Closes #18719
2018-02-14 18:49:14 +05:30
Kinjal Mehta 102bb626f0 [FIX] account: changed the name of date filter in journal items search view.
As the old name 'date' of the filter was the same as the field date, the context key 'search_default_date':1 was ambigous and not well processed by the web client.
It was indeed considering on field by default and was trying to set value 1 on date field, which is not possible and it gave traceback.
2018-02-14 14:06:30 +01:00
Mehul Patel efe0112527 [FIX] account: recurring bills filter option always visible.
Previously, the installation of account_3way_match module was loosing these filters
2018-02-14 13:57:11 +01:00
Odoo Translation Bot 3809a8a41c [I18N] Update translation terms from Transifex 2018-02-14 13:43:39 +01:00
tbe-odoo c6a3e034dd [FIX] hr_holidays: Remove related on employee's manager
- In SaaS-16 we have added a related on the employee's manager as the manager of the leave.
    This cause access rights issues when changing the employee's manager.
    We do not want to rewrite all the old records, only the new ones should use the new manager.
2018-02-14 13:18:17 +01:00
Martin Trigaux fc6a04c622 [FIX] mass_mailing: don't specify search title
It is an inherited view.
It makes no sense and may be interprated as an xpath

Fixes #23014
2018-02-14 16:42:20 +05:30
RomainLibert bc86eb771d [FIX] mail: use config parameter as intended for alias_domain
Since commit a18bd499ac alias_domain was
not updating correctly in the settings.

This commit fixes the issue by updating to code to conform to the new
config_parameter interface.
2018-02-14 11:57:33 +01:00
Odoo Translation Bot 91f2209216 [I18N] Update translation terms from Transifex 2018-02-14 11:53:12 +01:00
Laurent Smet 805f3a610f [IMP] account_asset: improved depreciation dates management
related to task id 29411

    add selection field 'date_first_depreciation' on 'account.asset.asset' to manage the depreciation dates:
    -manual: set manually with the manual_date_first_depreciation field (defaulted on purchase date)
    -last_day_period: last day of purchase month/year

    add a selection field on 'account.asset.category' to set the default value as well.
2018-02-14 10:50:29 +01:00
Mathieu Duckerts-Antoine ee44d238f1 [IMP] web: close dialogs when navigating to another action.
This commit fixes a problem of usability. By the past if several dialogs were opened
(e.g. after having clicked on several one2manys) and a user would click on a many2one in a dialog,
a new view was charged but the dialog was kept open so that the change was unnoticed.
This behavior has been changed. Now all dialogs are automatically closed in such a situation.
2018-02-14 10:12:24 +01:00
3c0daf39e9 [IMP] survey: remove dependency to website
Set http_routing module as dependency of survey (to allow slug)
create website_survey to have the correct assets

Task-id: 23848
Closes #20485

Co-authored-by: Rawish Murari <rmu@odoo.com>
Co-authored-by: Rohan Patel <rop@odoo.com>
Co-authored-by: Richard Mathot <rim@odoo.com>
2018-02-14 14:28:19 +05:30
Nicolas Lempereur 268443657e Revert "[FIX] project: follow stage change"
This reverts commit 5fa4f4cc31.

Explanation: https://github.com/odoo/odoo/commit/5fa4f4cc31#commitcomment-27551833
2018-02-14 09:53:46 +01:00
Haresh Shyara 824b48f335 [FIX] account: show payment methods only for journal of type 'bank' or 'cash' 2018-02-14 09:45:42 +01:00
Haresh Shyara 601997df6d [IMP] account_check_printing: Assign the check number on payment confirmation
Purpose
=======

Avoid issues in checks numbering.

Specification
=============

When the manual numbering of the checks is ticked on the bank journal, assign and display number to the check only when the payment is confirmed, not when the check is still in draft.
2018-02-14 09:44:56 +01:00
Jeremy Kersten c9edca7896 [FIX] website_sale: force int for qty in UI to stay coherent
Previously, some screen in front was casted in Integer, others not.

This commits closes #22443

To improve in master using precision decimal, t-field, ...
But avoid to change in dom tree in stable version
2018-02-14 09:00:02 +01:00
Christophe Simonis 19a37782fb [MERGE] forward port branch 9.0 up to 2d73ea9bed 2018-02-13 19:02:37 +01:00
Nicolas Martinelli 5fa4f4cc31 [FIX] project: follow stage change
- Create a project and a task
- Add a channel as follow of the project and task
- Set the channel to follow task stage change only

When changing the stage, the tracking is sometimes received in the
channel, sometimes it is not.

In the case of a stage change, the subtype returned for tracking depends
on the stage sequence. If the sequence is `<= 1`, the subtype for task
creation is returned. Therefore, if the channel is not following task
creation, the tracking message might or might not appear, depending on
the which stage is impacted.

We can remove this specific case, since the creation will be handled
when `user_id` is in the `init_values` or when `mail_create_nolog` is in
the context.

opw-802924
closes #22926
2018-02-13 17:38:25 +01:00
Goffin Simon 33e7c8d60c [FIX] website_event: Duplicating event with a menu
When duplicating an event.event record with a website_menu, the duplicated
event had also a website_menu pointing to the first record.

opw:813270
2018-02-13 17:19:17 +01:00
Raphael Collet 34c52e9938 [FIX] fields: performance of onchange on related fields
Optimize the copy of the cache being made by related fields to compute
themselves.  Instead of traversing records data in cache, follow the cache
structure itself and copy everything!

OPW 816125
2018-02-13 17:08:49 +01:00
Nicolas Martinelli f19e0f8047 [FIX] project: set as favorite
- Connect as a user with only 'User' rights on projects
- Set a project as favorite (click the star)

The project is not set as favorite.

Since only project managers are allowed to write on projects, the field
`is_favorite` is set as read-only. Therefore, it is filtered out by
`_generateChanges`, and nothing happens.

First step is to set the attribute `force_save` in the view, so the RPC
`write` call is forced. Second step is to compute directly the inverse
thus bypassing access rights.

Co-authored-by: Nicolas Lempereur <nle@odoo.com>
opw-814604
opw-801587
closes #22938
2018-02-13 16:07:21 +01:00
Goffin Simon 5ca0ef978f [FIX] account, point_of_sale, stock_account: POS Anglo-Saxon Accounting
Anglo-Saxon Accounting entries are not created when the POS session
was closed with button "Close and post entries

opw:802727
2018-02-13 15:52:54 +01:00
Goffin Simon 2d73ea9bed [FIX] point_of_sale, stock_account: POS Anglo-Saxon Accounting
Anglo-Saxon Accounting entries are not created when the POS session
was closed with button "Close and post entries

opw:802727
2018-02-13 15:46:21 +01:00
qsm-odoo 5e6c5d24be [FIX] mass_mailing, *: duplicating two-columns snippets
* web_editor, website

This commit fixes a bug with table duplication in mailing template:
- Click on a snippet with two columns
- Duplicate it
-> the snippet is duplicated but the two columns are transformed in two
   rows.

This was because there is an implemented behavior for column
duplication: if we duplicate a column which was alone on its row, we
duplicate the row instead. This code should however be triggered when
duplicating the column alone to be working, not the snippet that
contains it.

Note: this required a backport of a33ec972ab
which was fixing a non-critical "bug" for 11.0. This non-critical "bug" is
therefor fixed here too.

opw-807105
2018-02-13 14:19:07 +01:00
Goffin Simon d7fdb636b8 [FIX]mrp, mrp_byproduct: Qty is not "produced" for Byproducts
When producing a product as a BoM, the quantity for the byproduct was not increased in "produced".

opw:814768
2018-02-13 14:07:23 +01:00
tde-banana-odoo f78ebb33e3 [FIX] mail: no crash for portal url when not logged in
When portal user get email with portal url (like using
website_quote), it crashes because user is not logged.
For this case, we don't want to display the url with the
access token, but simply redirect it to messaging page.

The crash was about the "KeyError: 'view_type'" in
record_action dict, coming from website_quote.

opw-814647
2018-02-13 13:56:45 +01:00
qsm-odoo 32bdadad13 [FIX] web_editor, mass_mailing: better transcode alignment inheritance
Browsers' default alignement of <td/> is 'inherit'. Some mail clients do
not set this value properly though and even if it is explicitely set,
they do not compute the final value well.

As a fix, this commit forces the 'inherit' value on <td/> and computes
the real alignment for 'inherit' values when transcoding.

opw-813688
2018-02-13 13:37:50 +01:00
Luis González 79f137f342 [FIX] base: Avoid error when keep_query is used outside an httprequest context
When the utility method `keep_query()` is used outside an httprequest
context (e.g. rendering a template from a unittest) the following
exception is throwng:
`RuntimeError: object unbound`

The above exception is caused by the method trying to retrieve
parameters from the HTTP request, even if the request object is unbownd.

This change ensures those parameters are retrieved only when exists,
making possible to use it outside the web client

Closes #18841

Closes #22942
Closes opw-815322
2018-02-13 12:03:20 +01:00
Sebastien LANGE 1a7f3c7335 [FIX] stock: wrong domain in stock.quant.package
Closes #22666
2018-02-13 11:39:27 +01:00
Martin Trigaux ca0875231f [FIX] survey: properly detect wrong token
Was in old API
  user_input_obj.search(...)[0]
but the tr/except was not migrated

Introduced at 66cb880
2018-02-13 15:56:01 +05:30
Rumpen 98a9ee022e [FIX] stock: inventory line write return
The override of 'write' function in inventory line doesn't return the
result, wihch prevent to override it, and may lead to trouble with RPC
calls.

This close the PR: https://github.com/odoo/odoo/pull/22118

Thanks to the author: https://github.com/Rumpen
2018-02-13 10:59:50 +01:00
Christophe Simonis adeea2a88d [MERGE] forward port branch saas-11.2 up to 0f02dcb639 2018-02-12 18:34:43 +01:00
Nicolas Lempereur a6e66131ce [FIX] web_editor: error on cross domain stylesheet
On latest chromium (as of version 64), accessing rules of a stylesheet
is forbidden for cross-domain.

This commit catch and ignores the error when that happened.

chromium commit: https://chromium.googlesource.com/chromium/src/+/a4ebe08c91

opw-813480
opw-815860
closes #23009
2018-02-12 18:21:00 +01:00
Christophe Simonis 0f02dcb639 [MERGE] forward port branch saas-11.1 up to c69d00157e 2018-02-12 18:08:27 +01:00
Alexandre Kühn 83354c2b24 [MERGE] mail,web,*: JS mail and services tracebacks
* account,bus, web_editor, website, website_slides, web_tour

This merge fixes most issues where the webclient crashed with
discuss installed in mobile.

These issues occur due to the fact that the chat_manager, now
a service, was loaded after the webclient is instantiated.
The main idea of the fix is to let the webclient register services
that are loaded after its instantiation.

Despite appearances, the desktop mode had also this issue, but
most of the bugs were hidden thanks to the availability of tours
that are loaded after the module mail.
2018-02-12 16:16:06 +01:00
Alexandre Kühn 7339ae978f [FIX] mail,web,*: Cleaning some JS code
- Whitespace trailing
- Split long lines
- Replace some 'self' to 'this'
- Improved some JS docs
- DRY in tests using services
2018-02-12 16:09:38 +01:00
Alexandre Kühn 066eaaeafa [FIX] mail,web: JS mail and services tracebacks
Fix over this commit: https://github.com/odoo/odoo/commit/02ec09cb1c3e2d7bc7968f40c18f2208d7f3f498

In mobile, when discuss is installed, there is a traceback.

This is a consequence on an issue with JS services, where some of them
are not registered in the service provider.
For instance, the webclient (the service provider) was instantiated before
chat_manager (a service), so it was not aware of this service.

To solve this issue, service providers now listen on newly registered services.

Also improving deployment of JS services by not relying on topological sort.
2018-02-12 16:09:38 +01:00
Alexandre Kühn 0de5c1f076 [FIX] web{_site,_editor}: transparent root instance 'root widget'
With this commit, any component that needs an instance of the
root widget can simply require the module 'root.widget'. Based on
the context (backend, frontend, iframe), the real root.widget
will resolve to either the webclient, the website root instance, or
the iframe root instance.

This is desirable in order for the tour_manager to become a child
of the root widget, as tours are enabled in any of the above contexts.

This commit is a requirement in order to solve an issue with JS services,
in which there should be only one service provider at any given time.
2018-02-12 16:09:37 +01:00
William Henrotin dd610140bf [FIX] purchase_requisition delete requisition.
The PurchaseRequisition unlink method call the wrong variable
2018-02-12 13:52:19 +01:00
William Henrotin 7ad9f28895 [FIX] purchase_requisition remove api.multi in action_in_progress
The action_in_progress method was tagged as api.multi but badly. so we
remove it and add an ensure_one() check.
2018-02-12 13:52:19 +01:00
William Henrotin ab4b03efcd [FIX] purchase_requisition sequence handling
As the sequence name depends on the requisition type. The name must be
set not when the requisition is in draft but confirmed. In the confirm
state, the type in readonly. The name is also reset when the requisition
is put in draft.
2018-02-12 13:52:19 +01:00
William Henrotin 69890545b0 [FIX] purchase_requisition edit product price to 0
When editing a blanket order, if the price change, the price also change
in the supplier info. The issue is we can set 0 in the price.
2018-02-12 13:52:19 +01:00
Jaykishan Solanki 317f5f1111 [IMP] product: Allow to search on variants barcode/ref from template
Purpose
=======

Be able to search on the internal reference & Barcodes of the product variants from the search on product.template
https://drive.google.com/a/odoo.com/file/d/0B0ITmdw6h3ZrZmw3Ym1LUzcwYU0/view?usp=drivesdk
2018-02-12 13:20:01 +01:00
Jaykishan Solanki 62900064c0 [IMP] sale,purchase,...: Hide Variants menuitems in debug mode
Purpose
=======

Avoid confusion between product template and product variant. People don't understand that editing some stuff on the product variants may impact the other variants

Specification
=============

Hide the menu Product Variants/Product Template in the debug mode

List of product menuitems
-------------------------

sales > catalog > products  (product.template)
sales > catalog > product variants  (product.product) => Add in technical
website > catalog > products (product.template)
website > catalog > product variants (product.product) => Add in technical
point of sale > catalog > products (product.template)
point of sale > catalog > product variants (product.product) => Add in technical group
purchases > purchase >products (product.template)
purchases > purchase >product variants (product.product) => Add technical group
inventory > inventory control > products (product.template)
inventory > inventory control > product variants  (product.product) --> Add technical group
manufacturing > master data > products (product.template) => Add technical group
accounting > configuration  > products (product.product)
PLM > master data > products (product.template)
lunch > configuration > products (lunch.product)
2018-02-12 13:20:01 +01:00
Christophe Simonis c69d00157e [MERGE] forward port branch 11.0 up to 169f899e29 2018-02-12 13:15:06 +01:00
Christophe Simonis 169f899e29 [MERGE] forward port branch saas-16 up to 835e5ed62b 2018-02-12 13:11:09 +01:00
Thibault Delavallée a65b0b2363 [MERGE][FIX] mail: fix notification emails not containing global links for URLs and images
See sub commits for more details. Was task 55210. #Closes #22940 .
2018-02-12 13:08:33 +01:00
Thibault Delavallée 29955b2109 [DOC] test_mail: increment activity counter
Sometimes runbot adds one query. Not sure why, let us avoid having
red runbots.
2018-02-12 13:07:41 +01:00
Thibault Delavallée 2ef1394e67 [IMP] mass_mailing: use mail thread link replacer
Mail thread now holds a method to replace local links by global links.
Let us therefore use it in mass mailing as it does basically the same
job. Adding base tag is not necessary anymore since there are not
local links or images anymore.
2018-02-12 13:07:41 +01:00