Commit Graph
117030 Commits
Author SHA1 Message Date
Arnold Moyaux 2c5022b4f3 [FIX] purchase: orderpoint should redirect to linked PO
Since procurement order removal. We lost the behavior
to access PO directly from the orderpoint.
In 10.0 the puchase button redirect to the procurement order
and the purchases were accessible from the procurement order.

We do not have the procurement order anymore thus the button
return to a list view with all RFQ and PO.

Fixes #23096
2018-02-28 15:36:27 +01:00
Goffin Simon c7526407ab [FIX] stock: Wrong production/scrap/adjustment location used in multicompany
- When using perpetual inventory valuation, the accounts used for scrap, manufacturing,
and inventory adjustment operations are set on the corresponding locations .
- In a multicompany environment, you will have a separate chart of accounts for each company.
- Account fields on locations are not property fields.
- Therefore, in order to separate the accounting of manufacturing, scrap, and inventory
adjustment operations, you must use a location for each operation for each company.
- Set up one location for each company for scrap, production, and adjustment
locations, setting the company field on each.

Bug:
- When attempting to create a MO, inventory adjustment, or scrap order while signed
in to the second company, you will receive a permissions error on stock.location.

Fix:
- Now the right location is taken according to the company of the user.

opw:1817339
2018-02-28 15:32:30 +01:00
Olivier Colson d1377650da [FIX] account: prevent the user from assigning to an account a tax belonging to another company than the one the account is linked to. 2018-02-28 15:27:48 +01:00
Laurent Smet bff30f58c5 [FIX] base: disable the copying of the res.company
When copying a company, the default accounts/journals are copyied too.
The chart_template_id and the opening move are also copyied.
To conclude: copying a company is a very bad idea that leads to a lot of access rights issues.

-githug issue: 21213
2018-02-28 15:19:48 +01:00
Thibault Delavallée 768e34756c [REV] hr_timesheet: revert commit 4e9138f8f9.
No purpose, no explanation, incorrect commit message, no review from
technical and functional team, no task, separate features mixed in same
commit, incorrect code.

As /dev/null and its related POs manage timesheet applicationplease ask us
for guidance and review before committing that kind of commits. Many thanks.
2018-02-28 14:29:59 +01:00
Thibault Delavallée 2d82d3a4b9 [REV] hr_timesheet: revert commit bfed0c82e6
No purpose, incorrect commit message, incorrect tag, no review from
functional team, no task.

As /dev/null and its related POs manage timesheet applicationplease ask us
for guidance and review before committing that kind of commits. Many thanks.
2018-02-28 14:29:50 +01:00
Christophe Simonis dae9b1a10e [FIX] account: correct move reversal
Oversight of previous forward-port
2018-02-28 13:56:11 +01:00
Christophe Simonis 0261d6d595 [MERGE] forward port branch 9.0 up to 239f4fec29 2018-02-28 13:41:04 +01:00
Laurent Smet d5d2a33424 [IMP] account_analytic_default: get the analytic acc. based on commercial_partner_id
The suggested analytic account must search based on the commercial_partner_id instead of
the partner_id field.

E.g. create an invoice with 'Agrolait, Thomas Passot', the analytic account 'Agrolait' wasn't set by default.

-github issue 21401
2018-02-28 13:32:18 +01:00
Kishan Gajjar bfed0c82e6 [ADD] hr_timesheet: Added employee_id field to form view so that default values passed in context can be set and send to server when save record 2018-02-28 13:30:06 +01:00
Kishan Gajjar 4e9138f8f9 [IMP]hr_timesheet: Only reset task_id if project_id is different thant task_id.project_id
- set employee_id if there is default_employee_id in context
2018-02-28 13:30:06 +01:00
Aaron Bohy d4126f7278 [FIX] web: DomainSelectorDialog: prevent overflow
The DomainSelectorDialog behaves differently from classical dialogs
in terms of height and overflow: (1) its height can be larger than
the screen height, and (2) its content is never scrollable
(overflow visible).

However, before this rev., the 'height: auto' rule ensuring (1)
didn't apply, so the dialog's height was limited to the screen's
height, and when it had to much content to display, it overflowed.

It didn't work because the code tried to apply the rule too soon,
so the .modal-dialog element was not yet available.

Fixes #23292
2018-02-28 12:04:33 +01:00
auyeung112002 b2c321fd1f [FIX] account: dummy_account_is should be readonly
Setting dummy_account_id to readonly avoid the journal entry items being wrongly set automatically.
2018-02-28 12:02:03 +01:00
Nicolas Martinelli 26325dc943 [FIX] sale: sale_count
- Create a user with Inventory access but no Sales access
- Access a product

An AccessError is raised because the user doesn't have access to
`sale.report`.

We hide the stat button if user has no access to Sales, and moreover we
do not compute the sales count in this case.

opw-1815436
2018-02-28 11:59:52 +01:00
Christophe Matthieu 7922dcbe48 [FIX] web: increase unit test speed
The method removeSrcAttribute is critical, because each changes trigger
this one. this method must be optimized to the maximum to be the fastest.

Before this fix, removeSrcAttribute method search the image and iframe for
all body nodes instead of search only in the inserted nodes, and the method
are very slow.
2018-02-28 11:55:20 +01:00
Christophe Matthieu b9a763ba3c [FIX] web_editor: avoid unnecessary slowdown of the web client
create range method slow down all the web client because the handler who
use this method it's in the module (not in the widget method) and called
for each click and keyup. We need only this handler for the iframe or the
website, used by the rte.
2018-02-28 11:55:20 +01:00
Laurent Smet 91be355bf9 [FIX] account: set "Financial Report" print action invisible
This action is generic to print the account reports (in community).
However, it doesn't make sense to call this method from list view because
the data are added explicitly in the _print_report method (in account.common.report).

-github issue 22349
2018-02-28 11:49:09 +01:00
Olivier Colson 239f4fec29 [FIX] account: When modifying the currency or company of a bank journal, also set it on the related res.partner.bank (if set)
See issue https://github.com/odoo/odoo/issues/22980
2018-02-28 11:39:05 +01:00
Vandan Shah 74a813542f [IMP] note: Use first stage as default stage_id if is stage_id empty
UI improvement:
If there is no stage then there will be no button(no status bar) but there will be stages but task or note etc.. will not be in any stage then there will be 'undefined' so by click on that ('undefined') user can move to any stages. To avoid this behavior we add a default stage in note.
2018-02-28 11:27:02 +01:00
Vandan Shah 476d125b63 [IMP] web: Status widget dropdown should be displayed on right side in mobile view 2018-02-28 11:27:02 +01:00
Nicolas LempereurandHumberto Arocha f0c801778a [FIX] base_import: allow whitespace as empty float
Empty cells containing only spaces may have unexpected results (not
shown traceback and broken import) when being imported and they were
intended for a float or monetary field.

To avoid the error we could either, ignore left/right whitespace when
parsing a float value (so same behavior as en emtpy cell) or prevent the
error and get an friendly import report error:

 ' ' does not seem to be a number for field 'Name of Field'

This change choose the first way, so a float ' ' (just whitespace) will
be considered as '' (empty).

opw-1816784
closes #23105
closes #23355

Co-authored-by: Humberto Arocha <hbto@vauxoo.com>
2018-02-28 11:17:21 +01:00
Sergei Ruzki 0dc32e6b8c [IMP] base_iban: add support of IBAN code for Republic of Belarus
Was PR #23058. Courtesy of Sergei Ruzki
2018-02-28 11:10:01 +01:00
Goffin Simon 287516c1a9 [FIX] sale:Empty email sent to followers when confirming the quotation
Steps to reproduce the bug:

- Subscribe another person as follower to all kind of messages in your default sales team.
- Create a new quotation.
- Hit on Send by Email and send the email.

Bug:

A empty email was sent to the followers.

Fix:

Now only the email rendered in the wizard is sent to the followers.

opw:1816028
2018-02-28 10:57:48 +01:00
Simon Lejeune 79d1529c57 [FIX] stock: tests and inactive locations
`child_of` used to return inactive records, it doesn't anymore
2018-02-28 10:33:44 +01:00
Raphael Collet e724858d50 [REF] models: use parent_path to implement parent_store
This replaces the former modified preorder tree traversal (MPTT) with the
fields `parent_left`/`parent_right`.  Each record is associated to a string
`parent_path`, that represents the path from its root node to itself.  The path
is made of the node ids suffixed with a slash:

              a                 node | id | parent_path
             / \                  a  | 42 | 42/
           ...  b                 b  | 63 | 42/63/
               / \                c  | 84 | 42/63/84/
              c   d               d  | 85 | 42/63/85/

This field provides an efficient implementation for parent_of/child_of queries:
the nodes in the subtree of record are the ones where `parent_path` starts with
the `parent_path` of record.  It is also more efficient to maintain than the
MPTT fields, and less sensitive to concurrent updates, because the value of
`parent_path` does not depend on sibling nodes.
2018-02-28 10:33:44 +01:00
Raphael Collet 80f1ac3599 [REF] never defer parent_store computation
Simplify the implementation of parent_left/parent_right by removing this
optimization.
2018-02-28 10:33:44 +01:00
Raphael Collet af05bf2027 [IMP] test_new_api: tests on parent_store 2018-02-28 10:33:44 +01:00
mreficent 38fde3bc01 [IMP] account: support company_id in community reports
Was PR #23259. Courtesy of Miquel Raïch (Eficent)
2018-02-28 10:29:38 +01:00
Laurent Smet c08f563795 [FIX] account: fix access rights of sequence journal
Changing the next sequence number on a journal requires having Administration/Settings access
rights. However, this feature should be available for advisors.

- github issue: 23352
2018-02-28 09:57:10 +01:00
XavierDo 561db474e0 [FIX] im_livechat: livechat now diplay messages.
The busbus wasn't available in the then clause and caused
the chat to be partially broken: message were not displayed
in customer window.
2018-02-28 09:56:45 +01:00
Humberto Arocha 13a59a4610 [FIX] l10n_mx: Add new tag to allow the reporting of importation taxes
This is needed in the DIOT report (l10n_mx_reports)
2018-02-28 09:46:25 +01:00
Lucas Perais (lpe) d396ed515c [FIX] website_sale_delivery: avoid double conversion to currency on delivery provider
Yourcompany is in currency USD
Go to the website and select the CAD pricelist
Have Fedex installed (then you'll have to set weight on the product you buy)
*Expected with DHL and generally any API driven delivery*

Make an online order to the USA but in CAD

Before this commit:
At the "Choose your delivery method" step
You'll see that the amount for Fedex that seems to be 'converted twice' into CAD
(And it is)

This is because there is a slight mismatch in how delivery compute their price
When the delivery is fixed, or based on a rule
Its price is always in terms of its company's currency
Whereas
in other delivery type, the price is computed in terms of ther order's currency

See the difference between the implementation of the  methods:
<get_price_available>
and
<provider_get_shipping_price_from_so>

OPW 1813466
2018-02-28 09:14:10 +01:00
Lucas Perais (lpe) b6d4cd5deb [FIX] account: reconcile on move reversal
Make an invoice for partner X
Make a payment from partner X (not using the register payment button)
On the invoice, you'll see your payment proposal

Now, reverse the move of the payment

Before this commit:
On the invoice you *still have* the payment proposal
This is because nothing reconciled the reversed entries with the original ones when they were created

After this commit:
The reversed moves are reconciled one on one with their original counterparts
And the original payment doesn't show up anymore on the invoice's proposal

OPW 1816462
OPW 1816641
2018-02-28 09:08:38 +01:00
Florent de Labarre 6c044b3675 [FIX] base : prevent unallowed launch
Do not allow to trigger the cron manually (e.g. via RPC call)

Closes #23157
2018-02-27 18:02:58 +01:00
Olivier Sarrat f620e78301 [FIX] doc: remove readonly as button possible attrs
According to #13264, setting a button as readonly is not working
Remove from the documentation

Closes #23114
2018-02-27 17:54:56 +01:00
David Arnold 56eead8356 [IMP] purchase,sale: use full map_tax signature
Some call signatures have not been aligned with the taxes/product/partner
signature
introduced by the tax cloud module and necesary by some localization modules

Closes #23334
Fixes #23333
2018-02-27 17:35:26 +01:00
qsm-odoo a206cca404 [FIX] base: properly layout contact name + country flag
Commit https://github.com/odoo/odoo/commit/13ee5596c6dd32b3471ce705b62b54ea59c00431
broke the behavior by changing a <t> to a <div> for no apparent reason.

(opw-1819038)
2018-02-27 17:03:27 +01:00
Martin Trigaux 65be76829a [ADD] doc: add missing params and profiling
* Add some missing database parameters in documentation
* Explain how to profile code

Closes #22554
2018-02-27 16:51:05 +01:00
Florent de Labarre cc10778927 [IMP] stock: allow inherance to find a picking
Closes #23300
2018-02-27 16:44:36 +01:00
XavierDo 4f4fa90aea [Fix] project: enable tag listing from configuration
Enable tag listing from configuration to allow admin to remove or edit tags

Task #58927
PR #23200
2018-02-27 16:18:07 +01:00
XavierDo 51957c1171 [Fix] hr_timesheet: task for view
Improves some aspect of timesheet for a better usability:
Rename "Subtask Planned hours" into "Subtasks" AND put "hours planned" next to the hours as units
changes track visibility of Deadline Planned hours so that a message will be generated when those values are changed.
Progress : it was possible to to have a progress higher than 100% when more time have been spend that the planned hours, but it doesn't reely makes sence for a progress bar.
Remaining hours should be editable: it is now possible to edit the remaining hours if needed, the field planned hours is updated in this case to keep informations consistent.
Also remove the default values of description for the subtasks when it was taken from the parent task name in some cases.

Task #58927
PR #23200
2018-02-27 16:18:07 +01:00
XavierDo 0fe1021982 [Fix] sale: move re-invoice policy
Move the reinvoicing policy to the purchase tab to avoid some confusion in the product form

Task #58927
PR #23200
2018-02-27 16:18:07 +01:00
Swapnesh Shah bd0827ed23 [Fix] base_gengo: add target Inline
To open the setting in the full window

Closes #23209
Fixes second part of #23170
2018-02-27 16:07:11 +01:00
Christophe Matthieu 832b4721f3 [ref] account: proposition for reconciliation respect access rules is sql
Simplification of the search method of the lines lines (for the
propositions) of the two requests in one. The sql query returns the two
matching lines without filtering after the request because we inject the
rules of access rules directly into it.
This is an optimization in terms of clarity and speed. In addition to the
fix because the previous browse does not use access rules.
2018-02-27 15:35:23 +01:00
Christophe Matthieu 659ee94204 [IMP] account: remove comments useful for forward-port 2018-02-27 15:35:23 +01:00
Yannick Vaucher cf4020a3ce [IMP] account: Don't redefine builtin str 2018-02-27 15:35:23 +01:00
Christophe Matthieu bdfd1ebf0c [REF] account: create 'account.reconciliation.widget' model
Contains widget reconciliation methods. This refactoring does not modify
the feature, some errors have been notified in the code but not modified.
2018-02-27 15:35:23 +01:00
Jairo Llopis 77db32edf2 [FIX] base: do not force creating localhost SMTP server
Do no recreate the record if it was removed for any reason

Closes #23285
2018-02-27 15:07:08 +01:00
Martin Trigaux 56c173af9f [IMP] misc: rephrase
Courtesy of e2f translators
2018-02-27 14:58:29 +01:00
apesquero 4b1ed44936 [CLA] signature for apesquero
Closes #23338
2018-02-27 14:54:35 +01:00