Commit Graph
126131 Commits
Author SHA1 Message Date
jpr-odoo caad35c29c [IMP] account, sale: improvement into the invoice report view
with this commit, changed the label of 'Shipping address' => 'Shipping Address' and removed 'Reference'
into the printed invoice report for a portal view

Task ID: 1930087
2019-04-12 09:04:26 +00:00
jpr-odoo 3d204d063f [IMP]account, website_sale: improvement into the invoice form view
with this commit, we have restructured 'other info' tab with few fields and updated the tooltips
and update the 'XPath' regarding the new restructure

Task ID: 1930087
2019-04-12 09:04:26 +00:00
Thibault Delavallée a7ac71ed44 [FIX][IMP] various: perform small cleanup of mail templates
Notably
 * remove cdata and fix html code when necessary;
 * re-order fields declaration to have globally the same order in various
   template definition;
 * remove unnecessary reply-to, make user signature and auto delete fields
   explicit when necessary;
 * improve some name to ease template ordering and understanding in the
   template list view;

Related to task 1972615
Linked to PR #32872

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-23 14:26:50 +00:00
Thibault Delavallée 678e04c19d [FIX][IMP] various: improve lang computation in mail templates
Purpose: add lang definition on templates where it is missing

Related to task 1972615
Linked to PR #32872
2019-04-23 14:26:50 +00:00
Thibault Delavallée 0b74c9ab6e [FIX][IMP] various: improve recipients computation in mail templates
Purpose: use more email_formatted when possible, clean and simplify
email_from, email_to and partner_to computation.

Next step is to try to extract some common patterns in tools or methods in
order to simplify template creation and customization.

Related to task 1972615
Linked to PR #32872
2019-04-23 14:26:50 +00:00
Robot Odoo 25c2c5e012 [MERGE][REF] hr: lessen use of custom activity types in hr plan
Allow to use todo activity type by default in hr plan in order to avoid
having to define a lot of unnecessary activity types. Custom activity
types are still supported in plan, just not mandatory to create new one
for each step.

Linked to task 1923387 .

closes odoo/odoo#30235

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-23 13:42:54 +02:00
Thibault Delavallée 30871950d2 [IMP] hr: improve plan views
Some fields are missing to ease configuration and daily use of plan and plan
activity types.

While we are at it some xml ids are updated according to guidelines.

Commit linked to task ID 1923387 and PR #30235.
2019-04-23 10:53:33 +00:00
Thibault Delavallée 5ce8f1e375 [REF] hr: clean some bits of models in plan
Containing

 * add missing rec name;
 * improve responsible computation;

Commit linked to task ID 1923387 and PR #30235.
2019-04-23 10:53:33 +00:00
Thibault Delavallée bea9662632 [REF] hr: allow to customize activity types in plan
Purpose of this merge is to avoid having to define custom activity types for
each step of HR onboarding plan. This is done by adding a summary field
on hr activities, allowing to use default Todo activity type and customize
directly the summary itself.

Using custom activity types is still possible. Here we allow to avoid noise
and having too much activity types defined as most of those activities can
be simulated using the default Todo.

People can still define and use their own activity types if necessary and
required in their daily workflow.

Commit linked to task ID 1923387 and PR #30235.
2019-04-23 10:53:33 +00:00
Thibault Delavallée 924a6d2a8a [MOV] hr: move files according to guidelines
Recent merge d5fd84b89a added onboarding plans to employees with some
new models. However conventions for naming files and views are not done.
This commit fixes that to ensure code readability.

Commit linked to task ID 1923387 and PR #30235.
2019-04-23 10:53:33 +00:00
Mohammed Shekha 04d5c36dd2 [IMP] web: consider select tag for o_row class
This commit will fix UI glitch when seletion field and
any other field kept on same line

Using o_row we can put two divs, two inputs side by side but
if we have case where from two elements 1 is input and second one
is selection widget then we will have glitches in UI,
this commit will fix that glitch

task-31003

closes odoo/odoo#23914

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-19 13:42:52 +00:00
Vandan Shah a57863f5a4 [IMP] *: use 'o_row' instead of 'oe_inline'
This will fix UI glitch for fields added in form view side by side

to get fields on same line and also to get space between
two fields use o_row oe_inline is used to put two elements
on same line but it is used mostly where 1 element is field
and second one is static string maybe in span, oe_inline on
two field creates glitch in UI, to have two fields or divs on
same line we should use o_row class, o_row class meant to do that

task-31003
2019-04-19 13:42:45 +00:00
Romain Derie d2ed857608 [FIX] website_sale: fix website_sequence
There was multiple issues with `website_sequence` field, mostly coming from
commits during the last few years (eg 43c544f8a8) that tried to change the
`website_sequence` order to be the same as `sequence` but changing only part of
the code.
Other commits tried to restore that again by changing only some parts.

This commit does:
1. Originally, the `website_sequence` was supposed to be the opposite of
   `sequence` field, the greater the first.
   This commit ensure this is not the case anymore and it is used as the
   regular `sequence` field.
2. `website_sequence` demo data was set between 4 and 1000, no need to use so
   big differences. Plus, having a website_sequence set to 4 means the next
   product would already have negative value.
3. Add `website_sequence` field in tree view in place of `sequence` for website
   product view, and in debug mode on form view.

task-1960777

closes odoo/odoo#32593

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-16 13:19:32 +00:00
mgh-odoo 728348f378 [IMP] survey: allow multiline comments using textarea
The comment for the question types:

- matrix
- simple_choice
- multiple_choice

Is now a textarea with a single row to allow expending it and see the full
answer when there is too much text to fit on the screen.

Some labels & alignments were also reworked in the process.

Task-ID: 1960726
closes : #32189

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-15 11:55:43 +00:00
Rishabh Jadia ae8d68c0fd [IMP] account, payment, sale, portal, *: unify section title on portal
* website_crm_partner_assign

Before this task, portal section titles were not unified, some titles had
'your', some 'my', some none.

This commit unifies everything.

task-51585

closes odoo/odoo#24697

Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2019-04-19 12:41:43 +00:00
Parth Patel 49bc5750a3 [IMP] project: UX Improvement of edit project form view.
Display field in two groups to display in four column.

Plus, email_from is used to 'Allow communication with a customer without
creating a partner'.
Since this field is not very useful, it is best to hide it to clean the UI.
Something was already done at aa33c81535

task-54027

closes odoo/odoo#22845

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-19 10:22:49 +00:00
Parth Patel c8a833cc10 [FIX] web, project: consider context pivot_row_groupby
Fixing missed 'pivot_row_groupby' assigned to groupedBy in pivot_model.js in
Load function (Already done in reload function), which was missed in commit
42f22a2.
Added qunit test case for testing correct value.
Apply pivot_row_groupby on user in project

task-54027
2019-04-19 10:22:44 +00:00
Robot Odoo 850bd33682 [IMP] website_form: auto install and add default form
Before this PR, if you don't know that we have a website_form module, you will never use it and keep the 80's feature of send an email. Now, it is automatically with website.

Before, when you drop a new form, you just had the default required fields.
Now, you will have default form and will be able to finetune this one.

There still some fixes to do:
 - extra_step: restore default value
 - contact_form: default value based on request.params
 - Refresh optionally data-source of x2many

That's one small step for Odoo, one giant leap for website_form.

See commits to have more details.

task-32212

closes odoo/odoo#32565

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-19 14:32:48 +02:00
Jigar Patel 126d180bc1 [IMP] website_form: set server-side form values outside the form
`t-att-` inside form should be removed because it makes the form not editable
by the form builder.
Instead of having these values set to the `<form>` DOM element, it will use a
`<span>` outside it.

task-32212
2019-04-19 10:39:21 +00:00
Jigar Patel 80ffa246e9 [IMP] website_form: adapt tour to new default form
Now, the default form already has multiple fields by defult, including
`subject` one.
The test was adding that field, so it now needs to add another one that is not
on the form.

task-32212
2019-04-19 10:39:21 +00:00
Jigar Patel 8cd6effa7f [IMP] website_sale: add default attributes for 'Create a Customer' form
task-32212
2019-04-19 10:39:21 +00:00
Jigar Patel 6c3de37761 [IMP] website_hr_recruitment: add default attributes for 'Job' form
task-32212
2019-04-19 10:39:21 +00:00
Jigar Patel 6df3ba8b22 [IMP] website_form_project: add default attributes for 'Task' form
task-32212
2019-04-19 10:39:21 +00:00
Jigar Patel cbd7a5c37f [IMP] website_crm: add default attributes for 'Create a Lead' form
task-32212
2019-04-19 10:39:21 +00:00
Jigar Patel 82a6222161 [IMP] website_form: add default attributes for 'Send an E-mail' form
task-32212
2019-04-19 10:39:21 +00:00
Jigar Patel 6404233bb0 [IMP] wesbite_form: add mechanism to allow default atttibutes to form
That way, it is possible to add the template, fields and success page to
different type of form.
Next commits will use what has been done in this commit.

task-32212
2019-04-19 10:39:16 +00:00
Jigar Patel e834de3d10 [IMP] website_crm: make CRM contact form editable by form builder
Add t-ignore to the DOM so it can be edited.
Also, now that website_form already add a form to contactus page, we need to
xpath that form.

task-32212
2019-04-19 10:32:19 +00:00
Jigar Patel 759350ce0b [IMP] website_form: add customize option for contactus form
As website_form is now auto installed with website, we want that module to
create a nice form by default but leave the possibility to the user to disable
it.

Wealso  want a thank you page in website_form as it now have a nice form on
contact us page.

task-32212
2019-04-19 09:15:01 +00:00
Jigar Patel fb51d5c648 [IMP] wesbite_form: change custom fields title for mail.mail
task-32212
2019-04-19 07:24:02 +00:00
Jigar Patel 41b8aa7f91 [IMP] website_form, website_crm: auto install website_form/website_crm
When website is installed, we want website_form to be auto installed so there
will be a nice form available instead of just a href mailto button.

Also, when both website_form and crm are installed, we want website_crm to be
loaded. Removing website_partner dependency do the trick. That dependency seems
to be only historical and not needed anymore anyway.

task-32212
2019-04-19 07:16:40 +00:00
Jinal Patel ba80cc63a7 [FIX] l10n_in: remove required
- Purpose of this task is to remove required attribute on HSN field because that is not more required.
- before applied this commit if set up an indian company, we have an error if we edit a product because of HSN field is required.

Related Task: 1948171

closes odoo/odoo#32077

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-19 05:19:51 +00:00
Jinal Patel bd4edfd5f1 [ADD] l10n_in(_pos,_sale,_stock): add demo data
- Add demo data in the field HSN/SAC Code and HSN Description into the products.

Related Task : 1948171
2019-04-19 05:18:01 +00:00
Yenthe666 4c333ec57c [IMP] mass_mailing: set ids on elements for cleaner xpath expressions
closes odoo/odoo#32751

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-17 07:13:39 +00:00
Kinjal Mehta 2b484317ff [ADD] website_sale_stock: allow to set warehouse on the website.
Purpose: Add option to set a default warehouse on the website.

Before this: We are showing all quantity of product for specific company not
specific warehouse.

After this: We will see availability of product based on warehouse set on the
website.

task-1913031

closes odoo/odoo#30104

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-19 06:22:02 +00:00
Jinal Patel 25153b50ef [IMP] sale: apply correct header to quotation email template
This commit applies the correct quotation header to the quotation email.
The header now states "Your Quotation" if the stage is quotation instead of "Your Sale Order".

Related Task ID : 1936003

closes odoo/odoo#30849

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-08 13:20:14 +00:00
Prakash Prajapati 0b9d752333 [IMP] payment: typo PayU Latam.
Change the label from PayUlatam to PayU Latam.

Hide s2s Form template field where Payment Flow is not s2s.

task-1940000

closes odoo#31048

closes odoo/odoo#31048

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-18 13:51:45 +00:00
Suraj Shukla 3f6aadaac4 [MOV] web, project: make cover image generic in kanban
Previously, we could only set cover image on the kanban view of project
task. This commit makes the feature generic so now cover image can be
added to any kanban view.

Technical notes:
- field used to display the cover image has to be set as 'data-field'
  attribute on the kanban dropdown's  menu related to cover image
- developer will have to take care while designing kanban views with
  cover image ability in such a way that it does not break the design

Task 32108

closes odoo/odoo#31731

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
2019-04-18 10:26:51 +00:00
RomainLibert 3c32f9b903 [IMP] fleet: add future drivers on cars + managers on models
Basically when someone requests a new car, getting that car ready takes
some time, this means that during the waiting period, that person is
still driving its old car.

This commit adds a field future_driver_id on fleet.vehicle to tackle
that problem and a boolean plan_to_change_car on the partner to track
who wants to change car.

+ Apply some linting to the files
This commit cleans the vehicle form view, the vehicle contract form
view, the cost list view and adds a manager_id field on the
vehicle.model which is then used as a related on the vehicle.

Task: 1930298

closes odoo/odoo#31197

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-04-18 11:55:25 +00:00
Yenthe666 5b2cf15c05 [IMP] website_forum: use plural for action and tree name
As multiple records are displayed

closes odoo/odoo#32588

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-18 10:17:05 +00:00
jbm-odoo 4b7f05face [IMP] hr(_presence): Merge reporting menu
hr_prensence add a menu 'reports' in employee app and

hr_contract_dashboard add a 'Reporting' menu.

Merge both together.

closes odoo/odoo#32377

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-04-18 08:07:43 +00:00
jbm-odoo c44f6ffd61 [IMP] registry.py: Log info instead of warning about dropped view during installation
This problem appears when the module l10n_be_hr_payroll_fleet is installed with the
dynamic report for employees (enterprise module hr_contract_reports).

This module inherits from hr.contract and will create and modify some fields.

By modifying contract's table, PostgreSQL will drop the view from
hr_contract_employee_report. At the end of the installation, PostgreSQL will
check if tables exist, it isn't the case for the view from
hr_contract_employee_report, so it will recreate it.

It's the normal behavior.

But when a table is missing, a warning is logged and create problem with
Runbot. For this reason, it's better to log an Info and not a Warning message.

Validated with @rco
2019-04-18 08:07:43 +00:00
William Henrotin 204a673ca6 [FIX] stock: computation of quantity on hand
On the product form view, the stat button computing the quantity on hand
doesn't give the same result as the quants list triggered by this button

    What's displayed in the stat button of the quantity on hand ?
    1 get the view location of all the warehouses
    2 built the generation tree from the view locations
    3 get all the quants for those locations

    What's displayed in the quants list of the quantity on hand ?
    1 get all the quants stored in internal locations

This commit share the same logic for those two views, by building the
generation tree for the view location then filter on internal locations

Task : 1929515

closes odoo/odoo#30501

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-04-18 08:37:59 +00:00
Josse Colpaert 06320be488 [FIX] l10n_in: do not set country on main company in demo data
Before this commit, the demo data in the
Italian localization would give errors,
because it was setting fields incompatible
with the company being Indian.

It is better not to do this and leave it empty.
 (Indian localization is the only to do this)

closes odoo/odoo#32781

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-04-17 14:49:58 +00:00
Pierre Rousseau fa87df0ddb [IMP] crm_iap_lead*: improve credits consumed feedback
To be able to correctly translate the information message on consumed credits, we are building those message in python in a computed field instead of building in xml with four computed fields.

Task-ID 1965687

closes odoo/odoo#32676

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-04-18 07:51:01 +00:00
Robot Odoo 7aa1e72779 [IMP] mail: Delete tracking values when uninstalling module
[IMP] mail: Delete tracking values when uninstalling module
--------------
### Purpose

mail.tracking.values should be deleted when the corresponding field is deleted (when the module which defined it is uninstalled).

Firstly because we don't want useless data in db.
Secondly because the groups associated with the field can no longer be checked if it was deleted. As we don't know to whom the value was restricted, the value should not be displayed anyway.

Note: this case was fixed in saas-12.2 by b9e96b7 but the proper
way to fix it is to delete the tracking values.

### Specification

Delete `mail.tracking.value` when the associated `ir.model.fields` is deleted.

Two alternatives were considered:

1. Change the `field` field of `mail.tracking.value` from Char to a m2o to `ir.model.fields` which allows to use delete oncascade. This implies to modify existing code, but more importantly it adds database queries.

2. Override the unlink method of `ir.model.fields` to first unlink associated tracking values.

The first method is probably cleaner but the second method was nonetheless chosen as we don't want to impact performance in the main tracking flow only to better support module uninstalls which happens rarely.

Note: when a module is uninstalled, `ir.model.fields` are unlinked one by one (in a for loop). Tracking values are therefore also unlinked field by field. Batchifying field deletion would greatly reduce the amount of queries.

[IMP] mail: Rename groups field of mail.tracking.value
----------------

This commit renames the `groups` field into `field_groups`.

The previous name was impossible to grep as the word `groups` is everywhere in the code base.

Also the new name better follows the implicit convention that fields related to the tracked field all start
with `field_`.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#31861

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-04-18 11:01:15 +02:00
Jigar Vaghela ab4f5b1ff3 [imp] point_of_sale: payment journal filter
Before this commit, payment journal "Available in PoS" should not
ticked by default if created from PoS. And if I remove the filter
"Available in PoS", I should not see all payments methods.

Now, payment journal "Available in PoS" is ticked by default if
created from PoS. And if I remove the filter "Available in PoS",
I should see all payment methods.

closes odoo/odoo#30748

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-04-18 07:11:57 +00:00
Dharmraj Jhala c1dbc3f5ab [IMP] website: make hamburger menu scrollable in small devices
Currently, in small devices, hamburger menu of the cloned navbar
is not scrollable due to fixed position.

This commit improves the behavior and makes the affixed navbar
scrollable, enabling user to navigate through all the available
menus.

task-1938637

closes odoo/odoo#32359

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-18 05:18:49 +00:00
Lucas Lefèvre ad8e969323 [FIX] mail: Don't display message if only subtype
Currently, if a message does not have any tracking
value, any attachment and no body BUT has a subtype
with a description, the message is not considered
as empty.

The message subtype should not influence its
"emptyness".
2019-04-17 17:44:08 +02:00
Lucas Lefèvre fbf9b55c5b [IMP] mail: Rename groups field of mail.tracking.value
This commit renames the `groups` field into
`field_groups`.

The previous name was impossible to grep as
the word `groups` is everywhere in the code base.

Also the new name better follows the implicit convention
that fields related to the tracked field all start
with `field_`.
2019-04-17 17:05:17 +02:00
Lucas Lefèvre 8d2d41068d [IMP] mail: Delete tracking values when uninstalling module
Purpose
=======
mail.tracking.values should be deleted when the corresponding
field is deleted (when the module which defined it is uninstalled).

Firstly because we don't want useless data in db.

Secondly because the groups associated with the field can no longer
be checked if it was deleted. As we don't know to whom the value
was restricted, the value should not be displayed anyway.
Note: this case was fixed in saas-12.2 by b9e96b7 but the proper
way to fix it is to delete the tracking values.

Specification
=============

Delete `mail.tracking.value` when the associated
`ir.model.fields` is deleted.

Two alternatives were considered:

1. Change the `field` field of `mail.tracking.value` from Char
to a m2o to `ir.model.fields` which allows to use delete
oncascade. This implies to modify existing code, but more
importantly it adds database queries.

2. Override the unlink method of `ir.model.fields` to
first unlink associated tracking values.

The first method is probably cleaner but the second method
was nonetheless chosen as we don't want to impact
performance in the main tracking flow only to better
support module uninstalls which happens rarely.

Note: when a module is uninstalled, `ir.model.fields`
are unlinked one by one (in a for loop). Tracking values are
therefore also unlinked field by field. Batchifying field
deletion would greatly reduce the amount of queries.
2019-04-17 17:05:17 +02:00