In the crm tour, we have a step where we want the user to drag and drop the
card. But the bubble for this step is just besides the icon to schedule the
activity. So if user tries to schedule the activity and hovers on the tour
bubble, the tour help overlaps the drop-down of activities and prevents
user from scheduling one.
This commit fixes the issue by moving the bubble for this step at the right
side of kanban card so that tour does not prevent user from scheduling the
activity.
closesodoo/odoo#66136
Task-id: 2449223
X-original-commit: e9b5a0522f019adb7ae17164e314206a61c71cc6
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit:
* When a o_status class is set on a label element it is not well displayed
in project.task_type_edit, event.event_stage_view_form and helpdesk.helpdesk_stage_view_form
since this commit has been introduced 288b24cbdf
After this commit:
* o_status labels are correctly displayed.
task-2453268
Related PR: odoo/enterprise#16173closesodoo/odoo#66048
X-original-commit: 6bb64722a11fb6c7ba216aff5ae1c11159c92559
Related: odoo/enterprise#16300
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
QWeb fields formatting would go to its own `html_escape` function
which could skip escaping depending on an option. This handles the
`html-escape` option from the early days of qweb (added in 2013), it's
unclear that it's ever been used (certainly is not now) and has been
superseded by things like HTML fields anyway.
closesodoo/odoo#65720
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
No sensitive information is releaved when querying this method but no
reason to let it public either. Better safe than sorry.
closesodoo/odoo#66093
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
The hex and rgba inputs styles were not matching other inputs ones when
focused.
closesodoo/odoo#66057
X-original-commit: 850581c49c84042bd5b40b632798c56789a1c60e
Signed-off-by: Samuel Degueldre <sdegueldre@users.noreply.github.com>
Description of the task :
Make the website ui as consistent as possible by making some layout
quick wins.
Behaviour before the PR is merged :
When changing an image in the image gallery snippet, its miniature
is not updated.
Desired behaviour after PR is merged :
The miniature of an image of the image gallery is updated when the
image is changed.
The snippet options listens to the 'image_changed' event triggered
by the media widget.
task-2438556
X-original-commit: a291923a95841c8b1ff9d3bb743f3da03a80dedb
Description of the task :
Make the website ui as consistent as possible by making some layout quick
wins.
Behaviour before the PR is merged :
'Recently View Products' filter is active by default on a product page.
Desired behaviour after PR is merged :
'Recently Viewed Product' is inactive by default.
task-2438556
X-original-commit: 33561335c55dc0a7586bea24935ec107df24dd89
Description of the task :
Make the tool as consistent as possible by making some layout quick
wins.
Current behavior before PR:
There is a padding between Product Attributes filter subitems.
Desired behavior after PR is merged:
There is no padding between Product Attributes filter subitems.
task-2438556
X-original-commit: 5a2d8dd188a80434b7006692b6c470948ad29291
When synced, if the user has an event on Microsoft Calendar and if this
user is not the organizer (he is only an attendee), he will have to
enable "Everybody's calendars" on Odoo Calendar to see this event.
To reproduce the error:
(Need one Google/Microsoft account A01 and one Microsoft account A02)
1. With A01, on Google/Microsoft calendar, create an event and invite A02
2. On Odoo, enable the sync with Microsoft
- See [instructions](https://www.odoo.com/documentation/user/14.0/general/calendars/outlook/outlook_calendar.html)
3. Go to Odoo Calendar, click on "Sync With Outlook"
- ! The sync must be done with A02
Error: The event is not displayed. The user must enable "Everybody's
calendars" to see it.
The problem comes from the attendees creation: it uses Microsoft
attendees' email address to link a partner with the event. However,
nothing ensures or requires that A02's email address is the same than
current partner's one. As a result, it is possible that the current
partner is not among the attendees. Moreover, Microsoft does not say
which attendee is the synced one. Thus, this fix always adds the current
partner to the attendees, so he will no longer need to enable
"Everybody's calendars".
OPW-2439189
closesodoo/odoo#66103
X-original-commit: 7579787c101923d450217cd167f50b9fcf21c690
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
When adding a line to a new SO, if the delivery date is in the future,
and even though the quantity will be sufficient at that time, the
symbol of the quantity remains red ("Not available").
To reproduce the error:
1. Create a storable product P
2. Create + Confirm a RfQ
- Add 1 x P
- Set the receipt date in the future (e.g., today + 7 days)
- (! Do not receive the product)
3. Create a SO
- Add 1 x P
- (In Other Info) Set the delivery date after the receipt date
(e.g., today + 8 days)
4. Save & Go back to order lines
Error: The chart next to the requested quantity is always red. This is
not true since the delivery is scheduled after the product reception. If
you click on the chart, the forcasted stock on delivery date is 1.
Therefore, the chart should be green.
This fix improves #60054: the latter updates the computation of
`will_be_fulfilled` using `free_qty_today` because there was an issue
when the SO is confirmed. However, the initial widget behaviour was
correct when the SO is not confirmed.
OPW-2440724
closesodoo/odoo#66101
X-original-commit: 685006681a54670b5e3f1615c2eb632700fffc65
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
Depdending on situation several fixes (f885202, fc8e446) leads to issue
in small screen size:
- in iframe editor with without snippets => the width of the content is
decreased of several times the sidebar that is not shown
- in editor with sidebar => the content gets behind the sidebar
With this changeset we remove part of the above commits which seem to
fix both issue.
note: this also fixes that the mass mailing content applied CSS should
not depend on screen size, or what is send would differ dependin on
which screen size clicked on SAVE (on last inlining of CSS).
opw-2426400
closesodoo/odoo#66104
X-original-commit: 3e41618240036f1f47bb25b993c46b4d268031d5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
This commit prevents the opening/closure of a channel on mobile when
the action is performed on desktop and reciprocally
closesodoo/odoo#66102
Tasks-id: 2267593
X-original-commit: a257e0ede12ead06c0f8dba90c3868761da6ea71
Related: odoo/enterprise#16323
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
In ff81fa479 there was some refactoring for change of structure on
frontend, but for the iframe editor (eg. mass mailing), this caused that
the top edition bar was over the content.
opw-2426400
closesodoo/odoo#66099
X-original-commit: d4a2e6cda246b498f604ac5765a5ef5d0041a577
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Current behavior before PR:
When looking for a user through the new message chat window, if there is already
a chat open for this user, the new message window is still open on selecting the
user.
Desired behavior after PR is merged:
when opening a chat from a new message, if the chat with this user is already
open then it will close the new message chat window on selecting the user.
LINKS:
PR https://github.com/odoo/odoo/pull/65851
Task-2449118
closesodoo/odoo#66085
X-original-commit: 016dedf172f750a0fcb1138a798faf2a224d513e
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
with this commit, we fixes UI glitch on image widget when image is too small,
when hovering over too small image Edit and Delete icon will ne displayed but
it is displayed with glitch, so to avoid that glitch we added min-width to
icons div.
task-2376452
closesodoo/odoo#66077
X-original-commit: 7aaad8480dde97b2d04b4148e4e54beb57b7f141
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Previously, since the group name was wrong, nobody can access this.
Now we let group_website_publisher read it...
Change is not critical, since previous typo make it unreadable for
all.
closesodoo/odoo#66061
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Before this commit, select the "No" option of a boolean field in the
search bar autocompletion menu would crash.
closesodoo/odoo#66058
X-original-commit: ad5d642c455d3215857f25e0d69c593324178d29
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Allow to set the work entry button as primary or secondary.
closesodoo/odoo#66047
Taskid: 2447940
X-original-commit: ab00e33796e3083714649e46beb0514e9333ce74
Related: odoo/enterprise#16299
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Issue
- Install `Time Off` module
- Go to `Time Off` and switch to month calendar view (default view)
- Select range of date
In wizard, `duration` is not set.
Cause
`date_to` and `date_from` are overided on default get request.
Solution
Do not override default value of `date_from` and
`date_to` if provided in default get request.
opw-2447931
closesodoo/odoo#66044
X-original-commit: 1ec4aa0b61777739d8bc82bbee968b9838f58410
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
This reverts commit 82f236d98e322efd84c873df54f8e728e1d2a1bf.
The fix is actually not solving all the issues, and also introduce
a behavior change. Actually, the expected result for filters like
<filter string="My Pipeline" name="my" domain="[('user_id', '=', uid)]"/>
will result into a evaluated filters, but invalid as the uid is set to
the person configuring the google configuration, not the user who will
use it.
As it is tricky (or even impossible) to solve the issue properly in all
the cases, we prefer to warn the user that the filter is invalid instead.
closesodoo/odoo#66042
X-original-commit: 5df2c1d10318cc53f1c3e90256cba6a48d246dcb
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
When buying a subcontracted product, if the inventory valuation of the
product category is automated, the product delivery does not create a
new journal entry, i.e. the automated inventory valuation is not done.
To reproduce the error:
(Need account_accountant,purchase)
1. In Settings, enable "Subcontracting"
2. Create a product category PC
- Parent: All
- Inventory Valuation: Automated
3. Create a product P
- Must be storable
- In category PC
- Set a positive cost
4. Add a BoM to P
- Type: Subcontracting
5. Create a RfQ
- Vendor: BoM's subcontractor
- Product: P
6. Confirm & Receive Products
7. Go to Accounting > Accounting > Miscellaneous > Journal Entries
Error: There isn't any journal entry about the new product. This is an
error because the inventory valuation for this product is automated, so
there should be a line with the P-product and the cost set on step 3.
When validating the delivery, the server checks the stock move lines
considered as incoming:
https://github.com/odoo/odoo/blob/5098cb25accce91347760cbd2f6427c07265fa00/addons/stock_account/models/stock_move.py#L61-L65
Problem is that `_should_be_valued` for subcontractor's location returns
`True`, therefore the stock move line will not be added.
=> The `mrp_subcontracting` module needs to add a condition:
A location can be valued if it is not subcontractor's location.
OPW-2446298
closesodoo/odoo#66004
X-original-commit: beb7159980f7ed29323d99fd4b72de3fa187f455
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
When changing a contract's state to "Expired", if the contract has an
end date, the latter is not updated. As a result, contracts' reporting
contains some error.
To reproduce the error:
1. Create an employee E
2. Create a contract C
- Employee: E
- Start date: in the past
- End Date: in the future (! at least after the current month)
3. Set contract's state to "Expired"
4. Go to Employee > Reporting > Contracts
5. On pivot view, change the rows:
- Total must be split into "Date > Month"
- Current month must be split into "Employee"
Error: on current month, "# Departure Employee" of E-employee is 0. It
should be 1. This value's computation is based on `contract.date_end`,
but when changing the state to "Expired", the variable will not be
updated if it already has a value. So "# Departure Employee" will be
equal to 1 for the month of end date defined on step 2, instead of
current month.
Note: The fix result can not be directly tested. The end date must be
done for the departure to be effective (`contract.date_end` < 'today').
Since this fix updates `contract.date_end` to 'today', "# Departure
Employee" will not count this contract until the following day.
OPW-2445504
closesodoo/odoo#66002
X-original-commit: 3cfc1e7dc3ad8396a92d12f74b65485e5938077a
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
Before this commit, clicking on the copy button on a
CopyClipboard field triggered the quick edit.
Now, clicking on the copy button won't trigger the quick edit
but clicking on the field's value will.
task 2455358
closesodoo/odoo#66035
X-original-commit: 050efe415ba7821305390be125ab3a9b059f3273
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Issue
- Install CRM module
- Go to CRM -> Configuration -> Lead Generation -> Lead Mining Requests
- Click on create and select a Sales Team
Traceback is raised.
Cause
`kanban_view_ref` attribute on sales team field is hardcoded.
Solution
Replace value to `%(sales_team.crm_team_view_kanban)s`.
opw-2444553
closesodoo/odoo#66013
X-original-commit: 2df520f0506770bc7b4486d827e2c9117d0d0c68
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>
Followup of odoo/odoo#61999 and odoo/upgrade#2060 . Not sure why version
counter has not been increased in community but well in upgrade finally.
Probably a mismatch between two reviewers.
closesodoo/odoo#66015
X-original-commit: 9c4eeb4fd2df40fe9136fed239c043917bc6d139
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
When reconciling a statement line that has no partner with multiple lines having different partners, the partner wasn't set on the auto-generated lines during the reconciliation.
X-original-commit: 09d44f94f1fe8ce3926adfa7196ed3a837260015
The currency is not always consistent between the journal and their accounts when coming from migrations.
It leads to some traceback when installing l10n_us_nacha or account_sepa writing a payment method at the installation of the module in case of the journal has a foreign currency but not the account.
X-original-commit: 426d5f429d85e42a31052f618a9a179148f501c4
Such repartition lines put their amount in debit for inbound operations (customer invoices, vendor refunds), and credit for outbound (vendor bills, customer refunds) ; so, the opposite of the lines with a positive percentage. However, we expect the tags set on the repartition line to express the way this debit or credit value will impact the tax report, so it means the tax_tag_invert has to be true in case this amount has gone to credit (so that a negative line balance doesn't change the sign in the report).
Before this, we computed the tax_tag_invert in the same way for all the tax lines, whatever the sign of their factor_percent. So, all the inbound stuff had tax_tag_invert=true (because we expected their amount to be in credit), and all the outbound stuff had false instead. So, we totally disregarded negative percentages, which was obviously wrong.
closesodoo/odoo#65977
X-original-commit: 08f3d2b90e3d48daa26ab48872b9cfd4d8db981f
Related: odoo/enterprise#16281
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Flow:
- Make an invoice in foreign currency with a given rate
- Register a payment for that invoice, in company currency, worth the invoice amount_residual but with a different rate
=> The cash basis entry was wrongly taking a rate of 1 to make the conversion between the amount in foreign currency and the company currency (see new test)
=> Additionally, the amounts to report on the tax report should always be equal to the ones from the original invoice when it's fully paid. Some tests were wrong in that regard.
In order to fix the issue, the way the cash basis is handling the percentage and the way used to fix all rounding issues at the generation of the exchange difference entry is different:
=> The condition triggering the exchange difference items for the cash basis entry is now handling correctly the case when the payment is made using another currency but the amount in company currency is fully paying the invoice.
=> The complexe method '_fix_cash_basis_full_balance_coverage' defined in order to manage rounding issues on the tax report when the invoice becomes fully paid is no longer necessary since the balance of each account (base + tax account) is automatically fixed by the extra journal items added to the exchange difference.
Indeed, after the generation of the exchange difference journal entry:
- the balance of tax transfer account is now reset to zero.
- the balance of the tax account is exactly the balance of the tax transfer account defined on the invoice.
- the journal items containing the tax base amount is exactly equals to the balance of the invoice lines.
closesodoo/odoo#65939
X-original-commit: 6db073e8f1865991b79b5b31b4a4a77158aa0d15
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Before this commit, the form renderer would call "on_attach_callback"
only when the whole _render process was over. The problem was that this
process is asynchronous and this callback should be invoked as soon as
the widgets are appended.
As such, any asynchronous operation is performed before appending the
content in a new function "__renderView".
Task 2346540
closesodoo/odoo#65991
X-original-commit: 953fb092636b9919aaa6c6a6cfaffd003ba951d5
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Using a new team rd-notif-muted
closesodoo/odoo#66020
X-original-commit: 157ac9a5bb034dec5edd630ea5d1c929e80ca7ea
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Actually, We don't want to distract the admin with an unnecessary notification
on General Channel. The main focus should be on odoobot's tour, not on the
general channel's welcome message. And it is also not a good idea to remove the
general channel as it would reduce the discoverability of the feature.
So, we are marking the first message as read for at least admin user.
therefore admin can not distract over unnecessary welcome notification and
focus more on the rest of the functionality.
Task : 2442023
closesodoo/odoo#66010
X-original-commit: 069923e53fcb93c4cf0a0715d500d23525aafbe7
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Prevent mistakenly adding "portal" to existing internal users through
the portal wizard as that can lead to odd behaviors (to the extent
that since 12.0 the "user type" uses radio buttons so it's not
possible to easily set a user as both internal and portal).
closesodoo/odoo#65981
X-original-commit: 8105902c4f6f467facad728ccd9763b7a44002bc
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
When copy-pasting text from rich text, the content may contain
unwanted formating instructions. Unsure it's escaped to avoid
propagating the content.
X-original-commit: 42f596a5b50e530fd5dc3f8c2939bc5b4e5921af
Due to asynchronous rendering, the attachment template can be rendered
when its attachment is undefined, this was causing an issue with an
unguarded getter call that was attempting to access the attachment.
This commit fixes this issue.
opw-2457983
closesodoo/odoo#65992
X-original-commit: 33802c65c3e8d04c54de3fca5903f66b34b9d13a
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
PURPOSE
Lessen differences between documentation and training courses
in eLearning frontend display.
SPECIFICATIONS
Allow documentation lessons to be seen in fullscreen mode. Default mode
is still the slideshare-like one but fullscreen is now available. This
imply notably computing category data in both modes to enable fullscreen
support and course lessons navigation.
Unify layouts. In this merge we
* use the left bar with course information on course page view on both
courses;
* unify menus and tabs;
* better integrate sale and forum as everything is not a single layout;
* move Type under Display to have all display related options within the
same option group;
* unify display, notably remove "+" on "+ Add Tags";
Finally provide some fixes for profile and rating, notably copywriting.
LINKS
Task ID-2275688
COM PR odoo/odoo#65454
UPG PR odoo/upgrade#2130
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Co-authored-by: Mariska Archielli <ram@odoo.com>
Co-authored-by: Thibault Delavallée <tde@odoo.com>
Purpose is to have some data in a documentation channel to see a bit
how they behave compared to training channels.
LINKS
Task ID-2275688
PR odoo/odoo#65454
Purpose of this commit is to lessen difference in layouting between courses
being documentation or training. Indeed we want a smoother user experience.
In this commit we
* use the left bar with course information on course page view on both
courses;
* unify menus and tabs;
* better integrate sale and forum as everything is not a single layout;
* move Type under Display to have all display related options within the
same option group;
* unify display, notably remove "+" on "+ Add Tags";
LINKS
Task ID-2275688
PR odoo/odoo#65454
Co-Authored-By: Mariska Archielli <ram@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>
Allow documentation lessons to be seen in fullscreen mode. Default mode
is still the slideshare-like one but fullscreen is now available. This
imply notably computing category data in both modes to enable fullscreen
support and course lessons navigation.
LINKS
Task ID-2275688
PR odoo/odoo#65454
Co-Authored-By: Mariska Archielli <ram@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>
Currently in profile, karma circle progress is black due to a wrongly set
scss variable.
LINKS
Task ID-2275688
PR odoo/odoo#65454
Co-Authored-By: Mariska Archielli <ram@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>
Steps:
- Install website_event_sale
- Go to Events
- Create a new event:
- Add a line:
- Sales Start: yesterday
- Sales End: tomorrow
- Click the "Go to Website" smart button
Bug:
The sales end date is not displayed. It's displayed when there are more
items.
Explanation:
When there is only one item, the layout is not the same.
This commit adds "Sales end on" next to the price.
opw:2449080
closesodoo/odoo#65994
X-original-commit: 5719f2eca7aedfba71fef1e6c94f31277b3dc0b9
Signed-off-by: backspac <backspac@users.noreply.github.com>
PURPOSE
Displaying the subject when the name of the record is exactly the same is
redundant and crowds the interface needlessly
SPECIFICATION
Subject should only be displayed if it is different than the name of the
record
LINKS
closesodoo/odoo#65969
Taskid: 2363130
Pr: https://github.com/odoo/odoo/pull/61044
X-original-commit: 2558768aadc1ab80443472ae9911b39f0b818d95
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, non-editable forms could switch to edit mode
when clicking on a field or a label.
Now, the edit right is checked when the quick edit is triggered.
task 2456324
closesodoo/odoo#65964
X-original-commit: 298746a3cce3d241417bcf62f4deeeb8f3d3ca92
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
ijas ahammed