Add a loader over the editor if an option takes some time to be applied
to indicate that something is being done.
In this commit, the following changes have been made:
- Add "_execWithLoadingEffect" method (will be used to add actions
to the mutex queue and set a loading screen over the editor 1s later).
- As soon as the mutex is unlocked (all computations are completed),
the loading effect will be removed (or canceled).
Part of https://github.com/odoo/odoo/pull/55614
task-2213114
X-original-commit: a4a745cf4f9ccade9876d885ab0774d3ec0bbf69
The overridden payment_transaction() method needs to accept positional
arguments as well, otherwise it will break any other override that would
use positional arguments, and will fail with:
payment_transaction() takes 1 positional argument but 6 were given
Introduced by 4d3f2fbdcda68d4f0e0bb3bb34d51e71d963621b via #51898closesodoo/odoo#57890
X-original-commit: a4f5f811aba02cb29e344a576fbae9305481dd73
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
Before this commit:
Currently, the 'Re-Invoice Expenses' field visible when 'Can be Expensed' is
true but after the module sale_timesheet installation, it is not working.
After this commit:
The 'Re-Invoice Expenses' field visible when 'Can be Expensed' is true even
when we have a sale_timesheet module.
LINKS
PR https://github.com/odoo/odoo/pull/57259
Task-2328493
closesodoo/odoo#57856
X-original-commit: 92ef9e1198090aa51556a63f42d91282d2070c0a
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Currently, method _apply_timesheet_label will add label on field
unit_amount with widget timesheet_uom but the widget on this
field is changed in another module as timesheet_uom_timer so it will
not work when that module is installed.
So in this method pass the view_type as argument so it can be easily
override in another module based on view_type.
closesodoo/odoo#57847
Taskid: 2287390
Related: https://github.com/odoo/enterprise/pull/11884
Related: odoo/enterprise#13279
X-original-commit: 6ce434b6d6ab686c91c111d2f86503176fec6517
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Purpose
=======
Some fields weren't editable, even when the option is enabled on
the settings.
closesodoo/odoo#57842
X-original-commit: 57d595e87642fa6f7bec62cbb88a39c35cc72589
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
The raw error message from psycopg2 wasn't clear for users and led to
multiple support tickets.
In case of such "concurrency" errors, the user should retry later, it's
not a "real" bug.
closesodoo/odoo#57851
X-original-commit: 9f7f1db5add5b8a940e53707091133c0bcadd350
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
On runbot the tour shows transient failures related to race
conditions.
The issue here is that when a user updates their own TOTP status, if
hr is not installed this will close the Preferences dialog requiring
reopening the dialog in order to check that everything worked.
However if hr is installed there is no dialog ("My Profile" opens as a
full action, which will not disappear on TOTP updates).
We still reopen the My Profile action, but if the server is a bit too
slow the tour may see the "old" version of "My Profile" which has not
been unloaded, click the tab to go to the next step, but because it's
already there the action has no effect, the next step is triggered
when "My Profile" finally (re)loads at which point we're back on the
first tab while the tour believes it should be on the second, and the
tour breaks.
Fix this by forcing a full reload of the action: between updating TOTP
status and checking for the status change, navigate to the Discuss
application then back to the preferences / profile screen.
closesodoo/odoo#57843
X-original-commit: 7a1dc71186d00ece21cede205a045fa93cd6dcfb
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
1. Login as admin
2. Go to any product page and click Personalize > Enable recently viewed
products
3. Login in another browser session as portal user
4. Open some products until you start seeing the recently viewed
products
5. With the admin account unpublish one of the recently viewed
6. On the portal account browse more to display the recently viewed
Access error will raise because an unpublished product is requested by
the user.
Filtering the product to allow only published products fix the issue.
opw-2336699
closesodoo/odoo#57836
X-original-commit: 668778125c2d4231d9b48456c3397edb8d04acb3
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
This commits solves different rendering issues in the javascript reference
documentation, following the work done in #57270, but for issues added in
further versions and missed in the forward-port.
Forward-port of #57758
Forward-port of #57775closesodoo/odoo#57835
X-original-commit: 8885cf578468d34e740bada95440f092f10c6268
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
- Create a SO
- Add a line with a lead time != 0, e.g. 7 days
=> the Expected Date is today + 7 days
- Add a note or a section on the SO
The Expected Date is today
This happens because we do not filter out notes and sections when
computing the minimum date.
opw-2340419
closesodoo/odoo#57792
X-original-commit: d3a6afe51fc4b864368acbc40a86ac6974d328dd
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Add back the default filters when opening the WO view from the work
center kanban views.
opw-2329401
closesodoo/odoo#57813
X-original-commit: 15ed2b92b83929becfd50334c7a31282c46d44d6
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Virtual keyboard has been removed in c6397ab, but the field to activate
it still existed. We remove it from the view and delete the field.
closesodoo/odoo#57794
X-original-commit: 0979435d6612f4de8b7c94e09be1302cec53e706
Related: odoo/upgrade#1773
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
According to the Spanish accounting rules, this commit tries
to set more appropriate account types to the different
account_account templates.
closesodoo/odoo#57741
X-original-commit: 970d9bf10283e770c984d78fe145fd61a2be43dc
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
PURPOSE
On the user rights screen, we can't choose responsible.
It shouldn't be visible.
SPECIFICATIONS
A "Time off Responsible" rights will be implicited as a checkbox in debug mode.
Also, changed "Manager" by "Approver" on Time Off type settings.
LINKS
PR https://github.com/odoo/odoo/pull/56807
Task-2314833
closesodoo/odoo#56807
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
PURPOSE
user with the 'team approver' or the 'all approver' access right levels
cannot approve his own expenses. However, the 'approve' button is still
being displayed, which is confusing and misleading, and an ugly user error
is thrown when the user tries to click on it
SPECIFICATIONS
Hide the 'approve' button on expense reports If the user has either the
'team approver' or 'all approver' access right levels and the employee_id
set on the report is linked to the current user
LINKS
Task-2323982
closesodoo/odoo#56784
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
If the partner was created then the company, the api would return the
partner, find the corresponding company and return it with the
partner, but not actually link the newly found/created company with
the partner in the db.
Would happen for example if the user had no reveal credit when he
added the partner. Then credited his account and opened an email from
the same partner again, triggering the creation and enrichment of the
company.
closesodoo/odoo#57825
X-original-commit: 5879f7dede16c8ba574ed648e4c91ca438eb93fa
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Before this commit, selecting the whole content of the custom filter
input and releasing the cursor outside of the dropdown closed the
dropdown.
With this commit, the dropdown is kept open in this situation.
task - 2276544
closesodoo/odoo#57807
X-original-commit: 450e0ec45005c3d6c2e8475e134113a7d8515e9f
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: Mohammed Shekha <msh@odoo.com>
* Prior to this commit only one selector could be provided in order to got to the
next tour step.
* After this commit an additional selector can be provided in order to consume
a tour step. This additional selector can be specified through the step property
alt_trigger. We also toke the opportunity to remove $actualAnchor in tip.js as no
more used.
task-2325001
Related PR: odoo/enterprise#12711closesodoo/odoo#57680
X-original-commit: 9606e9e231be9e1e7d15ea0efdedbf5afff47102
Related: odoo/enterprise#13214
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
The behavior isn't exactly undefined: it will appear to work if the
relation refers to only 1 instance. If there are multiple it will give
results for 1 instance and ignore the others. This behavior should not
be relied upon, hence I'm documenting it as undefined. I confirmed this
with mat from the ORM team.
Even better would be to raise an error or warning if `related` is used
in this context.
closesodoo/odoo#57270closesodoo/odoo#57815
X-original-commit: 6ae421f551ee36afa836494bc8563fc9276ab31e
Signed-off-by: Raf Geens <raf-odoo@users.noreply.github.com>
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Co-authored-by: Raf Geens <raf@odoo.com>
Added an example because it's non-trivial to realize why you would want
to set `mode` to `primary` together with `inherit_id`.
Another way to look at it is that the view matching doesn't understand
delegation inheritance. If it did there would be no need to override
`mode` because it would be able to see that the parent and derived views
refer to related models. But since that feature might not be worth the
effort, it's ok for me to just document the current situation.
X-original-commit: 549d159a836229f634be04131db947b275240edb
Some line items in a bulleted list would span a paragraph but the first
line of the paragraph would be in bold and the rest would be indented
and not bold below it. You would end up with sentences that broke off
half in bold and half in the regular font. This was due to wrong
indentation in the source.
The pattern was also used for more legitimate cases (field descriptions),
as well as borderline cases (where a section might have also worked).
I've updated the borderline cases to have consistent formatting across
the document and removed the bullet points that were prefixing
description lists in both cases.
X-original-commit: 2d865d80b1b9d14994562f0c77b16e99a4167fcf
MAT confirmed the Javascript API is currently not being built due to
repeated compatibility problems between ES6 and the docstring output
with no clear solution in sight.
X-original-commit: 3198d0120a9388768ee882bb98e279f860a5b456
The page shows the first 15 lines of a CSV in raw form as an example.
Next it shows the same data rendered as a table. However, it was
displaying the entire 680-line source data. `csv-table` doesn't have a
`:lines:` directive. I copied and truncated the original file for use
in the documentation.
X-original-commit: 04d4ec33043627747e36730953479557aae278f2
Add reservation information in the forecasted report.
Also this information is used by the forecasted information in
stock move.
closesodoo/odoo#57814
X-original-commit: 87b16dab35c2326220d5bbd51bb7f07e876352d1
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>
Before this commit, the pad key and server were saved on the company. It was an historical decision whose reasons no longer applies.
The "Root url" called later "URL template" was company dependant but it no longer exists.
closesodoo/odoo#57014
Taskid: 2326514
Related: odoo/upgrade#1739
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Task 2333152
The call to `ref` can not be done in py.js, it needs to be evaluated
before, when creating the action.
closesodoo/odoo#57770
X-original-commit: 1e9ddfbf9dbc8bbe86e3ebc183d5936b146cdf14
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Signed-off-by: wan <william-andre@users.noreply.github.com>
*: website_blog
- The scroll button option is now again available for all snippets, not
only when the height is forced to 50% or 100%. Indeed, nobody would
think to change that option if the snippet is already naturally tall
and you could well want that scroll button on small-height covers.
- The scroll button is now placed on top of the snippet content instead
of below in its natural flow. This allows it to work with snippets
like "Big Boxes" and actually prevent to miscenter the snippet content
just by adding that scroll button.
- Review the option UI and allow to control the spacing around the
scroll button.
- the "Big Boxes" snippet was at last adapted to work well with 50% and
100% height options.
- The 100% height option has now associated JS so that the height is
computed to use 100% minus the size of the header.
Note: this may be backported to 13.2 where the option was introduced and
where those improvements may appear essential for the feature to not be
considered as buggy.
Part of https://github.com/odoo/odoo/pull/57764
task-2224404
X-original-commit: 9d5cd2c1747488524c107e6165d7c55d74b80606
Issue was spotted in list views containing the "badge" widget with
decorations (e.g. in the Purchase Order list view). At first, the
decorations were correctly applied, but they weren't anymore after
a reload (e.g. after toggling a filter).
They weren't because the list renderer didn't called
'on_attach_callback' on its subwidgets at reload (thus, 'mounted'
wasn't called on its subcomponents, and the decorations are applied
in the mounted hook).
This commit moves the logic from the FormRenderer to the
BasicRenderer, so that it applies on List, Kanban, and Form views.
This commit also removes the transition scss rule on the badge
field widget as it caused a flickering at reload.
Task 2336440
closesodoo/odoo#57766
X-original-commit: 713bce22e8f412f2c26e663b9e30fdd64933ff0c
Signed-off-by: Michaël Mattiello <mcm-odoo@users.noreply.github.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This test ensures that method `Callbacks.run` is re-entrant, i.e., it
can be called from a callback being run. The behavior is to execute the
remaining callbacks, and then resume the current one.
This completes https://github.com/odoo/odoo/pull/57469.
closesodoo/odoo#57778
X-original-commit: 7de434ebc091c4d85615c6cf69240e07b98fe767
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
This simply makes it less easy to screw up a database by preventing all
users to do their daily tasks.
closesodoo/odoo#57776
X-original-commit: 665a795fc1b199f4f17cc9f1257d1b36b6276e6f
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Co-authored-by: Florent de Labarre <florent.mirieu@gmail.com>
When running -i website --test-enable, the test was falsy.
The last page created page was present in matching_page wich one is a criteria
to be excluded from last modified page to avoid duplicate suggested page.
Now we substract correctly them before comparison.
https://github.com/odoo/odoo/blob/saas-13.4/addons/website/controllers/main.py#L243closesodoo/odoo#57777
X-original-commit: 19319a7f88f474a6410ea1dabc6bcc1ac51e97bb
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Without this you have to overwrite the entire function.
closesodoo/odoo#57696
X-original-commit: c2e980c3798c3cf75e4f96b71c7bc81dbad6b78c
Signed-off-by: jorenvo <jorenvo@users.noreply.github.com>
Remove fold/unfold from the tab 'Style', as we have in fact enough
vertical space. For the UX it is better to remove it from there.
task-2327111
closesodoo/odoo#57726
X-original-commit: fd36b2ad01c902b0d5745b0faaabed9afccede17
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
saas-13.5 version of odoo/odoo@15f2bbd40a
The tests must be only imported in a test context, not in a running
context.
Since 92a7f8c a new test requirement was added but it should
not be necessary to run a module, only to execute the tests.
closesodoo/odoo#57728
X-original-commit: 5a74fdad59144a68ed8b6670dbd63731c8090048
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Up to Odoo 13.0, the windows setup is 32 bits and embeds an old
postgresql 9.5 32 bits version too.
With this commit, the postgresql server is no longer embedded in the
resulting setup file. Instead, if the user choose to install the
postgresql server, the 12.4 version is downloaded from the official site
(version 10.14 in the case of a 32 bits windows).
Also, the Python target achitecture is choosen based on the Windows
system on which Odoo is installed.
This imply changes on the KVM images used to build the installer:
- The Windows system on the KVM as to be 64 bits.
- A 32 bits WinPython version must be in `c:/odoobuild/WinPy32`
- A 64 bits WinPyhton version must be in `c:/odoobuild/WinPy64`
A little bit of cleaning also comes with this commit to get rid of the
old `openerp` references.
closesodoo/odoo#57727
X-original-commit: c47d7c67066ff15602b16f18c4c3acebfd3a2755
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
QR-IBAN can be different than IBAN, so we added a separate field
to be able to put the QR-IBAN. It can be in handy in cases of
reconciliation afterwards or when different systems are used
at the same time.
If this field is filled in, we will use it for generating the
QR-IBAN barcode instead of the Account Number.
Thanks to Ravi Gohil.
closesodoo/odoo#57707
Task: 2307262
X-original-commit: 1cca4d9ec624b08cb85b1e53727fd67a3804c95a
Signed-off-by: Josse Colpaert <jco@openerp.com>
We refactored a method to check if the IBAN is in the correct
range to be a QR-IBAN or not. (to be able to reuse it)
Thanks to Ravi Gohil
Task: 2307262
X-original-commit: efd6e493a6d855c12e43e9b3cb7c436c6d7de35a
This warning is unlikely to be triggered during an install, and is problematic
during an upgrade since upgrade scripts will already do the same check but are
able to manage exceptions. The log is kept in log 25 for debuging/monitoring.
closesodoo/odoo#57667
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Add the address in purchase protal so that when in a multiple company
environment, the user can see which company the purchase order comes
from.
Task 2328169
PR #
closesodoo/odoo#57651
X-original-commit: 2081048662c219a181d7309307f021f02fb43739
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Remove the json_forecast of the sale order line,
it was a duplicate of information with the qty_at_date_widget.
But improve this one:
- Use the forecasted move information in case of confirmed SO.
- Change the icon (i) to chart.
- Link to the forcasted change to target new forcasted report
(Unfortunately we loose the feature to see components product forcasted
of a kit)
- Change information print in the popover in case of confirmed SO.
Also refactor the json_forcasted of `stock.move` into multiple fields
to avoid to dump/loads for other model who needed the forcasted data.
task-2324039
closesodoo/odoo#56425closesodoo/odoo#57526
Related: odoo/enterprise#13063
Related: odoo/enterprise#13160
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
xO-Tx