Commit Graph
124195 Commits
Author SHA1 Message Date
qsm-odoo 932fdb4e24 [FIX] web_editor: hide link buttons duplicates instead of removing them
For example, if primary = alpha, the primary button option is removed
in the link dialog. When editing a primary button, this lead to broken
behaviors. Hiding the button does the trick.
2018-10-19 09:58:00 +00:00
qsm-odoo b154709645 [FIX] website: remove useless select-class class 2018-10-19 09:27:29 +00:00
qsm-odoo 74086da371 [FIX] website: clone correct slide on addition
When adding a new carousel item, the first one was duplicated instead of
the active one.
2018-10-19 09:27:28 +00:00
qsm-odoo 3704e9583b [FIX] web_editor, website: remove traces of CKE 2018-10-19 08:37:01 +00:00
qsm-odoo aa2f86b14c [FIX] website: border/rounded/shadow options were not working together 2018-10-19 08:37:01 +00:00
qsm-odoo 720a129544 [FIX] website: make rounded option work with jumbotron 2018-10-19 08:37:01 +00:00
qsm-odoo 2d4c3bf662 [FIX] website: increase compatibility with previous column system
Before 12.0, snippet columns were using col-md instead of col-lg.
Also, this improves efficiency and readability.
2018-10-19 08:37:01 +00:00
Lucas Perais (lpe) 4e72669cc8 [FIX] auth_signup: compute signup_valid in sudo
Before this commit, the signup_valid field was miscomputed
probably due to some env mayhem.
Hence the banner with the link to reset the password was never shown

After this commit, the field is well computed, and the banner displays

OPW 1894390

closes odoo/odoo#27901
2018-10-17 14:30:22 +00:00
Christophe Simonis 1810f6be4c [FIX] core: early fail on missing foreign records
When installing/updating a module, verify existence of foreign records
before updating them.  Also handle forcecreate=False records.

Also fix misprefixed XML id in sale_quotation_builder.

closes odoo/odoo#27659
2018-10-19 11:23:47 +00:00
Robot Odoo 78537943b9 [MERGE][FIX] livechat, *: open livechat from URL
*: mail, web

This fixes the following issues:

### 1. Livechat menu was not visible when accessing from the customer URL

The customer URL is obtainable by following those steps:

- Access `/web`
- Click on Live Chat app
- Open a Live Chat Channel
- Click on "Widget" sheet
- Access livechat from (2nd) "Copy Text" button

This is due to missing JS modules in the external lib, such as the root widget.

### 2. The position of the buttons "Copy Text" is modified on pressing 'ALT'

This is caused by the keyboard navigation overlay that changes the CSS
position of the parent of the overlay element. It sets the position to
`relative`, so that the overlay exactly covers the element. However, if the
element had a position `absolute`, changing it to `relative` may re-position it
somewhere else on the page.

In fact, it is not necessary to set the CSS position to `relative` in this case,
because the overlay has CSS position `absolute`: an element with `absolute`
will match the size of the parent if the parent is also `absolute`.

Task-ID 1885445

closes odoo/odoo#27578
2018-10-19 13:37:08 +02:00
Mohammed Shekha a4bcbecff1 [FIX] web: keyboard overlay with position absolute
Before this commit, when an element with access key has a CSS
position absolute , pressing the key 'ALT' to show the access
key overlay may break the position of the element.

This is due to altering the CSS position of the element which the
overlay is attached to: it becomes `relative`, so that the overlay
takes the whole size of the attached element.

In case of an absolute element, it should not become relative,
otherwise its position on the document may be completely different.
Since the overlay has position `absolute`, if its parent has also
position `absolute`, then keeping both with position `absolute` will
let the overlay take the size of the parent, without changing the
position of the parent.

Task-ID 1885445
2018-10-19 09:23:21 +00:00
Mohammed Shekha 10cf85e4c5 [FIX] mail: ignore popover if bootstrap not available
Before this commit, there may be a silent crash when accessing the
livechat from the customer URL, e.g.
`http://mycompany.odoo.com/im_livechat/support/1`.

This issue occurs when bootstrap popover lib is not available.
This does not occur if one tab of the current browser has this lib
loaded. To reproduce this issue, open the customer URL from another
browser:

1. Access to `/web` from any browser (e.g. Chrome)
2. Go to Live Chat app
3. Select a livechat channel
4. Go to sheet page "Widget"
5. Copy text of the customer URL (2nd "Copy Text")
6. Paste the URL in a different browser (e.g. Firefox)
7. Open the livechat menu
8. Inspect dev tools

=> It will complain that `popover` is not a function.

We would like to keep the livechat lib as small as possible,
so instead of importing the boostrap lib, we simply prevent
the logic that generates the issue.

Task-ID 1885445
2018-10-19 09:07:24 +00:00
Prakash PrajapatiandMohammed Shekha 8929960492 [FIX] im_livechat, bus: open livechat from customer url.
Before this commit, there was no livechat menu when accessing it from
the customer URL, e.g. `http://mycompany.odoo.com/im_livechat/support/1`)

This is due to missing JS modules, such as the root widget.

Also, the crosstab polling directly requires the session module,
because the public root widget does not return the session module
from the OdooEvent `get_session`.

Task-ID 1885445

Co-authored-by: Mohammed Shekha <msh@openerp.com>
2018-10-19 09:05:17 +00:00
TWA 972c8e9ff5 [FIX] web: File upload input on_clear event not propagated
The handler function was used directly in the code. The MouseEvent wasn't provided in that case.
This FIX split the handler function and the processing function so that it doesn't interfere.

closes odoo/odoo#27929
2018-10-18 08:55:07 +00:00
Adrian Torres 0ac93c3828 [FIX] loading: set dbdemo if demo install success
opw-1896028

closes odoo/odoo#27945
2018-10-19 07:42:30 +00:00
Julien (juc) Castiaux 6e97e354d8 [FIX] sale: Wrong email state for order confirmation
The email sent after an electronic payment is sent using the
quotation template instead of the order template.

This PR changes the way payment are done in the backend so
the order has the correct state before sending the email.

opw-1894258

closes odoo/odoo#27847
2018-10-17 09:18:49 +00:00
len-odoo 89b15b6d87 [FIX] account: do not crash if base_import is not installed
The BillsListView adds an 'Upload' button to the view list of buttons.
However it tried to add the 'Import' button even if 'base_import', the module
adding that feature, was not installed.
It resulted in a crash, making impossible to access vendor bills.

opw 1895223

closes odoo/odoo#27939
2018-10-18 11:48:11 +00:00
Robot Odoo 0bcf9cae18 [MERGE][REF] (test_)mass_mailing: move/improve tests and fix link shortener
Purpose of this merge is to move some mass mailing tests into test_mass_mailing
module. Some tests were duplicated when merging new mass mailing tests at
https://github.com/odoo/odoo/commit/0c37eb272fba1063444f0ec91db1fe543c1beebf . This merge moves some tests to the specific test module for mass mailing.

Performance tests are also added to have some counters for future mass mailing
improvements.

A tool method to create new test users is also added in order to reduce
duplicated code present in a lot of tests. It allows to quickly create tests
users given a login and access rights groups.

See sub commits for more details.

This merge is linked to task ID 1889703

closes odoo/odoo#27526
2018-10-18 17:30:06 +02:00
Thibault Delavallée b4b2a04291 [IMP] test_mass_mailing: add performance tests
Purpose is to have some basis performance counters when sending a mailing
on 100 records, with and without blacklist involved. It will serves as
reference when working on mass mailing performance improvements in future
tasks.

This commit is linked to task ID 1889703 and PR #27526.
2018-10-18 13:57:02 +00:00
Thibault Delavallée dcec209805 [FIX] mass_mailing: fix tracking link creation in mass mailing
When using only mass mailing two issues arise when trying to send mass
mailings containing links

 * a link.tracker is created for each link to shorten; however rights are
   given currently only in website_links for website designers and not to
   marketing users that use mass mailing. This commit adds the rights for
   link.tracker model to those people;
 * a link.tracker.code is created to hold the shortened versions of the
   links. As it is a technical model it is now done as superuser as rights
   on link.tracked model has already been granted and adding rights on such
   a technical model is not necessary;

A test is added that checks what is done with links when sending mass
mailings. It helped spotting the hereabove issue.

This commit is linked to task ID 1889703 and PR #27526.
2018-10-18 13:57:02 +00:00
Thibault Delavallée 7edcbfec38 [REF] test_mass_mailing: use odoo test helper method to create test users
Purpose of this commit is to use the newly introduced helper to create
test users in a quick way and reduce code duplication.

This commit is linked to task ID 1889703 and PR #27526.
2018-10-18 13:57:02 +00:00
Thibault Delavallée 96fbc1a957 [MOV] (test_)mass_mailing: move not mass-mailing models specific tests
Purpose of this commit is to move tests not completely specific to some
mass mailing models to test_mass_mailing. Purpose is to allow to write
more in-depth tests based on existing ones by using test models instead
of some standard odoo ones.

This commit is linked to task ID 1889703 and PR #27526.
2018-10-18 13:57:02 +00:00
Thibault Delavallée 78f14a0aef [MOV][REF] test_mass_mailing: move and clean blacklist access rights tests
Purpose is to continue the move of some tests from mass_mailing to
test_mass_mailing done at https://github.com/odoo/odoo/commit/0c37eb272fba1063444f0ec91db1fe543c1beebf. Some additional cases are added in the
parsing of blacklist entries to test some corner cases.

This commit is linked to task ID 1889703 and PR #27526.
2018-10-18 13:57:02 +00:00
Thibault Delavallée 397434a75d [REF] test_mass_mailing: use odoo test helper method to create test users
Purpose of this commit is to use the newly introduced helper to create
test users in a quick way and reduce code duplication.

This commit is linked to task ID 1889703 and PR #27526.
2018-10-18 13:57:02 +00:00
Thibault Delavallée dc2ade763a [REF] hr, hr_holidays: use odoo test helper method to create test users
Purpose of this commit is to use the newly introduced helper to create
test users in a quick way and reduce code duplication.

This commit is linked to task ID 1889703 and PR #27526.
2018-10-18 13:57:02 +00:00
Thibault Delavallée a7b3d1697c [REF] test_mail: use odoo test helper method to create test users
Purpose of this commit is to use the newly introduced helper to create
test users in a quick way and reduce code duplication. A mail specific
helper tool function is defined based on the standard one defined in test
allowing to pass a custom context. It bypasses mailing features in order
to speedup the creation.

This commit is linked to task ID 1889703 and PR #27526.
2018-10-18 13:57:02 +00:00
Thibault Delavallée 7429c61dfc [IMP] tests: add an helper in odoo tests in order to quickly create test users
Following great @odony review we decided to add a helper method allowing
to quickly create users in tests in a one-liner. It will allow to remove a
lot of duplicate code in various test classes and methods.

This method basically requires a login and a comma separated list of user
groups xml ids. Kwargs are supported to further customize the created
user. A custom context can be given to the creation as user creation in
odoo can support several options within standard addons, like mailing or
signup options.

Next commits will propagate the use of this helper in some test classes
notably in mail, hr and mass mailing.

This commit is linked to task ID 1889703 and PR #27526.
2018-10-18 13:56:56 +00:00
Alexandre Kühn 5a552f0302 [FIX] mail: auto-follow on message post
Before this commit, there was the following issue
in the chatter:

- on document with customer field set;
- open the composer;
- post a message with suggested partner checkbox set;

=> the partner is not added as a follower of the document

This was caused by a typo when refactoring the JS of the
module mail.

Task-ID 1896010
Closes #27864

closes odoo/odoo#27932
2018-10-18 09:24:53 +00:00
Christophe Simonis e9ae419fca [MERGE] forward port branch saas-11.3 up to 0de06a4132 2018-10-17 10:54:19 +02:00
zoggy444 52ab504a5b [CLA] signature for zoggy444
Closes #27259
2018-10-17 10:45:57 +02:00
Pierre Pizzetta a211c1493a [CLA] pierre-pizzetta signs Odoo CLA
closes odoo/odoo#27759
2018-10-17 08:41:56 +00:00
mgh-odoo cb8dcb5913 [FIX] web: avoid margin on top of list view in mobile
When header was too long, the text was breaking into next line.
We want to avoid this behavior in mobile because it causes
a big margin on the top of the list view.

This issue was probably caused by the upgrade of Bootstrap.

task-1878252

closes odoo/odoo#27927
2018-10-18 08:44:22 +00:00
Nicolas Martinelli 1f409dcea7 [FIX] base: do not crash if rtlcss.cmd is not found
closes odoo/odoo#27926
2018-10-18 08:14:29 +00:00
David Beguin 56832de6fd [FIX] website_mass_mailing : Fix is subscriber to filter on opt_out
since the opt_out per mailing list, to check if an email address is
subscribed to a mailing list, this cannot be done at contact level
but at the many2many contact-list level.

Fix Task ID : 33224

closes odoo/odoo#27899
2018-10-17 14:31:37 +00:00
Thomas Binsfeld da15c3a69a [FIX] l10n_be_invoice_bba: vendor bill copy 2018-10-17 08:14:46 +02:00
Christophe Simonis 0de06a4132 [FIX] board: remove duplicated test 2018-10-16 20:43:49 +02:00
Christophe Simonis e21ce71927 [FIX] board: use defined variable in newly added test
Oversight of previous forward-port
2018-10-16 19:14:19 +02:00
Christophe Simonis d23ddbd6ee [FIX] account: add missing field to view
This field is required since 1a99d22f19
2018-10-16 18:47:20 +02:00
Christophe Simonis 41bf8ce6d9 [MERGE] forward port branch 11.0 up to b29b545fe8 2018-10-16 17:53:26 +02:00
Nicolas Martinelli 60280e6bb1 [FIX] website_sale: image in carousel
Backport of https://github.com/odoo/odoo/commit/19255ee2604c196197b14427e2a4338604b11a8a

opw-1889960
2018-10-16 17:41:07 +02:00
qsm-odoo a9f11fb477 [FIX] web_editor: properly remove all bg when choosing a bg color
The code which removed the background image of a snippet when choosing a
background color worked kinda by chance. Indeed, on the final click on
the color option, the snippet background-image was reset... to the
current background-image, which is none thanks to the color preview.
Unfortunately, in some themes, the gradient color option interferes:
the current background-image at a color choice is equal to the current
gradient, and thus, that gradient is being moved as an inline style.

The bug was introduced with https://github.com/odoo/odoo/commit/285d95e946e5a15139c961e30dbe3598e0d99f6a
(as, before, the background reset was done by simulating a click on the
'background: none' option item, which was removed).

Closes https://github.com/odoo/odoo/pull/27808
2018-10-16 13:32:23 +02:00
Aaron Bohy 7063c50924 [FIX] web: FieldMany2one: don't ignore tabindex in readonly
opw 1889710
2018-10-16 10:58:49 +02:00
Nicolas Martinelli b29b545fe8 [FIX] sale_timesheet: project overview
Complement of commit fc1ba68c6a

opw-1893397

closes odoo/odoo#27835
2018-10-16 08:31:56 +00:00
Lucas Perais (lpe) 6e28e4f26c [FIX] account: display partner.bank on journals
Before this commit, when accessing journals through the menu item
Bank Account, one was able to enter an partner.bank account number
But, in case the partner.bank already exsited, there was no way to select it
and a cryptic unicity constraint was raised

After this commit, one can select an account already existing

OPW 1884515

closes odoo/odoo#27840
2018-10-16 10:24:16 +00:00
Goffin Simon 84e3ae140e [FIX] purchase_requisition: System pick wrong operation type in Purchase Agreement
When creating a "purchase.requisition" record, the default Operation Type was
always the one defined in the company 1 even if the user was not in the company 1.

opw:1890190

closes odoo/odoo#27830
2018-10-16 07:55:56 +00:00
Goffin Simon 7bee068a0f [FIX] sale: Sale channels duplicate field
Steps to reproduce the bug:

- In CRM, create an new Sales Channel
- Go to Reporting/Sales Channels
- Click in the new channel on "Click to define a target"

Bug:

Two input fields called "Set an invoicing target" appeared in the new channel

opw:1889406

closes odoo/odoo#27781
2018-10-16 07:41:50 +00:00
Florent de Labarre 57d9f9ee32 [FIX] qty_invoiced is wrong if uom_id in invoice line is updated
closes odoo/odoo#27837
2018-10-16 08:34:56 +00:00
Lucas Perais (lpe) a7732bb839 [FIX] board: translate custom views according to current user
forward port of 62cbc5f

Have a user in English, put a sale report as "favorite" (pinned to dashboard app)
Change the user's language

Before this commit, the pinned view was in English (because it was recorded that way)

After this commit, the pinned view is in the user's language.

OPW 1890664
closes #27799
2018-10-16 08:12:48 +02:00
William Henrotin f652c8d1da [FIX] mrp: done workorder on multiple reserved move lines
Producing a manufacturing order on components with more than one unit
could leads to multiple move line reserved on this component. Marking the
workorder as done, in that case, will trigger an error saying "Cannot set
the done quantity from this stock move, work directly with the move
lines". Instead of setting the quantity done directly, this commit
uses the magical function _set_quantity_done() that manage the case
of more than one move lines.

OPW-1888780

closes odoo/odoo#27773
2018-10-15 13:20:52 +00:00
Joren Van Onder 6c42ca8a7b [FIX] point_of_sale: make card readers work again on payment screen
Swiping a credit card through pos_mercury no longer worked on the
payment screen.

3a74afd21e introduced some special code
in BarcodeEvents for mobile Chrome. This code relies on an invisible
input being filled in by barcode device. On the payment screen the POS
uses a keypress event handler on body to manage input. This handler
preventsDefault which stops the input from being filled in.

It's worth noting that this new approach in
3a74afd21e is not fully equivalent to
the original barcode events handler. Events are not redispatched, so
this effectively disables keyboard input on the payment screen (or
anywhere where it is used).

opw-1888466

closes odoo/odoo#27820
2018-10-15 21:05:17 +00:00