Commit Graph
124195 Commits
Author SHA1 Message Date
Robot Odoo 7614eaf725 [IMP] stock location cleanup
Here we are cleaning some stuff in locations

closes odoo/odoo#28449
2018-11-27 13:24:26 +01:00
Pierre Masereel 0d6bcd3918 [IMP] stock: scrap location internal or inventory
We restrict the case of locations that can be scrap locations to
locations of usage internal or inventory loss, depending on how you want
to manage your scrap. Other usage of location shouldn't be scrap
locations.

TASK-ID: 38469
2018-11-27 11:05:56 +00:00
Pierre Masereel e0cac32bdc [IMP] stock: orderpoint only on internal and view location
We put a domain on location_id on order point to only allow to create
orderpoint on location of type 'view' or 'internal'.

TASK-ID: 38469
2018-11-27 11:05:55 +00:00
Pierre Masereel 5e42f46b87 [IMP] stock: warehouse view
We add the stock and view location in debug mode for warehouse form to
be able to check easily the warehouse configuration.

TASK-ID: 38469
2018-11-27 11:05:55 +00:00
Pierre Masereel 9775d4cce8 [FIX] stock: Don't allow to archive main locations of warehouse
When a location is archived, we are checking that it is not used a
warehouse stock or view location to avoid bad configration leading to
inconsistencies on stock available quantities.

TASK-ID: 38469
2018-11-27 11:05:55 +00:00
Pierre Masereel f3ad1e2bcb [REF] stock: remove confusing demo data
As configuring multiple vendor locations is a quite advanced case, that
need too change configuration on partners, and eventually routing, we
remove those demo data that can lead to misunderstanding the way vendor
locations works.

We've also adapted a test that was using those demo data

TASK-ID: 38469
2018-11-27 10:47:36 +00:00
Pierre Masereel 2062ac6dec [REF] stock: remove unsused field partner_id
The field partner_id on locations is not used in odoo, and can create
some confusion in odoo with the customer/supplier location you can set
on your partner and/or the owner_id you can set on your moves ans
quants. So we removed it.

TASK-ID: 38469
2018-11-27 10:47:36 +00:00
Pierre Masereel feb336a203 [REF] stock: remove unused location usage
The stock location usage 'procurement' is not used anymore in stock, and
we remove it as it is not used either for the stock and valuation of
stock.

TASK-ID: 38469
2018-11-27 10:47:36 +00:00
Darshil Trivedi e94477f746 [IMP] stock: Set company_id empty on sequnce of orderpoint.
Purpose : When we create order point in another company, it is not setting name ( sequence ).

After this commit it will use ( sequence ) in all company, as we not set company_id on the sequence of order point.

Task #1908526
Closes #28597
2018-11-27 08:46:16 +00:00
Pratima Gupta 5a2b38918a [IMP]stock_account: Prevent user to set same valuation account and IN/OUT accounts.
In this commit use the python constraint to check the accounts if they are duplicate.

This change is because before this configuration there will be an entry cancelling another one in the same account,
resulting in a not impacted valuation account.

This commit is related to task #1908065.

closes odoo/odoo#28604
2018-11-27 07:23:15 +00:00
Kirti Choudhary cca864f509 [FIX] product, point_of_sale, sale_management: Hide product sales tab
The sales tab is displayed on product form even if there are no modules
that need it are installed and no fields are displayed in it.

It has been introduced in this commit: https://github.com/odoo/odoo/commit/8e40fed7734793178e4b661a2b28a7f36f8ff626
that we revert and fix by adding an xpath in the point_of_sale module
that display the sales tab when point_of sale_module is installed (even
if sale module is not installed.

Task ID - 1893455

closes odoo/odoo#28176
2018-11-27 05:20:08 +00:00
Nimesh Jethva b0a6f3398d [IMP] *: add next activities on all modules
*: account, event, mrp, purchase_requisition, stock_landed_cost, stock_picking_batch

Add activity on below models:
account.payment
event.event
event.registration
mrp.workorder
purchase.requisition
stock.landed.cost
stock.picking.batch

Related Task ID : 1867620

closes odoo/odoo#26092
2018-11-26 12:28:19 +00:00
qsm-odoo 2dcd8c8566 [REF] web, *: review the assets helpers organization
* survey, website_slides

While not changing their name or their amount, this commit reorganizes
the assets helpers to:

Avoid all file duplicates in different helpers
----------------------------------------------

Before, we had to put some files in different helpers, like our
bootstrap mixin overrides which were in the _assets_utils template and
in the _assets_bootstrap template.

Enforce the use of an helper when using bootstrap
-------------------------------------------------

Bootstrap functions, variables and mixins are now out of the
_assets_bootstrap template, which now only contains bootstrap css rules
and our bootstrap fixes and extensions.

Allow using the correct bootstrap utils in all assets
-----------------------------------------------------

In some assets (especially editor ones), we may want to use bootstrap
variables even though bootstrap is not included in those. This worked
before but using *default* bootstrap variables. Now, our overrides can
be properly included if necessary.

Note: this commit may also be a first step to allow for backend
bootstrap and frontend bootstrap to co-exist.

closes odoo/odoo#28204
2018-11-26 12:23:09 +00:00
Robot Odoo 4173d4603e [IMP] stock: usability improvement
Description of the issue/feature this PR addresses:
- Task : https://www.odoo.com/web#id=1891230&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720
- Pad : https://pad.odoo.com/p/r.c685147bff2284699d1933fb36e3fec3

Current behavior before PR:
- Usability MTO route

Desired behavior after PR is merged:
- Rename stock_location_route "Make to Order (MTO)" into "Replenish on Order (MTO)".
- The field responsible on the product should be empty by default and it shouldn't be required.
  If empty, the next activity should be assigned to the "system" (the admin)

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#27554
2018-11-26 15:01:17 +01:00
Haresh Shyara abcfa38f2c [IMP] stock: rename 'Make to Order (MTO)' into 'Replenish on Order (MTO)' 2018-11-26 12:24:13 +00:00
Haresh Shyara 93a33e603a [IMP] stock: removed require on responsible field
- when responsible field is empty on the product then next activity should be assigned to the system admin.

Task ID : 1891230
2018-11-26 12:24:13 +00:00
Darshil Trivedi fbcf6e86e0 [IMP] purchase : Rename date_approve label
This commit is related to task ID 1869130.

closes odoo/odoo#27018
2018-11-26 11:54:16 +00:00
Robot Odoo d2b83bbe8f [MERGE][IMP] mail, web: drag/drop files in conversations
This merge adds the support of drag/drop files in a conversation
(discuss, document chatter and chat windows).

It also adds helper functions to simulate drag/drop with files in test
environments.

Task-ID 32469

closes odoo/odoo#18914
2018-11-26 13:50:33 +01:00
Robot Odoo db0f80ee53 [IMP] repair, stock: views improvements
Display destination and source location on picking tree view
Order repair button with primary first in the list
Add the source document on stock move line view

Pad:https://pad.odoo.com/p/r.66fe9d8682b74783346d91b0fe7e3a87
Task:https://www.odoo.com/web?#id=1872294&action=333&active_id=131&model=project.task&view_type=form&menu_id=4720

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#26380
2018-11-26 12:46:49 +01:00
Alexandre Kühn 6f8bb750f3 [ADD] mail:tests: discuss drag-and-drop file in composer
Task-ID 32469
2018-11-26 11:34:00 +00:00
Alexandre Kühn fb895f9119 [ADD] web:tests: test utils for drag/drop files
This commit adds test helper functions to drag and drop
files:

- `createFile`: create a file that can be used for drag and
  drop in tests.
- `dragoverFile`: to drag a file created from `createFile`
  over a DOM element.
- `dropFile`: to drop a file created from `createFile` on
  a DOM element.

These utility functions are available from `testUtils.file`.

Example of usage:

```js
var testUtils = require('web.test_utils');
testUtils.file.createFile({
	name: 'text.txt',
	content: 'hello, world',
	contentType: 'text/plain',
}).then(function (file) {
	testUtils.file.dragoverFile($el, file);
	testUtils.file.dropFile($el, file);
});
```
2018-11-26 11:34:00 +00:00
Dharmang Soni fb051d3420 [IMP] mail: Allowing drag/drop files/images on mail composer
By this commit user can upload attachments by drag and drop in chatter composer.
This feature can be used from discuss UI, chat windows and form view chatter.

Before this commit chatter unlinks the attachment if another attachment uploaded
with same name. Criteria for removing duplicate attachment is changed with this
commit. Now it will remove the attachment based on name and size of attachment.
The reason for this change is, when you upload image with same name from different
directory with old condition it was not possible to attach more then one image/file
of same name.

Related to task #32469
Closes #18914
2018-11-26 11:34:00 +00:00
Prakash Prajapati c5ce51168e [IMP] stock: Add the new field 'origin' in 'stock.move.line'
Useful to know for which SO the product is reserved

Task #1872294
Closes #26380
2018-11-26 10:40:41 +00:00
Prakash Prajapati 4e3a357cca [IMP] repair: Primary buttons first in form view
First display the primary button and after it display normal button.

Task #1872294
Closes #26380
2018-11-26 10:40:11 +00:00
Prakash Prajapati 4031227b54 [IMP] stock: Show source and dest in list view of pickings
If multilocation is active then display 'source' location in tree views.
Also in tree views rename the source location to 'From' and destination location to 'To'

Task #1872294
Closes #26380
2018-11-26 10:39:07 +00:00
Hetashree Chauhan 702317fbb8 [IMP] sale_stock: Show warehouse on SO only if user has rights for multi warehouses
Purpose of this commit:
Currently warehouse is showing in sale order even if user has no rights for multi warehouses.
After this commit:
User can access warehouse on sale order even if we have enabled multiple warehouses.

This commit is related to task_id  : 1896087.

closes odoo/odoo#28021
2018-11-26 07:26:54 +00:00
Nirali Sapra c892a11fb0 [IMP] purchase: Settings options for the invoicing policy should be right
This commit is change the name of deliverd quantities to received quantities in invoicing policy in settings of purchase module

This commit is related to task ID :1871494

closes odoo/odoo#27147
2018-11-26 08:57:06 +00:00
Darshil Trivedi 9e12dbc33d [FIX] base: Typo in summary of MRP II module.
This commit is related to task ID : 1893027

closes odoo/odoo#28400
2018-11-26 07:04:16 +00:00
Thibault DelavalléeandKishan Gajjar ec88479048 [IMP] mass_mailing: improve UTM display on mailings
This commit is the community commit linked to an enterprise improvement of
marketing automation. In this commit we simply improve display of UTM
information on mass mailings.

This commit is linked to task ID 42548 and PR #28500.

Co-Authored-By: Kishan Gajjar <kig@odoo.com>
Co-Authored-By: Thibault Delavallée <tde@odoo.com>
2018-11-23 13:34:15 +00:00
Robot Odoo ec078b88a7 [MERGE][REF] survey: refactor tests
Purpose of this merge is to clean survey tests and add some more. This
merge holds several commits that

 * create a common file holding test data and tools methods to create
   questions, answers and answerlines as well as implemented some custom
   assertions;
 * clean exiting tests by removing tests about implementation details and
   unnecessary code;
 * expand tests by adding a functional test using survey routes and
   controllers;

This merge is linked to task ID 1911238 and PR #28831 .
2018-11-23 14:29:08 +01:00
Thibault Delavallée 4eb9433bd5 [IMP] survey: add small functional flow test
Purpose of this commit is to add a test working with routes and controllers
that check the flow of people going through the portal to fill surveys.

This commit is linked to task ID 1911238 and PR #28831.
2018-11-23 12:51:45 +00:00
Thibault Delavallée 3124944d53 [REF] survey: clean existing tests
Purpose of this commit is to clean existing tests in survey. This commit

 * removes unnecessary tests checking that basically create / write correctly
   works;
 * removes tests based on implementation details;
 * cleans tests for validation and answer creation to make them more easier
   to read and understand;
 * moves invitation tests into their own file;

Some helpers methods are added in common.py to ease question and answer
creation.

This commit is linked to task ID 1911238 and PR #28831.
2018-11-23 12:49:52 +00:00
Thibault Delavallée 8349e1d77a [IMP] survey: improve common file and add tools methods
Purpose of this commit is to add some prepared data in survey common test
file. We also add some tool methods in order to easily create new questions,
answers and answer lines. Some specific assert methods are also added to
avoid noise in tests and avoid having to duplicate some check and assertions.

This commit is linked to task ID 1911238 and PR #28831.
2018-11-23 12:49:52 +00:00
Thibault Delavallée ed8842045e [REF] survey: use a common file for tests for tools and data
Purpose of this commit is to clean a bit survey test files before updating
them and creating new tests. In this commit we add a common file holding
user creation and we use the recently-introduced tool method to create
test users. Survey test class is done child of SavepointCase to use
breakpoints and avoid recreating data at each test.

Future commits will gradually remove unnecessary content for test_survey.py,
rewrite part of it to be easier to understand and add new tests.

This commit is linked to task ID 1911238 and PR #28831.
2018-11-23 12:49:52 +00:00
lul-odoo c370f644a2 [IMP] hr_holidays: add a leave request without validation mechanism
Purpose
=======

Allow to create a leave type for which leaves are not required to be approved
by a manager.

When a leave is created, it is automatically approved if the
validation type is set to "No validation".

It is useful if a manager does not need to manually approve some leave types.

Specification
=============

Add a validation type option for 'hr.leave.request': 'no_validation'

Automatically approve the leave when created and add the approver as follower
so that he can be notified about the leave creation/validation.

closes odoo/odoo#28268
2018-11-23 10:49:25 +00:00
Christophe Simonis 7a0243ec15 [MERGE] forward port branch 12.0 up to b3052b690f 2018-11-23 12:11:32 +01:00
Robot Odoo 75477052a0 [MERGE][IMP] snailmail: Improve integration and usability
- Improved the form and list views of snailmail.letter objects,
- Added menus to access the letters from the account app,
- Manage invalid address on the partners when trying to send a postal letter

This merge is linked to the task ID 1892473

closes odoo/odoo#28057
2018-11-22 19:06:51 +01:00
Antoine Prieels (ANP) a08cb50e7e [I18N] snailmail,snailmail_account: Update translation files 2018-11-22 15:38:42 +00:00
Antoine Prieels (ANP) 8573b4647b [IMP] snailmail_account: Deal with invalid addresses
- Raise UserError when sending an invoice with an invalid address
- Notify when sending letters in batch mode with invalid addresses
2018-11-22 15:38:42 +00:00
Antoine Prieels (ANP) f68df47ddf [IMP] snailmail: Show the price in terms of stamps
- The price of sending a letter was displayed in the currency of the company, now we express the price in terms of stamps
- Show a different message in the modal depending on the validity of the address
2018-11-22 15:38:42 +00:00
Antoine Prieels (ANP) d5ca268438 [IMP] snailmail: Change order of settings and default values
Task #1892473
2018-11-22 15:38:42 +00:00
Antoine Prieels (ANP) 2dfa7cd597 [IMP] snailmail: Add form and tree views for snailmail.letter
Add new form and tree views for snailmail.letter available in Accounting > Configuration > Management > Snailmail Letters
Add a many2one field to snailmail.letter to link to a mail.activity in case of an error with snailmail

Task #1892473
2018-11-22 15:38:42 +00:00
wan 182b4d86f4 [IMP] l10n_be/fr/lu: set refund_sequence on sale/purchase journals
Belgium, France and Luxembourg should, by default, have a dedicated sequence for refunds.

Task ID: 1872181

closes odoo/odoo#28639
2018-11-22 10:49:46 +00:00
Yenthe V.G 1b43116ec0 [IMP] uom: add sheet on uom.uom and uom.category form views
closes odoo/odoo#27335
2018-11-22 10:31:21 +00:00
Yenthe V.G fcc3766233 [IMP] membership: add sheet on product.template form view
closes odoo/odoo#27328
2018-11-22 10:36:30 +00:00
Yenthe V.G a5e6bf2397 [IMP] mass_mailing: Add sheet of mail.mass_mailing.tag form view
closes odoo/odoo#27200
2018-11-22 10:12:48 +00:00
Robot Odoo a8a7c248cd [MERGE][REF] survey: break survey composer inherit on mail composer
Purpose of this merge is to clean survey composer model. It currently
inherits from mail.compose.message which also inherits from mail.message.
That means a lot of fields and behavior coming from both models are present
on the survey composer. Most of them are not necessary as

 * send_mail method of mail composer is overriden and super is not called.
   Nothing from the complex behavior of mail.compose.message is used;
 * templates are just basically supported in survey, notably mass mailing or
   mass posting mode are not used;
 * methods from mail.message should not be available on survey composer;
 * most m2m fields coming from mail.message and composer have no use here;

In this merge we simply add the required fields and template behavior on
the survey composer and remove inheritance on mail.compose.message.

In this merge we also rename survey.mail.compose.message to survey.invite
as it simplifies code and is easier to understand.

This commit is linked to task ID 1909804.

closes odoo/odoo#28783
2018-11-21 15:48:06 +01:00
Thibault Delavallée cb59cb0436 [REF] survey: rename invitation wizard to better match its business use
Purpose is to have a somehow cleaner name for this wizard as its purpose
is to send invitations. Email and composer are details on how it works.

This commit is linked to task ID 1909804 and PR #28783.
2018-11-21 13:27:52 +00:00
Thibault Delavallée ebbe0cac03 [REF] survey: break dependency from survey composer on mail composer
Purpose of this commit is to clean survey composer model. It currently
inherits from mail.compose.message which also inherits from mail.message.
That means a lot of fields and behavior coming from both models are present
on the survey composer. Most of them are not necessary as

 * send_mail method of mail composer is overriden and super is not called.
   Nothing from the complex behavior of mail.compose.message is used;
 * templates are just basically supported in survey, notably mass mailing or
   mass posting mode are not used;
 * methods from mail.message should not be available on survey composer;
 * most m2m fields coming from mail.message and composer have no use here;

In this commit we simply add the required fields and template behavior on
the survey composer and remove inheritance on mail.compose.message.

This commit is linked to task ID 1909804 and PR #28783.
2018-11-21 13:27:52 +00:00
RomainLibert 8d869b06e2 [FIX] hr_holidays: change selection key type from float to string
In the following commit (744de4e) we introduced some floats as keys
to Selection fields (namely request_hour_from and request_hour_to)

This lead to the ORM creating a column of type int4 to store this
field which rounded the values.

In order to fix that faulty behaviour, we change these keys into strings
and then convert them to floats.

closes odoo/odoo#28891
2018-11-21 11:26:16 +00:00