Commit Graph
129619 Commits
Author SHA1 Message Date
Thibault Delavallée bf3cdac628 [FIX] website_slides: avoid display error messages twice in quizz completion
Purpose of this commit is to avoid having error message replacing the
cross used to close the container of the error message.

Task ID 2058595
PR #36281
2019-08-30 15:05:59 +00:00
Alexandre Kühn dc31884dcf [FIX] base, tools: add pre_locate to apply_inheritance_specs
Revision on https://github.com/odoo/odoo/commit/fc5878ecc668ee83cd1a374474f0b21bf6a51940

Commit above introduced server-side inheritance of static XML.
To do so, it made some changes to the way inheritance of view
templates is applied, such as moving this logic outside of the record
`ir.ui.view`.

This change, however, removed the feature to overwrite these methods.
Studio did that in order to correctly apply `group_ids`[1][2].

This commit fixes the issue by introducing an optional callback
`pre_locate` as parameter of the methods `apply_inheritance_specs`.
When set, this function is called just before locating a node during
the application of inheritance of the view. Studio can make use of
this callback to handle group_ids properly, again.

[1] https://github.com/odoo/enterprise/commit/b56101200ac35dae3eadbc0bdf4ba17461f33907
[2] https://github.com/odoo/enterprise/commit/38f7eb8153df8406498fa58eb809271db778e6d8

Related to: https://github.com/odoo/enterprise/pull/5321

Task-Id 2047439

closes odoo/odoo#36200

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-08-30 11:41:12 +00:00
svs-odoo ec9b365b18 [FIX] stock: don't show mrp_operation picking type
When creating a picking and selecting an Operation Type, can't no more
select operation type of `mrp_operation`.

Task #2060793

closes odoo/odoo#36262

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-30 13:08:15 +00:00
Pierre Masereel c95acd624e [IMP] point_of_sale: Send ticket by email.
When you select a customer in the front end, you can send him an email with the receipt as an image.
If you decided to send the mail and you'd like to print the receipt anyway, you have to click on the
When you're offline, the order will be queued and the ticket printed. You'll receive an error message
When invoicing, the invoice will be in attachment of the email.

TASK-ID: 1922660

closes odoo/odoo#35812

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-30 12:28:47 +00:00
Yannick Tivisse 8fad800dd8 [FIX] hr_work_entry: Remove 'confirmed' state
Zizizuseless

closes odoo/odoo#36276

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-30 11:03:33 +00:00
Yannick Tivisse 1c0de2fc19 [FIX] hr_work_entry: Remove warning banner on conflicts 2019-08-30 11:03:33 +00:00
Yannick Tivisse cf9eb7e02d [FIX] hr_holidays: Misc layout fixes + leaves_stat widget 2019-08-30 11:03:33 +00:00
Pierre Paridans 81d0f39480 [FIX] web, base: MockServer should have the same behavior as the server
An RPC call using an empty array of fields has not the same behavior on
the MockServer and the actual server:

- the MockServer returns only the 'id' field
- the actual server returns all the fields for the model

This is due to the fact that an empty array evaluates to a falsy value
in Python and evaluates to a thruthy value in JavaScript.

This commit restores the parity between the two.

closes odoo/odoo#36278

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-08-30 09:09:48 +00:00
Ankita Raval 92b647611e [IMP] mrp: label should be in one line.
In this commit alignment in bom structure & cost report
display in proper manner.

task-id : 2059697

closes odoo/odoo#36225

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-29 09:57:12 +00:00
Hardik PrajapatiandMohammed Shekha 2581076a09 [IMP] survey: do not set a question type on question being section
This commit header is quite fun. If a question is not a question it should
not have a type. Maybe it should not be a question but, hey, you don't always
do what you want. That's life my dear Lucette.

In this commit we remove required attribute from python field definition of
question_type and make it required conditional based. Real questions have a
type, unreal questions have no type.

Alss update Questions menu entry to display only real questions, not unreal
questions.

Most of this commit message makes no sense, but remember who asked to push
this model.

Task 2053833

closes odoo/odoo#35835

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>


Co-authored-by: Hardik K Prajapati <hap@odoo.com>
Co-authored-by: Mohammed Shekha <msh@odoo.com>
2019-08-30 11:09:21 +00:00
Lucas Lefèvre 7ff683a7e1 [FIX] portal: Allow to edit without state
From the user's frontend "My Account" page:
- Try to edit your details.
- Complete the form with all required fields.
- Select a country for which there are no states
(the `state_id` field is hidden)
- And confirm
=> Internal server error

The state was not filled, therefore the value sent to the server
is an empty string. This empty string is used in the UPDATE
query to register the state value. Since it's a string and
not a valid (integer) id, the query fails.

closes odoo/odoo#36272

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-30 10:13:29 +00:00
Arnaud Baes 7adc5e610b [REM] barcodes: module description
Remove old module description because "nobody will ever read this information".

TaskID: BugsLogistics

closes odoo/odoo#36266

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-30 09:23:12 +00:00
Arnaud Baes 064e556e07 [IMP] stock: partner label on picking
Follow up of back2basics for picking views

closes odoo/odoo#36234

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-30 08:27:54 +00:00
mcm-odoo 94e6e8187b [FIX] account: fix send invoice mail issue
This commit tries to fix the issue in the "Send Invoice" modal.
Because of this issue, the recipients and body are empty.

task-2032586

closes odoo/odoo#35536

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-08-29 14:14:50 +00:00
mcm-odoo 9bfab43d92 [IMP] payment,sale: clean Payment Method in onboarding
The modifications are applied in account, sale and website_sale
- Changed description to "Choose your default customer payment method."
- Removed the "Pay with" from labels in Modal
- In sale: Renamed "Confirmation & Payment" to "Payment Method"

task-2032586
2019-08-29 14:14:50 +00:00
mcm-odoo 1c34882478 [IMP] account: improve account views
Changes in account views to make them cleaner and
easier to use and understand.

Invoices/Bills tree view
---
- Distinct Invoices tree view from Bills tree view:
  In Invoices:
  - invoice_vendor_display_name is "Customer"
  - invoice_date is "Invoice Date"
  - "Payment Reference" is hidden because it's the same
    as "Number"
  In Bills:
  - invoice_vendor_display_name is "Vendor"
  - invoice_date is "Bill Date"
- "Source Document" is moved next to "Number"
- Renamed "Payment Status" to "Payment"
- "Payment Status" value "paid" renamed to "Paid"
- Search filters:
  - Renamed "Open" to "Posted"
  - Added a separator after "Posted"
  - Removed "Linked to revoked mandate"

Invoices/Bills form view
---
- Removed "Original vendor bills" from form but kept it in list
  and renamed to "Original Bills"
- Renamed state "Unposted" to "Draft"
- "Draft *" titles are now in h1
- Added placeholders and removed tooltips on Payment Terms
- Removed tooltips of invoice date
- Hid Accounting Date on Customer Invoices
  because it's the same as Invoice Date
- Rewamped payment info popup:
  - Renamed title to "Payment Info"
  - Removed right alignment
  - Removed Name info
  - Reordered info: Amount, Memo, Date, Method
- Added optional to few fields in tab "Invoice Lines":
  - Analytic Account: show
  - Analytic Tags: show
  - Intrastat: show
  - Origin Country of Product: hide (and renamed to "Product Country")
  - Unit of Measure: show
  - Disc (%): show
  - Taxes: show
- Added optional to few fields in tab "Journal Items":
  - Label: show
  - Analytic Account: hide
  - Balance in Currency: hide (renamed to "Amount in currency")
  - Taxes Applied: hide (moved before debit and renamed to "Taxes")
  - Tax Grids: show (moved after credit)
  - Due date: hide (moved before Balance in currency renamed to "Due Date")
- Tab "Other Info":
  - Renamed sections:
    Sales Information -> Invoice
    Accounting Information -> Accounting
    Payments Information -> Payments
  - Website is now hidden if not set and tracked in chatter

Payment form view and modal
---
- State "Posted" renamed to "Validated"
- State "Cancelled" is hidden while module account_cancel
  is not installed
- Renamed "Payment Method Type" to "Payment Method"
- Renamed "Payment Date" to "Date"
- Renamed "Payment Amount" to "Amount"
- Renamed "Payment Journal" to "Journal"
- Reordered fields:
  Journal                   Amount
  Payment Method            Date
  Recipient Bank Account    Memo
- Payment Difference is now visible only with
  accountant access rights.

Journals form view
---
- Removed Journal Groups
- Changed position of "Bank Account"
  it's now the first tab
- In "Advanced Settings":
  - Renamed section "Accounting App Options" to "Posting"
    and only visible when Accounting rights
  - "Post at Bank Reconciliation" was a Boolean field and is now a
    Selection field with values pay_val for Payment Validation and bank_rec
    for Bank Reconciliation.
    In form view it's now a radio button.
    Removed tooltip of this field.
  - Section "Control-Access" is now visible with Accounting Manager rights
  - Renamed "Invoice References" to "Payment References"
  - Field "Communication Type" value "Based on Partner" renamed to "Based on Customer"
  - Reorder sections:
    Payment References
    Email your Invoices/Bills
    Control Access

Purchase form view
---
- In Purchase Order: Field Billing Status is invisible if the status
  of the purchase.order is draft/sent/to approve/cancelled

task-2032586
2019-08-29 14:14:50 +00:00
mcm-odoo 4d64e553b8 [FIX] account: fix invoice reports
- This commit fixes invoice reports header and footer:
  The header was half displayed and "Phone Number" was
  displayed on two lines

- This commit also add a link in report preview to go back
  to the backend:
  When account was the only module installed there was no
  link to go back to the backend

task-2032586
2019-08-29 11:49:17 +00:00
mcm-odoo d4710d92dd [IMP] account: add payment terms to data
- This commit moves the Payment Term "End of Following Month" from
  demo data to data and adds two new Payment Terms: "21 Days" and
  "30% Now, Balance 60 Days".
  It allows the customer to define less Payment Terms

task-2032586
2019-08-29 11:49:17 +00:00
mcm-odoo 0e9a60a090 [IMP] account: reorder configuration menu
- This commit reorders the configuration menu in the
  Invoicing/Accounting app in order to split the Invoicing menu
  items from the Accounting ones.

- This commit also restores the Bank Account form view of V12.

task-2032586
2019-08-29 11:49:16 +00:00
mcm-odoo 373d59e866 [IMP] website_slides: add a toggle button to display/hide leaderboard
Before this commit, leaderboard was displayed only if user was not connected.
As we feel this is very interesting to show we decided to display it in all
cases (either connected or not) on eLearning frontpage. Activating it is
now done using an entry in the customize menu.

Task 2005981

closes odoo/odoo#35791

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-30 09:31:23 +00:00
Odoo's Mergebot 3a3383d926 [FIX] point_of_sale, hw_drivers: Payment terminals fixes
Different fixes for Payment Terminals in saas-12.5

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#36255

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-08-30 11:58:16 +02:00
Odoo's Mergebot 1becb2e0cf [MERGE] survey: perform a back 2 basics
PURPOSE

Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.

SPECIFICATIONS

Improve labels of fields and wording in actions. See commit content for proper
specifications.

Reorder some code to better understand module organization.

Order answer lines following question order.

Display section in answer lines form view to better understand question and
answer organization.

Add a correct flag on answer lines and display it in user input embedded
view in order to know which line are correct.

When finishing a certification survey, add an overall correctness circular
graph. Quarters are

* correct
* partially (if multiple corrects answers on the survey);
* incorrect
* unanswered

Questions without points are not displayed in this graph.

LINKS

Task 2039068

closes odoo/odoo#36229

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-30 11:58:09 +02:00
svs-odooandjip-odoo 25946bd3b4 [IMP] stock: empty inventory report
Before this commit, if user tries to create a new record from a empty
grouped editable list in 'Inventory Report', he/she will get the form
view open which isn't editable.
To avoid that, we remove the group filter if there is no quant, so user
can create a new quant directly in the editable list.

Task #2056651

closes odoo/odoo#36221

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>


Co-authored-by: jip-odoo <jip@odoo.com>
2019-08-30 08:12:12 +00:00
Antoine Prieels 02ce81699f [FIX] point_of_sale: Reverse payment error
When an error occurs during the reversal of a payment, we hide the
"Reverse" button.
2019-08-30 06:44:09 +00:00
Jitendra Prajapati 240e860f24 [IMP] survey: add an overall correctness graph when finishing a certification
PURPOSE

Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.

SPECIFICATIONS

When finishing a certification survey, add an overall correctness circular
graph. Quarters are

  * correct
  * partially (if multiple corrects answers on the survey);
  * incorrect
  * unanswered

Questions without points are not displayed in this graph.

LINKS

Task 2039068
PR #36229
2019-08-29 15:37:04 +00:00
Jitendra Prajapati ee5649cdff [IMP] survey: improve user answers model and display in backend
PURPOSE

Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.

SPECIFICATIONS

Order answer lines following question order.

Display section in answer lines form view to better understand question and
answer organization.

Add a correct flag on answer lines and display it in user input embedded
view in order to know which line are correct.

LINKS

Task 2039068
PR #36229
2019-08-29 15:36:48 +00:00
Thibault Delavallée 0636347099 [IMP] survey: reorder some code to ease understanding
PURPOSE

Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.

SPECIFICATIONS

Reorder some code to better understand module organization.

LINKS

Task 2039068
PR #36229
2019-08-29 15:36:32 +00:00
Jitendra Prajapati 4fbd4a8c6a [IMP] survey: improve wording and labels
PURPOSE

Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.

SPECIFICATIONS

Improve labels of fields and wording in actions. See commit content for proper
specifications.

LINKS

Task 2039068
PR #36229
2019-08-29 15:36:13 +00:00
Antoine Prieels 8449a7c607 [FIX] hw_drivers: Kill eftdvs w/o Six terminal
If no Six Payment terminal is configured, kill eftdvs if it is running.

When removing the configuration for a Six payment terminal, we just
removed the file with the configuration but we didn't stop eftdvs. The
terminal the nstayed connected to this Box even after removing the
configuration, blocking the connection to another terminal.
2019-08-29 14:09:24 +00:00
William Henrotin 3b0cc4861a [FIX] sale_stock: uses line route or category route
Commit 2408bef fixed the way a sale order line is considered as mto or
not but did not took the line route or product category route into account.

closes odoo/odoo#36064

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-29 08:02:48 +00:00
Meghna Jaswani 4670991d5b [FIX] account: Changed zip_from and zip_to fields into type char as 0 was passed by default
closes odoo/odoo#35957

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-08-22 09:30:38 +00:00
wan 5aeec0c3dc [IMP] account: Hierarchy in account type selection field
Task 2041865

We want to show a hierarchy to ease the account type selection (hack in the select widget)
BALANCE SHEET
ASSETS
Fixed Assets
Non-current Assets
Current Assets
Prepayments
Receivable
Bank and Cash
LIABILITIES
Equity
Current Year Earnings
Non-current Liabilities
Current Liabilities
Credit Card
Payable
PROFIT & LOSS
Income
Other Income
Expenses
Cost of Revenue
Depreciation
OTHER
Off-Balance Sheet

closes odoo/odoo#36170

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-08-29 15:07:47 +00:00
Julien Castiaux 33354f71e1 [FIX] payment_paypal: external tests
All dates in the backend must be naive (=in utc, without timezone)

closes odoo/odoo#36230

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-08-29 12:21:54 +00:00
Priyanka KakadiyaandMohammed Shekha 135079044c [IMP] web: removed autocomplete filters and groupbys
purpose of this commit is:
- to remove filter and groupby option which are added at the time of fuzzy
search, it was useless as we have separate groupby and filter menu
also it generates the big dropdown menu so it is more confusing.
- align caret icon with the label.

After this commit:
- when user do the fuzzy search then filter and groupby option will not be shown
in the dropdown

task-2036351

closes odoo/odoo#35092

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>


Co-authored-by: Mohammed Shekha <msh@odoo.com>
2019-08-30 05:06:47 +00:00
Xavier Morel ae8770e704 [FIX] core: gevent / longpolling logging
* fix the gevent worker "logging" everything to stderr and ignoring
the logging configuration: passing loggers to WSGIServer means it
uses those loggers instead of writing directly to stderr
* fix the gevent worker logging the wrong client address when behind a
reverse proxy: it would log the client_address, immitate the
behaviour of werkzeug which goes and gets whatever REMOTE_ADDR is
set on the environment, that way it gets whatever update were
performed by ProxyFix (if any)

Fixes #32914

closes odoo/odoo#36233

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-08-29 13:17:02 +00:00
Victor Feyens e00e2805a3 [FIX] sale_coupon: view coupon buttons in draft sent and sale states
closes odoo/odoo#36236

Signed-off-by: vfe <Feyensv@users.noreply.github.com>
2019-08-29 14:38:03 +00:00
Victor Feyens 16cf2ec5a2 [IMP] product_matrix: UI 2019-08-29 11:33:36 +00:00
Pierre Masereel def4acae20 [FIX] point_of_sale: make partner creation work
Since changes made in the ORM, we cannot pass anymore string of integer
to many2One. We are now parsing the fields from the formular to
reprensent the integer as integer.

Since changes made on image fields, the "image" field name was not
correct so we renamed it in imgage_1920.

TASK-ID: 2058650

closes odoo/odoo#36219

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-29 14:15:52 +00:00
Pierre Masereel 82e3bd4326 [FIX] point_of_sale: tip value not a discount
When we are adding a tip, the unit_price of the tip product is changed
on the line, but not the lst_price, that lead to show the difference
between the lst_price and unit_price as a discount on the receipt if the
pricelist is configured to show its price difference as a discount.

So we are now also changing the lst_price.

TASK-ID: 2058650
2019-08-29 11:38:35 +00:00
Pierre Masereel f84973578e [FIX] point_of_sale: total discount computation
When the total discount is computed on a receipt, it is computed based
on the the discount applied on lines, and the difference between the
pricelist price and the unit price. But there is an option on the
pricelist that say if you want to show or not the difference. Which is
not respected in this case because in total we always show all discount.

So we are now respecting the policy of the pricelist.

TASK-ID: 2058650
2019-08-29 09:16:45 +00:00
Pierre Masereel d4bfeec9ea [FIX] point_of_sale: get tip product if needed
When we are setting a tip product and restricted categories, the tip
product is not available in the POS, so we now force to download the tip
product if tips are set on the POS.

TASK-ID: 2058650
2019-08-29 09:16:10 +00:00
qsm-odoo 367813c98c [FIX] web_editor: implement better name attribution for snippets
When a snippet is selected, its options are shown in a section named
after the snippet. The name is guessed from the block classes if it
matches those of a snippet or is simply retrieved from the data-name
attribute. The problem is that that data-name attribute was not written
on the DOM but as jQuery data in some case which make them disappear
under some circonstances (like cloning a whole snippet thanks to the
keyboard, etc).

closes odoo/odoo#36217

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-08-29 12:22:15 +00:00
qsm-odoo d73b9b0cb1 [IMP] web_editor: add better visualization of opened block options
Now, the snippets options of the selected snippet use a blue color to
match the overlay color. When a block does not have any other option
than being removable or resizable, this helps a lot to see which option
is opened.
2019-08-29 12:21:21 +00:00
qsm-odoo ddcc97a481 [FIX] web_editor, *: review editor elements zindex
* website_mass_mailing

The overlay has to go over content dropdowns and modal but below
technical modal and dropdowns.
2019-08-29 12:21:21 +00:00
William Henrotin 238e5ed9ca [IMP] stock: assign quantities to services in batch
Since 2137e45bb5, services have their stock
quantities computed to 0. As it's the same value for all of them, we can
do it in one batch instead of iterating over products.

closes odoo/odoo#36214

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-08-29 08:05:37 +00:00
ryv-odoo 695c65131b [FIX] elearning: fix invisible kanban view label
In the the kanban view of slide.channel, text belong numbers
was invisible (white on white) on the community version.
We change the class to be visible for each version.

TASK-ID : 2049115

closes odoo/odoo#35858

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-20 13:25:37 +00:00
qsm-odoo 3daed421f4 [FIX] website: restore edit menu dialog
Since saas-12.5, with recent ORM changes, writing on non-existing fields
does not trigger a warning anymore but instead crashes. This revealed
that the 12.0 "Edit Menu" dialog was doing some of that. Indeed,
depending on what was edited, we ended up writing on the 'is_homepage'
field, the 'text' field, the 'isNewWindow' field, ... which do not
exist.

This commit takes advantage of the fix to also lint the dialog code and
convert some of it to ES6.

Discovered while working on task-1925319

closes odoo/odoo#36204

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-08-29 07:24:16 +00:00
Victor Feyens 4e9416b4d5 [FIX] account: product view
Minor revert of https://github.com/odoo/odoo/pull/35381

closes odoo/odoo#36203

Signed-off-by: vfe <Feyensv@users.noreply.github.com>
2019-08-28 15:50:22 +00:00
Odoo's Mergebot 4953b79484 [MERGE] website_slides: add UI and frontend tests
PURPOSE

Test frontend and UI tools of eLearning.

SPECIFICATIONS

Introducing eLearning test tours

* a tour in website_slides that tests a tour taken by a member notably
using the fullscreen player;
* a tour in website_slidesthat tests a course creationg by a publisher;
* a certification tour in a new test_website_slides_full module that tests
a payment-based certification tour;

In this merge we also

* improve and adapt demo data, notably to have a tour testing various
use cases;
* provide fixes due to bugs spotted when developing those tours;

See sub commits for more details.

Thanks @awa-odoo and @lul-odoo for their input.

LINKS

Task ID 1937768

closes odoo/odoo#36059

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-28 18:18:58 +02:00
jbm-odoo 58cf9b6754 [FIX] base: Open One2many with not yet updated values
When we have an onchange that modify items in One2many's lines (for
example the quantity of each line based on general quantity) and
we click on a record immediately after changing the field that
trigger the onchange, we have the the old value in the dialog box.
Indeed the dialog opens before the onchange has return the new
values, so the old one are used. This case appears only if the
One2many's line was never saved.

With this fix, we wait that the model is free of mutex, and so the
onchange is terminated before displaying it.

closes odoo/odoo#35306

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-28 13:51:40 +00:00